GNU bug report logs - #72575
[PATCH-scratch/igc] Fix gcc-8 compile error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72575 in the body.
You can then email your comments to 72575 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yikai Zhao <yikai <at> z1k.dev>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH-scratch/igc] Fix gcc-8 compile error
Date: Sun, 11 Aug 2024 21:12:24 +0800

[Message part 1 (text/plain, inline)]

Tags: patch


This is a patch for scratch/igc branch.

Before this commit, with MPS and X11 enabled, gcc-8 would fail to
compile complaining "label at end of compound statement"

[0001-Fix-gcc-8-compile-error.patch (text/patch, attachment)]

Message #10 received at 72575-done <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Yikai Zhao <yikai <at> z1k.dev>
Cc: "72575-done <at> debbugs.gnu.org" <72575-done <at> debbugs.gnu.org>
Subject: Re: bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error
Date: Sun, 11 Aug 2024 13:32:27 +0000

On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <yikai <at> z1k.dev> wrote:
> Tags: patch
>
> This is a patch for scratch/igc branch.
>
> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
> compile complaining "label at end of compound statement"

Thank you! Applied and pushed.

I don't know whether you have signed the copyright paperwork, but this change should be exempt in any case.

Thanks for testing this branch! I hope it works for you and would love to hear about any experiences.

(My apologies if you receive this twice, my mail agent was acting up).

Pip

Message #13 received at 72575 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: 72575 <at> debbugs.gnu.org
Cc: pipcet <at> protonmail.com, yikai <at> z1k.dev
Subject: Re: bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error
Date: Tue, 13 Aug 2024 04:38:31 -0400

Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <yikai <at> z1k.dev> wrote:
>> Tags: patch
>>
>> This is a patch for scratch/igc branch.
>>
>> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
>> compile complaining "label at end of compound statement"
>
> Thank you! Applied and pushed.
>
> I don't know whether you have signed the copyright paperwork,

He did, you see it by looking at his previous commits with no copyright
exempt or ask maitainers.

Thanks

  Andrea

Message #16 received at 72575 <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: yikai <at> z1k.dev, 72575 <at> debbugs.gnu.org
Subject: Re: bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error
Date: Tue, 13 Aug 2024 13:59:25 +0000

"Andrea Corallo" <acorallo <at> gnu.org> writes:

> Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs <at> gnu.org> writes:
>
>> On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <yikai <at> z1k.dev> wrote:
>>> Tags: patch
>>>
>>> This is a patch for scratch/igc branch.
>>>
>>> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
>>> compile complaining "label at end of compound statement"
>>
>> Thank you! Applied and pushed.
>>
>> I don't know whether you have signed the copyright paperwork,
>
> He did, you see it by looking at his previous commits with no copyright
> exempt or ask maitainers.

Thank you for that advice, I'll make sure to do that in future.

Pip

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.