From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 0/3] debbugs improvements. Add tests Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: michael.albinus@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72574@debbugs.gnu.org Cc: Morgan Smith , Michael Albinus X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Michael Albinus Received: via spool by submit@debbugs.gnu.org id=B.17233786149285 (code B ref -1); Sun, 11 Aug 2024 12:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Aug 2024 12:16:54 +0000 Received: from localhost ([127.0.0.1]:40896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7VG-0002Ph-3O for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:16:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:40942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7VE-0002PZ-No for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:16:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sd7Uj-00066B-O1 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 08:16:21 -0400 Received: from mail-dm6nam10olkn2071.outbound.protection.outlook.com ([40.92.41.71] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sd7Ui-0004Dw-22 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 08:16:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QaaIxiM/un5BUjuZ6ift3ElkaljibJw68jHmMIFIbFGAtGvIX4ehv1Yz9k3Tx+tVkopQ497SDUze3ct7s6wFuHmB8q4wKLHDN8JH5cMZlLLsJs2rlJX9XG66o+dDpdSCw9DBSIb/umT/uPVyg/2hF4cnuTS7vQ5GEDQaaxyr1X0hFgeLNOnpzJSVixch2MxEs/L+XkNYGj9rBd2buo6snBASGEldcwWNuG0645jFu0ZkoJmdDX44gRnskrJcvY0WJEkJNsjqthqFrJb7E0tvOuFw3yqv2W8COMECMaXhgXL7iqH21QgSoQZZZaftoScmd/1q5NhdmAhLhufAwcC+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ZZgRN3SPdQHbLvofI7akDGdfLy+Y4HVDvq1Sc4XmAs=; b=me7pGy5QZPnpzvA+ZiGQhqDB8pfHyfukJb/aEgj9nVbrHniOifzrb0ECdJIxfTg/3jdEaGeZzBx7HUrqj03XN2wo6BFk6VyiZp6l+PPPKp3GAX7VN4uugJK4kw9m917PVXfx+er5OhkdEuIk8z1gyr8Dyyjl0LxR6ye6zdRABqOZ0YUwnc6LFRtOkTt/rQzcq/v3d0WiyErHkY4n7WUI3HuoSDhD2Wl3eYPrx9D6C7e3fj2WLy3/phlpkuRP8yDaN80cv6bpYhvE/oghFAgmIL/xyDxYySdN7mbTRpnsFIxZiwSHgEieAVetKUl2NOjq0KTOy5iygQZuI03na72E7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ZZgRN3SPdQHbLvofI7akDGdfLy+Y4HVDvq1Sc4XmAs=; b=rUmv93QmLyXcLTuDKRlp5h4ObiaVCx7p4myD3OOxkmJtf8Dw6RFl/t4qJHMYZ/KoFgYvn9uuxbakUvnm/7XGWRdFxVlTA0HqxhG6JMX2PakOMrttYFaGAdLGMLY/uCxkbHPRK1Uwk+4npNUNY8nFBgLNbmbsa/5sY3/6TcfNOgT7kqJWwLoAm917JDKOBi95kn2cWByS3d5wr1KGCWt7RLU+TIwmZ+rAzhwgmXICrQh8oekRXU1kXsAxLtUFQFasQtSpRr7kY8f1GrSJ8k9tneTp60JWsJ9JMFR2jqSX/IqDStvB2/zVRiKX18OAXUggdZbLVxJ71AYGXDm+ke1PUw== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB1489.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Sun, 11 Aug 2024 12:16:15 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.018; Sun, 11 Aug 2024 12:16:14 +0000 From: Morgan Smith Date: Sun, 11 Aug 2024 08:15:31 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [PKzggXGld1NKNC0tkyU4aAGORU0WKfzO] X-ClientProxiedBy: YT4P288CA0072.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d2::25) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <20240811121530.5496-2-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1489:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d808357-a607-4022-6f65-08dcb9ff64cf X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|5072599009|15080799003|19110799003|440099028|3412199025|1710799026; X-Microsoft-Antispam-Message-Info: a6dD262xPABpomJPjU6BfxPhnOaQJX1fmTCpgk767Rh0q1u5w6ZF7O/sRjbXOz3PGEGw38HS5jTu8g5JwnSZMRffirICkCpJc8GCmUvGNcFsFWYDZOHKq8PL1zuGvxRR9BZdN8CK0v8LVFHNCUySCsxb/n3ytldGoUp509Gm/ml/0Wc+E4ZHCjqoElE5plFxzqWK+tgmh9KqgqjSNWSKJTmO+9bd6LXHkqJHVTHaT1AbR41QsjgJ2VpQiLgzbeu14gQOXMXOiEX2Y70v2KOjfrfJiH/BrQ4q/+0viJ88y9p6JPH3/NLM3vH/pbI6QIOMTR5/xK9/zUUKg+1rg2a0J75Ix4kBuCHpsc8ACmK+mJKaREI6tl4Ak1+gPPrIyKNguV4E15pAPEt5VmZ+2bT/Rb2GJAyCb84/sIQv+MWfLg5scGSYRiYu/jCFXxVUs+12g8FydwcQYFkF5xcOlwma8uiN7qMrs6PWWJP3HF+S0HTAzOrdwcY8M4t48XlrkHwE/Cela/J45FyJWgP9xrcd26ZGvvavOtY/8t45nhKjR0y/IzgXU9mpcBw1u+QHAaS/+rswNWbPR7zYWp9mddGZV5eONFeNpyjxdXyrAhvB6k03ZAuSuJ0PdjnvkRAweC4aMi+vMagQigaqSQT0Gfcn0viI8EHUEpuRbfEx1pb6w3IYkK7kY1Pq1Dr8wuqdUv/jOxSJ6qwNZEjpPE47t75u/v0YV57pOOfv7KhL+DNVJkg= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t+fDpSu6VdCyl7x1ZXM7TXUQWT3JOspPvNa6cAV3Wen3vdN044IlZkAIAbk3BqT8MxOr6nOdNbC6xe7wGYI34DTKO0ZMeYxCxJLRcLK/vPoIAPpFHAUebmDtlQwxECK2n8C1XNq51zo5hFj6p2679jNvo7aMoD9Eo/hd2ubkGryhZ9NwHqFOChCUMzF+yygyBoviN7dIcp2qgYFfzalCrNuYcTFJUwKg+j6dxRv7Y8jMx2roiIet1lffmf/Fat4yxssm+f+yHfNUIWoGsVt4VvI7wwqPTHOhkHpshBf2/djSlChjE777lkZk+BYuTIEDuWfRH/px9EoC6nabuj3ayJVlpTt4KjM0hDCCBksTNlqonD64Mg+oY+2g/Df+nUTL8NNShckOy8CFQyFHMfsk2HxIF/nV22eCrwvSwyxR53vVand+oMcshJJe/22XsURK+w3UQ6CvPiFgxjzTXhne/LoyZYEZ0UyN5hd9Wa//lpvcHqnORJB0jQyJ2q/UfFPKQxXXSH7/9WzWpPJphS31FurLa5CtOj1MQBFWC/OXOTAo0VwXQYl4UEOyqvEEpDH+Ary1rgy5Ut4VKlgM8J36qf6CM+JdV1gM97AG+pjgMVnyo/D9C5gl+cIyKVmgZelAcDYleYFGChtSM1JZkvMNwRUpizqk62+/GJGxN5IWW7HsWdRXS7kODDtUuAsbc89Z4tl4D9gYk0kzLivG8akdqdbXsvKuWTCht3Fr1VnAbE9ZN6oilkt5eCeqgaaP3SjLvOeXZ12qFPc+1S7/80M8sX2uIutlHM6yOVteCeHL5VADctj4wq9RmATE61jx5cwa7tbg71gAjfDVxCBNgrKV8OPZ/vb0IWm7PP3Q+eLgv7uPld5mrv3URPwlTdyn/A4JIQ0wYDMVmsQUAIaZs97yV3bmgUfFqnElJWrodVq9J/D/L75hA3xNcWoxeI1VONZKGtVDr3y+5bZOK8X60qW2NKmRVcjpkJtNKPrEXvlj/EWbPKKaZq1ip6zfGzJg6eYGVgjD2lMYj3fUUCSQK4SC+G4vg4IxoXE7IpMlO77aqC1XAgn81P0Foo0VUt8SGcabN01IHD+JxfiVhIRMqni7b/laeEwQ4RHbinFXWVqnJb1w4r2jkGAVZg2vB7ubaIQG091Z0dzPO22p+o0gnF8bdoaqPQo7zcWX0k+JnvvfiPV/jRPOktcTwoVBubvxe0hmkS1qvHtuyonN21wDDeZuK95b6iaG+w0evAkZtmLOqd/vgZLMMeCD+1mJ4i3keJGw X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d808357-a607-4022-6f65-08dcb9ff64cf X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 12:16:14.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1489 Received-SPF: pass client-ip=40.92.41.71; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello! I would like to start contributing some improvements to debbugs. However, when changing things I found it difficult to avoid regressions. So I figured I'd try to add a test suite to debbugs first. The first two patches are not that interesting. I was hoping to get feedback on the "Add tests" patch. Obviously more tests are needed but I would like to know if I'm on the right path. Thanks, Morgan Morgan Smith (3): * debbugs-gnu.el (debbugs-gnu-find-contributor): Make regex more specific Fix various warnings Add tests Makefile | 4 ++ debbugs-browse.el | 3 +- debbugs-compat.el | 3 ++ debbugs-gnu.el | 24 +++++----- debbugs-org.el | 7 +-- debbugs.el | 12 ++--- test/test-debbugs.el | 101 +++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 133 insertions(+), 21 deletions(-) create mode 100644 Makefile create mode 100644 test/test-debbugs.el -- 2.45.2 From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 1/3] * debbugs-gnu.el (debbugs-gnu-find-contributor): Make regex more specific References: In-Reply-To: Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72574@debbugs.gnu.org Cc: Morgan Smith , Michael Albinus Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.17233788009703 (code B ref 72574); Sun, 11 Aug 2024 12:20:02 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 12:20:00 +0000 Received: from localhost ([127.0.0.1]:40905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7YF-0002WM-Ok for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:20:00 -0400 Received: from mail-sn1nam02olkn2084.outbound.protection.outlook.com ([40.92.44.84]:58934 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7YE-0002W6-0g for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 08:19:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=orcE4I0zsBPeV/jntokUg90ipio/s5ppjOD7cvkHWBIbiBHYgwnoYxPPG84SkA2aViEAl+GsQE4AdP8HzqxfS73NxFw5ymAEanM6PdJcPH2QgkQcR8A320gajyYty2r8mJfaZwHqw5ybzEPT1ruhOXpXh+CSAAbK7pTMNGbVm7hUwP/Hg0pWYiGDfltzo2MA22BVIjTog+3OA7sJ9E5GhhBQtL3LTPvrgCmCax4jmgb112qVZDUTi1ajeX7hk9rNDmRtlAsyaCXHGzpZ3dMj+mMA2oAjxKpMK7PNdTmci751OrN0fEa0ZvndMiyw35TRgbGXvOpeWUfeDM+RdflWXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ng5hxP7jlMRLceXYRnTBG8lN95a2IJBDGSxXzbRFStM=; b=XwloPLkC/4MPj+oxyRwQEXMunzAHpUN2CYfzB8HYh24uOFONfsMFDfRTcAexUWMxUuIPfS7Oc5UkJLUFu2ez0tpk35+yvIeSiWx5Es02H2eqTPVUz0M9yrOr6d/p0aAPjWZjV8ZKkNzwGRkshFuqHB8cBx5DeFd+dEcNUtwH1lYS/ol2Sbpo7qXLiIMjsSU1ljaeYlbrLSMb1B8ADTTDLSNfPFAAWunbW16zrK3NGX21oUfw779DQJx+ZITd7/lElzrUFu18fulg+VT5RfvWii6396zJeD6qbPXQoXil3eWcqkAk71Oul0BzqamtZ5TTWruHrhGt/FR+C1MtoHBQDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ng5hxP7jlMRLceXYRnTBG8lN95a2IJBDGSxXzbRFStM=; b=YfhctF7AJjrT3nlpGC1l69BUWlhLGFN9fApjDND40IJUWIeXkUZ0q3XoMLqsi3JZblYSDhMletjtvX+R4JcxjzerEbkVEW6E7rhhcuOxDU/6bjpyUPricJZIA+qf/Pr9Ie1ZGFsOxtJBweXMG2ebJfSndiPtSGijr4yJXlj5iv2gA/ZgpFaQN4a/k3Li6XMvxQXZASC5iY3biQk9lx0gCLdPJN4OnbwM9112TcrHnqXaN7/3WWyCDwbbSWPRyL0xO0LdbgkJsUlmsUADXo5R4lHEYDUeERbFQVBbA8Kh+UN+nERpraqIfavFLTjbeSV0m8sHq7IawBmLVJgHVp2rjw== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB1489.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Sun, 11 Aug 2024 12:19:06 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.018; Sun, 11 Aug 2024 12:19:06 +0000 From: Morgan Smith Date: Sun, 11 Aug 2024 08:18:39 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [P+TEGOm+6XH+Lo2bkHtUjXyZ/WT4U6er] X-ClientProxiedBy: YQBP288CA0011.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::22) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1489:EE_ X-MS-Office365-Filtering-Correlation-Id: af309599-04f0-4169-5b1d-08dcb9ffcb68 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|5072599009|15080799003|19110799003|440099028|3412199025|1710799026; X-Microsoft-Antispam-Message-Info: iZgsze4p/y2++hgktvA9dafUgzzPmzmjt1p1+j4a/9DBJyN5Ey3PSbl7wYP/z7EhlOnGg/X73Fa3IBE8GeXOsGhnsgOmb44NqRVqbQz8GmvUZzk2ptMz5sEOoyCEoGIlWSX0WJjpjy1isYDaLphwdVBBkbX99DpBFNc4RMmMG0t40t3eBZaeHnWgmFhiSVylsXZhiQQq4RMLw0lfjfxHib7Pjt7hGntM2MRWoXCBCN3ML7Hjs9F9ny8cUJdqS7lzroWAmjOmK7obdGB/4Fjf0XmChcpCPWwB7bsWlBMVKdUhsxrLDC0l6dwmvozoRUVYE7bTCKZV0X+DE5et8hyYhiOSMGhTeTzbsyyCZPhr1t0Ms6jA6AdMOAl1pwaEWOAHm4aDsmRqbkinhNDqrTNvyTPqdPPjyotqUvfXQQz8rLGzwaHG0cto2RCG4rFiC8NID344AdsMTZpUmhal80kOi+g0NIeKkN1KRKFYVkt36RDQzHiL+eyeB3nKmk/moZHXnAedkS8+tGQx/9RyV2pL50ElCxoZl2hbsUTCzRuxRxN+OAUC9xZeFdaM/+I/ZL0COWtliNKYzvT7mTsSi4U2HL25a0Pp0WTok40Iw+2tUoXBveV5BFHP3XYdRwEtARmFA0bM7gXsP2vICFj/LVJ/6pjc8TnsI6PqiSD5jZzcasPM+8MklEKa1dmV/gsiT8xdKV3cd1MGy+BeEKkTvrUHKcGcvUIbGy7pncgcJI32ATs= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xIXFYdDkaVnMEQYb60+F8/zoSPbWfe6/Z7EqTcxbxq5rzuMXjLJ6iGNJkzNPkiaIIWSQ+QAZlzhus7WM8ETXq/ftAStgRNPZ9TYc6lytRJKiniDfsZUXvohhD2jBZMXE2Nwibg4tLSENQTFzm0AIrGBNQlGVvPvopT5QxR6SzyBLroFn8IsXI9yKqb+PSbjZ9pTPDg7zhQAUtJ4skAPcplbfan/BeZUZ3BAaBJfh7MMg7swVIJCq3fbxYp54qbqAy49B5EdUscG7ski/1s0AiMfYLn8F9ZoSthNLHSVjsxU29yg1VrlBEIhVL+G0R74W6EA6w25ABv6jMY+B+gxg1Pm6nRb8YisHxptXQMd8AUm4fpXYthDHYTwudaUQeEquxBJV2va5IQhqs9b6t4ppzintJEhGeBBizPhR9QWEgSilC7mEMTIh4fEgeGmPgX/ptgf4CfynUMB0wzrFormp4X7kg3s+oA1SkWo157KC27GqG2HU+cIXpCvZ1rbCqUY3d6ot/Grdl1RNIGWZXtln8f3ogMFTbegEOHPBHFff6lfgW/VFk6R8yF8gCWIsasPl984Y+Iu7WblizVkbiVXtTRCgDGc8Z6RIxI+MDlYWZ/KCUmrX8N0V0nBHSlYnwgsKZFD3t4keLIiLlPMtHynWlsaVEIVNTpMwhva9ZL1cOVxb11dW+q6mFWAltDzn+qkaSHdi26qrvgi6zENoMkpunp4WNMKVHSuw2cnU6gsx/McE5ewN2HdOUS+Pon9lKXlB7yUmG2trTc4M4XUPEC8CPaDS0KHzDknBvfHnPDfzDglMpqKwJUgkrmOyJJI0zKM//D5p5e/AZy+5Bo6Vhx+5mZD8s2LCEK24GpLGzG+ljhjGmjRvPWsS8+sY5zQVzJhNFbyXHFC608Ufkzmh7GOPq41bvawcJImmXY/10LIX2njC4Gv1YQILxZh8zsDk2avBXKoTmT99pjNWjclBey8nzzZT0MQ8Dnc0nnSuoRXcol/lU6NYWB0L4aO7NfywurqZb6QfWDD2gT80RjgAajW0xuAFuuoJjSM6YjIo2eXcOhM63rm4yBd7OXDbMj/rBc8O4s1BwatLf+m+TaWzCckToQPOnE7YdW+3YFopax3Ykm6euJ/ZQfTNOLhjhogyEvEjkog05c3Yd/pZJVgLiiXDzd4FGQl3Qv5utipJqAQ1eqZqW+9aIxtNY8jZ+OZx0Ivl6LWreTNNzOpWaxczfYpIrgxtNlyXJ9L/3dOSZMoxifdyEEmk+JW4usyVdEyJU5JQ X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af309599-04f0-4169-5b1d-08dcb9ffcb68 X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 12:19:06.1467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1489 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --- debbugs-gnu.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debbugs-gnu.el b/debbugs-gnu.el index 3f5a9aebc8..6b6dd4992b 100644 --- a/debbugs-gnu.el +++ b/debbugs-gnu.el @@ -2702,7 +2702,7 @@ If SELECTIVELY, query the user before applying the patch." (let ((found 0) (match (concat "^[0-9].*" string))) (dolist (file (directory-files-recursively - debbugs-gnu-current-directory "ChangeLog\\(.[0-9]+\\)?$")) + debbugs-gnu-current-directory "ChangeLog\\(\\.[0-9]+\\)?\\'")) (with-temp-buffer (when (file-exists-p file) (insert-file-contents file)) -- 2.45.2 From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 2/3] Fix various warnings Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 12:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72574@debbugs.gnu.org Cc: Morgan Smith , Michael Albinus Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.17233788039747 (code B ref 72574); Sun, 11 Aug 2024 12:21:01 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 12:20:03 +0000 Received: from localhost ([127.0.0.1]:40909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7YI-0002Wr-6u for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:20:03 -0400 Received: from mail-sn1nam02olkn2084.outbound.protection.outlook.com ([40.92.44.84]:58934 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7YE-0002W6-SV for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 08:19:59 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oZXI3OLilIY/ZqmAfCfYkHVLhH/ABfFRSidZQDA9P33l2Ojbsmmt3ut6jKAjVR357qP0I897glKFc3Wv308Qbo0qasdlzG/9oV+QZUkvS1eBPVPcwU/61bmVjawqdivRtmKQQEq032V9t11TfgWOqubpPod1JMOpnbMRJmPqDMFpTEEtvBBv1k3IphwjeYguNZeosFk7Z5fxi9czWhzZ1fXBgLv1C2+7Ekaq8cReiN4DJVNROhxXacgrkA5IINPtDRYnlcbK5Zw72tZIR3RQP55AbXES1IltAEzk4Ra/RkiSC92zToNMkMXUz46ZgKqtqVIoHRwH7Q73chZudnxf8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w1adJ+KN8krtQALHS3x8/iD+3Dg5FKeO09pmhcEI/y4=; b=ex0iXfTbkWkBQEJ9GVVfNMtq60+ErHFzKF6ras63m5BKo7wpgF/vPoRjJ0vWqGlKA2ScbnGXI4ldpnvjVFQ+nE5wTnVQ1AuSt+x6Xkjs6jjKYQtOjSeW5sJ28SJ5qiG+RorAmV8O2lhd4p2JwHBbni1DT49Ug69+Ro97UMRQ0FPWuBoJET26PirPbk8tNoxm5OfvLClAign09nOZlcT3KNZXhuc703gL3/++OP05KKPUNkHTabbU2hd8VmohGyfS4463kR1fVy+svhKjrmzD/Wj3rKFGAjdUsMswM+u2Rbob+vdlIrhrY0/zj+qkvg5LS7fZ5om1Iwl/y1hau9CGbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w1adJ+KN8krtQALHS3x8/iD+3Dg5FKeO09pmhcEI/y4=; b=RvqPo0Up1Xe4/LW4xb1pj2W20/ttsz2bo/7z8cHMIaR1QG+JiibMsGcCKwdkDsD+Jd4wyohFLyieOrxxF/PBkWH/MDKv/T9+NjloxxQV2nqj3oeXpE6hI14wO8voUXLtclXS+7qcb1khs8CJHdyz6I4AM4cocPhWCFf9cKj3cS5P0zG7aO7ojegjvEtHfmvLBSGsqJPZIeykyt4Qgl2tP3q8gz1hN3v7/3GhLSbRRcR2U2s57ThzIhzjiesVks/MJ+c6FoANGPYo2YdZQpDH5iDenIqz1llSA/17+WBq5nGwAzAiqG67eq5WUDcQqumr6ejmISmO1SxJb49IfeheDw== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB1489.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Sun, 11 Aug 2024 12:19:10 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.018; Sun, 11 Aug 2024 12:19:10 +0000 From: Morgan Smith Date: Sun, 11 Aug 2024 08:18:40 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> References: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [sXLGn9b45KdM3EgF9Qk3kIIcxszDBHAZ] X-ClientProxiedBy: YQBP288CA0009.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::7) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <20240811121841.5584-2-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1489:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a7ee74e-a145-41e7-cdcb-08dcb9ffce00 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|5072599009|15080799003|19110799003|440099028|4302099013|3412199025|1602099012|1710799026; X-Microsoft-Antispam-Message-Info: cGaQoDY3WCHMqSNTHX2CYBiSBkxOnrAvrLl1hEuyotdwCjAUaCyZRk3h4HLMPgH/u2+mfS17c0acjqD02qUqZADLg/pXJRSePwLfraxlf0UbGuEqkGcThFAxRxZTEwBCh8JZwW6g3G0Vl53Rx0N01/JlDp48ijeotXgzbVhex/BKgADo6p76kLjwBGsLKO/9BNdwdVxWyAEfWyKK2taSXx2RV2xm5UDewygBjW7YH4o7e91F/uQ2yNXJT8ytP2V+ms1FzcTh+QScN5OHWSgjzIbLGmYsS86AmQdhRglRKIsfSU/X6BDalXNOvY38kPCApByT61TkjS5t03iRL97WLXhp75hwj1Cb0pAROGIXzovm0hj9O9vgs90j56oKo1nyuRVubXfECwj9112yDYQgiUcAsoHLrF9BAmNcK2agyF6DF3f3YZ8pB5+IBq6OB+kbLDmBVQxXao1Z6/OpdAzYjcMO2lTYCZLsULC2AswxbJLE6PJz0cIkoNlMhNATxzlTQqG1cgckxpbBOSEX2QUL1GvlUonYJL/V4H7bgJS0r8NSDfOaoKVK9DAVuuNI4PW8dmkjIA7X8W/ZYpmFeuloMJLn46SvNjeMBnhYBh+DV+EmW8FezcY40TfLHy0jXtPxqqMlqQ+2/mnHZptSEb6PzWIiCEbxGLDUNfX6hL6X9GsKvcOltBS3OTU/Of3UJ2SSehYVKNrJIQ6YarWnMNekuSgEewhIE2vPGoO2SqxFMB36caB/cRzg+pJiMnLM+r0mQK8LCDAg1oK1Zc+a9IOtZGaafzu7bTRbM8uEXdFHuf16qba62jqwj1nDYdkJtGHfmDLBWfPLG+tBiaTiC4ixFE3nsNAYBgUT2cLbW9KCQ6A= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wZYu/GnWvDCP9mcXmMHMe6UQsLr3rYA6XnPhDnHlr/ZsNGc9BpiUpkqeJJKG5YAgDMqaiJP8qK6dTwyHurjLb4JGJ7DFn6LeYMDna3OaoAIPx3MPM4D/61Gr/la4kpwJXYliAc8AvHpZJFu1F0b4nx7hUxA7KkKugbhzmLrZfYUgO/bdP0uBeqdwyRZsUfc8z6ZY6fl6p8d4c92sVqAe9q+HvBFIAdjLFhp0nwep5pmBacyzcfpGWkLI9Sy09ipL3DxX1ADDzZFwjqby5KxT9ngD5GfeKoeT7AOCfaaw29z8afD7HPE/HQ9HLORf2bXfqljWDnw3Np+q9r+SXbUNfa4Q5vQ/mJ//K0k4WZpirN2WgF9uw69on5KTFrSuKqAabo5Nxn4+pPaQDFK8WF/HAj4nF1DVfhkaCeeaAnrm056uVLNIMMi7zPFEM1VORVrMxhDn7w0q1IZTyAsTAObAG2EsBz1xSHgj+B5k6HvICqt4BWMM1FO5n2DzWEj6MmRSsMt0LcmJYvvefGuzmzGJ70rg1LwvKVaYKHuA3VW3hcdrhBebZfBmJXbsLOuAK3ZbWdXbTbiG8H1xsUL1h0MrOyV8VL1T3KKYxhE7lLzN2xt8hnvR5jBPndIUbpQDZ3q7FytErgi/ZaBOkpItHx/yQc1ZvfD+/KIUijxXdJJkmoPWW5MsHjfqXAMBCssAS+uf6ovwnSpPzR0qTZE5T495VBP2i+j8zaEueLwl+hcGaFyZZEK6L7gbw+5Q1y+C+9Jt38aF6CKb7HyrBxVpzS8EtOQ4mdFxVcFUelqiUvmqIAj8sX6pJJ2cGHZgPoGpHn8ov9BRFI+71Jx9bZaHdDT/UU2hxCDT+4X+3DeccZ9IC5qOCpbd1wlC99mc7O6qSxI7eQlysphBhmC/+KGEAEfx/3B1o90FRdlDnHUChoGv2W9nOprAMlbbzRtFF6E53FWOIZ+FsSiZkWHS9YGNxYmFYx3UScLeSmJoZ2PqcG57/WINgWO9CQ7pQh0OylB41sSWxQH7Fyg2mbigUsYMw0hyIhuDMhk2TYpww+yAMdc3aKAmg7aTNs1+KNmPlupxRQjafdYVp175RNW5IUudYcjbiCnyYpTYNXrmTFmRF2wVIKxRgIuU9c6VuTExRgE2LoKCSD5pQ+u0S5esdi2LCZmHRg23+MmW7Sb9/b5CZj7WyJu4jm6R1x6lPvFLmPhytwI2f2yN5nsRPBlQ2+PX8iT8a1q0tuFLbmh3PpOe6CY9rIAozc2pjQueIJKJRrtksxKw X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a7ee74e-a145-41e7-cdcb-08dcb9ffce00 X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 12:19:10.5591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1489 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * debbugs-browse.el: * debbugs-compat.el: * debbugs-gnu.el: * debbugs-org.el: * debbugs.el: Fix various warnings and checkdoc warnings. --- debbugs-browse.el | 3 ++- debbugs-compat.el | 3 +++ debbugs-gnu.el | 22 +++++++++++----------- debbugs-org.el | 7 ++++--- debbugs.el | 12 +++++++----- 5 files changed, 27 insertions(+), 20 deletions(-) diff --git a/debbugs-browse.el b/debbugs-browse.el index 3b439b08b5..900adec818 100644 --- a/debbugs-browse.el +++ b/debbugs-browse.el @@ -54,6 +54,7 @@ This can be either `debbugs-gnu-bugs' or `debbugs-org-bugs'." ;;;###autoload (defun debbugs-browse-url (url &optional _new-window) + "Browse bug at URL using debbugs." (when (and (stringp url) (string-match debbugs-browse-url-regexp url)) (funcall debbugs-browse-function (string-to-number (match-string 3 url))) @@ -67,7 +68,7 @@ This can be either `debbugs-gnu-bugs' or `debbugs-org-bugs'." ;;;###autoload (define-minor-mode debbugs-browse-mode - "Browse GNU Debbugs bug URLs with debbugs-gnu or debbugs-org. + "Browse GNU Debbugs bug URLs with `debbugs-gnu' or `debbugs-org'. With a prefix argument ARG, enable Debbugs Browse mode if ARG is positive, and disable it otherwise. If called from Lisp, enable the mode if ARG is omitted or nil. diff --git a/debbugs-compat.el b/debbugs-compat.el index 29509fa6d2..96628a1921 100644 --- a/debbugs-compat.el +++ b/debbugs-compat.el @@ -21,6 +21,9 @@ ;; You should have received a copy of the GNU General Public License ;; along with GNU Emacs. If not, see . +;;; Commentary: +;;; Code: + ;; Function `string-replace' is new in Emacs 28.1. (defalias 'debbugs-compat-string-replace (if (fboundp 'string-replace) diff --git a/debbugs-gnu.el b/debbugs-gnu.el index 6b6dd4992b..68599cff7f 100644 --- a/debbugs-gnu.el +++ b/debbugs-gnu.el @@ -33,7 +33,7 @@ ;; ;; M-x debbugs-gnu -;; It asks for the severities, for which bugs shall be shown. This can +;; It asks for the severities, for which bugs shall be shown. This can ;; be either just one severity, or a list of severities, separated by ;; comma. Valid severities are "serious", "important", "normal", ;; "minor" or "wishlist". Severities "critical" and "grave" are not @@ -243,7 +243,7 @@ (defvar debbugs-gnu-limit) (defgroup debbugs-gnu () - "UI for the debbugs.gnu.org bug tracker." + "UI for the debbugs bug tracker." :group 'debbugs :version "24.1") @@ -426,7 +426,7 @@ They haven't been touched more than a week.") (defvar debbugs-gnu-persistency-file (expand-file-name (locate-user-emacs-file "debbugs")) - "File name of a persistency store for debbugs variables") + "File name of a persistency store for debbugs variables.") (defun debbugs-gnu-dump-persistency-file () "Function to store debbugs variables persistently." @@ -698,7 +698,7 @@ depend on PHRASE being a string, or nil. See Info node ;;;###autoload (defun debbugs-gnu-package (&optional packages) - "List the bug reports of default packages, divided by severity." + "List the bug reports of PACKAGES or default packages, divided by severity." (interactive (list (if current-prefix-arg @@ -2548,7 +2548,7 @@ If given a prefix, patch in the branch directory instead. If SELECTIVELY, query the user before applying the patch." (interactive "P") (unless (eq debbugs-gnu-mail-backend 'gnus) - (error "This function only works with Gnus.")) + (error "This function only works with Gnus")) (add-hook 'diff-mode-hook #'debbugs-gnu-diff-mode) (debbugs-gnu-init-current-directory branch) (let ((rej (expand-file-name "debbugs-gnu.rej" temporary-file-directory)) @@ -2695,12 +2695,12 @@ If SELECTIVELY, query the user before applying the patch." nil t))) (forward-line 2))) -(defun debbugs-gnu-find-contributor (string) - "Search through ChangeLogs to find contributors." +(defun debbugs-gnu-find-contributor (contributor) + "Search through ChangeLogs to find CONTRIBUTOR." (interactive "sContributor match: ") (debbugs-gnu-init-current-directory) (let ((found 0) - (match (concat "^[0-9].*" string))) + (match (concat "^[0-9].*" contributor))) (dolist (file (directory-files-recursively debbugs-gnu-current-directory "ChangeLog\\(\\.[0-9]+\\)?\\'")) (with-temp-buffer @@ -2710,7 +2710,7 @@ If SELECTIVELY, query the user before applying the patch." (while (and (re-search-forward match nil t) (not (looking-at ".*tiny change"))) (cl-incf found)))) - (message "%s is a contributor %d times" string found) + (message "%s is a contributor %d times" contributor found) found)) (defvar debbugs-gnu-patch-subject nil) @@ -2719,7 +2719,7 @@ If SELECTIVELY, query the user before applying the patch." "Add a ChangeLog from a recently applied patch from a third party." (interactive) (unless (eq debbugs-gnu-mail-backend 'gnus) - (error "This function only works with Gnus.")) + (error "This function only works with Gnus")) (let (from subject patch-subject changelog patch-from) (with-current-buffer gnus-article-buffer @@ -2848,7 +2848,7 @@ If SELECTIVELY, query the user before applying the patch." map)) (define-minor-mode debbugs-gnu-log-edit-mode - "Minor mode for providing a debbugs interface in log-edit buffers. + "Minor mode for providing a debbugs interface in `log-edit' buffers. \\{debbugs-gnu-log-edit-mode-map}" :lighter " Debbugs" :keymap debbugs-gnu-log-edit-mode-map) diff --git a/debbugs-org.el b/debbugs-org.el index c8a94c32dc..0a3a5b2a65 100644 --- a/debbugs-org.el +++ b/debbugs-org.el @@ -31,7 +31,7 @@ ;; ;; M-x debbugs-org -;; It asks for the severities, for which bugs shall be shown. This can +;; It asks for the severities, for which bugs shall be shown. This can ;; be either just one severity, or a list of severities, separated by ;; comma. Valid severities are "serious", "important", "normal", ;; "minor" or "wishlist". Severities "critical" and "grave" are not @@ -140,7 +140,7 @@ "Mapping of debbugs severities to TODO priorities.") (defun debbugs-org-get-severity-priority (state) - "Returns the TODO priority of STATE." + "Return the TODO priority of STATE." (or (cdr (assoc (alist-get 'severity state) debbugs-org-severity-priority)) (cdr (assoc "minor" debbugs-org-severity-priority)))) @@ -319,7 +319,7 @@ the corresponding buffer (e.g. by closing Emacs)." ;;;###autoload (define-minor-mode debbugs-org-mode - "Minor mode for providing a debbugs interface in org-mode buffers. + "Minor mode for providing a debbugs interface in `org-mode' buffers. \\{debbugs-org-mode-map}" :lighter " Debbugs" :keymap debbugs-org-mode-map @@ -374,3 +374,4 @@ defined." ;; - Sort according to different TODO properties. (provide 'debbugs-org) +;;; debbugs-org.el ends here diff --git a/debbugs.el b/debbugs.el index c90fb1008c..627cdf163d 100644 --- a/debbugs.el +++ b/debbugs.el @@ -44,7 +44,7 @@ (eval-when-compile (require 'cl-lib)) (defgroup debbugs nil - "Debbugs library" + "Debbugs library." :group 'hypermedia) (defcustom debbugs-servers @@ -56,10 +56,10 @@ :bugreport-url "https://bugs.debian.org/cgi-bin/bugreport.cgi")) "*List of Debbugs server specifiers. Each entry is a list that contains a string identifying the port -name and the server parameters in keyword-value form. Allowed +name and the server parameters in keyword-value form. Allowed keywords are: -`:wsdl' -- Location of WSDL. The value is a string with URL that +`:wsdl' -- Location of WSDL. The value is a string with URL that should return the WSDL specification of Debbugs/SOAP service. `:bugreport-url' -- URL of the server script that returns mboxes @@ -121,7 +121,9 @@ t or 0 disables caching, nil disables expiring." "The object manipulated by `debbugs-soap-invoke-async'.") (defun debbugs-soap-invoke-async (operation-name &rest parameters) - "Invoke the SOAP connection asynchronously." + "Invoke the SOAP connection asynchronously. + +OPERATION-NAME and PARAMETERS are as described in `soap-invoke'." (apply #'soap-invoke-async (lambda (response &rest _args) @@ -381,7 +383,7 @@ Every returned entry is an association list with the following attributes: `package': A list of package names the bug belongs to. - `severity': The severity of the bug report. This can be + `severity': The severity of the bug report. This can be \"critical\", \"grave\", \"serious\", \"important\", \"normal\", \"minor\" or \"wishlist\". -- 2.45.2 From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 3/3] Add tests Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 12:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72574@debbugs.gnu.org Cc: Morgan Smith , Michael Albinus Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.17233788049754 (code B ref 72574); Sun, 11 Aug 2024 12:21:02 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 12:20:04 +0000 Received: from localhost ([127.0.0.1]:40912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7YJ-0002XA-Mt for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:20:04 -0400 Received: from mail-sn1nam02olkn2084.outbound.protection.outlook.com ([40.92.44.84]:58934 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7YF-0002W6-Qt for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 08:20:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zFnxSsGQm6yIPQr1bXgLK1Q2Ib57Gwd3jzk3H9I7nrHeD3M1Rjgm2s/8YBkcPV21yZD5/SNe+79UuSR6ZesA58aZYekLuGUXUbFcb7jFZC/7DZiDBd5r2gYFwid9IE8gevZaU9pBNDZeJTu4vuIFreJS89Gazxb4IkK1UcFpit5C4PWQSTCluZxMPb/13DNjQqD4SCVvzO7y8XniMhU7MCJnzl8hgBAzig6XOwocmFhFC76WZa2sZC3p3uqKI2i6BvInTLZXSTMsAW9W5n11IbDX90Z6GLIQm2lXI+cUBRD2xQccsbmNmkY8JqGDHtxQ+xBYRzIPMWAy7bMIkvNb4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HxgQBghrK6E/UAJODKlz33DXPAHvFtN42yiCFy4o/q0=; b=zHEecxE1JU4VPR9aJ/YUnbZT+eTpc6XHBfZflKVLS+RpPzidnaeAqGE99Y/cE/m040z60TnjWE6OoNHZnbC7Xa++Wt8Uq0j8obAPpXbrZeHX9xng0J7NenB7xHKIy+MYPaOoLOflTkFF1dcheLBtTeznmhE2zEnFMUzrpVfZLWns4kfLsfS/zdLsla0D52hyFon08yXmGIvbnJmyeTU92RhdI5rZt5EzSW7ROct0fZkbfE/kWQq8Rwrxs7834gn9yu611+EnTb50CDMuCZhUwEO3mzb7f1tHE8DyPkHXqYhxUMsid5H5A5DvIbby/KJ1v+QqcU4L82WpNL3Z/KYgiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HxgQBghrK6E/UAJODKlz33DXPAHvFtN42yiCFy4o/q0=; b=ZLZt8t4Yj5/iNTsP3XtH0iz6GIOSPNrxWlgdTaC02TnxBmLZ3Jpc6iueqQ6bW5lVRBRtL9rfDZ55hgd+2h0XP/maRQFnn5L2o7wSyegLlbE6TFXZaKxCqs3zrX5S4Av//CgiNcjKioz6L3GqtU9nVzxrsZicpri2MPt1ulxP2iRtjtWFC5t7aEtP3OkAF8B2eVDRwADF2s+Zb10idYAfjXPddyC3fz//NY3Xc8EIs/J3nQ7aphr9CHxfJOv5hORqgngDUrJPG5HkzNgJ0HHTZfo5VEuavlbs4uLS/w0VzY0gKZLdHsIkeNbAkm9TpmifXNtaiarE6hoV4m3DFdJKuQ== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB1489.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Sun, 11 Aug 2024 12:19:14 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.018; Sun, 11 Aug 2024 12:19:13 +0000 From: Morgan Smith Date: Sun, 11 Aug 2024 08:18:41 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> References: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [BcLoMQD2anLEc8XbxHTP9HDL9e8v2kS5] X-ClientProxiedBy: YQBP288CA0018.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::21) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <20240811121841.5584-3-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1489:EE_ X-MS-Office365-Filtering-Correlation-Id: 905ef3d3-9b85-46ff-e4de-08dcb9ffcfa0 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|5072599009|15080799003|19110799003|440099028|3412199025|1710799026; X-Microsoft-Antispam-Message-Info: 02aGDC6hu7FPDcJaPJ4VEZDIJo2hp9m6+Yl99cDaY+ZjxuHeKCy7bJrYKTN9oJo028LkjIVWMLCiIkW6sMbt3+OfS9vJoS5gEVG8OjzJ+O40y8QxR0vuGQt31RNmkMuuGI6WZR7RdIOa64619DDvwv+AE5SVKfKXE176QzN9cTAMQR3rNEgIELzlhR2Ic2KMzm5We2x5P8GbA/WPrulSYroPtJhkRPAqOxuBb2IgGD6Kji8LN+Kbqfh51LqJglBLa23nRjVNAGuGSaf8WA1ciBQzVFQ1H6OXylvNYm2o2/3ZIZf9Dcp3QSGzb2xZcsUm9P+eJdxoo/bcQNP+Ma8M79ehWIvlMx9yaGQI/3MBFIXx+udzQRbpu7usZA/5jGiVQZcJf6hsPlsGXDPYyj7m/BZH/sKKP9GbZiGL1tMbgSAJqtqJwhGv/OuJYi/xd2WtgsHS/tsaXWx/Cif97klf5dathwiWGz4YjMMRVovp8AwvjMA6q9LRDxMPL8cT9QY3BGUPa2eOTMeSwbvIzppZh1FwnKINtHVaklRPyBP9dH3IvPLjdmpISzv3Fxx7h/C5YZbb9MIyB5UMkzkUXHGuird2EpMI0HrHk4LULdDT7QHpQQ5g+pe/321lRnWXvNFMiGhVAWgbMoO09vZX/53+6JpAI514D+EZy1B1Jy96VDerVzCuCnHIfTtqbqh71I1wKxuo6kgpMbarTT5zuTvOERGNk8+wEwDpur/KxqAZ41U= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: y5bW5Wt1DRKyj1UEuEvF+EoYjHYEzKucd4xgjTnM7TK7NC06VG2AdIQ84ElVxydEnFXakWcFl85rrVQfr2IyopNoG/UPvAzlSjQ3s1emPOK7aAFReUSJhz+sX0b4KjF62DrEeEfppmMlzyTD7/r3DnZhyJ4ZMkBG8eTmp4GVWne5UcZFuGLQ/qHnlt9glMLQzM7dyd/vpJWtNP0TQbkLtHZpRCOt5d9lfJpBPBXtOCR4iXjVfz3TpohDtET8fXRWbSHceLphyXrpUkhOo5yR8WO9W2Up5wa9FDrDg27VaQj3Q+lwHqElmn1O8vYzJSx161vWu3MO0CRG+WH6Q+4EcPq7VVRWu4MHk5l493bL+3Cc/qo68334//KQRrVyYe79QatLOsTcemmvonuNulDLs6n4dJ28K2pF+FKi5EqwLy3QsLGbYJfdeeZtsslafWvy8JfluQ9JlHC5Bgl9SGNo2NndPXFLUtD3mmjf+vi/bTYtOPlkd5wXmxlDDj2sb1zwFdfu8i9dcHugt7JUSMrRalrC2T2//GpXkAxpH4E9/vPxjuWnOkZKEM0UmAecsat5T4MhCKuCj0qi2weKecQtFiYuujwvZZidSlaM64YG1WlHXltWA5GBvCFbkP7ehWLoGU1ZGMeUFDr0R50G+K1XhQ5d/EDfW6vnIigtxQnRfaiW6NDPdOBCKNvlC0SBULp5Bu1p/QzhXmoUgA7C3G4YuDt4kCuSxiDnx1g/gSmS6eTckZDi7pzPy2DPJviQULxE2jK0KFl62CF6MaRAHFF2AMLQMAYj3ytoo1AN6ngbbH0Cd9pg6WZYS2kj8HvOKjNS9kN0d53W0AwthhgtwHHCKtvlwdNVI5TKHhpUZgtRLrhZJ+ij6LJQSkXQBHc4LaNtsHxKPzNjDp/q1YGD7swKR8Mk3drGVcQvZWkr+IYFOCu6Q/t8j7aqRlSPRS2KtG4WMXjq12eXyHh9XlALzdbW/3hfcxVB3+HKhLJS4/gMlEg7UrWIUW5zHQiSTdfF23Ng9NfoB6pAeTWdEUaJSel3TfBXkBHkClSWIV4tpzitg0+mQEGeToDSSRif4KVxeClMUPeZA+qUriy4+ub7SAsuDrGEZblr1KOCf26fXG8VEVYM+0PFRB1RdozrXuchPkLEajDq3r1NWQHrVebjFkDxcVMJGEjDpntK+zviLkeFEgj6nif0EYF8S4EGWuIRGkrObV67eM8iGBqa/szorM6tlJUnHKqR5Or1zo4DVMx0fX0uhqLllQRc79E0IwgEDrIV X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 905ef3d3-9b85-46ff-e4de-08dcb9ffcfa0 X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 12:19:13.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1489 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * Makefile: New file. * test/test-debbugs.el: New file. --- Makefile | 4 ++ test/test-debbugs.el | 101 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 105 insertions(+) create mode 100644 Makefile create mode 100644 test/test-debbugs.el diff --git a/Makefile b/Makefile new file mode 100644 index 0000000000..3a4b06a76e --- /dev/null +++ b/Makefile @@ -0,0 +1,4 @@ +.PHONY: check + +check: + emacs -Q --batch -L . -l test/* -f ert-run-tests-batch-and-exit diff --git a/test/test-debbugs.el b/test/test-debbugs.el new file mode 100644 index 0000000000..8eca3fe3a8 --- /dev/null +++ b/test/test-debbugs.el @@ -0,0 +1,101 @@ +;;; test-debbugs.el --- tests for debbugs.el -*- lexical-binding: t; -*- + +;;; Commentary: + +;; Please ensure tests don't actually make network calls. + +;;; Code: + +(require 'debbugs) + +;;; Helper Data: + +;; Generated using this: +;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064]) +(defvar test-bug-status-soap-return + '(((item (key . 64064) + (value (package . "emacs") (found_date) (last_modified . 1689593050) + (affects) (date . 1686745022) (fixed_versions) + (originator . "Morgan Smith ") + (blocks) (archived . 1) (found) (unarchived) (tags . "patch") + (severity . "normal") (location . "archive") (owner) (fixed) + (blockedby) (pending . "done") (keywords . "patch") (id . 64064) + (found_versions) (mergedwith) (summary) (forwarded) + (log_modified . 1689593050) + (done . "Michael Albinus ") + (source . "unknown") + (msgid + . "") + (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements") + (fixed_date)))))) + +;; Generated using this: +;; (debbugs-get-status 64064) +(defvar test-bug-status + '(((cache_time . 5000) (source . "unknown") (unarchived) + (keywords "patch") (blocks) (pending . "done") (severity . "normal") (found) + (done . "Michael Albinus ") (location . "archive") + (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements") + (last_modified . 1689593050) + (originator . "Morgan Smith ") (archived . t) + (blockedby) (affects) (mergedwith) (summary) (date . 1686745022) + (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded) (tags "patch") + (msgid + . "") + (owner) (found_versions) (fixed_date) (bug_num . 64064) (package "emacs")))) + +;;; Helper Functions: + +(defvar test-soap-operation-name nil) +(defvar test-soap-parameters nil) +(defun soap-invoke-internal (callback _cbargs _wsdl _service operation-name &rest parameters) + "Over-ride for testing" + (setq test-soap-operation-name operation-name) + (setq test-soap-parameters parameters) + (let ((return + (cond ((string-equal operation-name "get_status") test-bug-status-soap-return) + ((string-equal operation-name "get_usertag") '(((hi)))) + (t '((0)))))) + (if callback + (progn + (funcall callback return) + nil) + return))) + +;;; Tests: + +(ert-deftest test-debbugs-get-bugs () + (let (test-soap-operation-name test-soap-parameters) + (debbugs-get-bugs + :tag "patch" + :severity "critical" + :status "open" + :status "forwarded") + (should (string-equal test-soap-operation-name "get_bugs")) + (should (equal test-soap-parameters '(["tag" "patch" "severity" "critical" + "status" "open" "status" "forwarded"]))))) + +(ert-deftest test-debbugs-newest-bugs () + (let (test-soap-operation-name test-soap-parameters) + (debbugs-newest-bugs 4) + (should (string-equal test-soap-operation-name "newest_bugs")) + (should (equal test-soap-parameters '(4))))) + +(ert-deftest test-debbugs-get-status () + (let ((original-float-time (symbol-function 'float-time)) + test-soap-operation-name test-soap-parameters) + (fset 'float-time (lambda (&optional _specified-time) 5000)) + (should (= (float-time) 5000)) + (should (equal (sort (car (debbugs-get-status 64064))) (sort (car test-bug-status)))) + (should (string-equal test-soap-operation-name "get_status")) + (should (equal test-soap-parameters '([64064]))) + (fset 'float-time original-float-time))) + +(ert-deftest test-debbugs-get-usertag () + (let (test-soap-operation-name test-soap-parameters) + (should (equal (debbugs-get-usertag :user "emacs") '("hi"))) + (should (string-equal test-soap-operation-name "get_usertag")) + (should (equal test-soap-parameters '("emacs"))))) + +(provide 'test-debbugs) +;;; test-debbugs.el ends here -- 2.45.2 From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 0/3] debbugs improvements. Add tests Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Morgan Smith Cc: 72574@debbugs.gnu.org Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.172337995011661 (code B ref 72574); Sun, 11 Aug 2024 12:40:01 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 12:39:10 +0000 Received: from localhost ([127.0.0.1]:40918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7qo-000320-3W for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:39:10 -0400 Received: from mout.gmx.net ([212.227.15.15]:40243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7ql-00031X-8z for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 08:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1723379907; x=1723984707; i=michael.albinus@gmx.de; bh=W/PnqecFZ/dZoDWbBj0de7ZWLEnJYSmq8WU1Hzl2KZo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=WvuZWGfRkPsDhWRtFTzKhlhEfSm+kEXt9oGCcKlai+EZ7Kgobw5kTk2sY7VMyATg niA1T8NlLJXfm1hj6zgSbYTgYWoKGFwwqZjFI6Ud8C6fopyohtNX9R9nbT/eLTb7t k8kvbP8qRRPUMhgcairLlNQqGt3KIedF6aYTEHyHtt9qejq/MWGUCTyIb/wVlLlu6 9z/ROoKcng4iy2mFc/PyaUCAcbHuhNEtMCAjxuAwTX3QmPwFlJQ6R9awJjSFxoR/h VZdSIPPhaQkRyum9N93QW/j9pHN2PZJC6YHR5hu+zJrNQIlgjn1d7kv1I1QUWPJ7d 9jlzhdhf8geKmod4eA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MatVh-1s2QVk2qJn-00ck6E; Sun, 11 Aug 2024 14:38:27 +0200 From: Michael Albinus In-Reply-To: (Morgan Smith's message of "Sun, 11 Aug 2024 08:15:31 -0400") References: Date: Sun, 11 Aug 2024 14:38:25 +0200 Message-ID: <878qx35j5q.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:H5BIdpVHCj0Abzq8OgsuTAMzcD0PslJXDkovkP5i74mRhM1eGI4 dxg3EkJBkHPL445w9Yrp7a4JIa/s6sKi7t/R0HXNaP3u9u9ffU+5J+0k8Cr09Td3IdV/Ki5 JQ7y37RfI+oD97c0M7y3L3LzrzUCd42ry2LJccFWAAXJvMyIbzILFRXuXY46NN4Lh6vvFj1 SiNnEu1BtnSz8j2Kzdy1A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:i46cjg9IrJ0=;Pms3W/XEVDuIKxVLqDBAo3i+tdm Hp7dAjtZauoH5D4erx8Wo9+RIbiPrdP5yLlbHCL8st8EqYLPvPjSB5Q4qUue94DMQO+1oAucp FoJp5mAcp9lhKmZyxQXkE6NUfw1c7yk/8xaQQWmhvI8WWhtI6CiqaFgN6kIcRDg1m+N+/HHot 2ZE1TYZpQ7poTXpHBVn96Ln5/eswRJS4jPfD+5PXlTId8GhuBMKffkqzjCBs9kRAdVNofdd4E o8wuBvSdY6AV9klzqVGeaxFp7ja0QKR4BmqjLpnyxrjJ9PEeGhebROWKe8Z9UOWaW1fZ97LiZ oQho5EjYOkQjaJc35MMv/8VK8YBdvnwxJVt5SPpftxwGR0J6IeXNxIIMxUgpQ6Qlb9ERTfbpg tfgJhRmJaXV+7fq92dEAT6jOnNf2tWCkrnb6uW7xHyTAm1Cg0pYYasmMg7GOOi7xTBVKlbF27 RhgMh+R4ene6m0dfecHVPmPXWah1n70Je9RELu3X4O4keCeztnFQWVfDwwGlur3vKur7MIXBU ebQiNwZt6JDxNJVizX/vevNUa5M7JNC0tbWKj4yQqGvoxBKPc7DebmZHTiXuc61khj6zl25pq /FC2x0MLKqwARNrH/uhQ2aLc0eghJgn7upa6iWOb7U2utYos67lcWqvK6YCgfzCVpPa6CEwPO fjYaNboLalnGlgt55WdcBnwlKVt8YaMtyfSPsGbg+y/LyM7UDIih5ZuqRY8QH8NsCUKxQH99y WpF02xA+fp8O48sbqlJ//m206XynMvyiGQ557SNw55a+ZkCfXYWT6XLf1loBm+gvT8cSSrZQ1 mOHTREU4Au7lic1KVSaVKASg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Morgan Smith writes: > Hello! Hi Morgan, Great to see you, again! > I would like to start contributing some improvements to debbugs. However, when > changing things I found it difficult to avoid regressions. So I figured I'd > try to add a test suite to debbugs first. > > The first two patches are not that interesting. I've scanned them rougly, and they seem to be OK. Will commit them later today, with a more precise reading. > I was hoping to get feedback on the "Add tests" patch. Obviously more > tests are needed but I would like to know if I'm on the right path. It looks like the right path, yes. Will comment this patch. > Thanks, > > Morgan Best regards, Michael. From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 3/3] Add tests Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Morgan Smith Cc: 72574@debbugs.gnu.org Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.172338444721116 (code B ref 72574); Sun, 11 Aug 2024 13:55:02 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 13:54:07 +0000 Received: from localhost ([127.0.0.1]:41124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd91K-0005UV-HT for submit@debbugs.gnu.org; Sun, 11 Aug 2024 09:54:06 -0400 Received: from mout.gmx.net ([212.227.17.22]:45025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd91I-0005Ty-E8 for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 09:54:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1723384402; x=1723989202; i=michael.albinus@gmx.de; bh=OZEV7hmNKHSXKgpwWR6bjBernAC54/eOXXl0nlUgT3E=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=BjSQkcdpAKb0UlFgWBvafSYECmCRQKh9v4Aie1y41lab+vNa2UIQ0CAdMWZieiuY 6LJjvuLb2wDsq1DZLTJUONFvalz8moBn5M3WPryNwRiOyrfui9D56e/ApgPrpLPLp 2q1VwdMmny7MC9Mq8KRlHlOQV6/cPQY/G/tXmYfiPrxDCdroDKYTQOS/qf2kGuz5D S26Cxxu7dngI0ZHT3Z+rTJxkflZ3neQM/vPtKedDn/SmMM3SioZjF2avDPq7U0gf1 CK6SrTs9dDQPk8rBhi3Y8+NNeMwXK2ANM/xM7IEu2ZdJuGmIQ/tCOWyRRQg3dr1Tr U2W830616qbJtkpJNQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MulmF-1sMABm437b-00sjqH; Sun, 11 Aug 2024 15:53:22 +0200 From: Michael Albinus In-Reply-To: (Morgan Smith's message of "Sun, 11 Aug 2024 08:18:41 -0400") References: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> Date: Sun, 11 Aug 2024 15:53:20 +0200 Message-ID: <874j7r5fov.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:5ooJAXVsqPJHB8Fuze+9k1lbwzGc7EsrTS0h8VYH0HbSokWBtVp sz9qsd0LQhv87WCfz7NNDm/Gkv6/8usAFvDjxPW0He08DUl6jWeFsdaOEIGPf9VKaGDzGIR fK61HSI1EyPjqGKoPaTQ63a302fIAoiTte78l6VxUeFBGlVgJvPkX+jDTwrEIqR8hbgHC8t OkdHUob8vbnLlCe/EjJNQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:NmaxBZ7JQrE=;CdVmujCON42lPM68ASI5K98tWzH DbN+udRd5JeBgY1mdOPnwkRA4kLdu28r31xGQHs3CP3CMFkBn7l+IdHYLtHclpKdVsSezoYB9 EJfP4oF7VGt5wKsLRLzRLuDPyCwHWngCyLH7qNABPJBR7J4K+cMHVD1Ve8rMgnC8MZub24feQ rgV3wiBLDcbqr3gLVLOsXbsrm3J5Guz0W0i5JFuFtw5bRos/VzftvQUB4G9y0xw8xLlRPSVyN FofD/ca5lrmp7c92vTVMeJsZhqtKbBpUu87i9ZoYkcCK69SorgGoPLcHm1aVLsRWfGAHBTrHL 6ECUHPkqEnd+JLl0CX5ojcecyw8SXCvlpKupxAxYcyiyKSIHpw4Ep/3Gjsw+kb8rspzhFFVcn xNp4I0RrIXpq/N6zpmIUrJy/WgePXJCud78vWZqRkNiDayOZZzeOs435f2oB92U5pH6PwJzyn IwN2+PAuKfXWN6lYqCqDReUwTYiiLN/EHkyUA2zYO+7HJqxbHGpvQ7JERU4d+mcdvPRbJuKvu YOkK++DEXrjpNwG4cNOKWMDnQdhs2InTIrdQhwyaL/3mRcg0d8YFaQprg0ffi5doIoNyomb4/ bRpC5NAC1X5ffmqpboDXSZvPOO+rMgbKydKf+LzBfUGf26d50EBNrDNSYdG/Xf5tylkbrYt5b HLleWpx/VRLNUJe8KwQP8R/q44s7w/CxlC3mfVEieoHFy+d4HTmPjj8s2NhyC5XGe/2SnvG1L slq3TiMcFpEwNoajz34h1QW5w+C3JjWX/i/jkp1XwPB7OIk9bSgmWOW26zR0OqNeBu4mHdHXG NcX3TzZV7ljWQbGc5wI+zGuA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Morgan Smith writes: Hi Morgan, here are my comments: > * test/test-debbugs.el: New file. I propose to follow Emacs naming conventions. A file PACKAGE.el has a corresponding file PACKAGE-tests.el. So we might call the file now debbugs-tests.el. If more test functions arrive, we might split this file into the different debbugs-*-tests.el files. > +++ b/Makefile > +.PHONY: check > + > +check: > + emacs -Q --batch -L . -l test/* -f ert-run-tests-batch-and-exit Well, you run the tests on the source file. Usually, batch tests are run on compiled files. So you might add rules for compiling the debbugs*.el, and the test/debbugs-tests*.el files first. You call the program 'emacs', hardcoded. This is OK as default, but people (me!) might want to test with different Emacs versions on the same machine. Please add a variable 'EMACS ?= emacs', and use it. Don't use '-l test/*', better is -l 'test/*.el'. Perhaps you want to add something else in that directory, like a README? > +++ b/test/test-debbugs.el > +;;; test-debbugs.el --- tests for debbugs.el -*- lexical-binding: t; -*- The Copyright notice and the GNU GPL text is missing. And also the Author: and Package: header lines. > +;; Generated using this: > +;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064]) > +(defvar test-bug-status-soap-return Please prefix helper objects with 'debbugs-test--'. Yes, two hyphens, 'cos they are helpers. It has a fixed value, so it might be a defconst. > +;; Generated using this: > +;; (debbugs-get-status 64064) > +(defvar test-bug-status Same comments as above. > +(defvar test-soap-operation-name nil) > +(defvar test-soap-parameters nil) Please adapt the names. > +(defun soap-invoke-internal (callback _cbargs _wsdl _service operation-name &rest parameters) > + "Over-ride for testing" > + (setq test-soap-operation-name operation-name) > + (setq test-soap-parameters parameters) > + (let ((return > + (cond ((string-equal operation-name "get_status") test-bug-status-soap-return) > + ((string-equal operation-name "get_usertag") '(((hi)))) > + (t '((0)))))) > + (if callback > + (progn > + (funcall callback return) > + nil) > + return))) Don't override the function this way. It is better to write a helper function debbugs-test--soap-invoke-internal, and to override the original function with something like --8<---------------cut here---------------start------------->8--- (add-function :override (symbol-function #'soap-invoke-internal) #'debbugs-test--soap-invoke-internal) --8<---------------cut here---------------end--------------->8--- Another technique is to use cl-letf, see example below. > +(ert-deftest test-debbugs-get-bugs () Please rename all tests to debbugs-test-*. This is not formalized in the Emacs source tree, but good practice. > +(ert-deftest test-debbugs-get-status () > + (let ((original-float-time (symbol-function 'float-time)) > + test-soap-operation-name test-soap-parameters) > + (fset 'float-time (lambda (&optional _specified-time) 5000)) > + (should (= (float-time) 5000)) > + (should (equal (sort (car (debbugs-get-status 64064))) (sort (car test-bug-status)))) > + (should (string-equal test-soap-operation-name "get_status")) > + (should (equal test-soap-parameters '([64064]))) > + (fset 'float-time original-float-time))) Please respect max line width of 80. Please use cl-letf instead of fset. Something like --8<---------------cut here---------------start------------->8--- (ert-deftest debbugs-test-get-status () (cl-letf (((symbol-function #'float-time) (lambda (&optional _specified-time) 5000))) (let (test-soap-operation-name test-soap-parameters) (should (= (float-time) 5000)) (should (equal (sort (car (debbugs-get-status 64064))) (sort (car test-bug-status)))) (should (string-equal test-soap-operation-name "get_status")) (should (equal test-soap-parameters '([64064])))))) --8<---------------cut here---------------end--------------->8--- Best regards, Michael. From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 1/3] * debbugs-gnu.el (debbugs-gnu-find-contributor): Make regex more specific Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Morgan Smith Cc: 72574@debbugs.gnu.org Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.172338449021190 (code B ref 72574); Sun, 11 Aug 2024 13:55:02 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 13:54:50 +0000 Received: from localhost ([127.0.0.1]:41127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd922-0005Vi-4k for submit@debbugs.gnu.org; Sun, 11 Aug 2024 09:54:50 -0400 Received: from mout.gmx.net ([212.227.17.20]:54477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd920-0005VQ-CR for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 09:54:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1723384444; x=1723989244; i=michael.albinus@gmx.de; bh=T7uQpLPv5g24SkZ9KFjLgJSYDRFz0PsrCloYKyO6EzA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=qjWQFUCo/mg8bCXy1O8Tb8OchqL3DqgzHsmoZmEV9nIyLe7Ae6T7KDLk++G0s/T6 NCm9LdkO0AX8pCeUDJySV2OOgPOBpoImM2hoFhZObJfMXENvbCZoALt6GiYH4SR9E nAR28V4AY8J1hn0TD6552F6QBzAXRd3JoMfOiVhrn/DWM3bubyfAvxuhOx9FDUDjd 5rmE7vk9i7ASyC6Hn60N54vDq3kfLJxQbw7UkFts7P3ENAirZ82347449SZpqKPNX ZGQT9mT2XwnTgJwcSOUGs2IfISLrInOPKtq70epCpUp5ZrsxgwtH6FAmGmE5+lVcn tfsPz5B00NWQOWImUw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M3lYB-1sdy6C3wkF-0029GY; Sun, 11 Aug 2024 15:54:04 +0200 From: Michael Albinus In-Reply-To: (Morgan Smith's message of "Sun, 11 Aug 2024 08:18:39 -0400") References: Date: Sun, 11 Aug 2024 15:54:03 +0200 Message-ID: <87zfpj4138.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wWQhMDLLsd4ytxoObv5ID9mwbp/+6iedK7r9PVxHH+CoQ62PTSM 2XqX78ZtdlQHLJ3PIP9xKE0X/uo7KkB0iqTbGqNxAtqkHxtupEfBYhUWXIDgyI3ZnY7kQVG vNPH7hc2shNtGqEVQKcfraeRZkRzirVuRrxIAsDRacFLgWjffy/fpGHgjEt8vr99y0d8ec0 k4CRCHKlA1mJKQjEkvn5g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:JxygLMrgPYY=;esMsRLiSAXhsCo9kTo6n8urCae6 a6OaJKD+HfgzGihLe+8ayJYVggcEWNXAqyyaxtvLOUza7RSec+cKSbl/cHB8pW2R3o0sII7bp BNYKOkxAor7xURxZRgQElYYOCXU8EO2VkBRZqYRraPOKEEbRLiPTPhZ5hgNukc19CJ/OkPs5I B0/UQ7eDW/foa1XUYgcSO5GCytSj9bM9a7BjnDvvlfnrLlaYhjXEFWF5Sl6+kJONjOZraI9oX j1WcCYadptyv5UcyLiKV1B/9jdrjOF6BsX0qnzT5lps7TCeJVjBXUCaj9PosqfJlynSX0RSce 8sDpuJBGb8RVOq8hsjC+ZP4OAaU9EwdTafuHzaLyVsRE00ScFI+YLl7zK6fOaLQj/zrr8JsgA 32OMHev99z1F+vTaifX/0bq2q26BHCxsITLNmnvN5gsCoNT87zAjvwaFTemHIHxV7sZpTELnt CZw0LlL/kg8KZfBNwSKucCdWn2y9B3JIMU09bJVBT9m94CDkbO635xCuvENzFWPtHoOVOkoUR utULy41+PemZEhSZ/WPsFPr7Isuwi06K/Nef8UjA8H713TsH3PWmYHYu+nFdCw0u0cnvTC9gt DkE6oALoZWOkQVz5/8AO9uhO7AMVnwJic3aEPPCW5MVG1/Yk015fCzCUIC0+9hyReLl8KrQSS YwfCIkcA3HUGC0QfkMQnXpzIrAaixY2YALCFCxR1iE0YpdT2aQLSyJobBVCpakYyerB6n6I9s SJOdxDVlBzfDMjBOMo1lbdsS3G9BpY01+pvc2IvcuGgHAGvz/CpjlrhqS3Tm8GAnFmouIFyaP jwNuzUZ4Ey4hlF4Pg+Ww29WA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Morgan Smith writes: > --- > debbugs-gnu.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) pushed. From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 2/3] Fix various warnings Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Morgan Smith Cc: 72574@debbugs.gnu.org Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.172338451821375 (code B ref 72574); Sun, 11 Aug 2024 13:56:02 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 13:55:18 +0000 Received: from localhost ([127.0.0.1]:41236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd92U-0005Yd-Df for submit@debbugs.gnu.org; Sun, 11 Aug 2024 09:55:18 -0400 Received: from mout.gmx.net ([212.227.17.21]:33143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd92R-0005Wx-QQ for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 09:55:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1723384474; x=1723989274; i=michael.albinus@gmx.de; bh=esjqZSgQt7ZJJeY5J6t7Nqm24b1AZfQSz+NGHOQhtxk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=gqUoGpfltHD37bSXkrhlNcLIQIiZ++uYBiFH7liZDqLOMDQ4NuLyxX0DT7/hFhHI TKNobYfBbuT/HawZ4mg8wHkSL1nwhTWSIFy960opS1OrolqkYhc4oZsdDKEfqNHj/ U0sc/Nr7jlGcPzJTt+t7+JpAhFv9n7yHG7ffbLfL8YCJSP0richY7R2fE1slEFr/g I6dmXI7FYM4VZ6vHyyOA9vxVQBCKdLOUuTTA+phu1cjzD9tpXI4Jj3RN5na3tdDa9 OXvYiYGoexTJtAGvdGsex1fbCbYDUu3cFwBQUBCYDwpSe78p+DMqs4117CvFVFy17 ba33EOAPqzDu3EpKvA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mj8qj-1s0o4C3aTN-00hi5n; Sun, 11 Aug 2024 15:54:33 +0200 From: Michael Albinus In-Reply-To: (Morgan Smith's message of "Sun, 11 Aug 2024 08:18:40 -0400") References: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> Date: Sun, 11 Aug 2024 15:54:33 +0200 Message-ID: <87v807412e.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:diTZ5BDFgDTq+FHqzSAs3lDKfH4CRKf8qA/0JTcFGiRW2gvWa6q foHy8xsw8U9m/3FDOr3r5JHZPq3sgT/GJfeMu7g7wISBOAOZiXqPFymfCJ8vihqzLG6SADZ B26L2fWTr9RZfHO/pCUDohU0I/bT5tzw/YHjNtFgEHKVBlX8EHooSq6CoUzMnS62K1A+Fnj nvBsLKVOXhLp0KVwvloSQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:L9jNYrCfTmk=;NmMATuctSzfdhEUdHeQOuOLvF4Q Ot/hegjhrBehQQ2kRwFCMzP4RMIKGxXQpOuuetw5B6eTcxoXq//yZzdgjufPtVkCVJC66CwhP Acp28t/rB08+Rz7+IQMO7md4KW3AdKHG014tIU/jOM2QSrz5Dt7VsDDQ/cIliT+0rsAy0VUup ug+/kVRQtWcYcPmbHuhj2af0s1gSkTyRgV/Lgf/FJHigcHldPz64s0wesXn4p3uy9PkAb4v6Y FC99r13wMAAW8a58SiNLmaTvtkJSsyLOgZ4UFN8HHubpr2FKDm2dIu8cjj+HCNa95oaBZ8g4F 2Zt9n9nEf5d4g/CSGp4ruDftFpgvfej1ONk5CiNCciOXE7DNapKnBOIaXDDyUNzKi8h37SdoO 5xpK1m8M7uQq4Ll+tDp1ik/6scadQJVjOmlq0IubQN7AMuyKcYnwj/g3SWqlWysPLQBNxnwO/ VGLcMoMw5UfZy3ePsNh3HDybu5wDPSE1FtGxRB8fK1C1vyr1b+nLFcVu+/240zgf45twjptpZ 8QEHDhUFW4JW1dZcjpPUbURcv0od//Yl9oG4YVK4/As4hjy+NfMenuTKlaYA00Ga5qXL7DrNp YDNM+Niwj8Qi5Jpx2OcZYU3JXr9AC1SUNbqkwcuTwnBCU6d6OGmTopPod7FWDaHDZpV3EZu+t jpdYcbuoTCCevCXkHp5iHTZXtyvn1AfYCRIfeN2bCV/ERkY+lPuCuuSqo6te6+suupELmVa5j QIrScLgU4pRemeJbGgx7oHL37yBtWee7zb0gVLUFZdiQiVDI0j8MMTNpBH/aSV6u4R+ajM8MO hlLT/vMWy9vD9Qot9jwAl5mQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Morgan Smith writes: > * debbugs-browse.el: > * debbugs-compat.el: > * debbugs-gnu.el: > * debbugs-org.el: > * debbugs.el: > Fix various warnings and checkdoc warnings. > --- > debbugs-browse.el | 3 ++- > debbugs-compat.el | 3 +++ > debbugs-gnu.el | 22 +++++++++++----------- > debbugs-org.el | 7 ++++--- > debbugs.el | 12 +++++++----- > 5 files changed, 27 insertions(+), 20 deletions(-) Pushed. From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH 3/3] Add tests Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 72574@debbugs.gnu.org Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.172338580224300 (code B ref 72574); Sun, 11 Aug 2024 14:17:01 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 14:16:42 +0000 Received: from localhost ([127.0.0.1]:41789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd9NB-0006Jr-7F for submit@debbugs.gnu.org; Sun, 11 Aug 2024 10:16:41 -0400 Received: from mail-dm6nam11olkn2014.outbound.protection.outlook.com ([40.92.19.14]:48257 helo=NAM11-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd9N4-0006JW-Mn for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 10:16:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DmmnjJTw72FcxrvcFixD0XoMf0rOzSGylMbG16QdDnmzq7Tw1o3TfL7WTCmw9UGmMOFyntgKqb/eV8Bus+afXeJc0KlnOwQB8oCWpsm3PVKZsX/IOiMO+N1NEbWPWvl4Z5TqPWU4TU1uBQMczR1gR4pKaWv5Bdb+8W9a4NgDWP7MgNdNHMe8ACj2b6xSOuYhegF5UeDnodWMbZd2P1ypPgVexcs84/YOJJoS07a93IwherCI3FWBXJUcoQRekZBTZM7QOzJ74/LHWsX51RDxfmRPcscUb8ol6cpMJj8GCPsSEix7kymywM/K98ncbX/RnSR7J7Tss46DfdZtgDiEIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lw+d+ooKy+XTEQ8lbhN/4ysJG+8wdVJ5emfdRB0L4iQ=; b=caXSaEKTmhbaEtgmJWb3hmB8Bkg1ALW7e+o1JJEl0njRrSPiUWE/PBy1bnPYd7OFYTNZWIOvZ6tQWFA96PCT6euQbihCZ3eGGWt5np8Scl2jox+9weQYmK7yodQdGgbMi5Y8Yus1pTIfK8Xk5ip9BEn8JUUMTUyKoSIaIUG2lBqWf08i+URB/vr1zEFF7voMgXEzq3RzyKQbwavNYKcDgEZrVJHSnVZCcur9E8vzmn95+JYWO8Vlbfj9TrxommEwVcKR3+RVbkt68MDfqKPpfJGiFz3DcNjl1NL1eMVkoaDz0dakCIZ3lp0XuZG24SGPZSzSRuIT/B54yZDUZApPYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lw+d+ooKy+XTEQ8lbhN/4ysJG+8wdVJ5emfdRB0L4iQ=; b=YEscDmOniu0V1K8YHNRmZiiF9J08KUtThvtOxgRv5JjNa8VdjzpBufWsER6caHiiPjJG/hFEGMbd4KnGIdG3S8tB6zPyaJbuOOYzdgnRj91nd5poFvxatwSKCtRsm5kYqS36UAkeCQFw+mW7XT76UNXDRffalYpsB4RhT0IwZQtBlSWta2SSAryWo6JGrwo4Ujg1NsPVyCHcYnn+P+PsAkxsyrdYMnBskAx24dwciGEJK5mBjBRknhh3rQpDcq0Q8tQtqcBbGRkbE1w9zPJw2Oq3HH5r769jlbUMjAQEbjtlCX/FzO5c2QuYr90VBt+JoL6YaB1qENOIASdaKb5oqg== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by PH0PR84MB2028.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:163::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Sun, 11 Aug 2024 14:15:42 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.019; Sun, 11 Aug 2024 14:15:42 +0000 Message-ID: Date: Sun, 11 Aug 2024 10:15:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 References: <20240811121841.5584-1-Morgan.J.Smith@outlook.com> <874j7r5fov.fsf@gmx.de> Content-Language: en-US From: Morgan Smith In-Reply-To: <874j7r5fov.fsf@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TMN: [Z+w9BedNVP2xr7l39o4ki3HXd4VY1ICk] X-ClientProxiedBy: YQBP288CA0007.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::11) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <56d95553-2b95-5cdb-d23e-c256022f4692@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|PH0PR84MB2028:EE_ X-MS-Office365-Filtering-Correlation-Id: a5f0552e-e630-4305-4266-08dcba10154d X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|19110799003|15080799003|8060799006|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: CHhoLK2OuMi1w6/SBD6oUKuyHN3DqmlVGyiHSzAgHOBGrfbPYgSdyegkfsyhpWSb2erTZwVRKgYb12AQUpOJ8x/WETHkUY5gZXtxWvrh6vHICmYTOc4IO0TTJGzMwlN5h03ZYboltGAlGndFYVoFnPA2HwnX+4Xm3H69obrUepSzJQ6oXeqh5r2kIjV0un9h7CT2p8R+UM/f1zHNmRVfVZ0Lm0pCGAB6zI3E2J8obIyY6/HtjC3DK2GoZIQXiSvTFQw27zcW9UOO/XoudVNFwn2rWXCL54+nBbb//inBlVB2F6skjzTOVW6H5ePV4pooM+CzR8cTfMwv8D7NczMx8lmrU1AeouPvQR4eNfS+sPQSWiVmnBOrDmmoKmhLyvYuT4KyVHP+ibtRWUmuwZOqkg9OyT8U8TffdVq/OqeMYtLCj6ASICaT4iVrj0vFwrpk8/e/a3U8+Rx1bU2+ej5/AcJheU+eCzXHMYEnj5hjN7WRyL/PJFj5wPd8nD7lTVUkSMuEhpS+zlPdtV8EJygim9YsAjyu4eY0DqmZp3XhkWOWJlTjKFyJmdYch1mwTkYCnkAQyb66P3oQvQBpZ9JvyD5rqUn2XmV4TSKfcOPoCGvwPfE0ADiTKi38VwDbdibLK8ZWTashd0aXdgH/eACg1npUJU8yrMBjqUPB/5usmNhASkQQNOhPxgojRr5oN0dSifj/2Ae8fGifQEAFjvEFxw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OKxI9fTkpF56ejbZASfMLE4hrwHBzXQL6JaQdNejCIQ/7cEAzSjGbM1aVm+4RKXMiWD9QU9nH2eMX2mTzSZGLAAWWfzYO7NHFyQvhj95yKUoYPwt9Lhz6rQJ/g3gxdNQm6ogEsnWeorZ0GFQuU66YE2NNTAOw2hmTXps/xuq+l3cqrkNFIVH9u8A/d01LOr4ElFm651IT9Vl91930+dsHDBrgMXsfU1ksyFuxItMbEF3GypWH0l/B2jsFR6mmq2GuVPzS+9ijvtByiW6vf7PVly+1BFo+QrSYog+pUD75Yr/bqMde58BVdK3Zns00CnRIM8gxnswsK7098XeX/je92W+XnPvSZhVBv+9aX+hf3LhzOhM65uCF+6/J/otXmt9t33p73wmPYYgX5uYd+s3Tu/SQVixzYTlSZzj9DtK9iJd6LQDk7E5P39gwpcXr61NB+v+iXs9fynuM1jf1T6BhOHfYWalPjmMr/5gGmrVKV+FOMfUfwzcbAMf16H67+tZCjNVxnNLX1SFX+62GSTaLtBuYr9fOXcgv7SY3chctQKaf2Ah252rW5dNXfFDv5wrr4ozfctlzndXy+Shopa3c+sSSc+9MAqzYaLiqV/VmdK7eECzTc0RLDpOHxKBMjHlISNntzpf3CPj+IRwatUZdCeUzIVZwlY1LJDshFrksLy7IdNub8eHHWoZ+0o/NJ7fHZC3ClMNsSAeU9xufYw5qjMjc/GWlTMvcLTa30+pg8El0vDyaSWiSVahrlT8vtjBACMzvQ4lkEvV0EG5r4glKdLTic8YJdDKR8mipWWu2tHD8WQyMOk8q0G73+6GIL1kXYjwpAdbeGy++gY78Q99MYp6ghEFz478VHu+SlvIqCDwiwPoeCXZSwENG46o/C0mdiyg0rlJPm0ftxUwJSUFRlXv/WQJhrzI42IMhLO9/foRJHlloF5nC6HtdTaJlE4JQ/uS1tc7Ql9rp+DAOD19/o75FT3zwAMmaS95LdaJF3yJu5ofCknFytmXN6WiIEsgrHfvq73UgeGl98CbMxhmURNSInHPW/qinFsTsUPCNU9bMnLfl8hLL5afMD7ji+4oyE+m95Ao0BcltAmp8aCNqKnZhIOBr6sTcv1Vxoqw965bDYNo7WBIrr1Cl01PzHo6GDg4RFigHwR1o/VWP9HS4VVTkbNGBgarPEgjLKg6ei/IFl3bAU9+yZW4MsV+NvIsVa9k22jOfIIOoal771kCmaqr7dZEckyn9LlsEzKl/7rE+VX3AHrukds5nd4ijpni X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5f0552e-e630-4305-4266-08dcba10154d X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 14:15:42.1728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB2028 X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) Hi Michael, I really appreciate you taking the time let me know all of this. It would have taken me a while to figure out all of the best practices on my own. This saves me a lot of time! I'll get you an updated patch soon. Thank you! Morgan From unknown Tue Aug 19 02:59:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72574: [PATCH v2] Add tests References: In-Reply-To: Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 72574@debbugs.gnu.org Cc: Morgan Smith , Michael Albinus Received: via spool by 72574-submit@debbugs.gnu.org id=B72574.17234141425315 (code B ref 72574); Sun, 11 Aug 2024 22:10:02 +0000 Received: (at 72574) by debbugs.gnu.org; 11 Aug 2024 22:09:02 +0000 Received: from localhost ([127.0.0.1]:41998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sdGkH-0001NR-O0 for submit@debbugs.gnu.org; Sun, 11 Aug 2024 18:09:02 -0400 Received: from mail-mw2nam12olkn2069.outbound.protection.outlook.com ([40.92.23.69]:50176 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sdGkF-0001NA-Dv for 72574@debbugs.gnu.org; Sun, 11 Aug 2024 18:09:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OIoI9rAnMUHoRiKkA2l9wgFYCJqmk4JaRy8zSvF4xlPk6vq7RfCMJG36teynhFRgQ1+p245OVXE7KgqkujJSaaWXg0qSzP3kNqxoH23jgjAAiGdeSlCol2MED6btQa7nOk2KLYDZdzZJmuRUYTneAjtGrbzjEIc1/flwluA68ofLzYxjojsr5Ow013nXuGbPNoQQH7udPuqyI1/UbNDbHsMPSG7fl+Ltd9TO6xpCd2J/z/WKJi4Sk8pWgqllpweeNJjUmNc3YhprVBfFGJCPtUBmBjA05dD6cwEyvK9rUeq8SEyMDJSxg+LYGyqqEhhRN3cv0tiuBMxu4iO09S8RCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vFU7WzdZw9Hbm0Bd/0Mha46fUZXpKT2On7GqG+UZTi4=; b=fpbaCJs6/Ak7uUMcL84tAlI0K8TYL4daNL69IzrOokuuMPUBVMs9264abmdisu0/iYxZhcEJARYlqswYREzpYMcxdgEzGIHtZgoQ2I0m4KyLBk70MrjbTdhAqJsCx0UKu6Jkgk+LAMSQKEJl+6oLybpsd2MFNcanor2Fnt49vu9A9H7AkPE3e8LxeTCXj7+gXxSCGK7JJBDMEiQDdf+L9NP3uGeR6+gQYTP2L0msCCW74W2u90/Sfyw8yX1uYIQOMzZZmzYGvRr1bmQ6d0P234q4Vh47t0fUFKl2KIqvjVhj+T7LSxnIuFfNxSchQNBGkq12n7FwuBI0LSRoqtILRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vFU7WzdZw9Hbm0Bd/0Mha46fUZXpKT2On7GqG+UZTi4=; b=f2JclDlQdm3XiCkpdfeGzgYkwH4YJMOKV05GfqvOrtoIS/lKHgUGsXAejt3pC/V1pYlSfer41diPZljLrg4TdzdcU1YaKYRrahUVXCHC2ONFGICz1XwxSXbholzznXk4ceWiUFy/bqON6h8TjljVBorRE2yK2iqFaNrlvdX8anVSojNIJAuH9mt/wOylI+PtnV2gpqjYZnUVHZGxo/xL8gxpqI/E4+wp8JfpRWksxR0/Lt/dauYP8ciWvB+Z1jhd1xp6SScL/enVnOoK6FdaGH62SwUkk+K8R7jFeFyNJpSgpprtnLCvNxjrgIdSv67dmolDmoFfXM/HqMPPyP1Tmg== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by PH7PR84MB1703.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:152::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Sun, 11 Aug 2024 22:08:19 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.019; Sun, 11 Aug 2024 22:08:18 +0000 From: Morgan Smith Date: Sun, 11 Aug 2024 18:05:30 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [JsuGpDa0uGmm6lmr6DkwwA7+veUxyRVa] X-ClientProxiedBy: YQBPR0101CA0260.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:68::34) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <20240811220745.19222-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|PH7PR84MB1703:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e34ad8c-0499-4035-cfb9-08dcba521b2e X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799003|5072599009|8060799006|19110799003|461199028|1602099012|3412199025|4302099013|440099028|1710799026; X-Microsoft-Antispam-Message-Info: /Qud3ZQdvDh5QlB+55j/EBGL4L8gQspVn7yuyX5NUx11TKPSB3lDULN/fXUavIkNLWVy8ylao54mhYWosIY7iSrBgRtH/bjEFqzvnsZncljn6mq0NEQRPnY00jCfaJ0EM8pTCCXtu6QSCRhqZ0aL6eyknljNthepenz9et5WL2f0j3L3Cmtf55Ud22cxEUYJDDuhVRhSSet55GHUYhTJx3tcL4exnBNFysV3QG1ZUudegx6o7mTBm2U0UfVgCIbRvCOdyPHM8wb9JXU6+a2kjtwVPU2Q3GqLbNBJ3fStAqEdBXtd2UJnGbUfhLZgpMpLLJCiiQZ1tGaJBVP4qGp96NVmv6XuN1oMNm3NtunsSJYXskcrn9ct8xOCv21Pb9i4y4P5iglq8oO8g5e3PsGPeZtJiRsxqIw9cYq8c3v9zuXkjMFW+MnVEdRZF4IqjIwqfBNbC7CtfImuemXAjz8mh0RVpJCFPp3XxLoO85TX31R2bpxXdkeOR2KEeJFMHLmuofSzsYUW6lhlP6ls5O84+4+eXf/682V+9s/YFDFPWiEe8tZDFYAg/LxuMucfrbVgv9UMI3IdyYZKtVR+RjjFn2GTVudISJG+Rf7BxPvivfU4j0U6qridCX3//MGbQB0fVezDGczOT5rlMAnuYZdDROfjY2PyJW4jM6Q8LaWvBIwUk1aX1T9jXRaeJ8FnlJTf06xOTHAm0S1tK7uAJMbsPIjWPblEgLvy7mtHGS0JG/TqXQcVa1Wvbg1GmALzNhTQXvTVdQys+zxsDtYtWQGeBXxJdAtLQ+DvBnD3O0yGWTKmKuN6oYzzN8jQsrJ7UgiD4LBSfUWk4GuQR3echogw5g== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8LkH3XZbZIjz0Z3DnycLT28ssCkoHPpJ1oBY3o2Dz9mWfKI4NbrYYlNmdhpDP9eSoWnPuBbJ3RmADszL/7pePVzmHGXue4j8p3yy5R5z/EaCorm9piNYI0wwLtCTHLRiG07Hw1aOPRoQM6aNoBkNs8yrgD7RB5qGMqzqnkMx1TRs9dXviGepP0vQm27EyePf46JtWmbGQ36Lj1R59fjUWqnQT42rvJiTbMZ+S6IkzRD7OLveprAPwHasNyzTcBGhoeywt98ImPIi/Et542GqCcTiHaYvSIdOCKpkutDChTt9IfzlDZ0KgTjNCoWNmFYzcYmHIPWgf0V5KrXu5suzaOrWU3MtitpbtTDjs42GOPu5j5NXOjGXyruhfOs35mvg+6NSdSaz/Sl/sGZP4SpaF6xowc0B7Pkc0cZgdn8v6Fz0u97GLV/V3ymu6iKBl/YVnLZKWHh1/WT31+tR8WessqZNEd+6UAZolIWZZMDG+s+SXMQr58a39fRWxhRQYHLRaSbhXRQAgl85lmCdBwIm7b6IxRJSQPJEf0p+SSGFXIRQs1qpO4GNk3YhmtUt/MxO/qTiMWhnDcgh70/SHfFXieD93QheEr2bz5SzPJOrS+4KvGyTKByyLISplfui+2JN2li0uAe/BFgn2SmAgqK5YrhePMW0+zlKnEFsmq8H4yA9PY++Uo+gbBCp6bsaj4CH2elzzHe4TbBg4aMrR0xNCb/loGvim38eEnbC2pimeH4rdMVEg1l3GyV3lsTZU2ymCY6oV9sBGWyAFE8HPmVxd90Onj5TGSVwX1SRNJNBObsoaHxuWDfDtQPXwr5WJJAFFQmKGcWpeV5TjAgBXT6cJWO+ERYiXsvUjquaBgeXiQSiOiANQ0SLNTN+8wFksI8vn+P8FjZitZtfXIBiZEVUQRV1QvPsPH/7/xyPB1WY5Wc8vV3/4exkcEkFoYHU2CAykbhXkGXkDxgdSnOzcJkb9ET3MEE6dRLNfpk9C4/wjJVrIyk2sWTD/QRil83wa4Zn2xaMbXsKagmG0EcdOuuhioeyQHpGAB6CrrMoHnVp2ASmwP2ZXsfoCRm4lEepJrNXdQjtlOsvPq7CuNEq7VA3bI1JvzzUgOEIi/MZj+39te5saGmfJ/8MBaWl3tWlNgqq9t6h/tSFGzQT5UGcJCs/tQA5lEgtHSTcvwOc+z3Ev5M26dQngBMbHqB72r/emh0OvJs6d05p+CeAPzHm9ZYDGbCCcGbstR1y4NfD1V9FC6PWkOqXGM1x7Kb6n3fOOPu2 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e34ad8c-0499-4035-cfb9-08dcba521b2e X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 22:08:18.8011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB1703 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * Makefile: New file. * test/test-debbugs.el: New file. --- I made all the changes you requested. I hope you like it! Makefile | 20 +++++++ test/test-debbugs.el | 132 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 152 insertions(+) create mode 100644 Makefile create mode 100644 test/test-debbugs.el diff --git a/Makefile b/Makefile new file mode 100644 index 0000000000..86cc575a2b --- /dev/null +++ b/Makefile @@ -0,0 +1,20 @@ +EMACS ?= emacs + +SOURCE=$(wildcard *.el) +TESTSOURCE=$(wildcard test/*.el) +TARGET=$(patsubst %.el,%.elc,$(SOURCE)) +TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE)) + +.PHONY: check clean +.PRECIOUS: %.elc + +%.elc: %.el + @$(EMACS) -Q -batch -L . -f batch-byte-compile $< + +build: $(TARGET) + +check: build $(TESTTARGET) + emacs -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit + +clean: + -rm -f $(TARGET) $(TESTTARGET) diff --git a/test/test-debbugs.el b/test/test-debbugs.el new file mode 100644 index 0000000000..e22aadc14d --- /dev/null +++ b/test/test-debbugs.el @@ -0,0 +1,132 @@ +;;; debbugs-tests.el --- tests for debbugs.el -*- lexical-binding: t; -*- + +;; Copyright (C) 2024 Free Software Foundation, Inc. + +;; Author: Morgan Smith +;; Package: debbugs + +;; This file is not part of GNU Emacs. + +;; This program is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; Please ensure tests don't actually make network calls. + +;;; Code: + +(require 'debbugs) + +;;; Helper Data: + +;; Generated using this: +;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064]) +(defconst debbugs-test--bug-status-soap-return + '(((item + (key . 64064) + (value + (package . "emacs") (found_date) (last_modified . 1689593050) + (affects) (date . 1686745022) (fixed_versions) + (originator . "Morgan Smith ") + (blocks) (archived . 1) (found) (unarchived) (tags . "patch") + (severity . "normal") (location . "archive") (owner) (fixed) + (blockedby) (pending . "done") (keywords . "patch") (id . 64064) + (found_versions) (mergedwith) (summary) (forwarded) + (log_modified . 1689593050) + (done . "Michael Albinus ") + (source . "unknown") + (msgid + . "") + (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements") + (fixed_date)))))) + +;; Generated using this: +;; (debbugs-get-status 64064) +(defconst debbugs-test--bug-status + '(((cache_time . 5000) (source . "unknown") (unarchived) + (keywords "patch") (blocks) (pending . "done") (severity . "normal") + (done . "Michael Albinus ") (location . "archive") + (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements") + (last_modified . 1689593050) (found) (tags "patch") (package "emacs") + (originator . "Morgan Smith ") (archived . t) + (blockedby) (affects) (mergedwith) (summary) (date . 1686745022) + (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded) + (msgid + . "") + (owner) (found_versions) (fixed_date) (bug_num . 64064)))) + +;;; Helper Functions: + +(defvar debbugs-test--soap-operation-name nil) +(defvar debbugs-test--soap-parameters nil) +(defun debbugs-test--soap-invoke-internal (callback _cbargs _wsdl _service + operation-name + &rest parameters) + "Over-ride for testing" + (setq debbugs-test--soap-operation-name operation-name) + (setq debbugs-test--soap-parameters parameters) + (let ((return + (cond ((string-equal operation-name "get_status") + debbugs-test--bug-status-soap-return) + ((string-equal operation-name "get_usertag") + '(((hi)))) + (t '((0)))))) + (if callback + (progn + (funcall callback return) + nil) + return))) + +(add-function + :override (symbol-function #'soap-invoke-internal) + #'debbugs-test--soap-invoke-internal) + +;;; Tests: + +(ert-deftest debbugs-test-get-bugs () + (let (debbugs-test--soap-operation-name debbugs-test--soap-parameters) + (debbugs-get-bugs + :tag "patch" + :severity "critical" + :status "open" + :status "forwarded") + (should (string-equal debbugs-test--soap-operation-name "get_bugs")) + (should (equal debbugs-test--soap-parameters + '(["tag" "patch" "severity" "critical" + "status" "open" "status" "forwarded"]))))) + +(ert-deftest debbugs-test-newest-bugs () + (let (debbugs-test--soap-operation-name debbugs-test--soap-parameters) + (debbugs-newest-bugs 4) + (should (string-equal debbugs-test--soap-operation-name "newest_bugs")) + (should (equal debbugs-test--soap-parameters '(4))))) + +(ert-deftest debbugs-test-get-status () + (let (debbugs-test--soap-operation-name debbugs-test--soap-parameters) + (cl-letf (((symbol-function #'float-time) + (lambda (&optional _specified-time) 5000))) + (should (= (float-time) 5000)) + (should (equal (sort (car (debbugs-get-status 64064))) + (sort (car debbugs-test--bug-status)))) + (should (string-equal debbugs-test--soap-operation-name "get_status")) + (should (equal debbugs-test--soap-parameters '([64064])))))) + +(ert-deftest debbugs-test-get-usertag () + (let (debbugs-test--soap-operation-name debbugs-test--soap-parameters) + (should (equal (debbugs-get-usertag :user "emacs") '("hi"))) + (should (string-equal debbugs-test--soap-operation-name "get_usertag")) + (should (equal debbugs-test--soap-parameters '("emacs"))))) + +(provide 'debbugs-tests) +;;; debbugs-tests.el ends here -- 2.45.2 From unknown Tue Aug 19 02:59:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Morgan Smith Subject: bug#72574: closed (Re: [PATCH v2] Add tests) Message-ID: References: <87jzgm3vy1.fsf@gmx.de> X-Gnu-PR-Message: they-closed 72574 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 72574@debbugs.gnu.org Date: Mon, 12 Aug 2024 09:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1723456742-24047-1" This is a multi-part message in MIME format... ------------=_1723456742-24047-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72574: [PATCH 0/3] debbugs improvements. Add tests which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72574@debbugs.gnu.org. --=20 72574: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72574 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1723456742-24047-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72574-done) by debbugs.gnu.org; 12 Aug 2024 09:58:13 +0000 Received: from localhost ([127.0.0.1]:42476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sdRoa-0006E9-P5 for submit@debbugs.gnu.org; Mon, 12 Aug 2024 05:58:12 -0400 Received: from mout.gmx.net ([212.227.17.20]:50523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sdRoY-0006Dt-AQ for 72574-done@debbugs.gnu.org; Mon, 12 Aug 2024 05:58:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1723456650; x=1724061450; i=michael.albinus@gmx.de; bh=XMCwsCNVrvyb3vsngQ28FHViF/blwYGXApPSfLOmUCA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=YXQNKsQ4ZKjrwbx+niHsL7eLMzZmjatMMPLlZzHS7IU6q2d9zkcisUBaWXhxcNSD mnUxfFP+uvhNE/fuRAqFJneDv9tX/33cVNU5pt6gWtzXMrzep5HYvR8JfEO8mCHUf vPlqROODtm/Aicf3k8Zksqx8/9N+N73rixbg0eYxhzG4lQsQWYk1bn8Tn+0blqZN3 ErOvs/u5rUhNUQxSJyRd+NZi2QDz7ZbF6AnIAaH0CSaFxxPolAMxB9n1BGB7cELUD yKcP2zBmaPVn+ThnOpi3rxGWSt1svFudpSF49KieSszMye3wZs8Ya/FttMp1gIc0O VtBofSWzY3jjxkWQMw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDysm-1sVmJB3q5s-00D3mW; Mon, 12 Aug 2024 11:57:30 +0200 From: Michael Albinus To: Morgan Smith Subject: Re: [PATCH v2] Add tests In-Reply-To: (Morgan Smith's message of "Sun, 11 Aug 2024 18:05:30 -0400") References: Date: Mon, 12 Aug 2024 11:57:26 +0200 Message-ID: <87jzgm3vy1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:mG+yaycJdgOqP4blhq7lpr+Aoh+DczYdx5JaYhxKLIRoTb6T1Mc BGhquGXdotBXGIbjWWr6H9f2gpZm8oZIvTzxccelxNe97vJ5+1upaT4StezObls6AtcwCBr daySAYZsy8hPDQnWEjmbumsRjjykS7bwhSYIsuOmC36xbHsC7eMsPUkmQXZSA/30VzO9/sb tefgJ0OVK7FsqusCUtjOw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6iout4F/lnw=;6XajA0P/kl3rQjiVC0NgWquwppA Hh3fEyfOXBq5NwfGLSKhLIC8eu7inTZLsBTSa1+fSJRfVd1oW7RsBLq8S8sfKwOwvs3xovG/V X6atUyxx9Fd2y8UGeFEDzIeuovoAJMYySdjG3dRB11vnna51uRJLCSTQm0qO6Rk1TB64Q8LKU NNwz8J9KKQZ1/jKOy0/6TNpvzSsm6ZC8WJ/Ie69fODoMJhuTDp1f44eNnY9dkgIvLAiFhxZF4 w0yoCsn1XAPS4CJ2AJeYSH732P/1a0nc8y+d3vTgKSIO7FICIPAId5qsHkJdUbN/KdLFLx0Vk mJvQsZxmccRGZZxeGkkLl3culUxYaZjucifwVjE+1/rNTCthZcn2fRA3ll8GQnheHvMe+bJNM KTd8D7poismMEOxXaNUG1x+5qCg4gktQ4xsUD3ojWdDa9DvihnSsl1gycsRzPaDNBKtSuOiKv c5UDO4Boy4hAdg6avQPDz47Vf27CFVI0pgkAZZw8hVPiRGEAZNori18+U9/XOV3HDWP+ViEUL byAtnw12LUg43KB/MU2eE+L2dXl3oynKOod5fUPwaTSiNQ0OeDRuDp+3cU0Jty7xZcrzr950j qtrfbAyNmD4jnEZZyHqimJeWXqZnfnCHEq2d4hH5TRSoGXnFXYl7D3c87ENIO/Qzi/DxWivLV fcAQUaXo/rxv0mZE9X6T6Q3kd7SHgtGFwT+C3DMGxFjJvmfRjtv6SHyNjHfN5G9dDkmrBr6DB omGNHdjaJMHhFr53/ZwdNgmmImZZxkiGBfEtxFouKCNcdO3LG54RL9O/bdpYYGS5dx+0i+gnp iLghImrYdu/porvGzkL6WPHg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72574-done Cc: 72574-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Morgan Smith writes: Hi Morgan, > * Makefile: New file. > * test/test-debbugs.el: New file. > --- > > I made all the changes you requested. > > I hope you like it! Yes, thank you! I've pushed them to the ELPA repository. I made also some small changes afterwards, nothing serious. Closing the bug. Best regards, Michael. ------------=_1723456742-24047-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Aug 2024 12:16:54 +0000 Received: from localhost ([127.0.0.1]:40896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7VG-0002Ph-3O for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:16:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:40942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd7VE-0002PZ-No for submit@debbugs.gnu.org; Sun, 11 Aug 2024 08:16:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sd7Uj-00066B-O1 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 08:16:21 -0400 Received: from mail-dm6nam10olkn2071.outbound.protection.outlook.com ([40.92.41.71] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sd7Ui-0004Dw-22 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 08:16:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QaaIxiM/un5BUjuZ6ift3ElkaljibJw68jHmMIFIbFGAtGvIX4ehv1Yz9k3Tx+tVkopQ497SDUze3ct7s6wFuHmB8q4wKLHDN8JH5cMZlLLsJs2rlJX9XG66o+dDpdSCw9DBSIb/umT/uPVyg/2hF4cnuTS7vQ5GEDQaaxyr1X0hFgeLNOnpzJSVixch2MxEs/L+XkNYGj9rBd2buo6snBASGEldcwWNuG0645jFu0ZkoJmdDX44gRnskrJcvY0WJEkJNsjqthqFrJb7E0tvOuFw3yqv2W8COMECMaXhgXL7iqH21QgSoQZZZaftoScmd/1q5NhdmAhLhufAwcC+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ZZgRN3SPdQHbLvofI7akDGdfLy+Y4HVDvq1Sc4XmAs=; b=me7pGy5QZPnpzvA+ZiGQhqDB8pfHyfukJb/aEgj9nVbrHniOifzrb0ECdJIxfTg/3jdEaGeZzBx7HUrqj03XN2wo6BFk6VyiZp6l+PPPKp3GAX7VN4uugJK4kw9m917PVXfx+er5OhkdEuIk8z1gyr8Dyyjl0LxR6ye6zdRABqOZ0YUwnc6LFRtOkTt/rQzcq/v3d0WiyErHkY4n7WUI3HuoSDhD2Wl3eYPrx9D6C7e3fj2WLy3/phlpkuRP8yDaN80cv6bpYhvE/oghFAgmIL/xyDxYySdN7mbTRpnsFIxZiwSHgEieAVetKUl2NOjq0KTOy5iygQZuI03na72E7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ZZgRN3SPdQHbLvofI7akDGdfLy+Y4HVDvq1Sc4XmAs=; b=rUmv93QmLyXcLTuDKRlp5h4ObiaVCx7p4myD3OOxkmJtf8Dw6RFl/t4qJHMYZ/KoFgYvn9uuxbakUvnm/7XGWRdFxVlTA0HqxhG6JMX2PakOMrttYFaGAdLGMLY/uCxkbHPRK1Uwk+4npNUNY8nFBgLNbmbsa/5sY3/6TcfNOgT7kqJWwLoAm917JDKOBi95kn2cWByS3d5wr1KGCWt7RLU+TIwmZ+rAzhwgmXICrQh8oekRXU1kXsAxLtUFQFasQtSpRr7kY8f1GrSJ8k9tneTp60JWsJ9JMFR2jqSX/IqDStvB2/zVRiKX18OAXUggdZbLVxJ71AYGXDm+ke1PUw== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB1489.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Sun, 11 Aug 2024 12:16:15 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%7]) with mapi id 15.20.7849.018; Sun, 11 Aug 2024 12:16:14 +0000 From: Morgan Smith To: bug-gnu-emacs@gnu.org Subject: [PATCH 0/3] debbugs improvements. Add tests Date: Sun, 11 Aug 2024 08:15:31 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 X-Debbugs-Cc: Michael Albinus Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [PKzggXGld1NKNC0tkyU4aAGORU0WKfzO] X-ClientProxiedBy: YT4P288CA0072.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d2::25) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <20240811121530.5496-2-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1489:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d808357-a607-4022-6f65-08dcb9ff64cf X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|5072599009|15080799003|19110799003|440099028|3412199025|1710799026; X-Microsoft-Antispam-Message-Info: a6dD262xPABpomJPjU6BfxPhnOaQJX1fmTCpgk767Rh0q1u5w6ZF7O/sRjbXOz3PGEGw38HS5jTu8g5JwnSZMRffirICkCpJc8GCmUvGNcFsFWYDZOHKq8PL1zuGvxRR9BZdN8CK0v8LVFHNCUySCsxb/n3ytldGoUp509Gm/ml/0Wc+E4ZHCjqoElE5plFxzqWK+tgmh9KqgqjSNWSKJTmO+9bd6LXHkqJHVTHaT1AbR41QsjgJ2VpQiLgzbeu14gQOXMXOiEX2Y70v2KOjfrfJiH/BrQ4q/+0viJ88y9p6JPH3/NLM3vH/pbI6QIOMTR5/xK9/zUUKg+1rg2a0J75Ix4kBuCHpsc8ACmK+mJKaREI6tl4Ak1+gPPrIyKNguV4E15pAPEt5VmZ+2bT/Rb2GJAyCb84/sIQv+MWfLg5scGSYRiYu/jCFXxVUs+12g8FydwcQYFkF5xcOlwma8uiN7qMrs6PWWJP3HF+S0HTAzOrdwcY8M4t48XlrkHwE/Cela/J45FyJWgP9xrcd26ZGvvavOtY/8t45nhKjR0y/IzgXU9mpcBw1u+QHAaS/+rswNWbPR7zYWp9mddGZV5eONFeNpyjxdXyrAhvB6k03ZAuSuJ0PdjnvkRAweC4aMi+vMagQigaqSQT0Gfcn0viI8EHUEpuRbfEx1pb6w3IYkK7kY1Pq1Dr8wuqdUv/jOxSJ6qwNZEjpPE47t75u/v0YV57pOOfv7KhL+DNVJkg= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t+fDpSu6VdCyl7x1ZXM7TXUQWT3JOspPvNa6cAV3Wen3vdN044IlZkAIAbk3?= =?us-ascii?Q?BqT8MxOr6nOdNbC6xe7wGYI34DTKO0ZMeYxCxJLRcLK/vPoIAPpFHAUebmDt?= =?us-ascii?Q?lQwxECK2n8C1XNq51zo5hFj6p2679jNvo7aMoD9Eo/hd2ubkGryhZ9NwHqFO?= =?us-ascii?Q?ChCUMzF+yygyBoviN7dIcp2qgYFfzalCrNuYcTFJUwKg+j6dxRv7Y8jMx2ro?= =?us-ascii?Q?iIet1lffmf/Fat4yxssm+f+yHfNUIWoGsVt4VvI7wwqPTHOhkHpshBf2/djS?= =?us-ascii?Q?lChjE777lkZk+BYuTIEDuWfRH/px9EoC6nabuj3ayJVlpTt4KjM0hDCCBksT?= =?us-ascii?Q?NlqonD64Mg+oY+2g/Df+nUTL8NNShckOy8CFQyFHMfsk2HxIF/nV22eCrwvS?= =?us-ascii?Q?wyxR53vVand+oMcshJJe/22XsURK+w3UQ6CvPiFgxjzTXhne/LoyZYEZ0UyN?= =?us-ascii?Q?5hd9Wa//lpvcHqnORJB0jQyJ2q/UfFPKQxXXSH7/9WzWpPJphS31FurLa5Ct?= =?us-ascii?Q?Oj1MQBFWC/OXOTAo0VwXQYl4UEOyqvEEpDH+Ary1rgy5Ut4VKlgM8J36qf6C?= =?us-ascii?Q?M+JdV1gM97AG+pjgMVnyo/D9C5gl+cIyKVmgZelAcDYleYFGChtSM1JZkvMN?= =?us-ascii?Q?wRUpizqk62+/GJGxN5IWW7HsWdRXS7kODDtUuAsbc89Z4tl4D9gYk0kzLivG?= =?us-ascii?Q?8akdqdbXsvKuWTCht3Fr1VnAbE9ZN6oilkt5eCeqgaaP3SjLvOeXZ12qFPc+?= =?us-ascii?Q?1S7/80M8sX2uIutlHM6yOVteCeHL5VADctj4wq9RmATE61jx5cwa7tbg71gA?= =?us-ascii?Q?jfDVxCBNgrKV8OPZ/vb0IWm7PP3Q+eLgv7uPld5mrv3URPwlTdyn/A4JIQ0w?= =?us-ascii?Q?YDMVmsQUAIaZs97yV3bmgUfFqnElJWrodVq9J/D/L75hA3xNcWoxeI1VONZK?= =?us-ascii?Q?GtVDr3y+5bZOK8X60qW2NKmRVcjpkJtNKPrEXvlj/EWbPKKaZq1ip6zfGzJg?= =?us-ascii?Q?6eYGVgjD2lMYj3fUUCSQK4SC+G4vg4IxoXE7IpMlO77aqC1XAgn81P0Foo0V?= =?us-ascii?Q?Ut8SGcabN01IHD+JxfiVhIRMqni7b/laeEwQ4RHbinFXWVqnJb1w4r2jkGAV?= =?us-ascii?Q?Zg2vB7ubaIQG091Z0dzPO22p+o0gnF8bdoaqPQo7zcWX0k+JnvvfiPV/jRPO?= =?us-ascii?Q?ktcTwoVBubvxe0hmkS1qvHtuyonN21wDDeZuK95b6iaG+w0evAkZtmLOqd/v?= =?us-ascii?Q?gZLMMeCD+1mJ4i3keJGw?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d808357-a607-4022-6f65-08dcb9ff64cf X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2024 12:16:14.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1489 Received-SPF: pass client-ip=40.92.41.71; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Morgan Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello! I would like to start contributing some improvements to debbugs. However, when changing things I found it difficult to avoid regressions. So I figured I'd try to add a test suite to debbugs first. The first two patches are not that interesting. I was hoping to get feedback on the "Add tests" patch. Obviously more tests are needed but I would like to know if I'm on the right path. Thanks, Morgan Morgan Smith (3): * debbugs-gnu.el (debbugs-gnu-find-contributor): Make regex more specific Fix various warnings Add tests Makefile | 4 ++ debbugs-browse.el | 3 +- debbugs-compat.el | 3 ++ debbugs-gnu.el | 24 +++++----- debbugs-org.el | 7 +-- debbugs.el | 12 ++--- test/test-debbugs.el | 101 +++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 133 insertions(+), 21 deletions(-) create mode 100644 Makefile create mode 100644 test/test-debbugs.el -- 2.45.2 ------------=_1723456742-24047-1--