GNU bug report logs - #72556
29.1.90; vc-diff does not undo hunk in end of source file

Previous Next

Full log

View this message in rfc822 format

From: Tomas Nordin <tomasn <at> posteo.net>
To: Juri Linkov <juri <at> linkov.net>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>, 72556 <at> debbugs.gnu.org
Subject: bug#72556: 29.1.90; vc-diff does not undo hunk in end of source file
Date: Tue, 11 Mar 2025 22:33:15 +0000

Juri Linkov <juri <at> linkov.net> writes:

>> So I added a check to only satisfy the NEW *and* OLD case when REVERSE is
>> not given.  What do you think?  (Also aligned the leading whitespace
>> with original code).  In my manual tests it seems to work.  I learned
>> about the splitting of hunks and it doesn't seem broken.
>
> If Dmitry agrees then let's push this patch.

In the meantime I wrote two test cases in
test/lisp/vc/diff-mode-tests.el, one for a topmost and one for a
bottommost addition. They both fail before the patch but pass after it.
Maybe I could present them here as an attached patch as well?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.