Subject: [bug#72541] [PATCH] gnu: gerbv: Fix missing version.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 06 Sep 2024 23:51:11 +0200

Hi,

Evgeny Pisemsky <[email-masked]> skribis:

> This program currently lacks version number everywhere - in pkgconfig,
> in CLI and in GUI, because it is generated by a script that needs git
> and updating shebang. This patch fixes the problem.

This is surprising because the checkout lacks the ‘.git’ directory, and
thus Git cannot possibly determine the commit ID or anything.

Could it be that adding ‘git’ to $PATH just hides the problem?

>>>From c066b30a8f1afff37deb54d7ed571d99b059f619 Mon Sep 17 00:00:00 2001
> Message-ID: <[email-masked]>
> From: Evgeny Pisemsky <[email-masked]>
> Date: Fri, 9 Aug 2024 14:40:05 +0300
> Subject: [PATCH] gnu: gerbv: Fix missing version.
>
> * gnu/packages/engineering.scm (gerbv): Fix missing version.
> [source]: Change indentation.
> [arguments]: Patch version generator shebang.
> [native-inputs]: Add git.
>
> Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125

[…]

>      (build-system gnu-build-system)
>      (arguments
> -     '(#:configure-flags '("CFLAGS=-fcommon")))

Not related to your patch, but this thing is most likely wrong and
should read "CFLAGS=-O2 -g -fcommon", or the binaries will be
unoptimized (-O0) and unconditionally stripped.

Thanks,
Ludo’.