From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 09 08:01:45 2024 Received: (at submit) by debbugs.gnu.org; 9 Aug 2024 12:01:45 +0000 Received: from localhost ([127.0.0.1]:37776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scOJU-0005MS-He for submit@debbugs.gnu.org; Fri, 09 Aug 2024 08:01:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:56230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scOJR-0005MI-1v for submit@debbugs.gnu.org; Fri, 09 Aug 2024 08:01:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scOIv-0007q2-Vw for guix-patches@gnu.org; Fri, 09 Aug 2024 08:01:11 -0400 Received: from roxy-shared.hosting.energy ([137.74.182.160] helo=roxy.hosting.energy) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scOIt-0005Lf-KF for guix-patches@gnu.org; Fri, 09 Aug 2024 08:01:09 -0400 Received: from [185.211.158.13] (helo=laptop) by roxy.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1scOIg-000000003L1-1Xr3 for guix-patches@gnu.org; Fri, 09 Aug 2024 15:00:54 +0300 From: Evgeny Pisemsky To: guix-patches@gnu.org Subject: [PATCH] gnu: gerbv: Fix missing version. Date: Fri, 09 Aug 2024 15:00:51 +0300 Message-ID: <87sevdoqh8.fsf@pisemsky.site> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=137.74.182.160; envelope-from=mail@pisemsky.site; helo=roxy.hosting.energy X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain This program currently lacks version number everywhere - in pkgconfig, in CLI and in GUI, because it is generated by a script that needs git and updating shebang. This patch fixes the problem. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gerbv-Fix-missing-version.patch Content-Transfer-Encoding: quoted-printable >From c066b30a8f1afff37deb54d7ed571d99b059f619 Mon Sep 17 00:00:00 2001 Message-ID: From: Evgeny Pisemsky Date: Fri, 9 Aug 2024 14:40:05 +0300 Subject: [PATCH] gnu: gerbv: Fix missing version. * gnu/packages/engineering.scm (gerbv): Fix missing version. [source]: Change indentation. [arguments]: Patch version generator shebang. [native-inputs]: Add git. Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125 --- gnu/packages/engineering.scm | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index d5d72a0c85..697ceff59f 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -27,7 +27,7 @@ ;;; Copyright =C2=A9 2021 Ivan Gankevich ;;; Copyright =C2=A9 2021, 2022 Petr Hodina ;;; Copyright =C2=A9 2021 Foo Chuan Wei -;;; Copyright =C2=A9 2022 Evgeny Pisemsky +;;; Copyright =C2=A9 2022, 2024 Evgeny Pisemsky ;;; Copyright =C2=A9 2022 Olivier Dion ;;; Copyright =C2=A9 2022 Peter Polidoro ;;; Copyright =C2=A9 2022 Malte Frank Gerdes @@ -833,22 +833,30 @@ (define-public gerbv (package (name "gerbv") (version "2.10.0") - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/gerbv/gerbv") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj")))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/gerbv/gerbv") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj")))) (build-system gnu-build-system) (arguments - '(#:configure-flags '("CFLAGS=3D-fcommon"))) + (list + #:configure-flags '(list "CFLAGS=3D-fcommon") + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'patch-version-generator + (lambda _ + (substitute* "utils/git-version-gen.sh" + (("/bin/bash") + (which "bash")))))))) (native-inputs (list autoconf automake desktop-file-utils gettext-minimal + git `(,glib "bin") libtool pkg-config)) base-commit: 20dbf225f332ccc707578263ed710dcf2a8fb78e --=20 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 17:51:59 2024 Received: (at 72541) by debbugs.gnu.org; 6 Sep 2024 21:51:59 +0000 Received: from localhost ([127.0.0.1]:54295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smgs3-0002E3-2j for submit@debbugs.gnu.org; Fri, 06 Sep 2024 17:51:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smgs0-0002Dq-RU for 72541@debbugs.gnu.org; Fri, 06 Sep 2024 17:51:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smgrv-0008Gt-5q; Fri, 06 Sep 2024 17:51:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ERpR3VhUQqVbwqk0SFv5j1I/O+8JBCK3JxkWQo6ZNB0=; b=JrBytu4MabBnG5UABoKv 0NlzNyRbnRaJHgs7FgHD/+37i/Bvb0gVZQAgbJLMNsNirQfsYPmDctj2F20UOtrOVHsZsgER9jPTk aGNRva40H1skDrCcwyoJ4QVF4BqRn/JisIup4GaOBkwfkGpepipipzHJj3v5k8lqkJdIn1h8EvvOM L5p9GsS+K+ugH+8COaHk2ue6cxE19tgE2Y1rWxUwnkYZMOaiCVQ2BEK1asrY27Vm8ZiUi++enYtfg lTjrvaxHVyfWzwNwST/Ra2R1yTqFhexqk8FG2arG8BPgi+ywmNH9r2MYcXGGv5JkiSRBS6LiniO6Z yxw+kpuiljX3SQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Evgeny Pisemsky Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version. In-Reply-To: <87sevdoqh8.fsf@pisemsky.site> (Evgeny Pisemsky's message of "Fri, 09 Aug 2024 15:00:51 +0300") References: <87sevdoqh8.fsf@pisemsky.site> Date: Fri, 06 Sep 2024 23:51:11 +0200 Message-ID: <87frqcwiwg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72541 Cc: 72541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Evgeny Pisemsky skribis: > This program currently lacks version number everywhere - in pkgconfig, > in CLI and in GUI, because it is generated by a script that needs git > and updating shebang. This patch fixes the problem. This is surprising because the checkout lacks the =E2=80=98.git=E2=80=99 di= rectory, and thus Git cannot possibly determine the commit ID or anything. Could it be that adding =E2=80=98git=E2=80=99 to $PATH just hides the probl= em? >>>From c066b30a8f1afff37deb54d7ed571d99b059f619 Mon Sep 17 00:00:00 2001 > Message-ID: > From: Evgeny Pisemsky > Date: Fri, 9 Aug 2024 14:40:05 +0300 > Subject: [PATCH] gnu: gerbv: Fix missing version. > > * gnu/packages/engineering.scm (gerbv): Fix missing version. > [source]: Change indentation. > [arguments]: Patch version generator shebang. > [native-inputs]: Add git. > > Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125 [=E2=80=A6] > (build-system gnu-build-system) > (arguments > - '(#:configure-flags '("CFLAGS=3D-fcommon"))) Not related to your patch, but this thing is most likely wrong and should read "CFLAGS=3D-O2 -g -fcommon", or the binaries will be unoptimized (-O0) and unconditionally stripped. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 07 12:30:37 2024 Received: (at 72541) by debbugs.gnu.org; 7 Sep 2024 16:30:37 +0000 Received: from localhost ([127.0.0.1]:57333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smyKa-0006Rz-GM for submit@debbugs.gnu.org; Sat, 07 Sep 2024 12:30:37 -0400 Received: from roxy-shared.hosting.energy ([137.74.182.160]:46257 helo=roxy.hosting.energy) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smyKW-0006Rf-VO for 72541@debbugs.gnu.org; Sat, 07 Sep 2024 12:30:34 -0400 Received: from [185.211.158.4] (helo=laptop) by roxy.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1smyKO-000000001U9-3pzZ; Sat, 07 Sep 2024 19:30:25 +0300 From: Evgeny Pisemsky To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version. In-Reply-To: <87frqcwiwg.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 06 Sep 2024 23:51:11 +0200") References: <87sevdoqh8.fsf@pisemsky.site> <87frqcwiwg.fsf@gnu.org> Date: Sat, 07 Sep 2024 19:30:23 +0300 Message-ID: <87plpfo28w.fsf@pisemsky.site> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Scanned-By: ClamAV 0.101.4; Sat, 07 Sep 2024 19:30:25 +0300 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 72541 Cc: 72541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello! The problem is certainly in this script or its environment, since the only place where version can come from is this line in configure.ac: AC_INIT([gerbv], [m4_esyscmd(utils/git-version-gen.sh 2.10.0)]) This gave me the idea to do substitution there to avoid running it. As for wrong flag, I suggest just removing it. Alter these changes gerbv builds and works fine for me. Updated patch attached. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gerbv-Fix-missing-version.patch Content-Transfer-Encoding: quoted-printable >From 5bc5612026d51a2614b29668addf0f8de0aefe76 Mon Sep 17 00:00:00 2001 Message-ID: <5bc5612026d51a2614b29668addf0f8de0aefe76.1725723700.git.mail@p= isemsky.site> From: Evgeny Pisemsky Date: Sat, 7 Sep 2024 18:40:06 +0300 Subject: [PATCH] gnu: gerbv: Fix missing version. * gnu/packages/engineering.scm (gerbv): Fix missing version. [source]: Change indentation. [arguments]: Remove wrong configure flags, avoid running git version genera= tor. Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125 --- gnu/packages/engineering.scm | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index 26f47dbf9d..d2e524a7f8 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -27,7 +27,7 @@ ;;; Copyright =C2=A9 2021 Ivan Gankevich ;;; Copyright =C2=A9 2021, 2022 Petr Hodina ;;; Copyright =C2=A9 2021 Foo Chuan Wei -;;; Copyright =C2=A9 2022 Evgeny Pisemsky +;;; Copyright =C2=A9 2022, 2024 Evgeny Pisemsky ;;; Copyright =C2=A9 2022 Olivier Dion ;;; Copyright =C2=A9 2022 Peter Polidoro ;;; Copyright =C2=A9 2022 Malte Frank Gerdes @@ -837,18 +837,24 @@ (define-public gerbv (package (name "gerbv") (version "2.10.0") - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/gerbv/gerbv") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj")))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/gerbv/gerbv") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj")))) (build-system gnu-build-system) (arguments - '(#:configure-flags '("CFLAGS=3D-fcommon"))) + (list + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'avoid-git-version-gen + (lambda _ + (substitute* "configure.ac" + (("utils/git-version-gen.sh") + "echo -n"))))))) (native-inputs (list autoconf automake desktop-file-utils base-commit: 18d02443e1ec37779ee3cf63f9aaff1746bfdd8e --=20 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 08 12:00:50 2024 Received: (at 72541) by debbugs.gnu.org; 8 Sep 2024 16:00:50 +0000 Received: from localhost ([127.0.0.1]:59924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snKLJ-0004cA-Rn for submit@debbugs.gnu.org; Sun, 08 Sep 2024 12:00:50 -0400 Received: from roxy-shared.hosting.energy ([137.74.182.160]:57119 helo=roxy.hosting.energy) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snKLI-0004bt-K2 for 72541@debbugs.gnu.org; Sun, 08 Sep 2024 12:00:48 -0400 Received: from [185.211.158.4] (helo=laptop) by roxy.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1snKL9-000000001AJ-2fCU; Sun, 08 Sep 2024 19:00:40 +0300 From: Evgeny Pisemsky To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version. In-Reply-To: <87frqcwiwg.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 06 Sep 2024 23:51:11 +0200") References: <87sevdoqh8.fsf@pisemsky.site> <87frqcwiwg.fsf@gnu.org> Date: Sun, 08 Sep 2024 19:00:37 +0300 Message-ID: <87h6aqi196.fsf@pisemsky.site> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: ClamAV 0.101.4; Sun, 08 Sep 2024 19:00:40 +0300 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 72541 Cc: 72541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) *After these changes Looks like I have found the problem in this script: When git is absent, it stops at the following line: GIT=`command -v git` resulting an empty version. The reason is probably this instruction: set -e Anyway, IMO in guix it makes more sense to just exclude obviously useless script from the build process, rather than patch it. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 02:36:14 2024 Received: (at 72541) by debbugs.gnu.org; 16 Sep 2024 06:36:14 +0000 Received: from localhost ([127.0.0.1]:50965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sq5LK-0002b0-0j for submit@debbugs.gnu.org; Mon, 16 Sep 2024 02:36:14 -0400 Received: from roxy-shared.hosting.energy ([137.74.182.160]:41432 helo=roxy.hosting.energy) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sq5LI-0002al-H5 for 72541@debbugs.gnu.org; Mon, 16 Sep 2024 02:36:13 -0400 Received: from [185.211.158.52] (helo=laptop) by roxy.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1sq5Kz-0000000058J-0iJA; Mon, 16 Sep 2024 09:35:53 +0300 From: Evgeny Pisemsky To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version. In-Reply-To: <87frqcwiwg.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 06 Sep 2024 23:51:11 +0200") References: <87sevdoqh8.fsf@pisemsky.site> <87frqcwiwg.fsf@gnu.org> Date: Mon, 16 Sep 2024 09:35:48 +0300 Message-ID: <87wmjcrtq3.fsf@pisemsky.site> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 72541 Cc: 72541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) FYI this issue is one of two reasons why another package, pcb2gcode, does not build since around october 2023: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68036 The other one is incompatibility with geos, which can be solved in three different ways, but only after this one will be resolved. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 15:23:09 2024 Received: (at 72541) by debbugs.gnu.org; 16 Oct 2024 19:23:09 +0000 Received: from localhost ([127.0.0.1]:60522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t19bw-0000et-Pn for submit@debbugs.gnu.org; Wed, 16 Oct 2024 15:23:08 -0400 Received: from roxy-shared.hosting.energy ([137.74.182.160]:58876 helo=roxy.hosting.energy) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t19bu-0000eO-6d for 72541@debbugs.gnu.org; Wed, 16 Oct 2024 15:23:06 -0400 Received: from [212.233.86.59] (helo=laptop) by roxy.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1t19bS-000000001Fm-2oMe; Wed, 16 Oct 2024 22:22:38 +0300 From: Evgeny Pisemsky To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#72541] Any feedback? In-Reply-To: <87frqcwiwg.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 06 Sep 2024 23:51:11 +0200") References: <87sevdoqh8.fsf@pisemsky.site> <87frqcwiwg.fsf@gnu.org> Date: Wed, 16 Oct 2024 22:22:37 +0300 Message-ID: <878qun4zuq.fsf_-_@pisemsky.site> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: ClamAV 0.101.4; Wed, 16 Oct 2024 22:22:38 +0300 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72541 Cc: 72541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It's like I'm sending patches and messages into a black hole. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 14:04:46 2025 Received: (at 72541) by debbugs.gnu.org; 3 Jan 2025 19:04:46 +0000 Received: from localhost ([127.0.0.1]:52092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTmyQ-00027b-SM for submit@debbugs.gnu.org; Fri, 03 Jan 2025 14:04:46 -0500 Received: from sofi-shared.hosting.energy ([2001:41d0:602:1f56::]:41910 helo=sofi.hosting.energy) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTmyN-000275-Lk for 72541@debbugs.gnu.org; Fri, 03 Jan 2025 14:04:40 -0500 Received: from [212.233.84.7] (helo=laptop) by sofi.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1tTmyG-00043L-HP; Fri, 03 Jan 2025 22:04:32 +0300 From: Evgeny Pisemsky To: 72541@debbugs.gnu.org Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version. Date: Fri, 03 Jan 2025 22:04:30 +0300 Message-ID: <874j2fhg75.fsf@pisemsky.site> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 72541 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I tried to contact upstream, but they don't accept pull requests: - https://github.com/gerbv/gerbv/issues/244 - https://github.com/gerbv/gerbv/pull/226#issuecomment-2566103734 So it can only be done here. I updated initial patch with suggested configure flags and commented why git is added to native inputs. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-gerbv-Fix-missing-version.patch Content-Transfer-Encoding: quoted-printable >From f85ab2e24f0da292f639c07f4d66430896b18d13 Mon Sep 17 00:00:00 2001 Message-ID: From: Evgeny Pisemsky Date: Fri, 3 Jan 2025 21:40:01 +0300 Subject: [PATCH] gnu: gerbv: Fix missing version. * gnu/packages/engineering.scm (gerbv): Fix missing version. [source]: Change indentation. [arguments]: Set correct configure flags, patch version generator shebang. Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125 --- gnu/packages/engineering.scm | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index a5a91e62e9..5b43f8787e 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -27,7 +27,7 @@ ;;; Copyright =C2=A9 2021 Ivan Gankevich ;;; Copyright =C2=A9 2021, 2022 Petr Hodina ;;; Copyright =C2=A9 2021 Foo Chuan Wei -;;; Copyright =C2=A9 2022 Evgeny Pisemsky +;;; Copyright =C2=A9 2022, 2025 Evgeny Pisemsky ;;; Copyright =C2=A9 2022 Olivier Dion ;;; Copyright =C2=A9 2022 Peter Polidoro ;;; Copyright =C2=A9 2022 Malte Frank Gerdes @@ -837,22 +837,32 @@ (define-public gerbv (package (name "gerbv") (version "2.10.0") - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/gerbv/gerbv") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj")))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/gerbv/gerbv") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "06bcm5zw7whsnnmfld3gl2j907lxc68gnsbzr2pc4w6qc923rgmj")))) (build-system gnu-build-system) (arguments - '(#:configure-flags '("CFLAGS=3D-fcommon"))) + (list + #:configure-flags #~(list "CFLAGS=3D-O2 -g -fcommon") + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'patch-version-generator + (lambda _ + (substitute* "utils/git-version-gen.sh" + (("/bin/bash") + (which "bash")))))))) (native-inputs (list autoconf automake desktop-file-utils gettext-minimal + ;; Version generator needs git to work properly: + ;; https://github.com/gerbv/gerbv/issues/244 + git `(,glib "bin") libtool pkg-config)) base-commit: ce3ffac5d366ebf20e0d95779f2fe1ea6dde0202 --=20 2.47.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 13:43:53 2025 Received: (at 72541-done) by debbugs.gnu.org; 4 Jan 2025 18:43:53 +0000 Received: from localhost ([127.0.0.1]:57345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU97o-0006ox-UU for submit@debbugs.gnu.org; Sat, 04 Jan 2025 13:43:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58898) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU97m-0006oi-ED for 72541-done@debbugs.gnu.org; Sat, 04 Jan 2025 13:43:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU97g-0004u5-E9; Sat, 04 Jan 2025 13:43:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=OFKBKMiMiQdA7sFMWUpHTGGk+UGgvRoYVllQ2MNW82w=; b=CSD24q7xch53h2PIBtw+ G6YXdS2QHknwXq7ovluGiVKdPT4M2QX+hQEDfZpU8QPFXm2mrevRJRTG/2htKzdBihBSWK5vcrSE5 WTiMgNah0RKnK1i/20/gRFoCHdNcxLHJiBdI8gIpSkaEtBrUcqkzFZkuAextCqAvpVZKRnz+bopM0 o9MHk599SwLQTc5aexwmu3G99TiI1U8OtsH27+wuYpW8dGkfa05e5VLfUmG50VuNm49M6jcDNkWT+ kxCw6BOh0uNLP+EXJylQ3lpU4hZG+xqw7KGOxYBsFiH+uWAzoJpsiTZQdZGYtrr4V13Oyrg45TBf3 0siRHhpp7ZvrMQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Evgeny Pisemsky Subject: Re: [bug#72541] [PATCH] gnu: gerbv: Fix missing version. In-Reply-To: <874j2fhg75.fsf@pisemsky.site> (Evgeny Pisemsky's message of "Fri, 03 Jan 2025 22:04:30 +0300") References: <874j2fhg75.fsf@pisemsky.site> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 =?utf-8?Q?Niv=C3=B4se?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Lapin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 04 Jan 2025 19:43:24 +0100 Message-ID: <87ldvqpghf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72541-done Cc: 72541-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Evgeny Pisemsky skribis: > From f85ab2e24f0da292f639c07f4d66430896b18d13 Mon Sep 17 00:00:00 2001 > Message-ID: > From: Evgeny Pisemsky > Date: Fri, 3 Jan 2025 21:40:01 +0300 > Subject: [PATCH] gnu: gerbv: Fix missing version. > > * gnu/packages/engineering.scm (gerbv): Fix missing version. > [source]: Change indentation. > [arguments]: Set correct configure flags, patch version generator shebang. > > Change-Id: I29a38fff03127d9ce2b5e04ca638dacfc3720125 Finally applied with the change below. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index 5b43f8787e..f9c4ac9bbd 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -862,7 +862,7 @@ (define-public gerbv gettext-minimal ;; Version generator needs git to work properly: ;; https://github.com/gerbv/gerbv/issues/244 - git + git-minimal/pinned `(,glib "bin") libtool pkg-config)) --=-=-=-- From unknown Fri Sep 05 16:58:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Feb 2025 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator