GNU bug report logs - #7253
comment-dwim should easily allow mid-line comments

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7253 in the body.
You can then email your comments to 7253 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: bug-gnu-emacs <at> gnu.org
Subject: comment-dwim should easily allow mid-line comments
Date: Wed, 20 Oct 2010 18:06:35 +0800

Sometimes I want to make a comment in the middle of a line, not at the
end, but whenever I hit M-;, prefix or not, comment-dwim insists on
putting it at the end of line, at least in html-helper mode.
emacs-version "24.0.50.1".

Message #8 received at 7253 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: jidanni <at> jidanni.org
Cc: 7253 <at> debbugs.gnu.org
Subject: Re: bug#7253: comment-dwim should easily allow mid-line comments
Date: Wed, 20 Oct 2010 12:20:30 -0400

> Sometimes I want to make a comment in the middle of a line, not at the
> end, but whenever I hit M-;, prefix or not, comment-dwim insists on
> putting it at the end of line, at least in html-helper mode.
> emacs-version "24.0.50.1".

How would you tell Emacs that your intention is to make it in
the middle?


        Stefan

Message #11 received at 7253 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: monnier <at> iro.umontreal.ca
Cc: 7253 <at> debbugs.gnu.org
Subject: Re: bug#7253: comment-dwim should easily allow mid-line comments
Date: Thu, 21 Oct 2010 12:00:09 +0800

>>>>> "SM" == Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>> Sometimes I want to make a comment in the middle of a line, not at the
>> end, but whenever I hit M-;, prefix or not, comment-dwim insists on
>> putting it at the end of line, at least in html-helper mode.
>> emacs-version "24.0.50.1".

SM> How would you tell Emacs that your intention is to make it in
SM> the middle?

Excellent question. One would think adding a prefix argument to M-;
would be good... but that probably already is taken... and wait, M-; is
bound to different commands in different modes... Yuck. E.g., as I write
this it is bound to comment-region.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#7253: comment-dwim should easily allow mid-line comments
Date: Thu, 21 Oct 2010 13:20:38 +0200

Am 21.10.2010 06:00, schrieb jidanni <at> jidanni.org:
>>>>>> "SM" == Stefan Monnier<monnier <at> iro.umontreal.ca>  writes:
>>> Sometimes I want to make a comment in the middle of a line, not at the
>>> end, but whenever I hit M-;, prefix or not, comment-dwim insists on
>>> putting it at the end of line, at least in html-helper mode.
>>> emacs-version "24.0.50.1".
>
> SM>  How would you tell Emacs that your intention is to make it in
> SM>  the middle?
>
> Excellent question. One would think adding a prefix argument to M-;
> would be good... but that probably already is taken... and wait, M-; is
> bound to different commands in different modes... Yuck. E.g., as I write
> this it is bound to comment-region.
>
>
>
>

Hi,

as per chance played with commenting a little bit:
do you may present a show-case, where such a feature makes sense?

See a lot of difficulties beside: does "in the middle" mean splitting 
words if existing there?

Andreas

--
https://code.launchpad.net/~a-roehler/python-mode/python-mode-components
https://code.launchpad.net/s-x-emacs-werkstatt/

Message #17 received at 7253 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: jidanni <at> jidanni.org
Cc: 7253 <at> debbugs.gnu.org
Subject: Re: bug#7253: comment-dwim should easily allow mid-line comments
Date: Thu, 21 Oct 2010 14:40:00 -0400

> Excellent question. One would think adding a prefix argument to M-;
> would be good... but that probably already is taken... and wait, M-; is
> bound to different commands in different modes...

No, M-; should usually not be rebound in major-mods.

> Yuck. E.g., as I write this it is bound to comment-region.

Sounds like a misfeature of the major mode you're using.  Can you give
us some details?


        Stefan

Message #20 received at 7253 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: monnier <at> iro.umontreal.ca
Cc: 7253 <at> debbugs.gnu.org, ding <at> gnus.org
Subject: M-; rebound in message-mode
Date: Fri, 22 Oct 2010 03:28:36 +0800

>>>>> "SM" == Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

SM> No, M-; should usually not be rebound in major-mods.

>> Yuck. E.g., as I write this it is bound to comment-region.

SM> Sounds like a misfeature of the major mode you're using.  Can you give
SM> us some details?

major-mode ^U^X^E message-mode

M-; (translated from <escape> ;) runs the command comment-region,
which is an interactive autoloaded Lisp function in `newcomment.el'.

Message #25 received at 7253-close <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <lmi <at> gnus.org>
To: jidanni <at> jidanni.org
Cc: 7253-close <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, ding <at> gnus.org
Subject: Re: bug#7253: M-; rebound in message-mode
Date: Thu, 21 Oct 2010 21:59:52 +0200

jidanni <at> jidanni.org writes:

> M-; (translated from <escape> ;) runs the command comment-region,
> which is an interactive autoloaded Lisp function in `newcomment.el'.

I've now removed the binding from message-mode.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi <at> gnus.org * Lars Magne Ingebrigtsen

Message #30 received at 7253 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: jidanni <at> jidanni.org
Cc: 7253 <at> debbugs.gnu.org, ding <at> gnus.org
Subject: Re: M-; rebound in message-mode
Date: Thu, 21 Oct 2010 16:31:59 -0400

SM> No, M-; should usually not be rebound in major-mods.
>>> Yuck. E.g., as I write this it is bound to comment-region.
SM> Sounds like a misfeature of the major mode you're using.  Can you give
SM> us some details?
> major-mode ^U^X^E message-mode
> M-; (translated from <escape> ;) runs the command comment-region,
> which is an interactive autoloaded Lisp function in `newcomment.el'.

Thanks.  It might make sense for message-mode to redefine the binding
somewhat since it's not really a programming mode, but this binding
means that M-; can't be used to un-quote, so it's not a good idea as
it stands.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.