From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 07 08:42:09 2024 Received: (at submit) by debbugs.gnu.org; 7 Aug 2024 12:42:09 +0000 Received: from localhost ([127.0.0.1]:33924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbfzS-0004Tc-W0 for submit@debbugs.gnu.org; Wed, 07 Aug 2024 08:42:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:34354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbfEb-0002yw-Bz for submit@debbugs.gnu.org; Wed, 07 Aug 2024 07:53:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbfEB-0003pg-CG for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 07:53:15 -0400 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbfE7-000588-Ay for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 07:53:14 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 93C17417AC for ; Wed, 7 Aug 2024 13:53:07 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o35Ym4JFtZAG for ; Wed, 7 Aug 2024 13:53:06 +0200 (CEST) Date: Wed, 7 Aug 2024 13:53:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1723031586; bh=Pw+/IVgdWDxCk3jcbFD2oDz2JFqKtX481UYznvluH3w=; h=Date:From:To:Subject; b=Behm6BRV4NDGMrGklE8knHXIfGN3GcL1yg0p9mexiyOshSE6W3ogiWd0dox182kOx lEkc3hWnvQ0IZK/rtQXT3eYmGgDBHpyCutdDSGW08ggwS9p+/Op339weQIKFd2Y0H5 HytQ7lWWg5qbAU7s5Y/apkw6HHw+IklrLQWEo+fBms1tqS+1ThG39lFt/sQMX+Bew0 BVwfWDH+L8AaBJUaFtjib2uPnH1BQALvR44aC7cudYt/DOW+cBuvf3WVvdSMQ4G9oq uTru6vBdXLUPLwkm5++RFYH+ZsGwV0h+HRENVnpT10nP4OBwzkqlov26UHTwM1p2gv B7IyvaDjkammw== From: Chris Roberts To: bug-gnu-emacs@gnu.org Subject: 30.0.50; prefix-completions is always nil in help--symbol-completion-table Message-ID: <20240807135305.189c2c3e@cdr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=frayedultrasonicaligator@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 07 Aug 2024 08:42:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On lines 209-214 inside the function `help--symbol-complete-table' in help-fns.el there is a following block of code: (when help-enable-completion-autoload (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) (help--load-prefixes prefixes))) (let ((prefix-completions (and help-enable-completion-autoload (mapcar #'intern (all-completions string definition-prefixes))))) By default, `help-enable-completion-autoload' is t, so this code should normally run. The perceived problem here is that the definition of `help-definition-prefixes' function is as follows: (defun help-definition-prefixes () "Return the up-to-date radix-tree form of `definition-prefixes'." (when (> (hash-table-count definition-prefixes) 0) (maphash (lambda (prefix files) (let ((old (radix-tree-lookup help-definition-prefixes prefix))) (setq help-definition-prefixes (radix-tree-insert help-definition-prefixes prefix (append old files))))) definition-prefixes) (clrhash definition-prefixes)) help-definition-prefixes) Because of the `clrhash', `definition-prefixes' will always be empty after the function call to `help-definition-prefixes'. So in practice, `definition-prefixes' will always have zero elements when we're trying to calculate `prefix-completions', which makes the calls to `all-completions' and `mapcar' basically no-ops. The end result is that `prefix-completions' will always be NIL. This can be verified by evaluating the following code in emacs -Q: (require 'radix-tree) (require 'help-fns) (let ((string "string-remove-prefix")) (format "Definition prefixes count before: %d\n%sDefinition prefixes count after: %d\nPrefix completions: %s\n" (hash-table-count definition-prefixes) (or (when help-enable-completion-autoload (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) (help--load-prefixes prefixes))) "") (hash-table-count definition-prefixes) (let ((prefix-completions (and help-enable-completion-autoload (mapcar #'intern (all-completions string definition-prefixes))))) prefix-completions))) This has been first introduced in commit fd8084a (Automatically find vars and functions via definition-prefixes) I'm not sure if this was the intended behavior or not, but it seemed suspicious to me, so I decided it's better to report it. It might also be useful to note that `prefix-completion' is used in the following way: (complete-with-action action obarray string (if pred (lambda (sym) (or (funcall pred sym) (memq sym prefix-completions))))) I'm not sure what `pred' will be in this context, or what impact `prefix-completions' being always NIL will have, if any. But I believe that at the very least the code pertaining to `prefix-completions' could concievably be removed. Also, was clearing out the entirety of `definition-prefixes' on completion really the intended behavior? As it stands, just C-h f s is enough to completely truncate it. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2024-01-09 built on cdr Repository revision: 774c8ec74c98d69d56b2511a613145f2b69fb2eb Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Linux Mint 21.2 Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 07 10:21:28 2024 Received: (at 72511) by debbugs.gnu.org; 7 Aug 2024 14:21:28 +0000 Received: from localhost ([127.0.0.1]:34855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbhXc-0008ER-7q for submit@debbugs.gnu.org; Wed, 07 Aug 2024 10:21:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbhXa-0008Dy-IQ for 72511@debbugs.gnu.org; Wed, 07 Aug 2024 10:21:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbhX3-00023b-45; Wed, 07 Aug 2024 10:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vUxq1XX7lRDCUp4aC6UGKc8povm1e4qAj9nvSLp0Qp0=; b=MfxJPN734auv BK4E1061pDKpRFgNb0wCxp2G7RY8PJ4/78F0RFJinrQ/qbzrKUPaPr953s5JTmTXcHYNS9PIWjR5Z tpraP9u9VNYhWQ4MNfwCudDcEQl9he2eZiBCZFQoKKka84bCi0c7wAR8gBqkzHk92ddcXao6rJi+L y59UBinaAi4GU0P9TfRG+IDKvEdDyDtHU/WZXjIeGMQ2ogIQQqPMhSFjDZRwaYXR8uyPAbZBc+DiT 7/m9qhStR1kQNc0LxF4gQUQFYpS72cbfLllxIYtv7iQkGQ2keavrsHiMsSotEuZ8dFardNyC7LfPO UWtiIdMwBRiHAkrEiP8fMA==; Date: Wed, 07 Aug 2024 17:20:49 +0300 Message-Id: <864j7wo1mm.fsf@gnu.org> From: Eli Zaretskii To: Chris Roberts , Stefan Monnier In-Reply-To: <20240807135305.189c2c3e@cdr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#72511: 30.0.50; prefix-completions is always nil in help--symbol-completion-table References: <20240807135305.189c2c3e@cdr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72511 Cc: 72511@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 7 Aug 2024 13:53:05 +0200 > From: Chris Roberts via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > On lines 209-214 inside the function `help--symbol-complete-table' in > help-fns.el there is a following block of code: > > (when help-enable-completion-autoload > (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) > (help--load-prefixes prefixes))) > (let ((prefix-completions > (and help-enable-completion-autoload > (mapcar #'intern (all-completions string definition-prefixes))))) > > By default, `help-enable-completion-autoload' is t, so this code should > normally run. The perceived problem here is that the definition of > `help-definition-prefixes' function is as follows: > > (defun help-definition-prefixes () > "Return the up-to-date radix-tree form of `definition-prefixes'." > (when (> (hash-table-count definition-prefixes) 0) > (maphash (lambda (prefix files) > (let ((old (radix-tree-lookup help-definition-prefixes prefix))) > (setq help-definition-prefixes > (radix-tree-insert help-definition-prefixes > prefix (append old files))))) > definition-prefixes) > (clrhash definition-prefixes)) > help-definition-prefixes) > > Because of the `clrhash', `definition-prefixes' will always be empty > after the function call to `help-definition-prefixes'. So in practice, > `definition-prefixes' will always have zero elements when we're trying > to calculate `prefix-completions', which makes the calls to > `all-completions' and `mapcar' basically no-ops. The end result is that > `prefix-completions' will always be NIL. > > This can be verified by evaluating the following code in emacs -Q: > > (require 'radix-tree) > (require 'help-fns) > > (let ((string "string-remove-prefix")) > (format "Definition prefixes count before: %d\n%sDefinition prefixes count after: %d\nPrefix completions: %s\n" > (hash-table-count definition-prefixes) > (or > (when help-enable-completion-autoload > (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) > (help--load-prefixes prefixes))) > "") > (hash-table-count definition-prefixes) > (let ((prefix-completions > (and help-enable-completion-autoload > (mapcar #'intern (all-completions string definition-prefixes))))) > prefix-completions))) > > This has been first introduced in commit fd8084a (Automatically find > vars and functions via definition-prefixes) > > I'm not sure if this was the intended behavior or not, but it seemed > suspicious to me, so I decided it's better to report it. > > It might also be useful to note that `prefix-completion' is used in the > following way: > > (complete-with-action action obarray string > (if pred (lambda (sym) > (or (funcall pred sym) > (memq sym prefix-completions))))) > > I'm not sure what `pred' will be in this context, or what impact > `prefix-completions' being always NIL will have, if any. But I believe > that at the very least the code pertaining to `prefix-completions' could > concievably be removed. > > Also, was clearing out the entirety of `definition-prefixes' on completion > really the intended behavior? As it stands, just C-h f s is enough > to completely truncate it. Thanks, I'm adding Stefan, who wrote this code, to the discussion. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 14 11:51:51 2024 Received: (at 72511) by debbugs.gnu.org; 14 Aug 2024 15:51:51 +0000 Received: from localhost ([127.0.0.1]:47287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seGHu-0000S6-Px for submit@debbugs.gnu.org; Wed, 14 Aug 2024 11:51:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seGHs-0000Rp-De for 72511@debbugs.gnu.org; Wed, 14 Aug 2024 11:51:49 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 75710442BCE; Wed, 14 Aug 2024 11:51:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1723650665; bh=OKpWq0O25B+dM7gcrd/VWmrhnv8cSlf6NJhMeqXJoHA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=l/wRgRmbMCH/CHVCyzXbBaEX26PYIyMKr9P20AmEOjVrS7BvZpd7HIe0k0hJMk0Y8 1U84croe35l9Vxjsri46XmhFgLEo+pJ6XAg8CgIpfAnp5A74OddHMwvujk6Er2txwy AP9t+WNkjJT2tj5O2BuDQVYjcTGlpxD1eDGrBb6ULAQs4VXswT47kfVmXc/AdefEuv V6RZefn3HOCw9LzA+BATNy7256N6yz2Qjwx9e3Tu7HVI7DXv6V54bwiufMZmvf2YDw Acb26IJrS8RuGpXAXp7B8EXXzd/ebuyI1r8vHqdNAPGQdf5/Aa0Zjbrk1OBO7kXve/ ezqfg854jgt7A== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C1254442648; Wed, 14 Aug 2024 11:51:05 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B34D41205CC; Wed, 14 Aug 2024 11:51:05 -0400 (EDT) From: Stefan Monnier To: Chris Roberts Subject: Re: bug#72511: 30.0.50; prefix-completions is always nil in help--symbol-completion-table In-Reply-To: <20240807135305.189c2c3e@cdr> (Chris Roberts's message of "Wed, 7 Aug 2024 13:53:05 +0200") Message-ID: References: <20240807135305.189c2c3e@cdr> Date: Wed, 14 Aug 2024 11:50:47 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72511 Cc: 72511@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (when help-enable-completion-autoload > (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) > (help--load-prefixes prefixes))) > (let ((prefix-completions > (and help-enable-completion-autoload > (mapcar #'intern (all-completions string definition-prefixes))))) > > By default, `help-enable-completion-autoload' is t, so this code should > normally run. The perceived problem here is that the definition of > `help-definition-prefixes' function is as follows: > > (defun help-definition-prefixes () > "Return the up-to-date radix-tree form of `definition-prefixes'." > (when (> (hash-table-count definition-prefixes) 0) > (maphash (lambda (prefix files) > (let ((old (radix-tree-lookup help-definition-prefixes prefix))) > (setq help-definition-prefixes > (radix-tree-insert help-definition-prefixes > prefix (append old files))))) > definition-prefixes) > (clrhash definition-prefixes)) > help-definition-prefixes) > > Because of the `clrhash', `definition-prefixes' will always be empty > after the function call to `help-definition-prefixes'. Duh, indeed. IIRC it's a leftover from some older version of the code. I think the patch below is in order. > Also, was clearing out the entirety of `definition-prefixes' on completion > really the intended behavior? Originally, yes (after which we'd just use the `help-definition-prefixes` radix-tree instead), but then other places appeared where using the radix-tree was not convenient. Stefan diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 0a469a1fd6d..e3dc23036db 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -86,14 +86,14 @@ help-definition-prefixes (defun help-definition-prefixes () "Return the up-to-date radix-tree form of `definition-prefixes'." - (when (> (hash-table-count definition-prefixes) 0) + (when (and (null help-definition-prefixes) + (> (hash-table-count definition-prefixes) 0)) (maphash (lambda (prefix files) (let ((old (radix-tree-lookup help-definition-prefixes prefix))) (setq help-definition-prefixes (radix-tree-insert help-definition-prefixes prefix (append old files))))) - definition-prefixes) - (clrhash definition-prefixes)) + definition-prefixes)) help-definition-prefixes) (defun help--loaded-p (file) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 05:35:55 2024 Received: (at 72511) by debbugs.gnu.org; 17 Aug 2024 09:35:55 +0000 Received: from localhost ([127.0.0.1]:53524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFqk-0002lt-Nq for submit@debbugs.gnu.org; Sat, 17 Aug 2024 05:35:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFqj-0002li-7X for 72511@debbugs.gnu.org; Sat, 17 Aug 2024 05:35:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFq0-0005CP-5G; Sat, 17 Aug 2024 05:35:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MVkwaZI33gaChtfq3H75ljs6Ta8rAt85n39GQVIZc+Q=; b=hsIRMk9vZyD+ BQw6sK9ifIoyjaBy4UY7UzPW4r57Ktb8FFQssCWFMWFPF1AYKh4xEFDIwSY9+rRKmVfBiAcSb+WWR 4xTaE3LtoQBQne9j4rnByAylDRjjN7578HohU/wCKZ+YuZMr+KLgIBoPtcE1Baw5VDOCfdSRF4AF0 aZNBeBaVCu+GVoknsVg6x6GEgKNP6EgGajIeT8sbydVCvTOb+BJ5vWrZ63sVmDiYneTFR8kcV764N vbzD/1QI/pqrXymNsSMlld5tLZIXP52PQgSwWSUVHUfIuLX2XQsfPmO4c3rkgrJ9PiloKxGN1vNg/ U+0WDtVUQJULim/W2JS3NQ==; Date: Sat, 17 Aug 2024 12:35:05 +0300 Message-Id: <86wmkf331y.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#72511: 30.0.50; prefix-completions is always nil in help--symbol-completion-table References: <20240807135305.189c2c3e@cdr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72511 Cc: frayedultrasonicaligator@disroot.org, 72511@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 72511@debbugs.gnu.org > Date: Wed, 14 Aug 2024 11:50:47 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > (when help-enable-completion-autoload > > (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) > > (help--load-prefixes prefixes))) > > (let ((prefix-completions > > (and help-enable-completion-autoload > > (mapcar #'intern (all-completions string definition-prefixes))))) > > > > By default, `help-enable-completion-autoload' is t, so this code should > > normally run. The perceived problem here is that the definition of > > `help-definition-prefixes' function is as follows: > > > > (defun help-definition-prefixes () > > "Return the up-to-date radix-tree form of `definition-prefixes'." > > (when (> (hash-table-count definition-prefixes) 0) > > (maphash (lambda (prefix files) > > (let ((old (radix-tree-lookup help-definition-prefixes prefix))) > > (setq help-definition-prefixes > > (radix-tree-insert help-definition-prefixes > > prefix (append old files))))) > > definition-prefixes) > > (clrhash definition-prefixes)) > > help-definition-prefixes) > > > > Because of the `clrhash', `definition-prefixes' will always be empty > > after the function call to `help-definition-prefixes'. > > Duh, indeed. > IIRC it's a leftover from some older version of the code. > I think the patch below is in order. Thanks, please install on the emacs-30 branch. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 08:14:35 2024 Received: (at 72511-done) by debbugs.gnu.org; 20 Aug 2024 12:14:36 +0000 Received: from localhost ([127.0.0.1]:59994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgNkx-0008SU-N0 for submit@debbugs.gnu.org; Tue, 20 Aug 2024 08:14:35 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgNkv-0008SA-Ow for 72511-done@debbugs.gnu.org; Tue, 20 Aug 2024 08:14:34 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1F35A10005D; Tue, 20 Aug 2024 08:13:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1724156023; bh=wq589Yfip7uwxOTZmFHFvCOOsFK3pkJBYsjd+TR6myU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FDNoo46oOyXoqIhLigH1ndL0ZH3YYnf14kAzbNeGEto3o+vjH6Ls2g5huJ7v/yjis siEas2oKdRbhd5npCBxtm03uzSea9QMK33X8G79MWyTUEkQvGgeqZUpCm+9iUv9FKP AuPm81GdVnimy3DoU3t4f4rbpulwcYHIh6r3Lkokx8FswT2Aj3YcQCuvpg0dIR5BJt jFS4xpOqvhMc5ZOTnLPfvC97plMWeipKoHugf9D3zu9HtOMD+Fh6EWI8QwnT1P/0pl B8x/B/pavcyXTLlAA+TTyXQWFiHTmDIBVc8B72L/vJMEPijKznpSQ4BmdF1cxlrH9d qGFmqv9/0nqFw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 09587100042; Tue, 20 Aug 2024 08:13:43 -0400 (EDT) Received: from pastel (unknown [216.154.9.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D0B9D120C39; Tue, 20 Aug 2024 08:13:42 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#72511: 30.0.50; prefix-completions is always nil in help--symbol-completion-table In-Reply-To: <86wmkf331y.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Aug 2024 12:35:05 +0300") Message-ID: References: <20240807135305.189c2c3e@cdr> <86wmkf331y.fsf@gnu.org> Date: Tue, 20 Aug 2024 08:13:41 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72511-done Cc: frayedultrasonicaligator@disroot.org, 72511-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> IIRC it's a leftover from some older version of the code. >> I think the patch below is in order. > > Thanks, please install on the emacs-30 branch. Done, thanks, Stefan From unknown Thu Sep 18 22:09:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Sep 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator