From unknown Fri Sep 19 20:44:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72489 <72489@debbugs.gnu.org> To: bug#72489 <72489@debbugs.gnu.org> Subject: Status: 29.4.50; forward-comment not working as expected in toml-ts-mode Reply-To: bug#72489 <72489@debbugs.gnu.org> Date: Sat, 20 Sep 2025 03:44:20 +0000 retitle 72489 29.4.50; forward-comment not working as expected in toml-ts-m= ode reassign 72489 emacs submitter 72489 Yang Yingchao severity 72489 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 02:07:54 2024 Received: (at submit) by debbugs.gnu.org; 6 Aug 2024 06:07:55 +0000 Received: from localhost ([127.0.0.1]:59869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbDMQ-0007ix-EY for submit@debbugs.gnu.org; Tue, 06 Aug 2024 02:07:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:45262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbDMP-0007iq-3v for submit@debbugs.gnu.org; Tue, 06 Aug 2024 02:07:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbDM1-0001o3-Cb for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 02:07:29 -0400 Received: from out203-205-221-235.mail.qq.com ([203.205.221.235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbDLy-0001KC-I9 for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 02:07:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1722924440; bh=ecWyWao4KLO8Z6axu11LLzFTrLiIUvqYvTpcafv2EwQ=; h=From:To:Subject:Date; b=IzCvYZ0cXNaDAKabbPqpChA+lq637ZMcLj+I66ZPSG1uyzu2uXIsxQ6DKAH2N/8tR Pj5tF8RDY1o4hEqEbaq0zgP5R3A/eJ+DsY2J10YWoOInT9/U1leNNzxVPGeJ2Ez7xW rB1+XVH6mT9WfMFSIfbByL4pXGQCyUUK1H45jBBQ= Received: from tbook ([116.130.79.103]) by newxmesmtplogicsvrszc5-2.qq.com (NewEsmtp) with SMTP id EA323C25; Tue, 06 Aug 2024 13:58:35 +0800 X-QQ-mid: xmsmtpt1722923915tag5ffen8 Message-ID: X-QQ-XMAILINFO: MmpliBmRb3iCd6TQRZE4VTe4GvTLeeHsjpi+PVvNVTKqTbDSgg3f3lTJAJMeCr p3cri7m22NA/PZab2nTYkrWrWRpSRWeVdsLviFvNFgs/yptSXQJAhuRI1+Pvo/prpp//F2y1+4CO +DDlEq4e00bzyxSXqLSzUbHeeAKFqvcOPOXEVqIytat2S6IzFgrZPMDn5iZ9xs9PMh1bc5emmfQK gsC3IB/wnyL/qT/Z8Q69I7a96Tu1lhk90VtJceGgHZ6iQ7yJqQqNXAFIq8OegZXrxLrRGTAiI86x Ll9CQkL3Eqzwcytc5ODQOlHraZ8LNMTPKyrsmBbR+DZTHarDiGb2xDbQxlF/r5JIHEDoxJAr7pVA SPHzK/R8rO1A1wC/j1TtLwmAyHPy7aArXZTXh3WVjsusE4tkPmPETQGHv/lU+i5ZEI16xZkOtvU+ oFaBWCVgBRO7pKq8XmUE1YIbU8Nt0Y25+Ep8vxtepyuof+bzKwB8fYdz4MnGAoq5nfBAHdGB4Q2r SgyZELnLNqc1EBh91DqAg6t0xJMO/mDIIqtjA1B2VlTmLqZdar6g4ZhIMWlbiblTH0cltTMrPqfo P4drM6TQMGHbcZ8liOez9zpDEwYacGK7LqcRSEP/Um+XumY2tGV7Z1Jye/IqnVcurKZr2ZOE8Jh/ lSzdFGCnOK0FFnfMNxk2nopBQDle2c36m3Vx+ZasZuirtw8D1KrcBoGF5nACF+qh2clH40ZLVFc1 YAvBm3HX/4T6yeoor5HtuUDiWj/v/R37QEW/+wilTSIF5nre2J6Acsy5PB8LArcBMWifySUzSj/U 0CRjczIwUAMDw0RzlAAsb9FiRQxP5JpvzDzbj/we4FsgzZAjUOf/rjlDbbJ9qOU1aMyY780Dh1RA KMH+5vv1eAtg9rUljM4SvAqhJVB3To1z6xQYhEAPbmBmsGW6HegCl9Qm7E9hT62lFJwz1bBaWxj2 qFateBcxNH/6j6OK3/JzY1u+atQDTeox1EZTJWFytBm4zx5F/rmg== X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Yang Yingchao To: bug-gnu-emacs@gnu.org Subject: 29.4.50; forward-comment not working as expected in toml-ts-mode Date: Tue, 06 Aug 2024 13:57:28 +0800 Message-ID: <87bk269os7.fsf@qq.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=203.205.221.235; envelope-from=yang.yingchao@qq.com; helo=out203-205-221-235.mail.qq.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Steps to reproduce: 1. Open a new buffer in `toml-ts-mode`. 2. Insert the following simple snippets: ``` # (forward-comment 1) # [[keyboard.bindings]] # chars = "a" # key = "Tab" # mods = "Alt" ``` 3. Move the cursor to the first line and call `eval-last-sexp`. This should move the cursor to the beginning of the line "chars = a", but actually it moves the cursor to the end of the whole block. This might be an issue with `toml-ts-mode--syntax-table`. Making a change in https://github.com/emacs-mirror/emacs/blob/e993e479c324bb720bca3f1cf194e55e32f01ccd/lisp/textmodes/toml-ts-mode.el#L53 can fix this issue: ``` - (modify-syntax-entry ?\n "> b" table) + (modify-syntax-entry ?\n ">" table) ``` Regards yang From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 07:51:19 2024 Received: (at 72489) by debbugs.gnu.org; 6 Aug 2024 11:51:19 +0000 Received: from localhost ([127.0.0.1]:60358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbIik-00023P-OX for submit@debbugs.gnu.org; Tue, 06 Aug 2024 07:51:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbIii-000239-O7 for 72489@debbugs.gnu.org; Tue, 06 Aug 2024 07:51:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbIiF-0006qA-DF; Tue, 06 Aug 2024 07:50:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lviHfphdOwZ1jcVRbanv/TktWsXv4jCukX/FIjKCF2o=; b=Vn7YItbQJ7LuaNeyLEwj JEaBlBgyFzviNyRkfdViY+pxAj5h0pfnOfta4MZpZFsqlzUMOoY/i9S2YzFM9WRhGA5E0C/us7MyW JpALHDVSLdAZ9F1kdIgVWBI1xun6RC6d5rqZ3/e8xbEuVVbd7NMTnyCgjXFAB5m61JDzIqPQtA2V7 Kb+HvbkqrZTERDRSoO59+WGO+St7odUuQ1RrSVFqbCERzmuvqSLBea4FXfEdhR8i6nG7ZQAXWfFUR aV+NFklKaXuSZ3o2UZIhk+dLogblb09ijlVapIKXS2xO+ja01xTvGc6fyqESx5/dG4GifmR4YYiMo 6IrRo6aWaNKWNg==; Date: Tue, 06 Aug 2024 14:50:45 +0300 Message-Id: <86cymlq38q.fsf@gnu.org> From: Eli Zaretskii To: Yang Yingchao , Jostein =?utf-8?Q?Kj=C3=B8nigsen?= In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#72489: 29.4.50; forward-comment not working as expected in toml-ts-mode References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72489 Cc: 72489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 06 Aug 2024 13:57:28 +0800 > From: Yang Yingchao via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > > Steps to reproduce: > > 1. Open a new buffer in `toml-ts-mode`. > 2. Insert the following simple snippets: > ``` > # (forward-comment 1) > # [[keyboard.bindings]] > # chars = "a" > # key = "Tab" > # mods = "Alt" > ``` > 3. Move the cursor to the first line and call `eval-last-sexp`. > > This should move the cursor to the beginning of the line "chars = a", but actually it moves the cursor to the end of the whole block. > > This might be an issue with `toml-ts-mode--syntax-table`. > > Making a change in https://github.com/emacs-mirror/emacs/blob/e993e479c324bb720bca3f1cf194e55e32f01ccd/lisp/textmodes/toml-ts-mode.el#L53 can fix this issue: > > ``` > - (modify-syntax-entry ?\n "> b" table) > + (modify-syntax-entry ?\n ">" table) > ``` Thanks. Jostein, could you please look into this? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 09:06:49 2024 Received: (at 72489) by debbugs.gnu.org; 6 Aug 2024 13:06:49 +0000 Received: from localhost ([127.0.0.1]:60407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbJtp-0004UH-1y for submit@debbugs.gnu.org; Tue, 06 Aug 2024 09:06:49 -0400 Received: from fout1-smtp.messagingengine.com ([103.168.172.144]:54987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbJtl-0004Tp-HR for 72489@debbugs.gnu.org; Tue, 06 Aug 2024 09:06:47 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 8E4F2138830D; Tue, 6 Aug 2024 09:06:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 06 Aug 2024 09:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1722949576; x=1723035976; bh=6pE2mHp9rj XlpvW/S+lWjHJyEphizJhsm4p3wKuGceA=; b=gA+Hm04n2poVr7BB3Wk2LzOGy+ ojMAKjEq0v8/oZEFmSXlSiOBav98cyJlGiM8xg4VscuUVdlD5BClwaNGgn39Lttz 2d8KenQtJm8VbJNN+Pd8pwJDKy9axiZUeOGtaLza6a+3TGRfbsxeZAKQd28P1+NS NkIVuURkKIdaF9kAT7g94+uUl9LjJ4Va8+gE3DsQpEl1qlL7GrmJv8i1o0rORxS+ won/IkhkMfY1wNnZNASSl5v4s67dB7250ymLQ6dm/6emE8Slt/oCSKe8mlX10k6w 7cNPtXK0FYryu8YPMz0OUNoHwMAKdfQnfcp8rJJ5Hl4ZO8/VRg9WAOCA3Z8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722949576; x= 1723035976; bh=6pE2mHp9rjXlpvW/S+lWjHJyEphizJhsm4p3wKuGceA=; b=c G6VIW3GkhZAzfaXVn+tsABLTGR5lXZwWnDS8OzC9UBA373NPeM5YgjhEE0ONFVah hrO8W8sqPR2BHWMvt0dL9f9h6lzFrl5c8GbbSuuyDiTUJKWzjX4hm69Z0b1Az5Vw OZn86wMw5Y9zE0ecgYrw5xVuBOjBWg9wgQMFw+XhKW/KFfxbCOaL36BKPzVOL/2W wk9LT4l7hEUGcpfIR20ZdKXlW5xTbMINWjrrd6X8d23/hx5E0Zebl6p2MN3/DCxS J4wUQ3beOAvl+ZBEiko2TPTpgFHfEe4andYBNJ0qksXnGCFeyEbZYgqELmaTT6he VGMGyVySkokmhvLS1Rxow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrkeekgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptefhuefhvddtffdvheehtdfhfeeg gfevueellefggefhfeevkeefvdfgffejgeevnecuffhomhgrihhnpehgihhthhhusgdrtg homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvthdpnhgspghrtghpth htoheptd X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Aug 2024 09:06:15 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: bug#72489: 29.4.50; forward-comment not working as expected in toml-ts-mode From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= In-Reply-To: <86cymlq38q.fsf@gnu.org> Date: Tue, 6 Aug 2024 15:06:03 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <2BD4ADA2-2D9D-4D63-B08F-668EDF22193F@secure.kjonigsen.net> References: <86cymlq38q.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72489 Cc: Yang Yingchao , =?utf-8?B?Ik1yLiBKb3N0ZWluIEtqw7huaWdzZW4i?= , 72489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 6 Aug 2024, at 13:50, Eli Zaretskii wrote: >=20 >> Date: Tue, 06 Aug 2024 13:57:28 +0800 >> From: Yang Yingchao via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >>=20 >>=20 >> Steps to reproduce: >>=20 >> 1. Open a new buffer in `toml-ts-mode`. >> 2. Insert the following simple snippets: >> ``` >> # (forward-comment 1) >> # [[keyboard.bindings]] >> # chars =3D "a" >> # key =3D "Tab" >> # mods =3D "Alt" >> ``` >> 3. Move the cursor to the first line and call `eval-last-sexp`. >>=20 >> This should move the cursor to the beginning of the line "chars =3D = a", but actually it moves the cursor to the end of the whole block. >>=20 >> This might be an issue with `toml-ts-mode--syntax-table`. >>=20 >> Making a change in = https://github.com/emacs-mirror/emacs/blob/e993e479c324bb720bca3f1cf194e55= e32f01ccd/lisp/textmodes/toml-ts-mode.el#L53 can fix this issue: >>=20 >> ``` >> - (modify-syntax-entry ?\n "> b" table) >> + (modify-syntax-entry ?\n ">" table) >> ``` >=20 > Thanks. >=20 > Jostein, could you please look into this? Hey there. Let me see if I can help. Just to be clear I understand the issue and how to reproduce it: 1. you create an empty buffer and activate toml-ts-mode 2. you paste in the supplied text, which is all comments according to = TOML syntax 3. first line is actually a commented out emacs-lisp command. 4. you use (eval-last-sexp) to invoke the command emacs-lisp = (forward-comment 1) And once you do that, the expected outcome would be to jump to next = comment-line (ie each commented line is considered its own = comment-block)? I ask, because if I do that, I get an *error* about reaching the end of = file, so it seems like whatever I'm doing I'm getting slightly different = results than you are. Applying the suggested fix does not seem to change = behaviour either? Yang: Have you loaded/compiled/provided the toml typescript-grammar = before using this mode? The *-ts-modes depends on external grammar in order to properly = initialize the major-mode and provide correct highlighting and = indentation. -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 21:09:23 2024 Received: (at 72489) by debbugs.gnu.org; 7 Aug 2024 01:09:23 +0000 Received: from localhost ([127.0.0.1]:33383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbVB4-0008Mk-W9 for submit@debbugs.gnu.org; Tue, 06 Aug 2024 21:09:23 -0400 Received: from out203-205-221-153.mail.qq.com ([203.205.221.153]:45474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbVB0-0008MQ-K3 for 72489@debbugs.gnu.org; Tue, 06 Aug 2024 21:09:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1722992619; bh=uP1E5zjuRjyb/S0VZWVGZ8g9gxe4NOR9827BQdAAYXg=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=hhFQq0n3+dPi8ZHpfdS59i3CDnGXyQZzQXAnWKX+cL7qmjkodGEwz0gC6522cb0bV W6A9jvdgTsUm3i+hhV3qrWX72BrbZhJfu7g3LHtsZ5TA4sgVUHh338nOytXXW5m921 aoJk/9nefNf4cnqB3jv+fgRVzYvpOJE+3pCHcKWg= Received: from tbook ([116.130.79.103]) by newxmesmtplogicsvrszb9-0.qq.com (NewEsmtp) with SMTP id E585A20; Wed, 07 Aug 2024 09:03:37 +0800 X-QQ-mid: xmsmtpt1722992617t9bczssxj Message-ID: X-QQ-XMAILINFO: NIergYn61mJ1KQ1dJ0pEL/xSzooyL3flrUwhl9jNotanyRJ3IXO1e7Z/R25+O/ Ice96pOn7f+OtcioUn8hpZiKuHSa0n9zSTWWJt0iMo9XkeQbtbYxFIQCu1hvepk4kg749VxeB3Qs R+6q5iJYHJXOoXi2CysEOCR/5DxocaNhA9RXtUTzIbCm+BSHH33eIFD0loHna6LL/s8Cu0s5j86f dCqpS9uLFoOqPQ3CYRu2dKGM4qnZJpcYdyAxj/eCOdh7JPJLs54Bmo8FQlcYJwizyaQkbzjrWEJ3 g+TUoRTFxC9dsepu+dJMk+fOboDyR2Or3vVTphjfVIHHWEDTjCykWc4G3dPq8FLTwgHW5GAb7+rS WimO9AOZ2OEZdI3UlDGUsqF4+4oxMUsKPROZmUX+6xsFkTkRo2FQTHDjZuqfDk/pz8jcQss79e0+ lufsBvaKLk0yKcc2lGggVPQ1+Qdxhbe0/gKjYy6PapyFaVBjRsebjYq5RfJje3//9fNx80g3bIhU C2O1AKCi7/JJW8nWwRnopfIEi9YFfVFdblw2gIkQlpxu0MntPIGiSaTgoBDNntFRYik+6dalZEdC QcSE1oBOnjVpJaUTc1AdomdkhCMnwg6UshKIcpZ3axLsPfFR3tVEl6G1YQpUnAD8lFRSCrTU8pJG lMVloE+u8hBYebHXgfer5NdHqGuiUEixf0YroSlDlO+w0XF9m0MIZZpICfb9eCU0kJrNjsKU4+dL /CHlrToKuFLsHigmCPSdmiitqhBqWOqdxzUmFtZhDBmjvMIb4qMM67VqhGj4WAts8qcRmvG6SZUS Yu5QIveaGJ3cBIVhf3aX+xB+fUNYPdFGOINWGdIohrR8R3qa4A7OIQQnwckBK6K2RZU895/DvJPp HfwzYme7FNap0W+g6jtVM/7b0U2gywF0nzfp0VRIOKvQmT22A6xm1T8Pz2ZHh0dmUYOjLjOMY/h7 aHQKGuOIIBGwGjIfICCs0bfS3BWtM/ X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= From: Yang Yingchao To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= Subject: Re: bug#72489: 29.4.50; forward-comment not working as expected in toml-ts-mode In-Reply-To: <2BD4ADA2-2D9D-4D63-B08F-668EDF22193F@secure.kjonigsen.net> ("Jostein =?utf-8?Q?Kj=C3=B8nigsen=22's?= message of "Tue, 6 Aug 2024 15:06:03 +0200") References: <86cymlq38q.fsf@gnu.org> <2BD4ADA2-2D9D-4D63-B08F-668EDF22193F@secure.kjonigsen.net> Date: Wed, 07 Aug 2024 09:02:31 +0800 Message-ID: <87a5hpf8m0.fsf@qq.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Just to be clear I understand the issue and how to reproduce it: > > 1. you create an empty buffer and activate toml-ts-mode > 2. you paste in the supplied text, which is all comments according to T [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.153 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (yang.yingchao[at]qq.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 72489 Cc: Eli Zaretskii , =?utf-8?Q?Mr=2E_Jostein_Kj=C3=B8nigsen?= , 72489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Just to be clear I understand the issue and how to reproduce it: > > 1. you create an empty buffer and activate toml-ts-mode > 2. you paste in the supplied text, which is all comments according to T [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [203.205.221.153 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (yang.yingchao[at]qq.com) 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) --=-=-= Content-Type: text/plain Content-Disposition: inline > Just to be clear I understand the issue and how to reproduce it: > > 1. you create an empty buffer and activate toml-ts-mode > 2. you paste in the supplied text, which is all comments according to TOML syntax > 3. first line is actually a commented out emacs-lisp command. > 4. you use (eval-last-sexp) to invoke the command emacs-lisp (forward-comment 1) > > And once you do that, the expected outcome would be to jump to next comment-line (ie each commented line is considered its own comment-block)? > > I ask, because if I do that, I get an *error* about reaching the end of file, so it seems like > whatever I'm doing I'm getting slightly different results than you are. Applying the suggested fix > does not seem to change behaviour either? I think the error in your case also proves the misbehavior of forward-comment, and it breaks `uncomment-region' in my case. And with the suggested fix applied, and then recompile/evaluate, `uncomment-region' works as expected. > Yang: Have you loaded/compiled/provided the toml typescript-grammar before using this mode? > > The *-ts-modes depends on external grammar in order to properly initialize the major-mode and provide correct highlighting and indentation. I only have the required shared libraries (libtree-sitter.so & libtree-sitter-toml.so) installed. This should be enough, right? At least `treesit-explore-mode' works fine in toml buffer. Regards, -- *Yang Yingchao* --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 15 06:11:44 2024 Received: (at 72489) by debbugs.gnu.org; 15 Aug 2024 10:11:44 +0000 Received: from localhost ([127.0.0.1]:48381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seXSJ-0008VU-QC for submit@debbugs.gnu.org; Thu, 15 Aug 2024 06:11:44 -0400 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:57739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seXSG-0008VD-MU for 72489@debbugs.gnu.org; Thu, 15 Aug 2024 06:11:41 -0400 Received: from phl-compute-01.internal (phl-compute-01.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 802A61151CBD; Thu, 15 Aug 2024 06:10:59 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Thu, 15 Aug 2024 06:10:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1723716659; x=1723803059; bh=jRrwCS9GTSOxManI90RMYVpyGVCZKgyx7jlKDK4ikNI=; b= LF9wpwtlSydzd0oSGZB+x9Qkk9+YB5UY5B+bH4EYuCMuYayGlw/7RBkE8hgXgHEH 7695nJfACTyo2OsfBb8CsHD3N3sKrWYSTGNjW2PZrbLW9QzF2KoxnuHL1ShCOy2e UihpmXkw05QSs9SmimR7D4sQajSw/pFvvq6QR/QQJcyhZZxfeH71oshoOk+We9xR kII4+Nnbw81axPw+qRYUoYN8EHpey7w+FC0JBkp7M7o5amEYnzRiQRCqyYHFSsP1 oemwETU/HJmpkOIlvDDAd2FlhuBz7Vy5pTgdT7+FPfZHLy/q1MNnKEoAHjBE6Zm0 G2Mz1exOZwpg2greV/VQIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1723716659; x=1723803059; bh=jRrwCS9GTSOxManI90RMYVpyGVCZ Kgyx7jlKDK4ikNI=; b=fpLJWy5NRUkG5qeNNI9VspFe9W9QLpFfKf24XewGxMsw FwYjqbMXDN5p/C18A1sD8ojLlrGEWYs6OOjrzG4upgZ4VhUW1vgx5jPjgndqaM/h dgEakpeKfXKDI+8+drbwudfdUyNp1AndBbypuJ8f5lJmafxpkAq/v5a2j+Z0Vs0C R3hk9klXVcfR70Z2x0f5rbKKPKmvUc7WP5Z4NiH9kbOmRMhdI8xA5CAGabL+WDmE oVCLKkKqcF30pEvYAcw3B8gFgFgJLSTsigV9GT1o3Lrn0x3dltK0pOGmFbCJfj8l LkGIm/N1Vp/djQ3+RCj1JdfRF8Ifa/AEputfd3IRLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddtiedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdtvden ucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvg gtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepueeuteef ffeigfdtffdvjeduuedtveetleeutdeifeeludegvdeugfeugfefjeeknecuffhomhgrih hnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnh gvthdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep higrnhhgrdihihhnghgthhgrohesqhhqrdgtohhmpdhrtghpthhtohepvghlihiisehgnh hurdhorhhgpdhrtghpthhtohepjhhoshhtvghinheskhhjohhnihhgshgvnhdrnhgvthdp rhgtphhtthhopeejvdegkeelseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Aug 2024 06:10:58 -0400 (EDT) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Message-Id: <52D8946D-CABF-413B-977E-F5FD96586509@secure.kjonigsen.net> Content-Type: multipart/alternative; boundary="Apple-Mail=_41A633E4-62C8-43B0-AD1A-6F4EAA81156B" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: bug#72489: 29.4.50; forward-comment not working as expected in toml-ts-mode Date: Thu, 15 Aug 2024 12:10:46 +0200 In-Reply-To: To: Yang Yingchao References: <86cymlq38q.fsf@gnu.org> <2BD4ADA2-2D9D-4D63-B08F-668EDF22193F@secure.kjonigsen.net> X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72489 Cc: Eli Zaretskii , =?utf-8?B?Ik1yLiBKb3N0ZWluIEtqw7huaWdzZW4i?= , 72489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_41A633E4-62C8-43B0-AD1A-6F4EAA81156B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 7 Aug 2024, at 03:02, Yang Yingchao wrote: >=20 > I think the error in your case also proves the misbehavior of = forward-comment, and it breaks `uncomment-region' in my case. And with = the suggested fix applied, and then recompile/evaluate, = `uncomment-region' works as expected. >=20 >> Yang: Have you loaded/compiled/provided the toml typescript-grammar = before using this mode? >>=20 >> The *-ts-modes depends on external grammar in order to properly = initialize the major-mode and provide correct highlighting and = indentation. >=20 > I only have the required shared libraries (libtree-sitter.so & = libtree-sitter-toml.so) installed. This should be enough, right? At = least `treesit-explore-mode' works fine in toml buffer. >=20 > Regards, >=20 > -- *Yang Yingchao* I've recompiled from scratch and confirm this indeed fixes all issues = mentioned. Eli: Feel free to apply the supplied patch. I still don't have commit = access :) = https://github.com/emacs-mirror/emacs/blob/e993e479c324bb720bca3f1cf194e55= e32f01ccd/lisp/textmodes/toml-ts-mode.el#L53 > ``` > - (modify-syntax-entry ?\n "> b" table) > + (modify-syntax-entry ?\n ">" table) > ``` --Apple-Mail=_41A633E4-62C8-43B0-AD1A-6F4EAA81156B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On 7 Aug = 2024, at 03:02, Yang Yingchao <yang.yingchao@qq.com> = wrote:

I think the error in your case also proves the = misbehavior of forward-comment, and it breaks `uncomment-region' in my = case. And with the suggested fix applied, and then recompile/evaluate, = `uncomment-region' works as expected.

Yang: Have you loaded/compiled/provided the toml = typescript-grammar before using this mode?

The *-ts-modes depends = on external grammar in order to properly initialize the major-mode and = provide correct highlighting and indentation.

I only = have the required shared libraries (libtree-sitter.so & = libtree-sitter-toml.so) installed. This should be enough, right? At = least `treesit-explore-mode' works fine in toml = buffer.

Regards,

-- *Yang = Yingchao*

I've recompiled = from scratch and confirm this indeed fixes all issues = mentioned.

Eli: Feel free to apply the supplied = patch. I still don't have commit access :)

```
- =    (modify-syntax-entry ?\n "> b" =  table)
+ =    (modify-syntax-entry ?\n ">" =  table)
```

= --Apple-Mail=_41A633E4-62C8-43B0-AD1A-6F4EAA81156B-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 05:31:50 2024 Received: (at 72489-done) by debbugs.gnu.org; 17 Aug 2024 09:31:50 +0000 Received: from localhost ([127.0.0.1]:53505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFmo-0002eE-91 for submit@debbugs.gnu.org; Sat, 17 Aug 2024 05:31:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFml-0002dx-8b for 72489-done@debbugs.gnu.org; Sat, 17 Aug 2024 05:31:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFm2-0004m9-UL; Sat, 17 Aug 2024 05:31:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gXGj9XkXUnkXtXE3JbsmuZt6eIgjfFQ/ZBI6DrvomVg=; b=X6VLQdutmrQDFK87t9Cp eDKqs8NCOuRaCRakldqMyNLcDwmvE2E1AFMgcTgttl+CB6wr6klPBWBWMYSv7BgbcNyRkU3vzrVUi 11i0HwVuzAIBdxfze058+X0wdwEi90qZG3OhAMJ8WHGojKksAdycYJoxU0p8U6+THWQEc58Jftp+y fUDj4EHovZ/cn/rYGYCZDWNPMcYv0biArkICpxxuVxioufjiZtMiabLMbqbYaDQNrLPO+4zDqiCuJ 8XVjyw4Gc2j1XrJDSsKIcJMqwQiU6KIof80em/YguptUMBi5cs4lkMdoibPvE6U46seM6n3Xpq2u5 MuyXSvUuIalK/A==; Date: Sat, 17 Aug 2024 12:31:00 +0300 Message-Id: <861q2n4ht7.fsf@gnu.org> From: Eli Zaretskii To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <52D8946D-CABF-413B-977E-F5FD96586509@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Thu, 15 Aug 2024 12:10:46 +0200) Subject: Re: bug#72489: 29.4.50; forward-comment not working as expected in toml-ts-mode References: <86cymlq38q.fsf@gnu.org> <2BD4ADA2-2D9D-4D63-B08F-668EDF22193F@secure.kjonigsen.net> <52D8946D-CABF-413B-977E-F5FD96586509@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72489-done Cc: yang.yingchao@qq.com, 72489-done@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jostein Kjønigsen > Date: Thu, 15 Aug 2024 12:10:46 +0200 > Cc: Eli Zaretskii , > "Mr. Jostein Kjønigsen" , > 72489@debbugs.gnu.org > > On 7 Aug 2024, at 03:02, Yang Yingchao wrote: > > I think the error in your case also proves the misbehavior of forward-comment, and it breaks > `uncomment-region' in my case. And with the suggested fix applied, and then recompile/evaluate, > `uncomment-region' works as expected. > > Yang: Have you loaded/compiled/provided the toml typescript-grammar before using this mode? > > The *-ts-modes depends on external grammar in order to properly initialize the major-mode and > provide correct highlighting and indentation. > > I only have the required shared libraries (libtree-sitter.so & libtree-sitter-toml.so) installed. This should > be enough, right? At least `treesit-explore-mode' works fine in toml buffer. > > Regards, > > -- *Yang Yingchao* > > I've recompiled from scratch and confirm this indeed fixes all issues mentioned. > > Eli: Feel free to apply the supplied patch. I still don't have commit access :) > > https://github.com/emacs-mirror/emacs/blob/e993e479c324bb720bca3f1cf194e55e32f01ccd/lisp/textmodes/toml-ts-mode.el#L53 > > > ``` > - (modify-syntax-entry ?\n "> b" table) > + (modify-syntax-entry ?\n ">" table) > ``` Thanks, installed on the emacs-30 branch, and closing the bug. From unknown Fri Sep 19 20:44:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Sep 2024 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator