From unknown Mon Aug 18 04:07:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72485 <72485@debbugs.gnu.org> To: bug#72485 <72485@debbugs.gnu.org> Subject: Status: Support 'visual-wrap-prefix-mode' in SHR/EWW Reply-To: bug#72485 <72485@debbugs.gnu.org> Date: Mon, 18 Aug 2025 11:07:29 +0000 retitle 72485 Support 'visual-wrap-prefix-mode' in SHR/EWW reassign 72485 emacs submitter 72485 Jim Porter severity 72485 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 05 23:48:24 2024 Received: (at submit) by debbugs.gnu.org; 6 Aug 2024 03:48:24 +0000 Received: from localhost ([127.0.0.1]:59786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbBBP-0002S1-CF for submit@debbugs.gnu.org; Mon, 05 Aug 2024 23:48:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:34078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbBBN-0002Rq-5k for submit@debbugs.gnu.org; Mon, 05 Aug 2024 23:48:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbBAz-00084W-Gj for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2024 23:47:57 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbBAx-0000P8-Fi for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2024 23:47:57 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1fed72d23a7so1195835ad.1 for ; Mon, 05 Aug 2024 20:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722916074; x=1723520874; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=yljPzvSJ46QKIgAS4ouaFOIbx1P+YkxWGvIq7mBRrH0=; b=c2w6rvTpntQplH93P3QSGVE7iE02yAxxavuQ1CjNTI3+QiBCourrPBU9wriyZS3tkz jyGy6bAbSEI0UTinIUmkVPJpysp751TJzZsafguK4+BayWHHmQ3cNkv9tgf0xSpznGTk qRNaSUiE2pWu/CyV94BCKrLCV/2IwT4bUDaLog0fD0GUFGfjpxrWMbFcOdbrbiZysE9A OoYz6qm4kSmBMRSf6VSGPItfpWscdlfIOryHW/qaWIpxcLxkavc0NCIHjrUPq1BahKsM HBGzcRnlR03gPkPV/X8UynYoq2CyTU+NqbXZT+djsr+DvjIdIqvrvevV9jh2suUTRu34 OPYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722916074; x=1723520874; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yljPzvSJ46QKIgAS4ouaFOIbx1P+YkxWGvIq7mBRrH0=; b=YGYPcl8E1yTM7SkO1EYzjzAcpxgYdr0haJoJnfZTHNU86aaVBg5I0WpRjmnjfX9Y/A AAs7gJ7qUuNkDFOOCMV0NX1UxHSbbQlsphLxnid0X5c4pky17m4ZDxRh0NjwIMNeNOe5 ZOGAJ+bYKc5JFF1fEZll0CqK1TjTG5mqwje+U2mO/GJuJLkbWEv6QoVea9GTmU/vjRUe t4YHYHhwxliiEGVHw/iW1txwS7TqMsJON6glz0k19bMUw0OdeCSBbaNIazquUL7/x1L0 hCjAoyMIs8g4oOxJjGIIU3LsKBfDZ3X3d5TpiY2raJ+pZxp4jp0WS+jlPENEHuNSOHhH Wb6Q== X-Gm-Message-State: AOJu0YwM8ZDZj2js2mUdQgAbv5H0iAtkSzUx1tUXbK0Cfh3Y9pfzWcqx e9AQoacqIooyFI1AzSlyj5RjdgZRZOtE4F3a3na+MIlURzG6oSJHSjZ4pA== X-Google-Smtp-Source: AGHT+IFw18EYd2pehEA4fy5jle5uUtHYhYX47cksU2IEhM+rpKHzl/Xyuz62vWQysR9LcbCwnlzY/w== X-Received: by 2002:a17:903:2308:b0:1ff:5049:7353 with SMTP id d9443c01a7336-1ff57281c4amr120646165ad.19.1722916073254; Mon, 05 Aug 2024 20:47:53 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1ff5929407asm76806935ad.242.2024.08.05.20.47.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 20:47:52 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------1Xt5M4ePysxEncC56MvjJmje" Message-ID: Date: Mon, 5 Aug 2024 20:47:52 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: Support 'visual-wrap-prefix-mode' in SHR/EWW Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------1Xt5M4ePysxEncC56MvjJmje Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This patch is an extension of bug#71605, and the first place to explicitly use the new variable-pitch support for 'visual-wrap-prefix-mode'. While implementing this, I found two small bugs in the new 'visual-wrap-prefix-mode' code: 1. When setting the min-width for the first line prefix, we should use 'add-display-text-property' so as not to clobber other display properties. 2. My attempts to be "helpful" by special-casing wrap-prefixes of all spaces ended up just interfering with more complex cases (like SHR), so I removed it. The code is now simpler (one fewer condition) and just works more smoothly overall. There's one limitation to this patch though: since SHR uses absolute pixel-widths for indenting internally, things can look mis-indented if you scale the text in the buffer. However, SHR has exactly the same issue when *not* using 'visual-wrap-prefix-mode', so it's really just a more-general bug in SHR. (It'd be nice to fix that, but I'd have to get a better understanding of how indentation and elements interact.) Attached is a test HTML page that shows off the indentation. You can see the results by running: emacs -Q --eval '(progn (setq shr-fill-text nil) (eww "test.html"))' (And also compare to the default behavior where 'shr-fill-text' is non-nil.) --------------1Xt5M4ePysxEncC56MvjJmje Content-Type: text/plain; charset=UTF-8; name="0001-Improve-SHR-EWW-support-for-visual-wrap-prefix-mode.patch" Content-Disposition: attachment; filename*0="0001-Improve-SHR-EWW-support-for-visual-wrap-prefix-mode.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA1ZTFkZTA5YWY1Mzk4YmQwYTYwNjgzZWJmNTNiZWYzZjg3NDQwYTkxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgNCBBdWcgMjAyNCAxOTozNzowMCAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEltcHJvdmUgU0hSL0VXVyBzdXBwb3J0IGZvciAndmlzdWFsLXdyYXAtcHJlZml4LW1v ZGUnCgoqIGxpc3AvdmlzdWFsLXdyYXAuZWwgKHZpc3VhbC13cmFwLS1hcHBseS10by1saW5l KTogVXNlCidhZGQtZGlzcGxheS10ZXh0LXByb3BlcnR5JyBzbyB3ZSBkb24ndCBjbG9iYmVy IG90aGVyIGRpc3BsYXkKcHJvcGVydGllcy4KKHZpc3VhbC13cmFwLS1jb250ZW50LXByZWZp eCk6IFJlbW92ZSBzcGVjaWFsLWNhc2UgZm9yIHNwYWNlcy1vbmx5CmluZGVudCBwcmVmaXg7 IHRoaXMgd2FzIGFuIGF0dGVtcHQgdG8gYmUgaGVscGZ1bCBmb3IgdmFyaWFibGUtcGl0Y2gK Zm9udHMsIGJ1dCBpbiBwcmFjdGljZSBqdXN0IGludGVyZmVyZXMgd2l0aCBtYXR0ZXJzLiAg VGhpcyBjYXNlIG5vdwpmYWxscyBiYWNrIHRvIHRoZSBvbmUgaW1tZWRpYXRlbHkgZm9sbG93 aW5nIGl0IChyZXR1cm4gdGhlIHN0cmluZyBvZgpzcGFjZXMpLikKCiogbGlzcC9uZXQvc2hy LmVsIChzaHItaW5kZW50KTogU2V0ICdzaHItcHJlZml4LWxlbmd0aCcgaGVyZSB0byBoZWxw CmtlZXAgdHJhY2sgb2YgdGhlIHByZWZpeGVzIG9mIG5lc3RlZGx5LWluZGVudGVkIGVsZW1l bnRzLgoqIGxpc3AvbmV0L3Noci5lbCAoc2hyLWFkYXB0aXZlLWZpbGwtZnVuY3Rpb24pOiBV c2UgJ3Noci1wcmVmaXgtbGVuZ3RoJwphcyBzZXQgYWJvdmUgdG8gcmV0dXJuIGEgZmlsbCBw cmVmaXguCgoqIGxpc3AvbmV0L2V3dy5lbCAoZXd3LXJlbmRlcik6IEVuYWJsZSAndmlzdWFs LXdyYXAtcHJlZml4LW1vZGUnCmFsb25nc2lkZSBvZiAndmlzdWFsLWxpbmUtbW9kZScuCihl d3ctbW9kZSk6IFNldCAnYWRhcHRpdmUtZmlsbC1mdW5jdGlvbicgdG8KJ3Noci1hZGFwdGl2 ZS1maWxsLWZ1bmN0aW9uJy4KLS0tCiBsaXNwL25ldC9ld3cuZWwgICAgIHwgIDUgKysrKy0K IGxpc3AvbmV0L3Noci5lbCAgICAgfCAxOSArKysrKysrKysrKysrKy0tLS0tCiBsaXNwL3Zp c3VhbC13cmFwLmVsIHwgMTIgKysrLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDIxIGlu c2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3 dy5lbCBiL2xpc3AvbmV0L2V3dy5lbAppbmRleCBiMmUxYzVhNzJlNS4uYjVkMmYyMDc4MWEg MTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAg LTcwOSw3ICs3MDksOCBAQCBld3ctcmVuZGVyCiAJICAgICAgKGFuZCBsYXN0LWNvZGluZy1z eXN0ZW0tdXNlZAogCQkgICAoc2V0LWJ1ZmZlci1maWxlLWNvZGluZy1zeXN0ZW0gbGFzdC1j b2Rpbmctc3lzdGVtLXVzZWQpKQogICAgICAgICAgICAgICAodW5sZXNzIHNoci1maWxsLXRl eHQKLSAgICAgICAgICAgICAgICAodmlzdWFsLWxpbmUtbW9kZSkpCisgICAgICAgICAgICAg ICAgKHZpc3VhbC1saW5lLW1vZGUpCisgICAgICAgICAgICAgICAgKHZpc3VhbC13cmFwLXBy ZWZpeC1tb2RlKSkKIAkgICAgICAocnVuLWhvb2tzICdld3ctYWZ0ZXItcmVuZGVyLWhvb2sp CiAgICAgICAgICAgICAgIDs7IEVuYWJsZSB1bmRvIGFnYWluIHNvIHRoYXQgdW5kbyB3b3Jr cyBpbiB0ZXh0IGlucHV0CiAgICAgICAgICAgICAgIDs7IGJveGVzLgpAQCAtMTMzNiw2ICsx MzM3LDggQEAgZXd3LW1vZGUKICAgOzsgZGVza3RvcCBzdXBwb3J0CiAgIChzZXRxLWxvY2Fs IGRlc2t0b3Atc2F2ZS1idWZmZXIgIydld3ctZGVza3RvcC1taXNjLWRhdGEpCiAgIChzZXRx IHRydW5jYXRlLWxpbmVzIHQpCisgIDs7IHZpc3VhbC13cmFwLXByZWZpeC1tb2RlIHN1cHBv cnQKKyAgKHNldHEtbG9jYWwgYWRhcHRpdmUtZmlsbC1mdW5jdGlvbiAjJ3Noci1hZGFwdGl2 ZS1maWxsLWZ1bmN0aW9uKQogICA7OyB0aGluZ2F0cHQgc3VwcG9ydAogICAoc2V0cS1sb2Nh bCB0aGluZy1hdC1wb2ludC1wcm92aWRlci1hbGlzdAogICAgICAgICAgICAgICAoY29ucyAn KHVybCAuIGV3dy0tdXJsLWF0LXBvaW50KQpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvc2hyLmVs IGIvbGlzcC9uZXQvc2hyLmVsCmluZGV4IGQzYzQ4YjM0NDI4Li5hMGY5Y2QyNTJkMiAxMDA2 NDQKLS0tIGEvbGlzcC9uZXQvc2hyLmVsCisrKyBiL2xpc3AvbmV0L3Noci5lbApAQCAtOTM4 LDYgKzkzOCwxMSBAQCBzaHItZmlsbC1saW5lCiAgICAgICAgICh3aGVuIChsb29raW5nLWF0 ICIgJCIpCiAJICAoZGVsZXRlLXJlZ2lvbiAocG9pbnQpIChsaW5lLWVuZC1wb3NpdGlvbikp KSkpKSkKIAorKGRlZnVuIHNoci1hZGFwdGl2ZS1maWxsLWZ1bmN0aW9uICgpCisgICJSZXR1 cm4gYSBmaWxsIHByZWZpeCBmb3IgdGhlIHBhcmFncmFwaCBhdCBwb2ludC4iCisgICh3aGVu LWxldCAoKHByZWZpeCAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnc2hyLXByZWZpeC1s ZW5ndGgpKSkKKyAgICAoYnVmZmVyLXN1YnN0cmluZyAocG9pbnQpICgrIChwb2ludCkgcHJl Zml4KSkpKQorCiAoZGVmdW4gc2hyLXBhcnNlLWJhc2UgKHVybCkKICAgOzsgQWx3YXlzIGNo b3Agb2ZmIGFuY2hvcnMuCiAgICh3aGVuIChzdHJpbmctbWF0Y2ggIiMuKiIgdXJsKQpAQCAt MTA0MSwxMSArMTA0NiwxNSBAQCBzaHItZW5zdXJlLXBhcmFncmFwaAogCiAoZGVmdW4gc2hy LWluZGVudCAoKQogICAod2hlbiAoPiBzaHItaW5kZW50YXRpb24gMCkKLSAgICAoaWYgKG5v dCBzaHItdXNlLWZvbnRzKQotICAgICAgICAoaW5zZXJ0LWNoYXIgP1xzIHNoci1pbmRlbnRh dGlvbikKLSAgICAgIChpbnNlcnQgP1xzKQotICAgICAgKHB1dC10ZXh0LXByb3BlcnR5ICgx LSAocG9pbnQpKSAocG9pbnQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgJ2Rpc3BsYXkg YChzcGFjZSA6d2lkdGggKCxzaHItaW5kZW50YXRpb24pKSkpKSkKKyAgICAobGV0ICgoc3Rh cnQgKHBvaW50KSkKKyAgICAgICAgICAocHJlZml4IChvciAoZ2V0LXRleHQtcHJvcGVydHkg KHBvaW50KSAnc2hyLXByZWZpeC1sZW5ndGgpIDApKSkKKyAgICAgIChpZiAobm90IHNoci11 c2UtZm9udHMpCisgICAgICAgICAgKGluc2VydC1jaGFyID9ccyBzaHItaW5kZW50YXRpb24p CisgICAgICAgIChpbnNlcnQgP1xzKQorICAgICAgICAocHV0LXRleHQtcHJvcGVydHkgc3Rh cnQgKHBvaW50KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Rpc3BsYXkgYChzcGFj ZSA6d2lkdGggKCxzaHItaW5kZW50YXRpb24pKSkpCisgICAgICAocHV0LXRleHQtcHJvcGVy dHkgc3RhcnQgKCsgKHBvaW50KSBwcmVmaXgpCisgICAgICAgICAgICAgICAgICAgICAgICAg J3Noci1wcmVmaXgtbGVuZ3RoICgrIHByZWZpeCAoLSAocG9pbnQpIHN0YXJ0KSkpKSkpCiAK IChkZWZ1biBzaHItZm9udGl6ZS1kb20gKGRvbSAmcmVzdCB0eXBlcykKICAgKGxldCAoKHN0 YXJ0IChwb2ludCkpKQpkaWZmIC0tZ2l0IGEvbGlzcC92aXN1YWwtd3JhcC5lbCBiL2xpc3Av dmlzdWFsLXdyYXAuZWwKaW5kZXggY2FjM2JjNzY3YjguLjUxYzAyMTNhMDM3IDEwMDY0NAot LS0gYS9saXNwL3Zpc3VhbC13cmFwLmVsCisrKyBiL2xpc3AvdmlzdWFsLXdyYXAuZWwKQEAg LTEyMSw5ICsxMjEsOSBAQCB2aXN1YWwtd3JhcC0tYXBwbHktdG8tbGluZQogICAgICAgICAg ICAgICAgKG5leHQtbGluZS1wcmVmaXggKHZpc3VhbC13cmFwLS1jb250ZW50LXByZWZpeAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpcnN0LWxpbmUtcHJlZml4IHBv c2l0aW9uKSkpCiAgICAgICAod2hlbiAobnVtYmVycCBuZXh0LWxpbmUtcHJlZml4KQotICAg ICAgICAocHV0LXRleHQtcHJvcGVydHkKLSAgICAgICAgIHBvc2l0aW9uICgrIHBvc2l0aW9u IChsZW5ndGggZmlyc3QtbGluZS1wcmVmaXgpKSAnZGlzcGxheQotICAgICAgICAgYChtaW4t d2lkdGggKCgsbmV4dC1saW5lLXByZWZpeCAuIHdpZHRoKSkpKSkKKyAgICAgICAgKGFkZC1k aXNwbGF5LXRleHQtcHJvcGVydHkKKyAgICAgICAgIHBvc2l0aW9uICgrIHBvc2l0aW9uIChs ZW5ndGggZmlyc3QtbGluZS1wcmVmaXgpKSAnbWluLXdpZHRoCisgICAgICAgICBgKCgsbmV4 dC1saW5lLXByZWZpeCAuIHdpZHRoKSkpKQogICAgICAgKHNldHEgbmV4dC1saW5lLXByZWZp eCAodmlzdWFsLXdyYXAtLWFkanVzdC1wcmVmaXggbmV4dC1saW5lLXByZWZpeCkpCiAgICAg ICAocHV0LXRleHQtcHJvcGVydHkKICAgICAgICBwb3NpdGlvbiAobGluZS1lbmQtcG9zaXRp b24pICd3cmFwLXByZWZpeApAQCAtMTQxLDEyICsxNDEsNiBAQCB2aXN1YWwtd3JhcC0tY29u dGVudC1wcmVmaXgKICAgKGNvbmQKICAgICgoc3RyaW5nPSBwcmVmaXggIiIpCiAgICAgbmls KQotICAgKChzdHJpbmctbWF0Y2ggKHJ4IGJvcyAoKyBibGFuaykgZW9zKSBwcmVmaXgpCi0g ICAgOzsgSWYgdGhlIGZpcnN0LWxpbmUgcHJlZml4IGlzIGFsbCBzcGFjZXMsIHJldHVybiBp dHMgd2lkdGggaW4KLSAgICA7OyBjaGFyYWN0ZXJzLiAgVGhpcyB3YXksIHdlIGNhbiBzZXQg dGhlIHByZWZpeCBmb3IgYWxsIGxpbmVzIHRvIHVzZQotICAgIDs7IHRoZSBjYW5vbmljYWwt d2lkdGggb2YgdGhlIGZvbnQsIHdoaWNoIGhlbHBzIGZvciB2YXJpYWJsZS1waXRjaAotICAg IDs7IGZvbnRzIHdoZXJlIHNwYWNlIGNoYXJhY3RlcnMgYXJlIHVzdWFsbHkgcXVpdGUgbmFy cm93LgotICAgIChzdHJpbmctd2lkdGggcHJlZml4KSkKICAgICgob3IgKGFuZCBhZGFwdGl2 ZS1maWxsLWZpcnN0LWxpbmUtcmVnZXhwCiAgICAgICAgICAgICAgKHN0cmluZy1tYXRjaCBh ZGFwdGl2ZS1maWxsLWZpcnN0LWxpbmUtcmVnZXhwIHByZWZpeCkpCiAgICAgICAgIChhbmQg Y29tbWVudC1zdGFydC1za2lwCi0tIAoyLjI1LjEKCg== --------------1Xt5M4ePysxEncC56MvjJmje Content-Type: text/html; charset=UTF-8; name="test.html" Content-Disposition: attachment; filename="test.html" Content-Transfer-Encoding: base64 PG9sPgogIDxsaT5Wb2x1cHRhdGVtIGVzdCBub3N0cnVtIGltcGVkaXQgbmVzY2l1bnQgZXVt LiBSZWN1c2FuZGFlIHZvbHVwdGF0ZW0gcXVhZXJhdAogICAgaGljIGhhcnVtLiBDb25zZXF1 YXR1ciBpbiBmdWdhIG5paGlsIGFsaXF1aWQgY29tbW9kaSByZW0gc3VudC4gQXBlcmlhbSBv ZGlvCiAgICBvZGlvIGFtZXQuPC9saT4KICA8bGk+Vm9sdXB0YXRlbSBlc3Qgbm9zdHJ1bSBp bXBlZGl0IG5lc2NpdW50IGV1bS4gUmVjdXNhbmRhZSB2b2x1cHRhdGVtIHF1YWVyYXQKICAg IGhpYyBoYXJ1bS4gQ29uc2VxdWF0dXIgaW4gZnVnYSBuaWhpbCBhbGlxdWlkIGNvbW1vZGkg cmVtIHN1bnQuIEFwZXJpYW0gb2RpbwogICAgb2RpbyBhbWV0LjwvbGk+CiAgPGxpPkFuZCB0 aGVuOgogICAgPG9sPgogICAgICA8bGk+Vm9sdXB0YXRlbSBlc3Qgbm9zdHJ1bSBpbXBlZGl0 IG5lc2NpdW50IGV1bS4gUmVjdXNhbmRhZSB2b2x1cHRhdGVtCiAgICAgICAgcXVhZXJhdCBo aWMgaGFydW0uIENvbnNlcXVhdHVyIGluIGZ1Z2EgbmloaWwgYWxpcXVpZCBjb21tb2RpIHJl bSBzdW50LgogICAgICAgIEFwZXJpYW0gb2RpbyBvZGlvIGFtZXQuPC9saT4KICAgICAgPGxp PlZvbHVwdGF0ZW0gZXN0IG5vc3RydW0gaW1wZWRpdCBuZXNjaXVudCBldW0uIFJlY3VzYW5k YWUgdm9sdXB0YXRlbQogICAgICAgIHF1YWVyYXQgaGljIGhhcnVtLiBDb25zZXF1YXR1ciBp biBmdWdhIG5paGlsIGFsaXF1aWQgY29tbW9kaSByZW0gc3VudC4KICAgICAgICBBcGVyaWFt IG9kaW8gb2RpbyBhbWV0LjwvbGk+CiAgICA8L29sPgogIDwvbGk+Cjwvb2w+Cgo8aHI+Cgo8 dWw+CiAgPGxpPlZvbHVwdGF0ZW0gZXN0IG5vc3RydW0gaW1wZWRpdCBuZXNjaXVudCBldW0u IFJlY3VzYW5kYWUgdm9sdXB0YXRlbSBxdWFlcmF0CiAgICBoaWMgaGFydW0uIENvbnNlcXVh dHVyIGluIGZ1Z2EgbmloaWwgYWxpcXVpZCBjb21tb2RpIHJlbSBzdW50LiBBcGVyaWFtIG9k aW8KICAgIG9kaW8gYW1ldC48L2xpPgogIDxsaT5Wb2x1cHRhdGVtIGVzdCBub3N0cnVtIGlt cGVkaXQgbmVzY2l1bnQgZXVtLiBSZWN1c2FuZGFlIHZvbHVwdGF0ZW0gcXVhZXJhdAogICAg aGljIGhhcnVtLiBDb25zZXF1YXR1ciBpbiBmdWdhIG5paGlsIGFsaXF1aWQgY29tbW9kaSBy ZW0gc3VudC4gQXBlcmlhbSBvZGlvCiAgICBvZGlvIGFtZXQuPC9saT4KICA8bGk+QW5kIHRo ZW46CiAgICA8dWw+CiAgICAgIDxsaT5Wb2x1cHRhdGVtIGVzdCBub3N0cnVtIGltcGVkaXQg bmVzY2l1bnQgZXVtLiBSZWN1c2FuZGFlIHZvbHVwdGF0ZW0KICAgICAgICBxdWFlcmF0IGhp YyBoYXJ1bS4gQ29uc2VxdWF0dXIgaW4gZnVnYSBuaWhpbCBhbGlxdWlkIGNvbW1vZGkgcmVt IHN1bnQuCiAgICAgICAgQXBlcmlhbSBvZGlvIG9kaW8gYW1ldC48L2xpPgogICAgICA8bGk+ Vm9sdXB0YXRlbSBlc3Qgbm9zdHJ1bSBpbXBlZGl0IG5lc2NpdW50IGV1bS4gUmVjdXNhbmRh ZSB2b2x1cHRhdGVtCiAgICAgICAgcXVhZXJhdCBoaWMgaGFydW0uIENvbnNlcXVhdHVyIGlu IGZ1Z2EgbmloaWwgYWxpcXVpZCBjb21tb2RpIHJlbSBzdW50LgogICAgICAgIEFwZXJpYW0g b2RpbyBvZGlvIGFtZXQuPC9saT4KICAgIDwvdWw+CiAgPC9saT48L3VsPgoKPGhyPgo8cD4K ICBWb2x1cHRhdGVtIGVzdCBub3N0cnVtIGltcGVkaXQgbmVzY2l1bnQgZXVtLiBSZWN1c2Fu ZGFlIHZvbHVwdGF0ZW0gcXVhZXJhdCBoaWMKICBoYXJ1bS4gQ29uc2VxdWF0dXIgaW4gZnVn YSBuaWhpbCBhbGlxdWlkIGNvbW1vZGkgcmVtIHN1bnQuIEFwZXJpYW0gb2RpbyBvZGlvCiAg YW1ldC4KPC9wPgo8YmxvY2txdW90ZT4KICBWb2x1cHRhdGVtIGVzdCBub3N0cnVtIGltcGVk aXQgbmVzY2l1bnQgZXVtLiBSZWN1c2FuZGFlIHZvbHVwdGF0ZW0KICBxdWFlcmF0IGhpYyBo YXJ1bS4gQ29uc2VxdWF0dXIgaW4gZnVnYSBuaWhpbCBhbGlxdWlkIGNvbW1vZGkgcmVtIHN1 bnQuIEFwZXJpYW0KICBvZGlvIG9kaW8gYW1ldC4KCiAgPHVsPgogICAgPGxpPlZvbHVwdGF0 ZW0gZXN0IG5vc3RydW0gaW1wZWRpdCBuZXNjaXVudCBldW0uIFJlY3VzYW5kYWUgdm9sdXB0 YXRlbQogICAgICBxdWFlcmF0IGhpYyBoYXJ1bS4gQ29uc2VxdWF0dXIgaW4gZnVnYSBuaWhp bCBhbGlxdWlkIGNvbW1vZGkgcmVtIHN1bnQuCiAgICAgIEFwZXJpYW0gb2RpbyBvZGlvIGFt ZXQuPC9saT4KICAgIDxsaT5Wb2x1cHRhdGVtIGVzdCBub3N0cnVtIGltcGVkaXQgbmVzY2l1 bnQgZXVtLiBSZWN1c2FuZGFlIHZvbHVwdGF0ZW0KICAgICAgcXVhZXJhdCBoaWMgaGFydW0u IENvbnNlcXVhdHVyIGluIGZ1Z2EgbmloaWwgYWxpcXVpZCBjb21tb2RpIHJlbSBzdW50Lgog ICAgICBBcGVyaWFtIG9kaW8gb2RpbyBhbWV0LjwvbGk+CiAgICA8bGk+QW5kIHRoZW46CiAg ICAgIDxvbD4KICAgICAgICA8bGk+Vm9sdXB0YXRlbSBlc3Qgbm9zdHJ1bSBpbXBlZGl0IG5l c2NpdW50IGV1bS4gUmVjdXNhbmRhZSB2b2x1cHRhdGVtCiAgICAgICAgICBxdWFlcmF0IGhp YyBoYXJ1bS4gQ29uc2VxdWF0dXIgaW4gZnVnYSBuaWhpbCBhbGlxdWlkIGNvbW1vZGkgcmVt IHN1bnQuCiAgICAgICAgICBBcGVyaWFtIG9kaW8gb2RpbyBhbWV0LjwvbGk+CiAgICAgICAg PGxpPlZvbHVwdGF0ZW0gZXN0IG5vc3RydW0gaW1wZWRpdCBuZXNjaXVudCBldW0uIFJlY3Vz YW5kYWUgdm9sdXB0YXRlbQogICAgICAgICAgcXVhZXJhdCBoaWMgaGFydW0uIENvbnNlcXVh dHVyIGluIGZ1Z2EgbmloaWwgYWxpcXVpZCBjb21tb2RpIHJlbSBzdW50LgogICAgICAgICAg QXBlcmlhbSBvZGlvIG9kaW8gYW1ldC48L2xpPgogICAgICA8L29sPgogICAgPC9saT4KICA8 L3VsPgo8L2Jsb2NrcXVvdGU+Cg== --------------1Xt5M4ePysxEncC56MvjJmje-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 04:56:46 2024 Received: (at 72485) by debbugs.gnu.org; 17 Aug 2024 08:56:46 +0000 Received: from localhost ([127.0.0.1]:53471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFEr-0001c6-Pr for submit@debbugs.gnu.org; Sat, 17 Aug 2024 04:56:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfFEp-0001bt-9m for 72485@debbugs.gnu.org; Sat, 17 Aug 2024 04:56:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfFE7-0000LW-AV; Sat, 17 Aug 2024 04:55:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aXvEUxFf+LEZM/pNbB3vQjvxGHx5yYvo53OoektXPfA=; b=ONU1phypzGKH lre2Pf7ecRJc9vUlMh6d1a3V0wdGYEfoqfwVmBy3SonckQ0LtFpymoZ06dlzVcgakuNZyq89E6P/t NZv/5Yb1vTm9/7bIAMtxq53TC14WhJW/HtKoHLU6c3iId/oOF2WotY4YYl0dMYKPfi+LWqXcSg/Tg pANnKGWbFPIKYXbyZySGgrXjfG2DdB8PhlXKQiDf3JYtwFbJHXKq+OFkNmj6nRVQPUhMMuWLH3qca 53nF6xgS0sJ2LVqFEAkS4yEUeDThOUFTfYE9J5R2Qw5ibGXYspbWXBO+pJUuKcBGjG+iClBFW+vQY rMvyLOd2FKNVAnuDMngzKA==; Date: Sat, 17 Aug 2024 11:55:57 +0300 Message-Id: <867ccf4jfm.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Mon, 5 Aug 2024 20:47:52 -0700) Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 5 Aug 2024 20:47:52 -0700 > From: Jim Porter > > This patch is an extension of bug#71605, and the first place to > explicitly use the new variable-pitch support for > 'visual-wrap-prefix-mode'. While implementing this, I found two small > bugs in the new 'visual-wrap-prefix-mode' code: > > 1. When setting the min-width for the first line prefix, we should use > 'add-display-text-property' so as not to clobber other display properties. > > 2. My attempts to be "helpful" by special-casing wrap-prefixes of all > spaces ended up just interfering with more complex cases (like SHR), so > I removed it. The code is now simpler (one fewer condition) and just > works more smoothly overall. > > There's one limitation to this patch though: since SHR uses absolute > pixel-widths for indenting internally, things can look mis-indented if > you scale the text in the buffer. However, SHR has exactly the same > issue when *not* using 'visual-wrap-prefix-mode', so it's really just a > more-general bug in SHR. (It'd be nice to fix that, but I'd have to get > a better understanding of how indentation and
elements interact.) Thanks. This lacks a NEWS entry, but other than that, feel fee to install on master when ready. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 20:32:01 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 00:32:01 +0000 Received: from localhost ([127.0.0.1]:55095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfTpw-0001af-Il for submit@debbugs.gnu.org; Sat, 17 Aug 2024 20:32:01 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:58687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfTpt-0001aO-Mz for 72485@debbugs.gnu.org; Sat, 17 Aug 2024 20:31:59 -0400 Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-201cd78c6a3so24455445ad.1 for <72485@debbugs.gnu.org>; Sat, 17 Aug 2024 17:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723941012; x=1724545812; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=mirQaHGLRPm1EIdAKwZGjvmfafdz9OFYewpg6lDyNx4=; b=W6FIhZJLqhACFwFLYak3qBgSlRGRLNOcXia7LX402Zjjk41nl9d1gaMC+z8AQOx5dc dqxmNfAWQi7cicG8MbNXGgw9ZHxPBXSFwG03FSO9GtXLxZh6APHkR8hla6cjXCzn6VzN oi2p+snB39jHai7Q3crG7ytwP54WrMSo7ezzUY6J8OC8pKLMZ5MvyYnyoNR4YiAARIE5 6ncQrX6D9svcp+cns/xiYgdfo1Lgsp0mkSoFHJA5G032jkX5hyexUR6M/G9CXKW/eeaT 6vC1+JhifZm8agNMw+XhRm7yo/Rr5iwdZX5mEdwvgaTin2UYj7Hhm3At4cCPTqijSJcY AG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723941012; x=1724545812; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mirQaHGLRPm1EIdAKwZGjvmfafdz9OFYewpg6lDyNx4=; b=kI/JGQPozjMlCtGvwlFDhwQdH9vSU9U18mTmq+4FJUOZW+il2uizUMYT06j2E8D5q6 mUGcK9zLAa4PtoL0hk9eeZSBHP3CQqgvCvV6QOOMGRqCrnz082Ve9oDPczpmLjCKJ1qz 9C7PmvqfiHIGFxBY+5atn6E3qiUHbDGrJLT4ILvvC1SWWHFGQv3dE+vDP8sWu2onG7R4 2w4ikQlg3VzjrND/ZOSPDu7np5VbvVwESS4EkGYGgKfr+xC52byw07ghTkfiEamsNsi0 VZsrwHv3KxNzTCsy8Zb1TTplLaPeAfoTDG5xpnn/nm9PFhUHZGWfNzFzQLA4fQyQauoj YuaA== X-Gm-Message-State: AOJu0Yzo3BXvNDEJHU9BdpNV531MzQw+n3pWSFZm9l+7X7NZWlLerCiT +CWhacRyGlteAewFkL+C5z6kf/kPUNwr3ARkXV42seUso8v5cgWi962g2A== X-Google-Smtp-Source: AGHT+IFMWNJE/m+kzSRm18hYkYxXnarowDiwJHBgxDMd9geOZOfMBs8+i2Xmlzn7XTaVREcy4+Louw== X-Received: by 2002:a17:902:f683:b0:202:1db8:d9b0 with SMTP id d9443c01a7336-2021db8da79mr35291805ad.34.1723941011832; Sat, 17 Aug 2024 17:30:11 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-201f0375921sm43779865ad.140.2024.08.17.17.30.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Aug 2024 17:30:11 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------2J8rteu0Y0uFMLnC50PilR7C" Message-ID: <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> Date: Sat, 17 Aug 2024 17:30:10 -0700 MIME-Version: 1.0 Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW Content-Language: en-US To: Eli Zaretskii References: <867ccf4jfm.fsf@gnu.org> From: Jim Porter In-Reply-To: <867ccf4jfm.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2J8rteu0Y0uFMLnC50PilR7C Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/17/2024 1:55 AM, Eli Zaretskii wrote: >> Date: Mon, 5 Aug 2024 20:47:52 -0700 >> From: Jim Porter >> >> There's one limitation to this patch though: since SHR uses absolute >> pixel-widths for indenting internally, things can look mis-indented if >> you scale the text in the buffer. However, SHR has exactly the same >> issue when *not* using 'visual-wrap-prefix-mode', so it's really just a >> more-general bug in SHR. (It'd be nice to fix that, but I'd have to get >> a better understanding of how indentation and
elements interact.) > > Thanks. This lacks a NEWS entry, but other than that, feel fee to > install on master when ready. Thanks for taking a look. I've added a NEWS entry (see attached). I also improved the implementation a bit, so the above-mentioned limitation is no longer a problem. Now, SHR/EWW will indent things properly even when using 'text-scale-adjust'. (The additional changes aren't major, so I'll probably merge this in a day or two once I've had time to sleep on it.) --------------2J8rteu0Y0uFMLnC50PilR7C Content-Type: text/plain; charset=UTF-8; name="0001-Improve-SHR-EWW-support-for-visual-wrap-prefix-mode.patch" Content-Disposition: attachment; filename*0="0001-Improve-SHR-EWW-support-for-visual-wrap-prefix-mode.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA4Y2VmMTg1MmJmZTRkYmRmNTNiMDYzZmFlYWNkYjFlNmE4NWQxNWMyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgNCBBdWcgMjAyNCAxOTozNzowMCAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEltcHJvdmUgU0hSL0VXVyBzdXBwb3J0IGZvciAndmlzdWFsLXdyYXAtcHJlZml4LW1v ZGUnCgoqIGxpc3AvdmlzdWFsLXdyYXAuZWwgKHZpc3VhbC13cmFwLS1hcHBseS10by1saW5l KTogVXNlCidhZGQtZGlzcGxheS10ZXh0LXByb3BlcnR5JyBzbyB3ZSBkb24ndCBjbG9iYmVy IG90aGVyIGRpc3BsYXkKcHJvcGVydGllcy4KKHZpc3VhbC13cmFwLS1jb250ZW50LXByZWZp eCk6IFJlbW92ZSBzcGVjaWFsLWNhc2UgZm9yIHNwYWNlcy1vbmx5CmluZGVudCBwcmVmaXg7 IHRoaXMgd2FzIGFuIGF0dGVtcHQgdG8gYmUgaGVscGZ1bCBmb3IgdmFyaWFibGUtcGl0Y2gK Zm9udHMsIGJ1dCBpbiBwcmFjdGljZSBqdXN0IGludGVyZmVyZXMgd2l0aCBtYXR0ZXJzLiAg VGhpcyBjYXNlIG5vdwpmYWxscyBiYWNrIHRvIHRoZSBvbmUgaW1tZWRpYXRlbHkgZm9sbG93 aW5nIGl0IChyZXR1cm4gdGhlIHN0cmluZyBvZgpzcGFjZXMpLiAgVXNlICdzdHJpbmctcGl4 ZWwtd2lkdGgnIGluc3RlYWQgb2YgJ3N0cmluZy13aWR0aCcuCgoqIGxpc3AvbmV0L3Noci5l bCAoc2hyLWluZGVudCk6IFNldCAnc2hyLXByZWZpeC1sZW5ndGgnIGhlcmUgdG8gaGVscApr ZWVwIHRyYWNrIG9mIHRoZSBwcmVmaXhlcyBvZiBuZXN0ZWRseS1pbmRlbnRlZCBlbGVtZW50 cy4gIFNldCB0aGUKc3BlY2lmaWVkIHNwYWNlIHdpZHRoIGluIHRlcm1zIG9mIHRoZSBkZWZh dWx0IHdpZHRoIG9mIHRoZSBjdXJyZW50IGZhY2UuCiogbGlzcC9uZXQvc2hyLmVsIChzaHIt YWRhcHRpdmUtZmlsbC1mdW5jdGlvbik6IFVzZSAnc2hyLXByZWZpeC1sZW5ndGgnCmFzIHNl dCBhYm92ZSB0byByZXR1cm4gYSBmaWxsIHByZWZpeC4KCiogbGlzcC9uZXQvZXd3LmVsIChl d3ctcmVuZGVyKTogRW5hYmxlICd2aXN1YWwtd3JhcC1wcmVmaXgtbW9kZScKYWxvbmdzaWRl IG9mICd2aXN1YWwtbGluZS1tb2RlJy4KKGV3dy1tb2RlKTogU2V0ICdhZGFwdGl2ZS1maWxs LWZ1bmN0aW9uJyB0bwonc2hyLWFkYXB0aXZlLWZpbGwtZnVuY3Rpb24nLgoKKiBldGMvTkVX UzogQW5ub3VuY2UgdGhpcyBjaGFuZ2UgKGJ1ZyM3MjQ4NSkuCi0tLQogZXRjL05FV1MgICAg ICAgICAgICB8ICA4ICsrKysrKysrCiBsaXNwL25ldC9ld3cuZWwgICAgIHwgIDUgKysrKy0K IGxpc3AvbmV0L3Noci5lbCAgICAgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0t CiBsaXNwL3Zpc3VhbC13cmFwLmVsIHwgMTggKysrKysrKystLS0tLS0tLS0tCiA0IGZpbGVz IGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggOGNkMjFmNWZiNzQuLjUwNjNlNzU0NzMw IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTQ0LDYgKzE0NCwx NCBAQCBBZHZhbmNlZCIgbm9kZSBpbiB0aGUgRVdXIG1hbnVhbC4KIEJ5IGN1c3RvbWl6aW5n ICdzaHItaW1hZ2Utem9vbS1sZXZlbHMnLCB5b3UgY2FuIGNoYW5nZSB0aGUgbGlzdCBvZiB6 b29tCiBsZXZlbHMgdGhhdCBTSFIgY3ljbGVzIHRocm91Z2ggd2hlbiBjYWxsaW5nICdzaHIt em9vbS1pbWFnZScuCiAKKyoqIEVXVworCistLS0KKyoqKiBFV1cgbm93IGVuYWJsZXMgJ3Zp c3VhbC13cmFwLXByZWZpeC1tb2RlJyB3aGVuICdzaHItZmlsbC10ZXh0JyBpcyBuaWwuCitU aGlzIGltcHJvdmVzIHRoZSBkaXNwbGF5IG9mIG11bHRpbGluZSwgaW5kZW50ZWQgdGV4dCwg c3VjaCBhcyBibG9jaworcXVvdGVzIG9yICh1bilvcmRlcmVkIGxpc3RzLiAgTm93LCB0aGUg d3JhcHBlZCBsaW5lcyBvZiBpbmRlbnRlZCB0ZXh0Cit3aWxsIGxpbmUgdXAgdmlzdWFsbHkg d2l0aCB0aGUgZmlyc3QgbGluZS4KKwogKiogR28tdHMgbW9kZQogCiArKysKZGlmZiAtLWdp dCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3dy5lbAppbmRleCBiMmUxYzVhNzJl NS4uYjVkMmYyMDc4MWEgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2V3dy5lbAorKysgYi9saXNw L25ldC9ld3cuZWwKQEAgLTcwOSw3ICs3MDksOCBAQCBld3ctcmVuZGVyCiAJICAgICAgKGFu ZCBsYXN0LWNvZGluZy1zeXN0ZW0tdXNlZAogCQkgICAoc2V0LWJ1ZmZlci1maWxlLWNvZGlu Zy1zeXN0ZW0gbGFzdC1jb2Rpbmctc3lzdGVtLXVzZWQpKQogICAgICAgICAgICAgICAodW5s ZXNzIHNoci1maWxsLXRleHQKLSAgICAgICAgICAgICAgICAodmlzdWFsLWxpbmUtbW9kZSkp CisgICAgICAgICAgICAgICAgKHZpc3VhbC1saW5lLW1vZGUpCisgICAgICAgICAgICAgICAg KHZpc3VhbC13cmFwLXByZWZpeC1tb2RlKSkKIAkgICAgICAocnVuLWhvb2tzICdld3ctYWZ0 ZXItcmVuZGVyLWhvb2spCiAgICAgICAgICAgICAgIDs7IEVuYWJsZSB1bmRvIGFnYWluIHNv IHRoYXQgdW5kbyB3b3JrcyBpbiB0ZXh0IGlucHV0CiAgICAgICAgICAgICAgIDs7IGJveGVz LgpAQCAtMTMzNiw2ICsxMzM3LDggQEAgZXd3LW1vZGUKICAgOzsgZGVza3RvcCBzdXBwb3J0 CiAgIChzZXRxLWxvY2FsIGRlc2t0b3Atc2F2ZS1idWZmZXIgIydld3ctZGVza3RvcC1taXNj LWRhdGEpCiAgIChzZXRxIHRydW5jYXRlLWxpbmVzIHQpCisgIDs7IHZpc3VhbC13cmFwLXBy ZWZpeC1tb2RlIHN1cHBvcnQKKyAgKHNldHEtbG9jYWwgYWRhcHRpdmUtZmlsbC1mdW5jdGlv biAjJ3Noci1hZGFwdGl2ZS1maWxsLWZ1bmN0aW9uKQogICA7OyB0aGluZ2F0cHQgc3VwcG9y dAogICAoc2V0cS1sb2NhbCB0aGluZy1hdC1wb2ludC1wcm92aWRlci1hbGlzdAogICAgICAg ICAgICAgICAoY29ucyAnKHVybCAuIGV3dy0tdXJsLWF0LXBvaW50KQpkaWZmIC0tZ2l0IGEv bGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9uZXQvc2hyLmVsCmluZGV4IGQzYzQ4YjM0NDI4Li5i OWFjOWYwYzhjMCAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvc2hyLmVsCisrKyBiL2xpc3AvbmV0 L3Noci5lbApAQCAtOTM4LDYgKzkzOCwxMSBAQCBzaHItZmlsbC1saW5lCiAgICAgICAgICh3 aGVuIChsb29raW5nLWF0ICIgJCIpCiAJICAoZGVsZXRlLXJlZ2lvbiAocG9pbnQpIChsaW5l LWVuZC1wb3NpdGlvbikpKSkpKSkKIAorKGRlZnVuIHNoci1hZGFwdGl2ZS1maWxsLWZ1bmN0 aW9uICgpCisgICJSZXR1cm4gYSBmaWxsIHByZWZpeCBmb3IgdGhlIHBhcmFncmFwaCBhdCBw b2ludC4iCisgICh3aGVuLWxldCAoKHByZWZpeCAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50 KSAnc2hyLXByZWZpeC1sZW5ndGgpKSkKKyAgICAoYnVmZmVyLXN1YnN0cmluZyAocG9pbnQp ICgrIChwb2ludCkgcHJlZml4KSkpKQorCiAoZGVmdW4gc2hyLXBhcnNlLWJhc2UgKHVybCkK ICAgOzsgQWx3YXlzIGNob3Agb2ZmIGFuY2hvcnMuCiAgICh3aGVuIChzdHJpbmctbWF0Y2gg IiMuKiIgdXJsKQpAQCAtMTA0MSwxMSArMTA0NiwyNCBAQCBzaHItZW5zdXJlLXBhcmFncmFw aAogCiAoZGVmdW4gc2hyLWluZGVudCAoKQogICAod2hlbiAoPiBzaHItaW5kZW50YXRpb24g MCkKLSAgICAoaWYgKG5vdCBzaHItdXNlLWZvbnRzKQotICAgICAgICAoaW5zZXJ0LWNoYXIg P1xzIHNoci1pbmRlbnRhdGlvbikKLSAgICAgIChpbnNlcnQgP1xzKQotICAgICAgKHB1dC10 ZXh0LXByb3BlcnR5ICgxLSAocG9pbnQpKSAocG9pbnQpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgJ2Rpc3BsYXkgYChzcGFjZSA6d2lkdGggKCxzaHItaW5kZW50YXRpb24pKSkpKSkK KyAgICAobGV0ICgoc3RhcnQgKHBvaW50KSkKKyAgICAgICAgICAocHJlZml4IChvciAoZ2V0 LXRleHQtcHJvcGVydHkgKHBvaW50KSAnc2hyLXByZWZpeC1sZW5ndGgpIDApKSkKKyAgICAg IChpZiAobm90IHNoci11c2UtZm9udHMpCisgICAgICAgICAgKGluc2VydC1jaGFyID9ccyBz aHItaW5kZW50YXRpb24pCisgICAgICAgIChpbnNlcnQgP1xzKQorICAgICAgICAocHV0LXRl eHQtcHJvcGVydHkKKyAgICAgICAgICgxLSAocG9pbnQpKSAocG9pbnQpICdkaXNwbGF5Cisg ICAgICAgICA7OyBTZXQgdGhlIHNwZWNpZmllZCBzcGFjZSB3aWR0aCBpbiB0ZXJtcyBvZiB0 aGUgZGVmYXVsdCB3aWR0aAorICAgICAgICAgOzsgb2YgdGhlIGN1cnJlbnQgZmFjZSwgbGlr ZSAoTiAuIHdpZHRoKS4gIFRoYXQgd2F5LCB0aGUKKyAgICAgICAgIDs7IGluZGVudGF0aW9u IGlzIGNhbGN1bGF0ZWQgY29ycmVjdGx5IHdoZW4gdXNpbmcKKyAgICAgICAgIDs7IGB0ZXh0 LXNjYWxlLWFkanVzdCcuCisgICAgICAgICBgKHNwYWNlIDp3aWR0aCAoLChpZi1sZXQgKChm b250IChmb250LWF0ICgxLSAocG9pbnQpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChpbmZvIChxdWVyeS1mb250IGZvbnQpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICgvIChmbG9hdCBzaHItaW5kZW50YXRpb24pIChhcmVmIGluZm8gNykp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2hyLWluZGVudGF0aW9uKQorICAgICAg ICAgICAgICAgICAgICAgICAgIC4gd2lkdGgpKSkpCisgICAgICAocHV0LXRleHQtcHJvcGVy dHkgc3RhcnQgKCsgKHBvaW50KSBwcmVmaXgpCisgICAgICAgICAgICAgICAgICAgICAgICAg J3Noci1wcmVmaXgtbGVuZ3RoICgrIHByZWZpeCAoLSAocG9pbnQpIHN0YXJ0KSkpKSkpCiAK IChkZWZ1biBzaHItZm9udGl6ZS1kb20gKGRvbSAmcmVzdCB0eXBlcykKICAgKGxldCAoKHN0 YXJ0IChwb2ludCkpKQpkaWZmIC0tZ2l0IGEvbGlzcC92aXN1YWwtd3JhcC5lbCBiL2xpc3Av dmlzdWFsLXdyYXAuZWwKaW5kZXggY2FjM2JjNzY3YjguLjU2ZDU4ZWYxZDYwIDEwMDY0NAot LS0gYS9saXNwL3Zpc3VhbC13cmFwLmVsCisrKyBiL2xpc3AvdmlzdWFsLXdyYXAuZWwKQEAg LTEyMSw5ICsxMjEsOSBAQCB2aXN1YWwtd3JhcC0tYXBwbHktdG8tbGluZQogICAgICAgICAg ICAgICAgKG5leHQtbGluZS1wcmVmaXggKHZpc3VhbC13cmFwLS1jb250ZW50LXByZWZpeAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpcnN0LWxpbmUtcHJlZml4IHBv c2l0aW9uKSkpCiAgICAgICAod2hlbiAobnVtYmVycCBuZXh0LWxpbmUtcHJlZml4KQotICAg ICAgICAocHV0LXRleHQtcHJvcGVydHkKLSAgICAgICAgIHBvc2l0aW9uICgrIHBvc2l0aW9u IChsZW5ndGggZmlyc3QtbGluZS1wcmVmaXgpKSAnZGlzcGxheQotICAgICAgICAgYChtaW4t d2lkdGggKCgsbmV4dC1saW5lLXByZWZpeCAuIHdpZHRoKSkpKSkKKyAgICAgICAgKGFkZC1k aXNwbGF5LXRleHQtcHJvcGVydHkKKyAgICAgICAgIHBvc2l0aW9uICgrIHBvc2l0aW9uIChs ZW5ndGggZmlyc3QtbGluZS1wcmVmaXgpKSAnbWluLXdpZHRoCisgICAgICAgICBgKCgsbmV4 dC1saW5lLXByZWZpeCAuIHdpZHRoKSkpKQogICAgICAgKHNldHEgbmV4dC1saW5lLXByZWZp eCAodmlzdWFsLXdyYXAtLWFkanVzdC1wcmVmaXggbmV4dC1saW5lLXByZWZpeCkpCiAgICAg ICAocHV0LXRleHQtcHJvcGVydHkKICAgICAgICBwb3NpdGlvbiAobGluZS1lbmQtcG9zaXRp b24pICd3cmFwLXByZWZpeApAQCAtMTQxLDEyICsxNDEsNiBAQCB2aXN1YWwtd3JhcC0tY29u dGVudC1wcmVmaXgKICAgKGNvbmQKICAgICgoc3RyaW5nPSBwcmVmaXggIiIpCiAgICAgbmls KQotICAgKChzdHJpbmctbWF0Y2ggKHJ4IGJvcyAoKyBibGFuaykgZW9zKSBwcmVmaXgpCi0g ICAgOzsgSWYgdGhlIGZpcnN0LWxpbmUgcHJlZml4IGlzIGFsbCBzcGFjZXMsIHJldHVybiBp dHMgd2lkdGggaW4KLSAgICA7OyBjaGFyYWN0ZXJzLiAgVGhpcyB3YXksIHdlIGNhbiBzZXQg dGhlIHByZWZpeCBmb3IgYWxsIGxpbmVzIHRvIHVzZQotICAgIDs7IHRoZSBjYW5vbmljYWwt d2lkdGggb2YgdGhlIGZvbnQsIHdoaWNoIGhlbHBzIGZvciB2YXJpYWJsZS1waXRjaAotICAg IDs7IGZvbnRzIHdoZXJlIHNwYWNlIGNoYXJhY3RlcnMgYXJlIHVzdWFsbHkgcXVpdGUgbmFy cm93LgotICAgIChzdHJpbmctd2lkdGggcHJlZml4KSkKICAgICgob3IgKGFuZCBhZGFwdGl2 ZS1maWxsLWZpcnN0LWxpbmUtcmVnZXhwCiAgICAgICAgICAgICAgKHN0cmluZy1tYXRjaCBh ZGFwdGl2ZS1maWxsLWZpcnN0LWxpbmUtcmVnZXhwIHByZWZpeCkpCiAgICAgICAgIChhbmQg Y29tbWVudC1zdGFydC1za2lwCkBAIC0xNjksNyArMTYzLDExIEBAIHZpc3VhbC13cmFwLS1j b250ZW50LXByZWZpeAogICAgICAgICAobWF4IChzdHJpbmctd2lkdGggcHJlZml4KQogICAg ICAgICAgICAgIChjZWlsaW5nIChzdHJpbmctcGl4ZWwtd2lkdGggcHJlZml4IChjdXJyZW50 LWJ1ZmZlcikpCiAgICAgICAgICAgICAgICAgICAgICAgKGFyZWYgaW5mbyA3KSkpCi0gICAg ICAoc3RyaW5nLXdpZHRoIHByZWZpeCkpKSkpCisgICAgICA7OyBXZSBjb3VsZG4ndCBnZXQg dGhlIGZvbnQsIHNvIHdlJ3JlIGluIGEgdGVybWluYWwgYW5kCisgICAgICA7OyBgc3RyaW5n LXBpeGVsLXdpZHRoJyBpcyByZWFsbHkgcmV0dXJuaW5nIHRoZSBudW1iZXIgb2YgY29sdW1u cy4KKyAgICAgIDs7IChUaGlzIGlzIGRpZmZlcmVudCBmcm9tIGBzdHJpbmctd2lkdGgnLCBz aW5jZSB0aGF0IGRvZXNuJ3QKKyAgICAgIDs7IHJlc3BlY3Qgc3BlY2lmaWVkIHNwYWNlcy4p CisgICAgICAoc3RyaW5nLXBpeGVsLXdpZHRoIHByZWZpeCkpKSkpCiAKIChkZWZ1biB2aXN1 YWwtd3JhcC1maWxsLWNvbnRleHQtcHJlZml4IChiZWcgZW5kKQogICAiQ29tcHV0ZSB2aXN1 YWwgd3JhcCBwcmVmaXggZnJvbSB0ZXh0IGJldHdlZW4gQkVHIGFuZCBFTkQuCi0tIAoyLjI1 LjEKCg== --------------2J8rteu0Y0uFMLnC50PilR7C-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 00:50:26 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 04:50:26 +0000 Received: from localhost ([127.0.0.1]:55217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfXs2-0000J0-Fj for submit@debbugs.gnu.org; Sun, 18 Aug 2024 00:50:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfXs0-0000Il-3i for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 00:50:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfXrG-0007I8-WA; Sun, 18 Aug 2024 00:49:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C22RhKflpY0Ij02UzVEM9SXQmpk+RSnDsXVUAnJVb3Y=; b=BSSGSMlAWwKO AzFSC1e3PLYKTjTY/SDXfFUmYFpxbwKN0Gk+cdUu7Ud1uJCkuDzjEhWmxhERZU3WlqE7qzZVFALlf 9wJ8Yh49pgYe/EEBuFwMJ037uswDIV8rQfWWrVvsbkYiwXabwzLiqm+q8JS7kTbdz92cBeOdnhy6t ebiT0d2H+JKR4gCbO2ATOHzDqXV8NNj2uErppBFL3XpoFc6Y+/ErpAs9/0y6tsFAS1jVU0QQ2j7+P DZPNL9lQDJkPTPb3gk+JKhsy8FZ5dK3QeU+leawVz73D9ZDXcKGpLVNSUT1B//JA5/orvr07eadit YDqp3Rvy/oDe3GAlAOwwrw==; Date: Sun, 18 Aug 2024 07:49:37 +0300 Message-Id: <868qwu1llq.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> (message from Jim Porter on Sat, 17 Aug 2024 17:30:10 -0700) Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 17 Aug 2024 17:30:10 -0700 > Cc: 72485@debbugs.gnu.org > From: Jim Porter > > +** EWW > + > +--- > +*** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. > +This improves the display of multiline, indented text, such as block > +quotes or (un)ordered lists. Now, the wrapped lines of indented text > +will line up visually with the first line. I'm not sure many users know about shr-fill-text, including that its default is non-nil. So I think this NEWS entry should say something about that, otherwise this text might cause incorrect user expectations. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 02:14:49 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 06:14:49 +0000 Received: from localhost ([127.0.0.1]:55318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfZBg-00036j-Op for submit@debbugs.gnu.org; Sun, 18 Aug 2024 02:14:49 -0400 Received: from mail-pg1-f176.google.com ([209.85.215.176]:54687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfZBd-00036Q-S4 for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 02:14:46 -0400 Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7163489149eso2503664a12.1 for <72485@debbugs.gnu.org>; Sat, 17 Aug 2024 23:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723961580; x=1724566380; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=PIDE49lhAt4BqmWJjZz0NUoQGuziKSvRBBYwjPRfijA=; b=iq5g3FnBWoBRpjdq/D7eIDo28vXpTeIrh0c+7KyjTfGRQnuHN59TYG91F3S1QHeAFc JNn2E804sFdx3AfXKeInTQlVHPbtZHFEfwnov0jzw+SfRlu+4H6XPVecGy+47QnhdXXX OG6TnXBa4f0Y7FSp0oehkQhnGdQAm5EY7lLyh5U228iuaxtaUCmJo7NR6qB6KDNr9GdQ 2b/6ltCixDRYhKfMUj0miCVzhyyxKJrSQ6T2jUmvD7xXaWvyC7T3cQKrc2dg4OkNDGwU 6TZfPlr5j8GhR+2koJSih8SB/S5GG3I2WB63el7CtTH4pLVh1Ezwh/YW6xlFp/+CPWYf ivbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723961580; x=1724566380; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PIDE49lhAt4BqmWJjZz0NUoQGuziKSvRBBYwjPRfijA=; b=fV1ZTvgDK+fNIE39QCcOM/PxF8CdktZmPqzjkLcAZ1nO5W0qOn97Cjl/56649nCUmv k2Sz/Ey0L7JG6prYErCKR2aYp35rTz54Rb8lJGMUW/eUzc8N6+u83P/PZTyZzHF+RojO uX0RuHrK4SCuwAxcXAFKTNbqp9nBJvjdR3Z0T3a7p2IxpM5oBaWYJJviLvI/M08ZB40+ 0sRNrPGCFAXH+XOK+UNzPfXIJZPR8zQATyyGO7eiGsiflyOsUcmRSeweQTsQOjJ+laO/ 2GSar1O2APOMiQfWgckIPm74bmhA5SlVcBTlTtbcnT+K4ZRxtBkNlCiYW/IA0P6CDkVf ruhA== X-Gm-Message-State: AOJu0Yyl4FeXKlL7AZzLIreb4wg1wF7WFHW6TIPlR+UBp+M2CLBAPqCs /5nBG4Znv+8OVkiX9YRPy01ix14FmxyIKDB8JkLV5fLILN0/EJVX2mJa9A== X-Google-Smtp-Source: AGHT+IHzACXjX3QrrOl/ptDkD+X2nFObVT4N2puieUIFCoNiMYPCnhi/dvBlc9+dAx26lXWs4Gf0Xg== X-Received: by 2002:a05:6a21:9187:b0:1c4:8bba:76e4 with SMTP id adf61e73a8af0-1c9050534e7mr9588759637.50.1723961579968; Sat, 17 Aug 2024 23:12:59 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7127af19098sm4810728b3a.168.2024.08.17.23.12.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Aug 2024 23:12:59 -0700 (PDT) Message-ID: <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> Date: Sat, 17 Aug 2024 23:13:00 -0700 MIME-Version: 1.0 Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW Content-Language: en-US To: Eli Zaretskii References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> From: Jim Porter In-Reply-To: <868qwu1llq.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/17/2024 9:49 PM, Eli Zaretskii wrote: > I'm not sure many users know about shr-fill-text, including that its > default is non-nil. So I think this NEWS entry should say something > about that, otherwise this text might cause incorrect user > expectations. How does this sound? ---------------------------------------- *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. Previously, when 'shr-fill-text' was nil, EWW would use 'visual-line-mode' to wrap paragraphs instead of inserting newline characters. Now, EWW additionally enables 'visual-wrap-prefix-mode' in this case. This improves the display of multiline, indented text, such as block quotes or (un)ordered lists. ---------------------------------------- I also notice that 'shr-fill-text' is new in Emacs 30, but doesn't have a NEWS entry in that release. Should I add a mention of it to the Emacs 30 NEWS as well? (I don't see any harm in reiterating what 'shr-fill-text' does in the Emacs 31 NEWS as well though.) From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 05:21:07 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 09:21:07 +0000 Received: from localhost ([127.0.0.1]:55415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfc5y-00087h-PK for submit@debbugs.gnu.org; Sun, 18 Aug 2024 05:21:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfc5w-000875-Q4 for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 05:21:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfc5C-000856-Rj; Sun, 18 Aug 2024 05:20:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Vg/qKfCzKYmxW3syPFN05mc2ysDkaDaEjBDQgZBOGVo=; b=AnhUopwLrpNF GksgKbCZVWXqprGUbJi7II7P6EBdeNnki8HiJI0cGE9JS8EhKteG31llz40wzWKXkKrkL0Y6aLtIk yvmmD+qigOPGO7BLBwSe+vx5/8cCZf1fTW1hPCb5/a73Ve3AfT1NXJfncs58S6ClSZoUpKC+drqUg BZX4k/31dWK3A17a8KTIXwXeblvKkyuY8hIF59zMvkIEcovQQZ8BHkWqWSppO/tHqOeJtnmr4aNnw /dgpPr0qIIo/9zkfX+T8iJIBv5tnl9sBkXBTtQTizZ4+AubUtrTkrnyM8GacYHeQAvknZwOqEM5BI YeQl2mp5afHNDvgn4XysLw==; Date: Sun, 18 Aug 2024 12:20:13 +0300 Message-Id: <861q2m192q.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> (message from Jim Porter on Sat, 17 Aug 2024 23:13:00 -0700) Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 17 Aug 2024 23:13:00 -0700 > Cc: 72485@debbugs.gnu.org > From: Jim Porter > > On 8/17/2024 9:49 PM, Eli Zaretskii wrote: > > I'm not sure many users know about shr-fill-text, including that its > > default is non-nil. So I think this NEWS entry should say something > > about that, otherwise this text might cause incorrect user > > expectations. > > How does this sound? > > ---------------------------------------- > > *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. > Previously, when 'shr-fill-text' was nil, EWW would use > 'visual-line-mode' to wrap paragraphs instead of inserting newline > characters. Now, EWW additionally enables 'visual-wrap-prefix-mode' in > this case. This improves the display of multiline, indented text, such > as block quotes or (un)ordered lists. It still doesn't say that shr-fill-text is non-nil by default. > I also notice that 'shr-fill-text' is new in Emacs 30, but doesn't have > a NEWS entry in that release. Should I add a mention of it to the Emacs > 30 NEWS as well? Yes, please do. > (I don't see any harm in reiterating what 'shr-fill-text' does in > the Emacs 31 NEWS as well though.) I don't see a reason to reiterate that. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 12:59:54 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 16:59:54 +0000 Received: from localhost ([127.0.0.1]:56592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfjFy-00045n-Hv for submit@debbugs.gnu.org; Sun, 18 Aug 2024 12:59:54 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:60702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfjFw-00045S-MK for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 12:59:53 -0400 Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-7c691c8f8dcso2351872a12.1 for <72485@debbugs.gnu.org>; Sun, 18 Aug 2024 09:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724000286; x=1724605086; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=fw7OjFwkTbzJNcDXaITZvt662vjZcPzFT1AJwfhI698=; b=kI6ITSplN4CAIaKzkSwlQ2dRzlmEzjxpSm8W+fAOWF8VCjB4ikmiab+wBh8b348Cwn 6d2Jyet942yFV8kE+8UCrhCdG4LrDIi3o3ANnpg5dresP8wQCFRwyoGkH355xjNrM3Xx M6DiLUZYxlODSviAJHsqckw7C77//j7YEyI+qqsNFf6yQUIvJl78t1XWK04XSit05DfB /FU+tkztdxiVBGETfVrtg66aCUJKfHFwRraCbAjUtTI9EMnA62LxPD3AcQOr8uJox/oX DDyiy02sbITUSSYPvlcsJsJWy83Vyzskmq64ReMrI3BdFdo46I7/Y3KXhUAVDpqyHNlw bSBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724000286; x=1724605086; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fw7OjFwkTbzJNcDXaITZvt662vjZcPzFT1AJwfhI698=; b=CQDFi+MdZSjvrAYDF0Xs9g+dLDqPlX0l0n0VnED9y5IO01dvVcdMlZ9Tp91wFczGsJ 3QIWx7P8irI1lw+XCvGTOdxvvx1P8jg7Ol5+T0xQpWrl2A3rPBqIqLHvw8/Wmqb/WTXP 8Cke2qT2K/aO/Dt1HhlaPj6MJU19yTzarULgr5t+REtLH8Uhifs7I6jLMwy4ht48Ed/f dezYd0z/dYDq41PaXnEMfCs8Tv6AiN9w0sszbHcxEgcHh4LUH2rOZXRX2WoOOAMKE6Y1 Zx7H77omy9m6HsLx0Qqt8hDqgiprOqDfbohkhZ7Rsd9ihDXMsrKd9LXTIopLsDRCKQmr 32cQ== X-Gm-Message-State: AOJu0Yys3rQsMuxB4irfEqmpIr1Spu8RPVBQEcKmWkNCExlM3TDPw8rV nA3v6eL8VuYIDPRyrNjJnQoHYvfsT82P8Q0qNJQX7KlDWbuz8s4q X-Google-Smtp-Source: AGHT+IFNEQBX/b51IutJZwdcZ1CsKnunRM74wua8t8eUuSpSpH0cgaNKSPUNdIozQ/4UEAucbTslQQ== X-Received: by 2002:a17:902:cec7:b0:202:3e52:e124 with SMTP id d9443c01a7336-2023e52e346mr16027135ad.31.1724000286194; Sun, 18 Aug 2024 09:58:06 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2021bb414b3sm22928835ad.231.2024.08.18.09.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Aug 2024 09:58:05 -0700 (PDT) Message-ID: <3a549122-156c-2993-34b0-2c4b071e8b38@gmail.com> Date: Sun, 18 Aug 2024 09:58:07 -0700 MIME-Version: 1.0 Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW Content-Language: en-US To: Eli Zaretskii References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> <861q2m192q.fsf@gnu.org> From: Jim Porter In-Reply-To: <861q2m192q.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/18/2024 2:20 AM, Eli Zaretskii wrote: > It still doesn't say that shr-fill-text is non-nil by default. > >> I also notice that 'shr-fill-text' is new in Emacs 30, but doesn't have >> a NEWS entry in that release. Should I add a mention of it to the Emacs >> 30 NEWS as well? > > Yes, please do. How about this? ---------- For Emacs 30 ---------- *** New option 'shr-fill-text'. When non-nil (the default), SHR will insert newlines in text to wrap it. If customized to nil, SHR will leave the text as-is; in that case, EWW will automatically enable 'visual-line-mode' to visually wrap the text when displaying a page. ---------- For Emacs 31 ---------- *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. When 'shr-fill-text' is customized to nil, EWW now enables 'visual-wrap-prefix-mode' when rendering in addition to 'visual-line-mode'. This improves the display of multiline, indented text, such as block quotes or (un)ordered lists. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 14:13:02 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 18:13:02 +0000 Received: from localhost ([127.0.0.1]:56783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfkOk-0006HJ-D4 for submit@debbugs.gnu.org; Sun, 18 Aug 2024 14:13:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfkOj-0006Gw-0W for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 14:13:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfkNy-0000ff-Ag; Sun, 18 Aug 2024 14:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ct03dS65wz4YIAwsZZk+ArTJ36QxI3SO6Y4Ka+P0Nqs=; b=Z7zqKcU+R5ep 28m3GEhaD3gkZnwpEYPuLbdm4luSQSgHiWd3zbrgr8Iyg5+CDKcPxyXFHTC6dcFlor2uhoLAyauvg rh8TlhUFypn0b7f1LNGfcrgr5tauAl4mWwWIBfW2P0F8Q1LRqF81eOCk+msSkBZ07thRvNG3ZxaeU czMcs11Hly3RNqLqqUo+kK8TcAXGXdUmiGnYBsWjzqtDDmvQEqoo3GpPdrkeIXcXYPC7gkc73RYDU Cx77HrEWXohwnTN1aT9J5Sa/wTZ3tLPfYQkIzMrnYbzutWbkJGcD5EAGaes5Le/wuXQqDDjPHSG2b rJlSqQky2Bx5s60s75Tafw==; Date: Sun, 18 Aug 2024 21:12:09 +0300 Message-Id: <86zfp9ya2u.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <3a549122-156c-2993-34b0-2c4b071e8b38@gmail.com> (message from Jim Porter on Sun, 18 Aug 2024 09:58:07 -0700) Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> <861q2m192q.fsf@gnu.org> <3a549122-156c-2993-34b0-2c4b071e8b38@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 18 Aug 2024 09:58:07 -0700 > Cc: 72485@debbugs.gnu.org > From: Jim Porter > > *** New option 'shr-fill-text'. > When non-nil (the default), SHR will insert newlines in text to wrap it. > If customized to nil, SHR will leave the text as-is; in that case, EWW > will automatically enable 'visual-line-mode' to visually wrap the text > when displaying a page. Inserting newlines is not the important part of this variable's effect. The important part is filling the text, and shr does that with fixed-pitch and variable-pitch fonts alike. The NEWS entry should describe this important part. > *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. > When 'shr-fill-text' is customized to nil, EWW now enables > 'visual-wrap-prefix-mode' when rendering in addition to > 'visual-line-mode'. This improves the display of multiline, indented > text, such as block quotes or (un)ordered lists. I evidently fail to explain myself, so let me just propose an entry as I envisioned it: *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. By default, 'shr-fill-text' is t, and EWW fills the text according to the width of the window. If you customize 'shr-fill-text' to nil, EWW will now automatically turn on 'visual-wrap-prefix-mode' in addition to 'visual-line-mode', so that long lines are wrapped at word boundaries near window edge and the continuation lines are indented using prefixes computed from surrounding context. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 14:30:27 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 18:30:27 +0000 Received: from localhost ([127.0.0.1]:56797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfkfb-0006jt-HX for submit@debbugs.gnu.org; Sun, 18 Aug 2024 14:30:27 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:54682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfkfa-0006jg-3P for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 14:30:26 -0400 Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2d3c396787cso2738833a91.1 for <72485@debbugs.gnu.org>; Sun, 18 Aug 2024 11:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724005719; x=1724610519; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=gZLYUqkDp5FnlCepKgg0HHbasvdb4U9wZ6v7qSvkH+w=; b=bO4jnBxXWlabHhiAm0MWjQAiseAXB0zH+t7x2h9Ccj/VXxxcges9L/UMTZvz05ptjg MEUDl2R4gBhXXwfk9aZE1Eb74BsWb9KWZ+Mp45U2KtNTlUe0YX3cZB1uXa2eQ3ekMgdp 38FmcxoiFcD/dMd29Cj0GVD/tXIWBzau8RVI+9nPEAIeYTT5jyGlgg4sGtM+leR56xC+ EPMRnysd4C+MRe/1fLFTVbN4jV46HJRqTZvMIsYkzhM9DwnJjvC1masNWN6bP/gHpSfI kICaYqc4OlAjPZzXvh5PnyVg+GEF9G+i0aOPQ/1MdoBNIIIo556kxST8tQV4cKX9V613 15jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724005719; x=1724610519; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gZLYUqkDp5FnlCepKgg0HHbasvdb4U9wZ6v7qSvkH+w=; b=Hu8LCQurpoQdfY5j9lCZRr6hDAUcRf+bJ7MT7uBTkTt5XaqCe/tM+xNxZbV855hhN3 M4UPWZRVkVk2560klFB25/IIW7vajsUYYBsBktL5qO5/LFljlBT9aJFdy7FkdDrniw6i tcWG+GdMgJ76WGJpjTZ+tSXrMsagfM82/oz/5bZtv/GSl13CPoSaVmnCT/RPWwpfcaeu ycZVCVMmMTdsJ3jS8QGTDLYCjxwD02ATbRU493aYnprzlSfSooB2OgF9Gl6qq89daMn3 axv/8OK7fRsbmuW0DF+179hlKob8tYgZiiWJl3PBv1PzCPStFDs0/Pi6d+Su4vB0h6FQ +R6w== X-Gm-Message-State: AOJu0Yz30OzsvPEOakTSozZRWypMVnHRoqEYqkjY8K9hHLCg+tHFp/Vm w8BTj1fYoqptxWWgwU1y6WygdsG5gYN9suJbeao1skQdV18MTEtp X-Google-Smtp-Source: AGHT+IH5mDYKOUStbHkDU9KlGFF00bD6z+wYrRJ+SpVoLx7Po3WncXnYXJ43ge3zGuj/kuuRuYIZng== X-Received: by 2002:a17:90a:f001:b0:2ca:8b71:21f4 with SMTP id 98e67ed59e1d1-2d3dfc61aa6mr10051833a91.18.1724005719480; Sun, 18 Aug 2024 11:28:39 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2d3f0f1f51bsm5218799a91.32.2024.08.18.11.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Aug 2024 11:28:39 -0700 (PDT) Message-ID: <7fdfc885-3685-bc56-f3c7-bf7343711cc1@gmail.com> Date: Sun, 18 Aug 2024 11:28:40 -0700 MIME-Version: 1.0 Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW Content-Language: en-US To: Eli Zaretskii References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> <861q2m192q.fsf@gnu.org> <3a549122-156c-2993-34b0-2c4b071e8b38@gmail.com> <86zfp9ya2u.fsf@gnu.org> From: Jim Porter In-Reply-To: <86zfp9ya2u.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/18/2024 11:12 AM, Eli Zaretskii wrote: > *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. > By default, 'shr-fill-text' is t, and EWW fills the text according to > the width of the window. If you customize 'shr-fill-text' to nil, > EWW will now automatically turn on 'visual-wrap-prefix-mode' in > addition to 'visual-line-mode', so that long lines are wrapped at > word boundaries near window edge and the continuation lines are > indented using prefixes computed from surrounding context. That seems good to me, so I'll just use that as-is for Emacs 31. How about this for the release branch? *** New option 'shr-fill-text'. When 'shr-fill-text' is non-nil (the default), SHR will fill the text according to the width of the window. If you customize it to nil, SHR will leave the text as-is; in that case, EWW will automatically enable 'visual-line-mode' when displaying a page so that long lines are visually wrapped at word boundaries. (If you think this makes the Emacs 31 NEWS entry partially redundant, I can try to trim that one down to only discuss the new additions, but I don't mind either way.) From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 14:54:44 2024 Received: (at 72485) by debbugs.gnu.org; 18 Aug 2024 18:54:44 +0000 Received: from localhost ([127.0.0.1]:56819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfl36-0007Ku-41 for submit@debbugs.gnu.org; Sun, 18 Aug 2024 14:54:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfl34-0007Ki-KF for 72485@debbugs.gnu.org; Sun, 18 Aug 2024 14:54:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfl2K-0005Pz-Mo; Sun, 18 Aug 2024 14:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7iTKxg+p+7orp7nVspjLCwX4jAaDPSG34kek47lGHEc=; b=LVGv1SupX3R5 7IWkG1IdTRaO7rGzg2HDlZJsL3fWySqbRAgjjV8yXLgqT0mbxPMclOtPbfsuBFGU+OTnqTEV054ut VaSuW8X2M8BF7wXoabE+cMqQt/VXRk2x7eC5gn2R7JH+fK1zOnoImLoXSiVUj3808rJHUDt5wg1Oa Fo8GaCDiO0u+ulWNWs/dMkYbsEyXIFtFDwkDKBjlumqQoc0+rQQZZNpCPJAMzo1OteN7owe3iTS3h /dibNfgeUOidRfTdSClyHlZGjOB4ZhPD0chJje6oJ9PEUYrAKoUdquTwNRlFXPYn3NGvfZLLuOrvo cTertQZNz808ew59LjlKYA==; Date: Sun, 18 Aug 2024 21:53:54 +0300 Message-Id: <86sev1y859.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <7fdfc885-3685-bc56-f3c7-bf7343711cc1@gmail.com> (message from Jim Porter on Sun, 18 Aug 2024 11:28:40 -0700) Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> <861q2m192q.fsf@gnu.org> <3a549122-156c-2993-34b0-2c4b071e8b38@gmail.com> <86zfp9ya2u.fsf@gnu.org> <7fdfc885-3685-bc56-f3c7-bf7343711cc1@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72485 Cc: 72485@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 18 Aug 2024 11:28:40 -0700 > Cc: 72485@debbugs.gnu.org > From: Jim Porter > > On 8/18/2024 11:12 AM, Eli Zaretskii wrote: > > *** EWW now enables 'visual-wrap-prefix-mode' when 'shr-fill-text' is nil. > > By default, 'shr-fill-text' is t, and EWW fills the text according to > > the width of the window. If you customize 'shr-fill-text' to nil, > > EWW will now automatically turn on 'visual-wrap-prefix-mode' in > > addition to 'visual-line-mode', so that long lines are wrapped at > > word boundaries near window edge and the continuation lines are > > indented using prefixes computed from surrounding context. > > That seems good to me, so I'll just use that as-is for Emacs 31. How > about this for the release branch? > > > *** New option 'shr-fill-text'. > When 'shr-fill-text' is non-nil (the default), SHR will fill the text > according to the width of the window. If you customize it to nil, SHR > will leave the text as-is; in that case, EWW will automatically enable > 'visual-line-mode' when displaying a page so that long lines are > visually wrapped at word boundaries. LGTM, thanks. > (If you think this makes the Emacs 31 NEWS entry partially redundant, I > can try to trim that one down to only discuss the new additions, but I > don't mind either way.) I see no reason to trim it. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 18 19:12:05 2024 Received: (at 72485-done) by debbugs.gnu.org; 18 Aug 2024 23:12:05 +0000 Received: from localhost ([127.0.0.1]:56974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfp49-0005tJ-GR for submit@debbugs.gnu.org; Sun, 18 Aug 2024 19:12:05 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:61635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfp47-0005sn-B1 for 72485-done@debbugs.gnu.org; Sun, 18 Aug 2024 19:12:04 -0400 Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-710ece280b6so2723960b3a.2 for <72485-done@debbugs.gnu.org>; Sun, 18 Aug 2024 16:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724022616; x=1724627416; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=2Fr1TJbVS7O2V8dqCMS/wblEL24szoTNWaET3J89C9w=; b=LVJ0fp8VEy02Z7bYIHczVfkICr58KjpoNNUaHOmDYEIVEPZS76kxRMJou3M+5cJ53F 0Vo6fCeuOF6H8ciOfhuLtWS3BiKyJbLnRHUPxWR4aRvbmJe2NZXyAd+n5RjIT53g5MkM LjUyJWmyPyYENXUV+ZYD27m3bvbCBW8iA6P2TsNj+jtPeudgepTw6jifbUTlv1REIG9W 3ppx/Uu6xJOL7u1Cm0fJvl5d7XStI9cynSulc9syWGZD59eTDAAVeIRD/BTbbDd1vyud XCwA8aEJ1dqIu/8RTOv0bwawRJcS3yI0P4VhXxKdSjK+zUVYdCyqp2MjMcUDtiVrvAD/ j/oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724022616; x=1724627416; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Fr1TJbVS7O2V8dqCMS/wblEL24szoTNWaET3J89C9w=; b=nbtwq5428S1R+rm6YMGR3YQYkGM4UXnP3y890K7b4yN4G2MRtSCMoBAxqWkJYoJIBf C1xKPJLLkV0mrMxxj0NQYaL4pNOiF7rQkbmV4PKdF8VREtezOOuRPyJJVPY9BHusIEnS Sh9lc037o3ZVaLGH8cjqE0A5z0K3Hodqqvze/ODUxknvYdgcwYmGR++y4rB/Oc9HX2zW BQeTTxAxzXMKhdtF9P0evq+n9rBYyuwzA8Br3Ste4c+tAyshWJAfCIY7NMYy0LQufHpX 8qKnpYWg+bSsZCP3Kabyu4FByGkIKYAkRAGsBmFsGiO8zesyobQ6Sqh4EiBoINaAebTe boSA== X-Gm-Message-State: AOJu0YxX9ctSFQpWeQ5Acd96iGRSuN7tfQLEMJOc16uZJiMFGenbVj+w tjCsigDvenh1zz+46wUBB08SypwUU9wISFcJFxylZqZifDtrdAwf X-Google-Smtp-Source: AGHT+IGHJoMN4kimaPpy8v1jbFPlVQZsrX2JE2j4gqJBOwWZyOwGJ50IGFx06zOHdyRFCFWMWst8JQ== X-Received: by 2002:a05:6a21:1789:b0:1c6:91e3:e77d with SMTP id adf61e73a8af0-1c904f8f848mr9473570637.16.1724022616316; Sun, 18 Aug 2024 16:10:16 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7127ae0f300sm5624147b3a.49.2024.08.18.16.10.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Aug 2024 16:10:15 -0700 (PDT) Message-ID: Date: Sun, 18 Aug 2024 16:10:15 -0700 MIME-Version: 1.0 Subject: Re: bug#72485: Support 'visual-wrap-prefix-mode' in SHR/EWW Content-Language: en-US To: Eli Zaretskii References: <867ccf4jfm.fsf@gnu.org> <1936f13e-b10a-e4de-b26b-14a2d36a54fe@gmail.com> <868qwu1llq.fsf@gnu.org> <671bd15e-35f4-caca-d99c-ef6e92d6a588@gmail.com> <861q2m192q.fsf@gnu.org> <3a549122-156c-2993-34b0-2c4b071e8b38@gmail.com> <86zfp9ya2u.fsf@gnu.org> <7fdfc885-3685-bc56-f3c7-bf7343711cc1@gmail.com> <86sev1y859.fsf@gnu.org> From: Jim Porter In-Reply-To: <86sev1y859.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72485-done Cc: 72485-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/18/2024 11:53 AM, Eli Zaretskii wrote: > LGTM, thanks. > >> (If you think this makes the Emacs 31 NEWS entry partially redundant, I >> can try to trim that one down to only discuss the new additions, but I >> don't mind either way.) > > I see no reason to trim it. Thanks. Merged the NEWS update to the release branch as b54e8b3741b, and the main patch to the master branch as a876c4d7a17. Closing this bug now. From unknown Mon Aug 18 04:07:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Sep 2024 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator