GNU bug report logs - #72472
gzip: simplify printing of offsets using -l and -v

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72472 in the body.
You can then email your comments to 72472 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: bug-gzip <at> gnu.org
Subject: gzip: simplify printing of offsets using -l and -v
Date: Sun, 04 Aug 2024 17:10:01 -0700

[Message part 1 (text/plain, inline)]

Since gzip uses 'printf-posix' can't offsets be printed using that
instead of fprint_off? Patch attached + 1 more removing #ifndef CHAR_BIT
cruft.

Also, now that POSIX-1.2024 requires strcpy to be async-signal-safe can
'volatile_strcpy' be removed? Or is there something more to
that. Signals hurt my brain a bit, sorry...

Collin

[0001-gzip-simplify-printing-of-offsets-using-l-and-v.patch (text/x-patch, attachment)]

[0002-maint-depend-on-Gnulib-s-limits-h.patch (text/x-patch, attachment)]

Message #10 received at 72472-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 72472-done <at> debbugs.gnu.org
Subject: Re: bug#72472: gzip: simplify printing of offsets using -l and -v
Date: Tue, 13 Aug 2024 08:10:02 -0700

Thanks! Applied

Message #13 received at 72472 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 72472 <at> debbugs.gnu.org
Subject: Re: bug#72472: gzip: simplify printing of offsets using -l and -v
Date: Tue, 13 Aug 2024 09:20:41 -0700

On Sun, Aug 4, 2024 at 5:10 PM Collin Funk <collin.funk1 <at> gmail.com> wrote:
> Also, now that POSIX-1.2024 requires strcpy to be async-signal-safe can
> 'volatile_strcpy' be removed? Or is there something more to
> that. Signals hurt my brain a bit, sorry...

While somewhat related, I don't see how an async-safe strcpy would let
us remove that function.

Message #16 received at 72472 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, Collin Funk <collin.funk1 <at> gmail.com>
Cc: 72472 <at> debbugs.gnu.org
Subject: Re: bug#72472: gzip: simplify printing of offsets using -l and -v
Date: Tue, 13 Aug 2024 12:22:09 -0700

On 2024-08-13 09:20, Jim Meyering wrote:
> While somewhat related, I don't see how an async-safe strcpy would let
> us remove that function.

Agreed. You can't even use strcpy on 'char volatile *'; C prohibits 
that. Async safety is about something else (admittedly brain-hurting :-).

Message #19 received at 72472 <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 72472 <at> debbugs.gnu.org, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#72472: gzip: simplify printing of offsets using -l and -v
Date: Tue, 13 Aug 2024 13:27:44 -0700

Hi Jim, Paul,

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> On 2024-08-13 09:20, Jim Meyering wrote:
>> While somewhat related, I don't see how an async-safe strcpy would let
>> us remove that function.
>
> Agreed. You can't even use strcpy on 'char volatile *'; C prohibits
> that. Async safety is about something else (admittedly brain-hurting
> :-).

Thanks, I found the original thread prompting the addition of
volatile_strcpy and think I understand now [1].

Apologies for the extra noise. :)

Collin

[1] https://lists.gnu.org/archive/html/bug-gzip/2018-08/msg00013.html

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.