From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 14:29:11 2024 Received: (at submit) by debbugs.gnu.org; 4 Aug 2024 18:29:11 +0000 Received: from localhost ([127.0.0.1]:57270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1safyg-00073C-Ni for submit@debbugs.gnu.org; Sun, 04 Aug 2024 14:29:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:41194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1safye-000733-Qf for submit@debbugs.gnu.org; Sun, 04 Aug 2024 14:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1safyJ-0004zi-2A for guix-patches@gnu.org; Sun, 04 Aug 2024 14:28:47 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1safyG-0003VU-II for guix-patches@gnu.org; Sun, 04 Aug 2024 14:28:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1722796121; x=1723055321; bh=RVBPAUn9+MJOjTlr4PGocs3xSU/QfHqoalCrGW2Cxuk=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=p4hhdxuib28tGkZKyANhy7rCCNlGUPnxPrdq2QR9JX5rIsJksPwURgJ7U418qll5i ATG47g/d6LsLvs3opagtkGfS1cQ4OxL4iXBHJwEJtvsWinJReIGXoQKIqO93X8oShT sI25QibNFVk081eLDhdK2hCkhp0C9Iz8G3ETqq45GJYa3zGNwqQsO3giJOJ6xNJYVN yAK9K+uLID/1NoKfdyHyvd4c3xCwhDq1E2xi3QCrdEj/PujrxCZNBu8dkFkLq2RC8E Ycjy4fvqyNABwTmnXCgri3ph0cgeOhF1tq4rLjAmA/O5GNJ/CsOvUnQOWmgh8a0oDC xPN0+/AWDJjRg== Date: Sun, 04 Aug 2024 18:28:36 +0000 To: guix-patches@gnu.org From: Kaelyn Takata Subject: [PATCH core-updates] gnu: webrtc-audio-processing: Fix build on i686. Message-ID: Feedback-ID: 34709329:user:proton X-Pm-Message-ID: 59126c2bbd161b1ddeafc210e26f6dda199c20bf MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=kaelyn.alexi@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Kaelyn Takata X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/audio.scm (webrtc-audio-processing): Fix build on i686. * gnu/packages/patches/webrtc-audio-processing-1.3-Add-generic-byte-order-a= nd-pointer-size-detection.patch * gnu/packages/patches/webrtc-audio-processing-1.3-x86-no-sse.patch Change-Id: I3a95e5e2794df0d51e005672b5d3e2d98f27b767 --- gnu/packages/audio.scm | 11 ++++++- ...yte-order-and-pointer-size-detection.patch | 32 +++++++++++++++++++ ...brtc-audio-processing-1.3-x86-no-sse.patch | 13 ++++++++ 3 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/webrtc-audio-processing-1.3-Add-ge= neric-byte-order-and-pointer-size-detection.patch create mode 100644 gnu/packages/patches/webrtc-audio-processing-1.3-x86-no= -sse.patch diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 382bd77c47..7fd720a435 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -309,8 +309,17 @@ (define-public webrtc-audio-processing (string-append "http://freedesktop.org/software/pulseaudio/" name "/" name "-" version ".tar.gz")) (sha256 - (base32 "0xfvq5lxg612vfzk3zk6896zcb4cgrrb7fq76w9h40magz0jymcm")))) + (base32 "0xfvq5lxg612vfzk3zk6896zcb4cgrrb7fq76w9h40magz0jymcm")) + ;; See https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-proce= ssing/-/issues/5 + (patches + (search-patches + "webrtc-audio-processing-1.3-Add-generic-byte-order-and-pointer-s= ize-detection.patch" + "webrtc-audio-processing-1.3-x86-no-sse.patch")))) (build-system meson-build-system) + (arguments + (if (target-x86-32?) + (list #:configure-flags #~(list "-Dc_args=3D-DPFFFT_SIMD_DISABLE"= )) + '())) (native-inputs (list pkg-config)) (inputs (list abseil-cpp)) (synopsis "WebRTC's Audio Processing Library") diff --git a/gnu/packages/patches/webrtc-audio-processing-1.3-Add-generic-b= yte-order-and-pointer-size-detection.patch b/gnu/packages/patches/webrtc-au= dio-processing-1.3-Add-generic-byte-order-and-pointer-size-detection.patch new file mode 100644 index 0000000000..e2d974afd9 --- /dev/null +++ b/gnu/packages/patches/webrtc-audio-processing-1.3-Add-generic-byte-ord= er-and-pointer-size-detection.patch @@ -0,0 +1,32 @@ +https://bugs.gentoo.org/917493 +https://sources.debian.org/src/webrtc-audio-processing/1.0-0.2/debian/patc= hes/Add-generic-byte-order-and-pointer-size-detection.patch/ + +Description: Add generic byte order and pointer size detection +Author: Than +Origin: https://bugs.freedesktop.org/show_bug.cgi?id=3D95738#c4 +Last-Update: 2022-02-01 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/webrtc/rtc_base/system/arch.h ++++ b/webrtc/rtc_base/system/arch.h +@@ -58,7 +58,19 @@ + #define WEBRTC_ARCH_32_BITS + #define WEBRTC_ARCH_LITTLE_ENDIAN + #else +-#error Please add support for your architecture in rtc_base/system/arch.h ++/* instead of failing, use typical unix defines... */ ++#if __BYTE_ORDER__ =3D=3D __ORDER_LITTLE_ENDIAN__ ++#define WEBRTC_ARCH_LITTLE_ENDIAN ++#elif __BYTE_ORDER__ =3D=3D __ORDER_BIG_ENDIAN__ ++#define WEBRTC_ARCH_BIG_ENDIAN ++#else ++#error __BYTE_ORDER__ is not defined ++#endif ++#if defined(__LP64__) ++#define WEBRTC_ARCH_64_BITS ++#else ++#define WEBRTC_ARCH_32_BITS ++#endif + #endif +=20 + #if !(defined(WEBRTC_ARCH_LITTLE_ENDIAN) ^ defined(WEBRTC_ARCH_BIG_ENDIAN= )) diff --git a/gnu/packages/patches/webrtc-audio-processing-1.3-x86-no-sse.pa= tch b/gnu/packages/patches/webrtc-audio-processing-1.3-x86-no-sse.patch new file mode 100644 index 0000000000..c194dd9244 --- /dev/null +++ b/gnu/packages/patches/webrtc-audio-processing-1.3-x86-no-sse.patch @@ -0,0 +1,13 @@ +https://bugs.gentoo.org/921140 +https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-processing/-/issues= /5 +--- a/webrtc/rtc_base/system/arch.h ++++ b/webrtc/rtc_base/system/arch.h +@@ -34,7 +34,7 @@ + #else + #define WEBRTC_ARCH_32_BITS + #endif +-#elif defined(_M_IX86) || defined(__i386__) ++#elif defined(__SSE__) && (defined(_M_IX86) || defined(__i386__)) + #define WEBRTC_ARCH_X86_FAMILY + #define WEBRTC_ARCH_X86 + #define WEBRTC_ARCH_32_BITS base-commit: baad95b19a24401cad8bee7290e5dbf3b3f38287 --=20 2.45.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 11:39:33 2024 Received: (at 72469-done) by debbugs.gnu.org; 21 Aug 2024 15:39:33 +0000 Received: from localhost ([127.0.0.1]:36122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgnQq-0007Rl-Nh for submit@debbugs.gnu.org; Wed, 21 Aug 2024 11:39:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgnQo-0007RY-8M for 72469-done@debbugs.gnu.org; Wed, 21 Aug 2024 11:39:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgnPz-0006rO-Ld; Wed, 21 Aug 2024 11:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=zdTG4S11q9JIZ3WVneXm6isrpbDe2iP4vaZiaAcA/uc=; b=iohIcs7yrNF5HLnHPP8y pdmdW0Bj/slBehoTL7n7+6yah21v4W1AQas3yZUvXGAA+VXDunZqJ9o6zuoa5GKRunhT/Ka4mhrK9 2yndkfTqsNNYCr1AbTvAHJwjde1+blgW2w0UZO7+lpBS+pJ3Pgt/9TE0ocRGyQIoxuI+BWhP3qrJo f/VSeHipta0XSuQg3DnovOTRIcRzgksADTHwyVDjYEWGROOU2Og5R4NKVkmkJZiJRzKybpnYe9BzQ uYL22xPwKp6SSx/J266Gi4t3qR5+NmxUrxyoVDm6RFpWQ/q91WQS0+xs6v7mXhtcbV/hP5LCdwz4s 5x2e+yEh+C2GHw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Kaelyn Takata Subject: Re: bug#72469: [PATCH core-updates] gnu: webrtc-audio-processing: Fix build on i686. In-Reply-To: (Kaelyn Takata's message of "Sun, 04 Aug 2024 18:28:36 +0000") References: Date: Wed, 21 Aug 2024 17:38:34 +0200 Message-ID: <87le0psx6t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72469-done Cc: 72469-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Kaelyn, Kaelyn Takata skribis: > * gnu/packages/audio.scm (webrtc-audio-processing): Fix build on i686. > * gnu/packages/patches/webrtc-audio-processing-1.3-Add-generic-byte-order= -and-pointer-size-detection.patch > * gnu/packages/patches/webrtc-audio-processing-1.3-x86-no-sse.patch > > Change-Id: I3a95e5e2794df0d51e005672b5d3e2d98f27b767 Applied. I added the patches to =E2=80=98gnu/local.mk=E2=80=99, shortened = a bit the file names, and more importantly I arranged so that the patches are applied in a phase and only on i686-linux and powerpc64le-linux, to avoid a rebuild on other architectures (=E2=80=98webrtc-audio-processing=E2= =80=99 has ~3K dependents). Thank you! Ludo=E2=80=99. From unknown Mon Jun 23 13:13:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Sep 2024 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator