Subject: Re: [bug#72457] [PATCH v5 00/15] Rewrite bootloader subsystem.

From: Herman Rimm <[email-masked]>
Date: Thu, 19 Sep 2024 19:38:52 +0200

Hello,

On Thu, Sep 19, 2024 at 05:35:42PM +0200, Herman Rimm wrote:
> Anyway, maybe you can send a diff based on/relative to:
> 
Include something like this, to get code that actually compiles and is
not extremely fragile:

diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm
index 73176bddff..ee0fe450ba 100644
--- a/gnu/bootloader.scm
+++ b/gnu/bootloader.scm
@@ -495,14 +495,14 @@ (define (report-duplicate-type-field targets)
              (seen    '()))
     (match targets
       ((target rest ...)
-       (let (type (bootloader-target-type target)))
+       (let ((type (bootloader-target-type target)))
          (when (memq type seen)
            (error loc (G_ "target with duplicate type~%") duplicate))
-         (loop rest (cons type seen)))
+         (loop rest (cons type seen))))
       (() #t))))

-(define-with-syntax-properties (warn-update-targets (targets properties))
-  (let ((targets (if (list? targets) targets (list targets)))
+(define-with-syntax-properties (warn-update-targets (value properties))
+  (let ((targets (if (list? value) value (list value)))
         (loc (source-properties->location properties)))
     (define string->target
       (match-lambda

Cheers,
Herman