GNU bug report logs - #72456
[PATCH] rcirc: Fix startup channels triggering flood protection

Previous Next

Full log

View this message in rfc822 format

From: Thuna <thuna.cing <at> gmail.com>
To: 72456 <at> debbugs.gnu.org
Cc: philipk <at> posteo.net
Subject: bug#72456: [PATCH] rcirc: Fix startup channels triggering flood protection
Date: Sun, 04 Aug 2024 02:00:11 +0200

[Message part 1 (text/plain, inline)]

If too many channels are set up to be joined on startup, all of their
JOIN messages are sent at once, possibly triggering the flood protection
of the server and causing the link to be forcefully severed.  (In libera
I hit this limit with 12 channels - not a lot, all things considered.)

This patch mitigates this by sending a single JOIN message with all the
channels joined with ",".

This has a flaw, which is mentioned in the patch in a FIXME, in that if
the total length of the channels exceeds the maximum length of a message
then the message will likely split and break.  While checking for it
while joining the channel names is a possibility, it's probably better
if we split command messages more elegantly in the first place.

[0001-WIP-rcirc-fix-startup-channels-flooding-the-server.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.