GNU bug report logs - #72452
[PATCH] add guile-swayer package

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: mrh <mrh57 <at> posteo.net>, 72452 <at> debbugs.gnu.org
Cc: mrh <mrh57 <at> posteo.net>
Subject: [bug#72452] [PATCH] add guile-swayer package
Date: Sat, 07 Sep 2024 18:15:18 +0200

Hi mrh,

A few remarks below.

On 2024-08-03 20:31, mrh wrote:

> guile-swayer provides guile bindings to manipulate windows via the sway wayland compositor
>
> Change-Id: If579694d8fb20bec5f3fd542430783a25a6c155b
> ---
>  gnu/packages/guile-xyz.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 3ce4f6a8d6..5693bbde0f 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -1027,6 +1027,24 @@ (define-public guile2.2-filesystem
>      (name "guile2.2-filesystem")
>      (inputs (list guile-2.2))))
>  
> +(define-public guile-swayer
> +  (package
> +    (name "guile-swayer")
> +    (version "0.2.0")
> +    (home-page "https://github.com/ebeem/guile-swayer")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/ebeem/guile-swayer")
> +             (commit "9c962281f405453fb3770dd0546ef6951c9236dd")))
> +       (sha256 (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))

This line exceeds 79 characters, you should put base32 part on the next line.

> +    (native-inputs (list guile-3.0))
> +    (build-system guile-build-system)
> +    (synopsis "Extensible Guile bindings for SwayWM")
> +    (description "Extensible Guile bindings for SwayWM")

The description needs to be more informative. What about

"This package provides extensible Guile bindings for the Sway window
manager.  It can be used to query Sway, assign keybindings and listen to
events in Guile."

> +    (license license:expat)))
> +

Otherwise the package builds properly, I'll be happy to review that once
you send a v2.

Please also abstain from opening duplicate issues, thanks!

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.