From unknown Fri Jun 20 18:22:09 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#72451] [PATCH core-updates] gnu: gsl: Fix build on i686. Resent-From: Kaelyn Takata Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Aug 2024 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72451 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72451@debbugs.gnu.org Cc: Kaelyn Takata X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172271534914885 (code B ref -1); Sat, 03 Aug 2024 20:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Aug 2024 20:02:29 +0000 Received: from localhost ([127.0.0.1]:54838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saKxR-0003s1-24 for submit@debbugs.gnu.org; Sat, 03 Aug 2024 16:02:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:51514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saKxP-0003rt-Kk for submit@debbugs.gnu.org; Sat, 03 Aug 2024 16:02:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saKx5-0006Cc-BU for guix-patches@gnu.org; Sat, 03 Aug 2024 16:02:07 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saKx2-000770-Iv for guix-patches@gnu.org; Sat, 03 Aug 2024 16:02:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1722715314; x=1722974514; bh=3w7dD8EnoUaCKoV2ZMQKVeaj46pwMYdFknYs49L1yRs=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=aox4t5EhKrJzPJopHsUDL4vUF+HhLMHBwWz45NwfzwKy4tVs2nwOix9hDrGH3e1Vh oa8V9cj5CMovRrwRuqikdWwODVdReJ68w1JAMGM7uWEBlxFPhizY76VTcZGU2zwVgM 8moYdig8NZZcJRDyOBJeR2Uf4fjHIAEDai0u+hW5W+ZcsdQ504MOb39FMTQbLbs0hH veDQ0OgiOiQpR5uZ6FAW/Lub8tfDYmm2fUt7IHJrUVGEi4c+N3N7MLD0+tLDBcn1rS IXgd29uP8uqnMmUKnzbkHrSjFT1DPSgahSx9he6eiF8Iw7xfpfIxP6EQoNb5tBwdxH E4wgpSoqDiFAA== Date: Sat, 03 Aug 2024 20:01:47 +0000 From: Kaelyn Takata Message-ID: <71397042b223b98e0937b56018749c89eeb638e2.1722715149.git.kaelyn.alexi@protonmail.com> Feedback-ID: 34709329:user:proton X-Pm-Message-ID: 6136d699d280dfb74f7d7d46ce3e23a6d8e9a8b2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=kaelyn.alexi@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/maths.scm (gsl)[arguments]<#:make-flags>: Include the defaul= t CFLAGS, restoring the optimized build and fixing test failures on i686. Change-Id: I64a43368b000995e03810b33de131aba4203d02b --- gnu/packages/maths.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index c06eddcc34..984aa35066 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -729,7 +729,7 @@ (define-public gsl (build-system gnu-build-system) (arguments (let ((system (%current-system))) - `(#:make-flags (list "CFLAGS=3D-fPIC") + `(#:make-flags (list "CFLAGS=3D-g -O2 -fPIC") #:phases (modify-phases %standard-phases ,@(cond base-commit: baad95b19a24401cad8bee7290e5dbf3b3f38287 -- 2.45.2 From unknown Fri Jun 20 18:22:09 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#72451] fixing the gsl test failures on i686 References: <71397042b223b98e0937b56018749c89eeb638e2.1722715149.git.kaelyn.alexi@protonmail.com> In-Reply-To: <71397042b223b98e0937b56018749c89eeb638e2.1722715149.git.kaelyn.alexi@protonmail.com> Resent-From: Kaelyn Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Aug 2024 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72451 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "72451@debbugs.gnu.org" <72451@debbugs.gnu.org>, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 72451-submit@debbugs.gnu.org id=B72451.172400310321282 (code B ref 72451); Sun, 18 Aug 2024 17:46:02 +0000 Received: (at 72451) by debbugs.gnu.org; 18 Aug 2024 17:45:03 +0000 Received: from localhost ([127.0.0.1]:56753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfjxf-0005XA-Fg for submit@debbugs.gnu.org; Sun, 18 Aug 2024 13:45:03 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:57047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfjxe-0005WW-33 for 72451@debbugs.gnu.org; Sun, 18 Aug 2024 13:45:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1724003055; x=1724262255; bh=YsHnpoJrrwEzY+pAPbg8UAXRFLEi6u84gNgxPApUt4A=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=DGfMWuuq4sbcHZ7dG/zULOD6OzzW1emewJsFQHB87hXUNsNow5yRH/iJteNx3PWaE R1/nCulAxnLFYJTi//UQJYD9K5lfRk71Tt1Fh1GRM6YwHDwD1o/aeyew3RhnRJf2Pb 9Lwz1Zn3e4Jy7TTLBMMFng0FUoZK/nVv6hHqMp7PlPxjgPCEBRlC1oR7KHuIw+uiP3 1svoMmD/2+BuYzsboI0iTKifa/v/Js6RWhQwnRV0VIWjYTieEegZUcVtt8LP6G1l9/ 6/FOU/I3PpoykaKsm0oHgJcqeNPL7wuU4RVeK1trmi/B5OJbjr44zB4IvF7oC9Nw4P ckuRt+OIpsQ+g== Date: Sun, 18 Aug 2024 17:44:09 +0000 From: Kaelyn Message-ID: Feedback-ID: 34709329:user:proton X-Pm-Message-ID: 0d19b146b3b90ad30f20db3c12457f41981bedcd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, I noticed this morning that you recently pushed commit fa8dbbe59d to fix th= e i686-linux gsl test failures. I'd submitted a similar fix about two weeks= ago (along with a couple of other i686-linux fixes that affect building wi= ne64), and I wanted to mention that I don't think your commit does the righ= t thing with CFLAGS. When I figured out the error, I noticed a side-effect = of passing CFLAGS=3D-fPIC as the #:make-flags is that it disables the optim= ized build (or at least relies on whatever optimizations the compiler defau= lts to, which AFAIK is little to none). While your patch also cleans up the= definition a bit by no longer disabling some tests, I think the correct ap= proach is to include the package's default CFLAGS as part of the #:make-fla= gs as I did in issue 72451 so that optimizations aren't unintentionally dis= abled. Cheers, Kaelyn From unknown Fri Jun 20 18:22:09 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#72451] fixing the gsl test failures on i686 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Aug 2024 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72451 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kaelyn Cc: "72451@debbugs.gnu.org" <72451@debbugs.gnu.org> Received: via spool by 72451-submit@debbugs.gnu.org id=B72451.17241578293170 (code B ref 72451); Tue, 20 Aug 2024 12:44:02 +0000 Received: (at 72451) by debbugs.gnu.org; 20 Aug 2024 12:43:49 +0000 Received: from localhost ([127.0.0.1]:60043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgODF-0000p3-Bi for submit@debbugs.gnu.org; Tue, 20 Aug 2024 08:43:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgODD-0000oo-Al for 72451@debbugs.gnu.org; Tue, 20 Aug 2024 08:43:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgOCQ-0001Al-TW; Tue, 20 Aug 2024 08:42:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=OOvX9WsemQdDnX99hDEs0XtEC+tEsK2otZJdDDyFUtU=; b=p7dj8q/SxMiDl6lRKSeE JA3GV+RrS96u/Xgeds0hKr3ytyGpxm+mY7xm+1HidPGpBG7gxvWKXVKcVnOo9f+PuZ2Zh8dz/2XAG bA+ck1rvcuQcA+BtrkxxP+49mbwOLWitLJ8/Mc7doXfsuyVRdy9IRahHu9Q/gnaNAxzhWfey+gqXf mk51SQanjOUmS+DYJxJCGbxlWr7ExON6XkrxQJ2cfOfOzYAAIDFb4cu4sigRGZ7nbftjS82jyzehx SBBP2AQPeRsRhAUqBXR2wxLlOxmqymhp8/iEssil48dcAGKLe+SuRxxItMT9rr3UZezK6J3fMqZFt +5QBSjz0M6rYLQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Kaelyn's message of "Sun, 18 Aug 2024 17:44:09 +0000") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 4 Fructidor an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Escourgeon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 20 Aug 2024 14:42:56 +0200 Message-ID: <877ccbtlf3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Kaelyn, Kaelyn skribis: > I noticed this morning that you recently pushed commit fa8dbbe59d to fix = the i686-linux gsl test failures. I'd submitted a similar fix about two wee= ks ago (along with a couple of other i686-linux fixes that affect building = wine64), and I wanted to mention that I don't think your commit does the ri= ght thing with CFLAGS. When I figured out the error, I noticed a side-effec= t of passing CFLAGS=3D-fPIC as the #:make-flags is that it disables the opt= imized build (or at least relies on whatever optimizations the compiler def= aults to, which AFAIK is little to none). While your patch also cleans up t= he definition a bit by no longer disabling some tests, I think the correct = approach is to include the package's default CFLAGS as part of the #:make-f= lags as I did in issue 72451 so that optimizations aren't unintentionally d= isabled. Oh, apologies for not noticing . What you did looks correct to me. I added a FIXME about =E2=80=98CFLAGS=3D= -fPIC=E2=80=99 stating roughly what you explained here. The reason I did not change CFLAGS on other architectures was to avoid a massive rebuild at this late stage of the branch (=E2=80=98gsl=E2=80=99 has= 2.9K dependents). But I agree: we should clean that up for all platforms, and check which of the tests really need to be skipped on 32-bit platforms once compiled with optimizations. We can create a branch with such a patch once =E2=80=98core-updates=E2=80=99 is merged. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 28 17:19:41 2024 Received: (at control) by debbugs.gnu.org; 28 Aug 2024 21:19:42 +0000 Received: from localhost ([127.0.0.1]:49811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjQ4r-0004UD-Mw for submit@debbugs.gnu.org; Wed, 28 Aug 2024 17:19:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjQ4q-0004Tt-4Y for control@debbugs.gnu.org; Wed, 28 Aug 2024 17:19:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjQ3s-0003SJ-By for control@debbugs.gnu.org; Wed, 28 Aug 2024 17:18:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=/E4i7cWXjhYntu08YKKcB7azUOyFP93Kzidsolxo9MQ=; b=IXbjOCfi3R5oiM hwUN9C33iZ/pSAEEQmIxxZvGHOOr4ApcIz1WLrZpXOngtIHw8iDEJ8fYEpZsWIufWxxBF2U7Akr2S JZP09Gv7epaTr2G2gED459WfAjkpv2NMo6rY4Y7jGPKD5rsrf5BhaRLYW8gJawlVEG/8tc5RpCd+i 7nci4PdAvefKrJ6f1knwcO0tPfpdH5Mlaog/etA64M+BDF6TM5ACieqBsDamxwROYp+iezKHafFhd AoYYZGp46htZbbRKFyfNzVXM5XZSO5UCVPePDA8tCkrAUz5IuEO6MWZYMD5OuJswQF5grESfAta2C jbdr08/KjHJrML0pmZ7A==; Date: Wed, 28 Aug 2024 23:18:38 +0200 Message-Id: <87y14ggxch.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #72451 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 72451 quit