From unknown Wed Jun 18 23:07:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72446 <72446@debbugs.gnu.org> To: bug#72446 <72446@debbugs.gnu.org> Subject: Status: [PATCH] stat: Fix memleak Reply-To: bug#72446 <72446@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:07:09 +0000 retitle 72446 [PATCH] stat: Fix memleak reassign 72446 coreutils submitter 72446 Dmitry Chestnykh severity 72446 normal tag 72446 patch notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 03 13:23:53 2024 Received: (at submit) by debbugs.gnu.org; 3 Aug 2024 17:23:53 +0000 Received: from localhost ([127.0.0.1]:54757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saITw-0004gv-PA for submit@debbugs.gnu.org; Sat, 03 Aug 2024 13:23:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:35348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saHIo-0000w9-6u for submit@debbugs.gnu.org; Sat, 03 Aug 2024 12:08:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saHIT-0006tp-W5 for bug-coreutils@gnu.org; Sat, 03 Aug 2024 12:07:58 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saHIS-0008Cw-Dl for bug-coreutils@gnu.org; Sat, 03 Aug 2024 12:07:57 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2ef243cc250so17315421fa.0 for ; Sat, 03 Aug 2024 09:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722701273; x=1723306073; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HGoXYbMvNTNXe5YIhzOaTZSvv4m6TiCwROZDWvgPnnw=; b=YIXZskolq1p+qh9Tf6vntmwz8UtSiYyRLNIlNtDG7W+8CSG2aJjcN1HPgA3yd7fhwZ aHaNITexqBeRH4If/lYgZt1FRh8w2Ikh/Q9yKgfkqdvEAArkWOG6e6lLiZ+RzQ3lXOVJ mCPw3/rMipNJ+a/GD0lukTt9oqKS1PywB/qobjV8lSbtjaIraIvZ0VGTjNLNeKGJeA35 Ul5IJdTR4T9SNiiEYPYERhcNQi9NSWX2sDz+9kM3Wiy7V0W7dTy5CuCMd4pFNNpIQhiu nYXpwgoHi5Arf78LL0aAvaj9yB/pPmCSf6F1jTBKpOJ3xEP65Am9vLNjeqXkhMfK14Dp tkpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722701273; x=1723306073; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HGoXYbMvNTNXe5YIhzOaTZSvv4m6TiCwROZDWvgPnnw=; b=BOlazxJ2cu2i3EmmEayasBHhJg0tKDWGIrnkCEI5Z42Ao2xeBTN0nXvWQbzWwuxLVG FYNvpgGl8OcYx2rwdz6rDEY4u3vs3fAA0FeXk7Lw3Rx1d004qN00T+57DTQWM0DMPsdA wnmC3ocx/z3whNqYVPndPlXeejPPlorudxbdVigCEVSh9WiQknQx8KsV4BuTKt5e9DMH RmvFTInCawE6NIiNM+DREMCtzsh4wE7B233px5ZFYZMv3WF1ldfI+fVatSWNuDxSfW1X JphzZryB9LWxlR1bk6VwY8G75d27FII1ttuaQjMCFOdjyAAAlJuBSd5Msb83UPUWCJs1 jMpA== X-Gm-Message-State: AOJu0YwHC1cOtLZQHj3idOLG4dqqZIqiNnMYefd0xgtwolI2wgwiPPky 3OAjubt1S2ZIEbpENUV3w1CnRFmwOJdo+RSlK6EQYWarnIaLSc6DGDP9Zg== X-Google-Smtp-Source: AGHT+IGDTbo9EVBEGOszX9QcTt3drbgfsH+BFcaQGCr5GIqm7uo9dJLg+RnPl0i01ZTx6yqroIR0iA== X-Received: by 2002:a2e:9c8f:0:b0:2ef:24a9:6aa8 with SMTP id 38308e7fff4ca-2f15a9f8824mr26386341fa.0.1722701273020; Sat, 03 Aug 2024 09:07:53 -0700 (PDT) Received: from localhost.localdomain ([2a00:1370:817a:3109:2d1b:6983:7619:b726]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f15e1c25f1sm4818001fa.58.2024.08.03.09.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Aug 2024 09:07:52 -0700 (PDT) From: Dmitry Chestnykh To: bug-coreutils@gnu.org Subject: [PATCH] stat: Fix memleak Date: Sat, 3 Aug 2024 19:10:28 +0300 Message-ID: <20240803161028.197567-1-dm.chestnykh@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=dm.chestnykh@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 03 Aug 2024 13:23:49 -0400 Cc: Dmitry Chestnykh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) format and format2 strings are allocated by `malloc()` inside `xasprintf` so the memory should be freed * src/stat.c: Call `free()` on `format` and `format2` --- src/stat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/stat.c b/src/stat.c index 1513abfaa..47f3b5052 100644 --- a/src/stat.c +++ b/src/stat.c @@ -1974,5 +1974,7 @@ main (int argc, char *argv[]) ? do_statfs (argv[i], format) : do_stat (argv[i], format, format2)); + free(format); + free(format2); main_exit (ok ? EXIT_SUCCESS : EXIT_FAILURE); } -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 03 14:36:09 2024 Received: (at 72446) by debbugs.gnu.org; 3 Aug 2024 18:36:09 +0000 Received: from localhost ([127.0.0.1]:54789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saJbt-0008De-1y for submit@debbugs.gnu.org; Sat, 03 Aug 2024 14:36:09 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:47393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saJbr-0008Ct-2z; Sat, 03 Aug 2024 14:36:07 -0400 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4280bca3960so63763865e9.3; Sat, 03 Aug 2024 11:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722710081; x=1723314881; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=RwRIvU51r29EMUsKvAykEEm2XFjy8tMwGmI0hD4rWsI=; b=kBd9nFfv/1Vit1Op8fsvSf1mDSQXEhDuz1wVHCUbwArUHSqIP48CF2EjvE08+aI1xq wI7z9jcIzA+q2+hl2zFlDCcx7cb/rar4Td8wXFEEsviV87nisMveeoygJBZ2b2tRh64C JcC5A0+sJVfs4XG5fMhnpRVuL3XJdJv8+XwshjDvDYlQ7xIgnALvrVBqk+/mGt/nZ1KV H+5tiL+QgT85Rgh6HdJn+L6iWPnIRNJ1cz8GNZt/de53XSHNWmZMWF1PaZ8dQ17Yw1kI OTaOOXgfByo9omyO3+7d1UFZDXmJAXOgH3XW1dZCjJAeh+FH/8rITkXygjqtnn3S0XnF xD+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722710081; x=1723314881; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RwRIvU51r29EMUsKvAykEEm2XFjy8tMwGmI0hD4rWsI=; b=HRErRK6fevI79FPZxD5emwAOAPONQwq6UAAiAmtmabxrrXdoCp4NQ6suV9UYgbbcdn 2mcxY923PYwQvdF0m6N65/bycfMUDUTuWEbSICLBlMdEGbzh6893RLo2OfgE95gJbqvZ IvSJu4UnilNRwYmOMKtvl2HSS7AwXRKiMV72N3/RXjwqznpj/FqDyJQ18sPn1i3mGjdE 4Kd3JLv7ZeqqXsTz9OieEOBEqeSQY6mQ1fYOkzqnrlXkpIxEFC17TqP5N6GsgtwkmF35 GsPwnqbs3aVSF3cn3UzbCXX76Hi0btXyYgnH6u3/F8HXHh/ldQ7csuWlC9rR7WJDCSql Jphw== X-Forwarded-Encrypted: i=1; AJvYcCVTkKjLhTan8WySeC/f2we2Xxa/b6t9xPnMNxbXkBc0mKyd5c9mji2L9RVwGraLBjbMlKbKhOAseLAHUePIR9Vu4uH1Jxd9rNMCFT/PQZIgXLAMFkEIOPyX1Po4v7tm X-Gm-Message-State: AOJu0YwTxpV2FareV5MiuSJ3NPt0R3z6iBhoj0C1IIDZ4dVCwG2S3Gb2 5TpJ/CXp5CrQkSbzwZc1mrtZMFFTPC9rIbN85J6fW+cAsGY3T1eP X-Google-Smtp-Source: AGHT+IEadz5HvfGRZAwUSnIHlQmhK7n3veFW/1Z9JqS0/i8Wg+932t3FIG1UnTryZaqC4PXo1kPGRA== X-Received: by 2002:a05:600c:4f90:b0:426:5416:67e0 with SMTP id 5b1f17b1804b1-428e6b831a1mr44268115e9.31.1722710080809; Sat, 03 Aug 2024 11:34:40 -0700 (PDT) Received: from [192.168.1.28] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-36bbd06d078sm4901467f8f.94.2024.08.03.11.34.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Aug 2024 11:34:40 -0700 (PDT) Message-ID: Date: Sat, 3 Aug 2024 19:34:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: bug#72446: [PATCH] stat: Fix memleak To: Dmitry Chestnykh , 72446@debbugs.gnu.org References: <20240803161028.197567-1-dm.chestnykh@gmail.com> Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: <20240803161028.197567-1-dm.chestnykh@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72446 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tag 72446 notabug close 72446 stop On 03/08/2024 17:10, Dmitry Chestnykh wrote: > format and format2 strings are allocated > by `malloc()` inside `xasprintf` so the memory > should be freed > > * src/stat.c: Call `free()` on `format` and `format2` > --- > src/stat.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/stat.c b/src/stat.c > index 1513abfaa..47f3b5052 100644 > --- a/src/stat.c > +++ b/src/stat.c > @@ -1974,5 +1974,7 @@ main (int argc, char *argv[]) > ? do_statfs (argv[i], format) > : do_stat (argv[i], format, format2)); > > + free(format); > + free(format2); > main_exit (ok ? EXIT_SUCCESS : EXIT_FAILURE); > } Hi, There are a could of problems with this. 1. It's redundant to free just before exit 2. It's invalid to free this memory with the -c format specified. valgrind currently shows no leaks with or without -c (it does show reachable blocks, but that's fine). thanks, Pádraig From unknown Wed Jun 18 23:07:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 01 Sep 2024 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator