GNU bug report logs - #72435
[PATCH] gnu: vulkan-loader: Fix cross-compilation.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72435: closed ([PATCH] gnu: vulkan-loader: Fix
 cross-compilation.)
Date: Sun, 11 Aug 2024 10:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 11 Aug 2024 11:36:36 +0100
with message-id <8734nbz6q3.fsf <at> cbaines.net>
and subject line Re: [bug#72435] [PATCH] gnu: vulkan-loader: Fix cross-compilation.
has caused the debbugs.gnu.org bug report #72435,
regarding [PATCH] gnu: vulkan-loader: Fix cross-compilation.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72435: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72435
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: vulkan-loader: Fix cross-compilation.
Date: Sat,  3 Aug 2024 10:23:54 +0800

* gnu/packages/vulkan.scm (vulkan-loader)[arguments]<#:configure>: When
cross-compilation, set the PKG_CONFIG_EXECUTABLE variable.

Change-Id: Ie0466a64effa5c93f859ff872423f2403f23f5cb
---
 gnu/packages/vulkan.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index 25542c1e06..8aee673653 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2021 Mathieu Othacehe <othacehe <at> gnu.org>
 ;;; Copyright © 2022 Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
 ;;; Copyright © 2022, 2024 dan <i <at> dan.games>
-;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2023, 2024 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -297,7 +297,11 @@ (define-public vulkan-loader
                                        (search-input-directory
                                         %build-inputs "include/vulkan"))))
               #$@(if (%current-target-system)
-                     #~("-DBUILD_TESTS=OFF" "-DUSE_GAS=OFF")
+                     #~("-DBUILD_TESTS=OFF" "-DUSE_GAS=OFF"
+                        (string-append "-DPKG_CONFIG_EXECUTABLE="
+                                       (search-input-file
+                                        %build-inputs
+                                        (string-append "bin/" #$(pkg-config-for-target)))))
                      #~("-DBUILD_TESTS=ON")))
        #:phases
        #~(modify-phases %standard-phases

base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
-- 
2.45.2

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 72435-done <at> debbugs.gnu.org
Subject: Re: [bug#72435] [PATCH] gnu: vulkan-loader: Fix cross-compilation.
Date: Sun, 11 Aug 2024 11:36:36 +0100

[Message part 4 (text/plain, inline)]

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:

> * gnu/packages/vulkan.scm (vulkan-loader)[arguments]<#:configure>: When
> cross-compilation, set the PKG_CONFIG_EXECUTABLE variable.
>
> Change-Id: Ie0466a64effa5c93f859ff872423f2403f23f5cb
> ---
>  gnu/packages/vulkan.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Sounds good to me, I've pushed this to master as
0f82dfeb0abe2d1d7a0fc45d7e164c3842234820.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.