GNU bug report logs - #72420
set-goal-column misbehaves with a line-prefix and visual-line-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72420: closed (set-goal-column misbehaves with a line-prefix
 and visual-line-mode)
Date: Sat, 07 Sep 2024 07:18:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 07 Sep 2024 10:16:54 +0300
with message-id <86plpgyluh.fsf <at> gnu.org>
and subject line Re: bug#72420: set-goal-column misbehaves with a line-prefix and visual-line-mode
has caused the debbugs.gnu.org bug report #72420,
regarding set-goal-column misbehaves with a line-prefix and visual-line-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72420: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72420
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Martin Edström" <meedstrom <at> runbox.eu>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Subject: set-goal-column misbehaves with a line-prefix and visual-line-mode
Date: Fri, 02 Aug 2024 12:35:32 +0200 (CEST)

There remains a niggling issue related to bug 61580 ( https://lists.gnu.org/archive/html/bug-gnu-emacs/2023-03/msg00094.html )

Basically, reproduce that same setup. Now turn on M-x visual-line-mode and try to use M-x set-goal-column (C-x C-n).  It does not stick to the goal column you choose.

Martin Edstrom

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: meedstrom <at> runbox.eu
Cc: 72420-done <at> debbugs.gnu.org
Subject: Re: bug#72420: set-goal-column misbehaves with a line-prefix and
 visual-line-mode
Date: Sat, 07 Sep 2024 10:16:54 +0300

> Cc: 72420 <at> debbugs.gnu.org
> Date: Thu, 22 Aug 2024 17:33:16 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > Cc: 72420 <at> debbugs.gnu.org
> > Date: Tue, 20 Aug 2024 15:24:12 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > 
> > > From: "Martin Edström" <meedstrom <at> runbox.eu>
> > > Date: Tue, 20 Aug 2024 10:28:44 +0200 (CEST)
> > > 
> > > Can we undo the "notabug" tag on this one?  The bug is with visual-line-mode.
> > 
> > I didn't yet have time to take another look at this, sorry.  When I
> > do, I will consider this aspect.
> 
> I've now made this test case behave the same both with and without
> visual-line-mode on the master branch of the Emacs Git repository.
> The patch is below (you will need to rebuild Emacs for it to be
> effective, since simple.el is preloaded).
> 
> diff --git a/lisp/simple.el b/lisp/simple.el
> index a9f8b58..1d3be2b 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -8200,7 +8200,7 @@ line-move-finish
>  
>  	;; Move to the desired column.
>          (if (and line-move-visual
> -                 (not (or truncate-lines truncate-partial-width-windows)))
> +                 (not (or truncate-lines (truncated-partial-width-window-p))))
>              ;; Under line-move-visual, goal-column should be
>              ;; interpreted in units of the frame's canonical character
>              ;; width, which is exactly what vertical-motion does.
> 

No further comments, so I assume the bug is indeed fixed, and I'm
closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.