From unknown Fri Jun 20 20:03:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7242: `read-color' and `facemenu-read-color' redundant-p Resent-From: MON KEY Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2010 18:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7242@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12874270371319 (code B ref -1); Mon, 18 Oct 2010 18:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Oct 2010 18:37:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7uaC-0000LE-K1 for submit@debbugs.gnu.org; Mon, 18 Oct 2010 14:37:16 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7uaB-0000L8-BO for submit@debbugs.gnu.org; Mon, 18 Oct 2010 14:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7udm-0003PV-Be for submit@debbugs.gnu.org; Mon, 18 Oct 2010 14:40:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:44056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7udm-0003PR-9f for submit@debbugs.gnu.org; Mon, 18 Oct 2010 14:40:58 -0400 Received: from [140.186.70.92] (port=48662 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7udl-0002lA-0M for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 14:40:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7udk-0003Op-12 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 14:40:56 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:56149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7udj-0003OQ-Sr for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 14:40:55 -0400 Received: by wyf28 with SMTP id 28so1603514wyf.0 for ; Mon, 18 Oct 2010 11:40:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.145.66 with SMTP id c2mr1601176wbv.34.1287427253926; Mon, 18 Oct 2010 11:40:53 -0700 (PDT) Received: by 10.216.67.195 with HTTP; Mon, 18 Oct 2010 11:40:53 -0700 (PDT) Date: Mon, 18 Oct 2010 14:40:53 -0400 X-Google-Sender-Auth: 2plBZevMoB5_-yOP56Y9nqVq9e8 Message-ID: From: MON KEY Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.1 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) lisp/faces.el defines `read-color' lisp/facemenu.el defines `facemenu-read-color'. Is the functionality of the two sufficiently similar that `read-color' can be used in lieu of `facemenu-read-color'? If not, maybe the two fncn's should be merged... -- /s_P\ From unknown Fri Jun 20 20:03:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7242: `read-color' and `facemenu-read-color' redundant-p Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2010 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: MON KEY Cc: 7242@debbugs.gnu.org Received: via spool by 7242-submit@debbugs.gnu.org id=B7242.128794561522909 (code B ref 7242); Sun, 24 Oct 2010 18:41:02 +0000 Received: (at 7242) by debbugs.gnu.org; 24 Oct 2010 18:40:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA5UM-0005xS-To for submit@debbugs.gnu.org; Sun, 24 Oct 2010 14:40:15 -0400 Received: from pantheon-po16.its.yale.edu ([130.132.50.72]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA5UK-0005xN-0j for 7242@debbugs.gnu.org; Sun, 24 Oct 2010 14:40:12 -0400 Received: from furball (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po16.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9OIiBSb026823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 24 Oct 2010 14:44:11 -0400 Received: by furball (Postfix, from userid 1000) id D16341607BF; Sun, 24 Oct 2010 14:44:12 -0400 (EDT) From: Chong Yidong References: Date: Sun, 24 Oct 2010 14:44:12 -0400 In-Reply-To: (MON KEY's message of "Mon, 18 Oct 2010 14:40:53 -0400") Message-ID: <87vd4re8hv.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) MON KEY writes: > lisp/faces.el defines `read-color' > lisp/facemenu.el defines `facemenu-read-color'. > > Is the functionality of the two sufficiently similar that `read-color' can > be used in lieu of `facemenu-read-color'? > > If not, maybe the two fncn's should be merged... Yeah, the introduction of read-color seems like an oversight. I've merged the two functions, and renamed the result into `read-color'. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 14:40:26 2010 Received: (at control) by debbugs.gnu.org; 24 Oct 2010 18:40:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA5UX-0005xd-Uy for submit@debbugs.gnu.org; Sun, 24 Oct 2010 14:40:26 -0400 Received: from pantheon-po42.its.yale.edu ([130.132.50.101]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA5UV-0005xY-PE for control@debbugs.gnu.org; Sun, 24 Oct 2010 14:40:24 -0400 Received: from furball (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po42.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9OIiNgq023114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 24 Oct 2010 14:44:23 -0400 Received: by furball (Postfix, from userid 1000) id 2C8DC1607BF; Sun, 24 Oct 2010 14:44:25 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7242 Date: Sun, 24 Oct 2010 14:44:24 -0400 Message-ID: <87eibfbfcn.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 7242 thanks From unknown Fri Jun 20 20:03:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7242: `read-color' and `facemenu-read-color' redundant-p Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2010 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Chong Yidong'" , "'MON KEY'" Cc: 7242@debbugs.gnu.org Received: via spool by 7242-submit@debbugs.gnu.org id=B7242.128794945627359 (code B ref 7242); Sun, 24 Oct 2010 19:45:02 +0000 Received: (at 7242) by debbugs.gnu.org; 24 Oct 2010 19:44:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA6UJ-00077E-Hl for submit@debbugs.gnu.org; Sun, 24 Oct 2010 15:44:15 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA6UH-000779-4v for 7242@debbugs.gnu.org; Sun, 24 Oct 2010 15:44:13 -0400 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o9OJm981010586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 24 Oct 2010 19:48:10 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o9OJm8VM032081; Sun, 24 Oct 2010 19:48:08 GMT Received: from abhmt007.oracle.com by acsmt353.oracle.com with ESMTP id 711514021287949577; Sun, 24 Oct 2010 12:46:17 -0700 Received: from dradamslap1 (/10.159.218.26) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 Oct 2010 12:46:17 -0700 From: "Drew Adams" References: <87vd4re8hv.fsf@stupidchicken.com> Date: Sun, 24 Oct 2010 12:46:16 -0700 Message-ID: <0E6486B04D1C45BBBB0E34996A71BB5A@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87vd4re8hv.fsf@stupidchicken.com> Thread-Index: Actzr31elydT+cRRRnq/IlgDSMoTuwAAedBw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) > Yeah, the introduction of read-color seems like an oversight. > > I've merged the two functions, and renamed the result into > `read-color'. See http://lists.gnu.org/archive/html/emacs-devel/2008-10/msg00474.html.