From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 13:32:55 2024 Received: (at submit) by debbugs.gnu.org; 31 Jul 2024 17:32:55 +0000 Received: from localhost ([127.0.0.1]:50237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZDC3-0006n9-BN for submit@debbugs.gnu.org; Wed, 31 Jul 2024 13:32:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:38316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZDC0-0006mw-Sz for submit@debbugs.gnu.org; Wed, 31 Jul 2024 13:32:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZDBk-0008RB-P5 for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2024 13:32:36 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZDBi-0007mF-TC for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2024 13:32:36 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 282D1E0002 for ; Wed, 31 Jul 2024 17:32:27 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 30.0.60; Customization of options is broken Organization: LINKOV.NET Date: Wed, 31 Jul 2024 20:25:30 +0300 Message-ID: <86a5hxv6cp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I found this bug while testing 'tab-bar-format', but all customizable variables that use :options are broken in emacs-30. Here is an example for 'log-edit-hook': 0. emacs-30 -Q 1. Eval: (require 'log-edit) 2. Check the value of 'log-edit-hook'. Its value is (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) 3. M-x customize-variable RET log-edit-hook RET 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. 5. Apply 6. Check the value of 'log-edit-hook'. Its value is (log-edit-insert-cvs-rcstemplate) In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d Repository branch: emacs-30 Windowing system distributor 'The X.Org Foundation', version 11 Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid' Whereas in GNU Emacs 29.3.50 it was correctly changed to (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 14:07:35 2024 Received: (at 72404) by debbugs.gnu.org; 31 Jul 2024 18:07:35 +0000 Received: from localhost ([127.0.0.1]:50287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZDja-0007i2-M8 for submit@debbugs.gnu.org; Wed, 31 Jul 2024 14:07:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZDjW-0007hf-8W for 72404@debbugs.gnu.org; Wed, 31 Jul 2024 14:07:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZDh4-0006oK-1l; Wed, 31 Jul 2024 14:04:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V2AEvUfcREUZUC2WIaD1ek7UQiVe/h5Ae2itfjg5AeA=; b=oMf+aRph/oqU EGm+BIcQ3iLM1baQGnEUE4SReuTgvnn21TvU3gri1iCumGLfxv2BFABGsQAOJorvh9v2GhL3UxUzB ulRIBZ2FBoFYq289ikcIUa8NppuUYNqU/iolykDyqKh6TEQQGL+HZ0b348jmMU6gl8PlPNesSvzqW GGdRloNq1vtztIO6viQ3wW3Gwnxwyr3Zpm8JkNJ0XFNQLjANZjDYjYa/qo0iM4o3dWSgvTpSUvkWy KHc+FeaZGEyG1QNpo4pLLBA4MmNOhN7SpC46JtzBqmZd4OSiLZxEvm4cK8Tb48RsRjR0PIBMxFxtQ N8XMRbFtzJfNOo0rd0nVtw==; Date: Wed, 31 Jul 2024 21:04:54 +0300 Message-Id: <86frrpxws9.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov , Mauro Aranda In-Reply-To: <86a5hxv6cp.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 31 Jul 2024 20:25:30 +0300) Subject: Re: bug#72404: 30.0.60; Customization of options is broken References: <86a5hxv6cp.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Wed, 31 Jul 2024 20:25:30 +0300 > > I found this bug while testing 'tab-bar-format', but all > customizable variables that use :options are broken in emacs-30. > Here is an example for 'log-edit-hook': > > 0. emacs-30 -Q > 1. Eval: (require 'log-edit) > 2. Check the value of 'log-edit-hook'. > Its value is > (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) > 3. M-x customize-variable RET log-edit-hook RET > 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. > 5. Apply > 6. Check the value of 'log-edit-hook'. > Its value is (log-edit-insert-cvs-rcstemplate) > > In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, > cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 > Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d > Repository branch: emacs-30 > Windowing system distributor 'The X.Org Foundation', version 11 > Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid' > > Whereas in GNU Emacs 29.3.50 it was correctly changed to > (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate > log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) Thanks. Bisection would be useful, I think. Adding Mauro, in case he has some ideas or even fixes. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 17:13:59 2024 Received: (at 72404) by debbugs.gnu.org; 31 Jul 2024 21:13:59 +0000 Received: from localhost ([127.0.0.1]:50398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZGdy-0003wt-JZ for submit@debbugs.gnu.org; Wed, 31 Jul 2024 17:13:58 -0400 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:49281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZGdx-0003wa-73 for 72404@debbugs.gnu.org; Wed, 31 Jul 2024 17:13:57 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 96B01138222B; Wed, 31 Jul 2024 17:13:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 31 Jul 2024 17:13:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1722460415; x=1722546815; bh=E4UxxuAel6 z1VrRmyAHJz2cjhWvorXKjuSQ7zyvO7C4=; b=a+p5L76orlGpTwCUwK93oqCtsK swMqT7m9GLJzpaSXVLXwyEm4oCwR9ZSGZ3GXhF6JalskhXVgNZN93n9KnkLGRCKX AfN9M+pKI/ZYMwWqEHq3XyLmMW0oW7S02K0m3rw63ElUgoIQ1bGB6MB4L31WkPG9 UwL0sn9WNLQMSVnNOnEiqQQw6e5UNXa6zhlKil6eXIsyPFnlKGYUfmtXIxAHhS4I +G5RKrqGHKZPL+siiAp1SkpEqifla6p1EgnRtp418vF+8kowoEWbXq7T9D0hjqsc TIC8bnk0BB6onMTOqSaNUiYO7pR2X4vfduDTAZLsm3yCQOPJ9slECF5dHMsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1722460415; x=1722546815; bh=E4UxxuAel6z1VrRmyAHJz2cjhWvo rXKjuSQ7zyvO7C4=; b=qtIc3jYdKZBN405i53I0lPD1XCkzQg2RyYsTnKizyh96 clUMure4euLwdwfxWSvZmeIxSmKdWopJF7/Cb9DC1inWKIKNiSJt81zqP5PFLT2L KPPPwp2j6vylgjKWcJ4LO0piMX1rJnvvxBzQnpNj6nGDU21JS1m+9kXom0hgVCH9 GgX1bg4hvaCOJPK6vgtTnzlrPXgFSztOM9yuHwPwxuUDvAd9FeMPXbDL4fXiWTo5 7hcIZalDmuPloR2evLdRv7362E6wP4SRC675sPQvnyoM34/4JVwXuF9j8b3MZscn 9SE0xXqz71lAz9lDqhbsRowUNQyyMyhw7VhtWl5hKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjeeigdduheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujgfffhgfkfggtgesthdtredttdertdenucfhrhhomhepjhhohhhn uchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrghtthgvrhhnpeduteehhf ehvdefuedtgfeuhfelieetgfduueekueekkeeuhefgfeevkeeiuefhudenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinh hkpdhnsggprhgtphhtthhopedt X-ME-Proxy: Feedback-ID: i74194916:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 31 Jul 2024 17:13:34 -0400 (EDT) From: john muhl To: Eli Zaretskii Subject: Re: bug#72404: 30.0.60; Customization of options is broken In-Reply-To: <86frrpxws9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 31 Jul 2024 21:04:54 +0300") Date: Wed, 31 Jul 2024 15:18:46 -0500 References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> User-Agent: mu4e 1.12.1; emacs 31.0.50 Message-ID: <87le1hs1s2.fsf@pub.pink> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org, stephen.berman@gmx.net, Mauro Aranda , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Juri Linkov >> Date: Wed, 31 Jul 2024 20:25:30 +0300 >> >> I found this bug while testing 'tab-bar-format', but all >> customizable variables that use :options are broken in emacs-30. >> Here is an example for 'log-edit-hook': >> >> 0. emacs-30 -Q >> 1. Eval: (require 'log-edit) >> 2. Check the value of 'log-edit-hook'. >> Its value is >> (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) >> 3. M-x customize-variable RET log-edit-hook RET >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. >> 5. Apply >> 6. Check the value of 'log-edit-hook'. >> Its value is (log-edit-insert-cvs-rcstemplate) >> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, >> cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d >> Repository branch: emacs-30 >> Windowing system distributor 'The X.Org Foundation', version 11 >> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid' >> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) > > Thanks. Bisection would be useful, I think. > > Adding Mauro, in case he has some ideas or even fixes. Reverting 8d354925ddb fixes it here. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 01 01:10:20 2024 Received: (at 72404) by debbugs.gnu.org; 1 Aug 2024 05:10:20 +0000 Received: from localhost ([127.0.0.1]:50677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZO4x-0007kv-Nz for submit@debbugs.gnu.org; Thu, 01 Aug 2024 01:10:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZO4v-0007kg-9a for 72404@debbugs.gnu.org; Thu, 01 Aug 2024 01:10:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZO4X-0003ky-UJ; Thu, 01 Aug 2024 01:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VHllCRDOxL2ei9wAuZptRoDIijYhu+HZVtEpISQx0/w=; b=K7JPdPpQ1Pfe 5bWu4nqqCE6ugM3ZW5Rd6SAADgs3KBkGfVwbwSJOxa0YZ7HkvNA4smvQkQyAXEVL5PPi/dVniGENk 6PVX0UqibiIo18i7NbBan0mLMAY213wxGYL6IzZJL9jPQw+OR8KGnwxZuAKt+5N14yZJTvyIqLRDU OGr+ktVAf7TPshJu7CHWq7VcIMjBcPciJdsFHIDeTxwHJaCLXm+/MlUI7kjDLZ9b//OEOZQh+i2Mm q9l2J+yShyXWS/LtajDEV76XVIMPZLmVQOF3pHEbSSe23LWxdb7q3ov6D/5LFuuX+sKtVxp8XxcWn ZAveAl9BNip6OQlMiF/P9A==; Date: Thu, 01 Aug 2024 08:09:52 +0300 Message-Id: <867cd0ygkf.fsf@gnu.org> From: Eli Zaretskii To: john muhl , stephen.berman@gmx.net In-Reply-To: <87le1hs1s2.fsf@pub.pink> (message from john muhl on Wed, 31 Jul 2024 15:18:46 -0500) Subject: Re: bug#72404: 30.0.60; Customization of options is broken References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org, maurooaranda@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: john muhl > Cc: Juri Linkov , Mauro Aranda , > 72404@debbugs.gnu.org, stephen.berman@gmx.net > Date: Wed, 31 Jul 2024 15:18:46 -0500 > > Eli Zaretskii writes: > > >> 0. emacs-30 -Q > >> 1. Eval: (require 'log-edit) > >> 2. Check the value of 'log-edit-hook'. > >> Its value is > >> (log-edit-insert-message-template log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) > >> 3. M-x customize-variable RET log-edit-hook RET > >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. > >> 5. Apply > >> 6. Check the value of 'log-edit-hook'. > >> Its value is (log-edit-insert-cvs-rcstemplate) > >> > >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, > >> cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 > >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d > >> Repository branch: emacs-30 > >> Windowing system distributor 'The X.Org Foundation', version 11 > >> Configured using: 'configure --with-native-compilation --with-x-toolkit=lucid' > >> > >> Whereas in GNU Emacs 29.3.50 it was correctly changed to > >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate > >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show-files) > > > > Thanks. Bisection would be useful, I think. > > > > Adding Mauro, in case he has some ideas or even fixes. > > Reverting 8d354925ddb fixes it here. Thanks! Stephen, please look at this ASAP, as this sounds like a serious and very recent regression. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 01 06:13:30 2024 Received: (at 72404) by debbugs.gnu.org; 1 Aug 2024 10:13:30 +0000 Received: from localhost ([127.0.0.1]:50903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZSoM-0007UM-3m for submit@debbugs.gnu.org; Thu, 01 Aug 2024 06:13:30 -0400 Received: from mout.gmx.net ([212.227.17.22]:37585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZSoJ-0007U7-41 for 72404@debbugs.gnu.org; Thu, 01 Aug 2024 06:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1722507175; x=1723111975; i=stephen.berman@gmx.net; bh=A6ek1DG5ySrbTN2FiBn3dIKcM55ffJkVRzt8n8qthSE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=AvIvNbboo4O6CMf/Dqh2Rqdh7saXWI05Cs4f3zQ7PQZAsYwJUdmS01en/yLpNFyB mM8O6nDxqEHAny3ylQw852hatKXJCqqILYKQXlh1Ks3iThiEge4nQD8WXm1ZA5n7a /d/q2q52mzhDJunDw12a/jTl8OEUzMh36lHIrdYR7P9L8QjGnqglQhwm/36/XlFV/ qtuaI4R37sKnAZOuRF0Gp5DN3iwRu9Qkvy2sdUpkrn0HbcEME9+P7TQOTJdLlR+qp vr5puaWn3uHcbScED9v0mK37fbeAyjjCWDoSlMKBDChO57d4Y6+tMDfzjSySbFvVL 9vYGAO+bTk3gK4+hmw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.94.179]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRmjq-1sfT5h0yQk-00KK3d; Thu, 01 Aug 2024 12:12:55 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#72404: 30.0.60; Customization of options is broken In-Reply-To: <867cd0ygkf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Aug 2024 08:09:52 +0300") References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> Date: Thu, 01 Aug 2024 12:12:52 +0200 Message-ID: <878qxga6vv.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Ny/a4/nHGp419cADnjpN44hmME96frwcT2flZbCv20RaMaIqCFy J17Qz9nSCR8PlfC0mGXmLKIoL3KvXs88LnJxFMGzftQZAmBftRU37Tzx0dHOntv4t7KHYM/ NkgrXPqBlIAMOwD3tD2s+AWJUeRMlHu2M6ZAOHCKJ2tgjjY2tn5T6gssiS2NkHoshrcyy3/ Ep5Jm80C/iAUsxb1gd1zg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fJl1wBtZ8o4=;lWSmnfTlQqmidgvPXPesjJF+1qY vgg2xCvfqURnFS2bSmUkXLmY7vbiJHUvkdsaqZUcshtUUtHxL4zyw5o8hSHcRCyDzs8yEnMLg fpnjUPgvKHpYjZS3mkcAJ70aOoU9rAFicnHTwDm87yWpum0vDD60/Ih6MwAJf8h1qytKT07dJ NAA4VsYczXTc9Kadw2K+jF3XmPZLIaNfjEnHrizb8tIp0nTxAYs0TujT+wSsn8TIuJ5RtUOlO DdwZm+kJRp5UUXtcJnrUgjykFD8GRCnyddJR/Nxp085xQbJyJIasggwLgbGktSBXrIpacPAJ5 PqFUqycgplZxDDGREkbYa2CynE4e658dwqnKzR4IU/fgGoqpmOxP5FQytJ71W6TZml3wVDK3p bHtsewrjXh6K2GP6HAUsLH6q+2fkwcsHbJyj0dEggSMWCL3Hxq3i3FsPBJr7v+ZT7XX6rVFFT 8cu81RpASl2Do4eshufNYYMKGqNfIuppihFDHKhDm53WPIv7k5OF8AvrNg0+jEmZ96Xbopu7E QLiru4/ujmzdXyARLL6Qf2ev3B1B9/I7iLcPPW1Rubi5pTFaaTy6cZcXiWzu8nh1uafNd9xHB kUVGSlavuP3lCYXscWNHn8jCZ9SUc9oC5iLhWeygHmZ39EGygECbU48c/VsqaYAXXdkeBPwlD PlVjexcxkW4HP4H88Fr5vjWGscnUMqELr3h/f1L1t5g+BHuRQf/1PX2yZMR/QKYR/yeswfu8h mghn6o4UL8QSFsKlGDpKWYMakl3jHB4s6kym4XevrxwN2zi9oHjZXYoK2TOCbxNhjS3H4PL4k Z/TTq6B735WboeuX6F0o0jkw== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org, john muhl , maurooaranda@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 01 Aug 2024 08:09:52 +0300 Eli Zaretskii wrote: >> From: john muhl >> Cc: Juri Linkov , Mauro Aranda , >> 72404@debbugs.gnu.org, stephen.berman@gmx.net >> Date: Wed, 31 Jul 2024 15:18:46 -0500 >> >> Eli Zaretskii writes: >> >> >> 0. emacs-30 -Q >> >> 1. Eval: (require 'log-edit) >> >> 2. Check the value of 'log-edit-hook'. >> >> Its value is >> >> (log-edit-insert-message-template log-edit-insert-cvs-template lo= g-edit-insert-changelog log-edit-show-files) >> >> 3. M-x customize-variable RET log-edit-hook RET >> >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. >> >> 5. Apply >> >> 6. Check the value of 'log-edit-hook'. >> >> Its value is (log-edit-insert-cvs-rcstemplate) >> >> >> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, >> >> cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 >> >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d >> >> Repository branch: emacs-30 >> >> Windowing system distributor 'The X.Org Foundation', version 11 >> >> Configured using: 'configure --with-native-compilation --with-x-tool= kit=3Dlucid' >> >> >> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to >> >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate >> >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-show= -files) >> > >> > Thanks. Bisection would be useful, I think. >> > >> > Adding Mauro, in case he has some ideas or even fixes. >> >> Reverting 8d354925ddb fixes it here. > > Thanks! > > Stephen, please look at this ASAP, as this sounds like a serious > and very recent regression. I took a look and tried stepping through with Edebug, but so far could not find out how my changes in that commit cause the regression. I won't have time for further debugging until next week, and given my unfamiliarty with the widget and custom code (I didn't even know about :options till now), I may well not be able to fix this. Feel free to revert the commit in the mean time. It would also be good to have a test for this case (in emacs-30 with the commit all widget and custom tests pass). Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 01 13:28:38 2024 Received: (at 72404) by debbugs.gnu.org; 1 Aug 2024 17:28:38 +0000 Received: from localhost ([127.0.0.1]:51921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZZbS-0002nH-0G for submit@debbugs.gnu.org; Thu, 01 Aug 2024 13:28:38 -0400 Received: from mout.gmx.net ([212.227.15.19]:58019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZZbN-0002my-MF for 72404@debbugs.gnu.org; Thu, 01 Aug 2024 13:28:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1722533285; x=1723138085; i=stephen.berman@gmx.net; bh=TepLuylHa2Fsc4ga8+AH2qFgVzN0wGrKBLyiqDOyFno=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=A0TJoiJc4dKMdE5B+zRj7IbBbYTXxgszUHjHlDJR67/p0PkhSg1Pm+zuGU0XcxX+ rZHbzv3sfVTRhxPCCPjjTcG87iy1xr7N2bfVtvAM+1ApWM6Or4dkl4rf1eIgrrBFa 298hDPf4J11NWB+/8YYqdEzcPuFhDfbOb6MqHUFT6bPMfGpRrVysKO6dBDXLgXFvD Lqy+FOAoA8d0iD/wAe55cbge9gDnxknfGCjsEwbjFPtx+NOEnm6ST5fyx+twx9mMQ uer75JB+kjRuXim3e7SWnpdmPqKyjOlBDHLJKPt9U/k+UY82WdpKM6T8o5aHhVMV+ /cx8ubI8PCKX40lQsg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.94.179]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8QWA-1sdzRl1DWa-004E61; Thu, 01 Aug 2024 19:28:05 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#72404: 30.0.60; Customization of options is broken In-Reply-To: <878qxga6vv.fsf@gmx.net> (Stephen Berman's message of "Thu, 01 Aug 2024 12:12:52 +0200") References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> <878qxga6vv.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 01 Aug 2024 19:28:04 +0200 Message-ID: <87ttg48863.fsf@gmx.net> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:8aN4ukL7tBTVhowoYjEEZ5DCG19tZUwmbbQCEuxeCBpZz3dASOv 77HmzYtQpkL6P6t49lcIiuRZ4PuV9FuP+IF16YlAljQr1JGjaBBO/+qb83oSFU25NFXWyaw 1FAfAk7k3N4x8baes28k6/vS7gByaQgSOC3B+zYQXBBsoVgEzc8dSsoP8Xww/qGhNSu9zsT SNQhox5hOIIichqvx+aZQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BzzB6lMqz24=;ddHxbSry/bJ5JE5aD+n89U7w9ZD ZOPTGQBHp0AQZGbwGoDnUdNSuQ0kwRUYEXCwRgMMXvgGEGLJk4xD1hWUdi96CrIiMnDhBvV17 EQOKGjeu8XQf6ouBHyANaKlPLDqVyFylAPHBojTzwybfUuTv3x5tDR4+5oNh6azDhYqTqR0cb Zz/ek5Gx7E2jjxa+hnfa8FnZQVrPq+4fB3Uhozv3gV1fwqqNAFfilcVQCGrsL/Sc4x+ar0M8J NupUdiDlQfX4C4pSMLtO+27rEsez88pr6uZCpv3dDFEcP8HirnSsZvN2UFyQYcvcHFGNhHLDr YwYnMRb3e6s8hHOEt3ZjjBezKaphM1D6wgeV0nlCZLez4eK2cIrdUjfZCie1/Qhzs2JtexTsY 3qJMtzWGIzgU0eRBBjhtivg/G+PVDW3GjBM9RgBHqawAGnM4DFsArD/wFCxhxAHW4QEMxY5Zh WZJaM4v/NTwDh6KWhghAVqxrS7X4WqI9dodDxjlWi/FeAk1/SqTk3L0/o2braBGC1wn1cF7OE i7KVvUh2H92XNwYyJ3ygZoejVdgIFwYHW7zcOcb/EHsmgnp9NhLsi2d/79KpZ41Mfyn3HgZYc lsDM/bw7hxgJ82hHQXBbHx+1VKGsTvqIEVnXT1G8Li9UvD+vApLdOSUPkjfUgyH+GPokGwu6T BgEfdsTeGH5ONSFoTQE+pQIuBfpq7g+tP33Xcf25bD8A+gT5luB4WcrmcmXoQTA73vUAosmLL AhP7cBjGf8Ql3CE6eNB9LBi4jCTef41ffSawMzpDbwTuC3lt7YThVn7QDkEIuDqwSXL8hHGOo NJev8yzjwX5E1RPXM7Gc5OnQ== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org, john muhl , maurooaranda@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman = wrote: > On Thu, 01 Aug 2024 08:09:52 +0300 Eli Zaretskii wrote: > >>> From: john muhl >>> Cc: Juri Linkov , Mauro Aranda , >>> 72404@debbugs.gnu.org, stephen.berman@gmx.net >>> Date: Wed, 31 Jul 2024 15:18:46 -0500 >>> >>> Eli Zaretskii writes: >>> >>> >> 0. emacs-30 -Q >>> >> 1. Eval: (require 'log-edit) >>> >> 2. Check the value of 'log-edit-hook'. >>> >> Its value is >>> >> (log-edit-insert-message-template log-edit-insert-cvs-template l= og-edit-insert-changelog log-edit-show-files) >>> >> 3. M-x customize-variable RET log-edit-hook RET >>> >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. >>> >> 5. Apply >>> >> 6. Check the value of 'log-edit-hook'. >>> >> Its value is (log-edit-insert-cvs-rcstemplate) >>> >> >>> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, >>> >> cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 >>> >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d >>> >> Repository branch: emacs-30 >>> >> Windowing system distributor 'The X.Org Foundation', version 11 >>> >> Configured using: 'configure --with-native-compilation --with-x-too= lkit=3Dlucid' >>> >> >>> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to >>> >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate >>> >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-sho= w-files) >>> > >>> > Thanks. Bisection would be useful, I think. >>> > >>> > Adding Mauro, in case he has some ideas or even fixes. >>> >>> Reverting 8d354925ddb fixes it here. >> >> Thanks! >> >> Stephen, please look at this ASAP, as this sounds like a serious >> and very recent regression. > > I took a look and tried stepping through with Edebug, but so far could > not find out how my changes in that commit cause the regression. I > won't have time for further debugging until next week, and given my > unfamiliarty with the widget and custom code (I didn't even know about > :options till now), I may well not be able to fix this. Feel free to > revert the commit in the mean time. It would also be good to have a > test for this case (in emacs-30 with the commit all widget and custom > tests pass). I did happen to have a bit more time for this problem, and I think I've found the cause, a single line in commit 8d354925ddb: diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index 693991a6f3e..aa653549dad 100644 =2D-- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -2549,7 +2549,8 @@ widget-checklist-add-item (t (widget-create-child-value widget type (car (cdr chosen))) - (widget-specify-selected child))))) + ;; (widget-specify-selected child) + )))) (t (error "Unknown escape `%c'" escape))))) ;; Update properties. With this line commented out as in the above patch, I get the expected value when carrying out Juri's recipe. Moreover, after making that change, I then briefly tested customizing the face widget-unselected (which the problematic commit added) to inherit from the default face and it shows the labels of unselected check boxes in the default face, as it should. So maybe deleting the commented out line above and leaving the rest of the change is a sufficient fix. But I have to admit I don't know why that line causes the problem, and I haven't done enough testing of this change to the widget-unselected face feature, so this is just a status report. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 03:39:15 2024 Received: (at control) by debbugs.gnu.org; 4 Aug 2024 07:39:15 +0000 Received: from localhost ([127.0.0.1]:55348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saVpj-00049A-0r for submit@debbugs.gnu.org; Sun, 04 Aug 2024 03:39:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saVpg-00048a-Dp; Sun, 04 Aug 2024 03:39:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saVpF-0006sI-Ar; Sun, 04 Aug 2024 03:38:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v1o6ioM0VtfFyZzgoC6hgaatW3wFyAHnDNIEPkNfFXE=; b=eL44wtJqrhPo nEbEqbKxI2nmaO8wbunhZrd+1pfN15FmJaan867SlqsarGnR2RxmSIU/kpyxlz+d8pkwbsciZjIf5 WkfLQ5IEhxiPzJWym5VgLJEKpgvtxZB2xkCBEPCpgskCqp8PA1G1eZjgkReeJ9S2ltTXKbp9XG1Uw MTdMQiMItXDFjLh0m3INVSdpdj2lEJc8aMbIPLNfy8ebA8h3TLlQb7/1jk5Dqr3s19h7Y3EMWJFO4 CJqQfmD7VrDxRT0QAEGNTUkcbauhwn+BQ6yYRjWxyGMJ+8DSIKr+krlUhcv0jVqb7j/sGljkPgZBo rUNM/Asa4l2N61FlUIpV7Q==; Date: Sun, 04 Aug 2024 10:38:42 +0300 Message-Id: <86bk28u48t.fsf@gnu.org> From: Eli Zaretskii To: spacibba@aol.com, maurooaranda@gmail.com In-Reply-To: <86le1we9aw.fsf@gnu.org> (message from Eli Zaretskii on Sat, 20 Jul 2024 11:50:47 +0300) Subject: Re: bug#72156: 31.0.50; defcustom set issue References: <87le206x0k.fsf.ref@aol.com> <87le206x0k.fsf@aol.com> <86le1we9aw.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 72156@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 72156 72404 thanks > Cc: 72156@debbugs.gnu.org > Date: Sat, 20 Jul 2024 11:50:47 +0300 > From: Eli Zaretskii > > > Date: Wed, 17 Jul 2024 14:08:59 +0200 > > From: Ergus via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > I have this defcustom: > > > > ``` > > (defcustom gtags-mode-features '(control meta) > > "HELLO WORLD" > > :type '(set (const control) > > (const meta) > > (const shift) > > (const hyper) > > (const super) > > (const alt))) > > ``` > > > > When I try the customize-variable I get this: > > > > ``` > > Hide Gtags Mode Features: > > Set: > > [X] control > > [X] meta > > [ ] shift > > [ ] hyper > > [ ] super > > [ ] alt > > [ State ]: EDITED, shown value does not take effect until you set or save it. > > HELLO WORLD > > Groups: [Gtags Mode] > > ``` > > > > But, if I do the next change and save > > > > > > ``` > > Hide Gtags Mode Features: > > Set: > > [X] control > > [X] meta > > [X] shift > > [ ] hyper > > [ ] super > > [ ] alt > > [ State ]: EDITED, shown value does not take effect until you set or save it. > > HELLO WORLD > > Groups: [Gtags Mode] > > ``` > > > > The customize variable value saved is: > > > > '(gtags-mode-features3 '(shift)) > > > > it only saved the "new" value and ignores the previous > > existing ones. > > > > When I restart and check the variable's value I get as expected '(shift) > > and lost the control and meta. > > > > Going to customize-variable again I get: > > > > ``` > > Hide Gtags Mode Features: > > Set: > > [ ] control > > [ ] meta > > [X] shift > > [ ] hyper > > [ ] super > > [ ] alt > > [ State ]: EDITED, shown value does not take effect until you set or save it. > > HELLO WORLD > > Groups: [Gtags Mode] > > ``` > > > > Consistent with the variable value, but inconsistent with what was > > actually saved before. > > > > IF instead of selecting a new value I un-select some, then variable > > saves nil and will be nil. > > This seems to be some bug in handling the 'set' type of defcustoms. I > see the same problem when customizing completions-merging-modes from > completion.el. Perhaps Mauro (CC'ed) could chime in and suggest how > to solve this. This actually seems to be the same problem as bug#72404, since the fix proposed by Stephen there fixes this one as well. So I'm merging them. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 03:50:25 2024 Received: (at 72404) by debbugs.gnu.org; 4 Aug 2024 07:50:25 +0000 Received: from localhost ([127.0.0.1]:55354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saW0X-0004h8-DF for submit@debbugs.gnu.org; Sun, 04 Aug 2024 03:50:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saW0U-0004gk-GM for 72404@debbugs.gnu.org; Sun, 04 Aug 2024 03:50:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saW02-0001Uh-5V; Sun, 04 Aug 2024 03:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z/shrS+nvt+FgDvW8fmWCibibnAYu1w/Cr55ENwKga8=; b=j9QId17bnuOD LAm3mP55K9SZy8n2bV2FsWD/Lq4JXKhPgqjBTyAA454BhYIrcsi/s00pZ7hmts7DfvkOv/GY8QJvk 85o0OKjfYvTZzSvfzeg6IaxnKz2Seb4v+RoVwXIPHTOtCbiAa642ARRLYCJdwf8BlPZWn0Ba3NRY5 ZTst3Xuy0wOW2Eb3um6Xpcygskq4AZ+voPPcZpNG73IQPLRjGNJ+Bq4GWa+4uY6Edro5H7yLk15di JeIfBh9bcVq5vgWKwm61c06Z0Dblx2g3sZHN3iBYNNzaYp+5Z/ZfAOG/eBmC4pVTPO9PrfqEply5g NMPxQyxBLRYhpjW2XVUkOQ==; Date: Sun, 04 Aug 2024 10:49:52 +0300 Message-Id: <86a5hsu3q7.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman In-Reply-To: <87ttg48863.fsf@gmx.net> (message from Stephen Berman on Thu, 01 Aug 2024 19:28:04 +0200) Subject: Re: bug#72404: 30.0.60; Customization of options is broken References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> <878qxga6vv.fsf@gmx.net> <87ttg48863.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org, jm@pub.pink, maurooaranda@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: john muhl , juri@linkov.net, maurooaranda@gmail.com, > 72404@debbugs.gnu.org > Date: Thu, 01 Aug 2024 19:28:04 +0200 > > On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman wrote: > > I did happen to have a bit more time for this problem, and I think I've > found the cause, a single line in commit 8d354925ddb: > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > index 693991a6f3e..aa653549dad 100644 > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -2549,7 +2549,8 @@ widget-checklist-add-item > (t > (widget-create-child-value > widget type (car (cdr chosen))) > - (widget-specify-selected child))))) > + ;; (widget-specify-selected child) > + )))) > (t > (error "Unknown escape `%c'" escape))))) > ;; Update properties. > > With this line commented out as in the above patch, I get the expected > value when carrying out Juri's recipe. Moreover, after making that > change, I then briefly tested customizing the face widget-unselected > (which the problematic commit added) to inherit from the default face > and it shows the labels of unselected check boxes in the default face, > as it should. So maybe deleting the commented out line above and > leaving the rest of the change is a sufficient fix. But I have to admit > I don't know why that line causes the problem, and I haven't done enough > testing of this change to the widget-unselected face feature, so this is > just a status report. Thanks, I installed the above fix. It turns out the same problem also caused bug#72156, so I've now merged them. I'm leaving this bug open, in the hope that you or someone else will find the root cause for the regression and fix it. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 04 06:01:05 2024 Received: (at 72404) by debbugs.gnu.org; 4 Aug 2024 10:01:05 +0000 Received: from localhost ([127.0.0.1]:55546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saY2z-0002mj-2l for submit@debbugs.gnu.org; Sun, 04 Aug 2024 06:01:05 -0400 Received: from mout.gmx.net ([212.227.17.20]:45767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saY2v-0002lw-Mx for 72404@debbugs.gnu.org; Sun, 04 Aug 2024 06:01:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1722765630; x=1723370430; i=stephen.berman@gmx.net; bh=hqmsjLKy04wCBk/tzWIYtjn2H5fTjX9/71DYm3XZOKk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PU6K+8c8awGNBti4yG3zU5/qH5OVTUFCwZHZiEZJQKfrjZ1nKac7foxeF2yAfBgI Kx/obgzyh/ykg24erSilckhEQuHqpbiw67inZWlkzoqNHVnvXnBOdEEIL0zbMiZRs W+Y41v4u+IgUaaw52yTe4GY026A2UYhJ0pNyI044OF+4JfLz3819gAvSuwnDAcDeZ yqeV5pGH65eG+NZENt+dVOXVgjo4MQoU12fww3W1hDhBpLBZ4NwJ0tUHedfSdkWEu r1fd6yl/U6ej3oL4DECK7fVZ41VU9R4edUZdOzOObXL5w+zx3/3C0MeNdqvhmYj3Q lQ6dJyqeuOhUOLrx5A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.95.222]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEFzx-1sQPYB2VmP-004jbO; Sun, 04 Aug 2024 12:00:30 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#72404: 30.0.60; Customization of options is broken In-Reply-To: <86a5hsu3q7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Aug 2024 10:49:52 +0300") References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> <878qxga6vv.fsf@gmx.net> <87ttg48863.fsf@gmx.net> <86a5hsu3q7.fsf@gnu.org> Date: Sun, 04 Aug 2024 12:00:23 +0200 Message-ID: <87bk28vc94.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:KvceWuiB4VcK7yZyrID+ShmUEI/vO8SjAPBdR+azqiDWizVnAFx jJvHbEXPnzykjEYAKd1AvCLcLveLO7QlpgI3QGHQx/ORQAY8F4/zjm2ANQpXVt28Rrz9qpd grig7f4xflMOJ5+w5Y4iuyRiU9Jf1hALJOMM7WvLjZia6ZuVJbtEkS4SXOlgMa6dHYG3dxD i8UT+fyEhPKtCORSqJJeQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/ZCErUCgXjA=;0hx7cnMPk1C1fqXoiXcZ2e9DQXw edenau8mJBsTDvN7Pq/kbzvBbtZ2N4/tF8HhNyS17m3kWTJ/9puGPnIk/PCfCrQP31XCL22ss GF9fXIjwiplEJgfaJi0xRT1atHI+y4oEnD9AvIIylhm1D4BtQdldaRRPhNhJwfeCFXHgLF9bU 5+7JA7sMx4r/LbzIRgUbMZqe5T4/ptGXbhahZPI0gOLL31ARe5m0aUXebbYdeFSqFvvNEg/Wo r6shf0ZHaWlCOwvdSPnt73JwSQqDGy4dtu4Z0crV7H5aNx2Y7ViWN43THdGS0navs/XFEA4Ah YQ047UgVyxdIh9RrHbeLdpTN7U5mntkv5cbf1h567HwJEx3HDtaB11RHdGkJnXjBV6FYvJNyu zHuxncaw6878KHSpdo5MmhFRKg13DpA4aOSr5YqWn61ocgXqI+HrxEv42w3LrPpv6/AQ12y13 rUqZi95AOqLL10cK1SS09iraaEgBSg314waoD3Ix1b1vM/CqbWX4STdWGpeOPrSI1ptqcl5FR UulD8oj55w/dg1oc/KFkrZPf4O+VxuZjgsJi59LtX886g28oH41ABhngHcP6AX/i5MJgGw2yh ywVxduadXTFLMjhHVBRQo2LekdlkAuP5shTz+KWXTXvmeXwlQfCA0nrUT86Itpslc/8LEU3kr qiM8SUvttfC/a+otF658EaG2DF/Sx08F9MkZwKW9ZW161rl4V9pmZPIwFAS4Q++B6i37iRSP+ m4rd84tbvQfX8BAUDWH9PTwkUnd0pClH4K9GnHotOIKFm1ZZfV9INa9GL238Hn8MVIy3cnYZc X3AIPYJe5gmwK58Q6MVlUBIi6UmIiQVknYDERQxpLcqe0= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 72404 Cc: 72404@debbugs.gnu.org, jm@pub.pink, maurooaranda@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 04 Aug 2024 10:49:52 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: john muhl , juri@linkov.net, maurooaranda@gmail.com, >> 72404@debbugs.gnu.org >> Date: Thu, 01 Aug 2024 19:28:04 +0200 >> >> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman wrote: >> >> I did happen to have a bit more time for this problem, and I think I've >> found the cause, a single line in commit 8d354925ddb: >> >> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >> index 693991a6f3e..aa653549dad 100644 >> --- a/lisp/wid-edit.el >> +++ b/lisp/wid-edit.el >> @@ -2549,7 +2549,8 @@ widget-checklist-add-item >> (t >> (widget-create-child-value >> widget type (car (cdr chosen))) >> - (widget-specify-selected child))))) >> + ;; (widget-specify-selected child) >> + )))) >> (t >> (error "Unknown escape `%c'" escape))))) >> ;; Update properties. >> >> With this line commented out as in the above patch, I get the expected >> value when carrying out Juri's recipe. Moreover, after making that >> change, I then briefly tested customizing the face widget-unselected >> (which the problematic commit added) to inherit from the default face >> and it shows the labels of unselected check boxes in the default face, >> as it should. So maybe deleting the commented out line above and >> leaving the rest of the change is a sufficient fix. But I have to admi= t >> I don't know why that line causes the problem, and I haven't done enoug= h >> testing of this change to the widget-unselected face feature, so this i= s >> just a status report. > > Thanks, I installed the above fix. Thanks, this seems at least a plausible stopgap. > It turns out the same problem also caused bug#72156, so I've now > merged them. > > I'm leaving this bug open, in the hope that you or someone else will > find the root cause for the regression and fix it. I will try to debug it further, but I do hope Mauro or someone else more familiar with the widget and custom code than I am will look into it. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 06:31:27 2025 Received: (at 72404) by debbugs.gnu.org; 1 Jan 2025 11:31:27 +0000 Received: from localhost ([127.0.0.1]:37888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSwwh-0000BD-56 for submit@debbugs.gnu.org; Wed, 01 Jan 2025 06:31:27 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:48492) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tSwwe-0000Az-PX for 72404@debbugs.gnu.org; Wed, 01 Jan 2025 06:31:26 -0500 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-21a1e6fd923so94963105ad.1 for <72404@debbugs.gnu.org>; Wed, 01 Jan 2025 03:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735731078; x=1736335878; darn=debbugs.gnu.org; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3GBguq4ORPlRgv6hy3v8IaqxxoJGhO7i8hGZFy5HrbI=; b=dHGhn5U1v25ReMDgI8l+hTR6Awgx5OhbrR3L4de3dGGcGaO4qviYR34ALol/LnrAy3 beew1oXUEBfiXMRFBB9bzcXkgmJRdXg/DatuNmOq3ARRMTfZJeVFe9dXc6CLpaCkWwi8 UUDfjmWH7eE5b22TT6WQHen3mOC0Ohfhozyd8NeVnwrWCflFP/zkG84fw10W8HWIn43U sfn/RQhw4wAJv+mt/fRBz8WVWikkoUshcsU74K54glRlXZDBeHZ3FE/s41lq8LPhF8Ww FaBtUhGzmDAPhas8OOBYhiEWrLmaY6G51t5UiZZe14SCeL5mkHEkGkXb3arlvU66wHId gTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735731078; x=1736335878; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3GBguq4ORPlRgv6hy3v8IaqxxoJGhO7i8hGZFy5HrbI=; b=EFcBCjYv4D/9GpeQ1TIdM9XR/JPjB8RvCjyXTISjqWVf6qDl0OL64VxwGwz7JuFS8H CDhvvvXYvgv2w52iRx7Kvr6XQayd/eSTnTXIiw0nRDbUj2J+ulB5oafl+xy9EUTwEGQR yTy37TWkx7dOG+fKCMB/bkK1Ap3b5jmPdagMGd/av5+Ou+SozLHprDl0mpMMOQCz1K5C noYZqes/rRVjB0TYOnBe/bT/xmyHa0Bv5Ou1xjW92oueDAqhcNvecMCwpmoXRNiJdYeO XeIRMFEYt7ejprXdWFFoJOHBCusXMbhdDKlof4omLLF3OZVPQwLKd1oPwC1l7GREzRxg ZSRA== X-Gm-Message-State: AOJu0Yy1aFMUHmjaSccYGyWfDa4dePZ75CFNci1smxFmhpL/10jj79dL 6iZhBoOD3vL9Gc+UMD6i8IElgKy1wJL4qaxGcfvQIWsy6jn70fY4e8qRnDxoQgc= X-Gm-Gg: ASbGncsN886ssv0A1faCX8akIPXRgjT//xhDqODZNP0eNn5IsnMJQin1FLhHOKA5Ikz AZccB16bbsUSduuWd5DukTq5FgEO6HVQGhEKkTnKAXmBuJ+uEizqR9rCjd7G+NXuIQ94n1XnaX4 mNRDvBbP5CA+iZ92WISZlrPLo45csj/T7p66JoVX36iNJ1KpDmsfuCwCLz366A1itE4ofN1gpH6 /7dj/tSFETXELVMlnzeMnIu+zrTRMq/SreR6r2KstQ8KGrhb95Twgqlt9tMCw4= X-Google-Smtp-Source: AGHT+IG6xFCNW2fdXUVgvXBdOVqjQMPtq+xfY/N7danAu6V/uccuEUFI4c++UQIUpGj1o9aqwesvcA== X-Received: by 2002:a17:902:dace:b0:216:3732:ade3 with SMTP id d9443c01a7336-219e6f25fd1mr581751735ad.35.1735731078246; Wed, 01 Jan 2025 03:31:18 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02b27sm207084315ad.276.2025.01.01.03.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2025 03:31:17 -0800 (PST) Content-Type: multipart/mixed; boundary="------------qYDWOXk9a5a0FUngty9ZQpji" Message-ID: <48d661cd-a77f-4974-95d8-0672cc1c73e2@gmail.com> Date: Wed, 1 Jan 2025 08:31:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: 72404@debbugs.gnu.org From: Mauro Aranda Subject: Re: bug#72404: 30.0.60; Customization of options is broken X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72404 Cc: Eli Zaretskii , Stephen Berman , jm@pub.pink, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------qYDWOXk9a5a0FUngty9ZQpji Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Stephen Berman writes: > On Sun, 04 Aug 2024 10:49:52 +0300 Eli Zaretskii wrote: > >>> From: Stephen Berman >>> Cc: john muhl , juri@linkov.net,  maurooaranda@gmail.com, >>>   72404@debbugs.gnu.org >>> Date: Thu, 01 Aug 2024 19:28:04 +0200 >>> >>> On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman wrote: >>> >>> I did happen to have a bit more time for this problem, and I think I've >>> found the cause, a single line in commit 8d354925ddb: >>> >>> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >>> index 693991a6f3e..aa653549dad 100644 >>> --- a/lisp/wid-edit.el >>> +++ b/lisp/wid-edit.el >>> @@ -2549,7 +2549,8 @@ widget-checklist-add-item >>>                  (t >>>                   (widget-create-child-value >>>                    widget type (car (cdr chosen))) >>> - (widget-specify-selected child))))) >>> +                             ;; (widget-specify-selected child) >>> +                             )))) >>>             (t >>>          (error "Unknown escape `%c'" escape))))) >>>       ;; Update properties. >>> >>> With this line commented out as in the above patch, I get the expected >>> value when carrying out Juri's recipe.  Moreover, after making that >>> change, I then briefly tested customizing the face widget-unselected >>> (which the problematic commit added) to inherit from the default face >>> and it shows the labels of unselected check boxes in the default face, >>> as it should.  So maybe deleting the commented out line above and >>> leaving the rest of the change is a sufficient fix.  But I have to admit >>> I don't know why that line causes the problem, and I haven't done enough >>> testing of this change to the widget-unselected face feature, so this is >>> just a status report. >> >> Thanks, I installed the above fix. > > Thanks, this seems at least a plausible stopgap. > >> It turns out the same problem also caused bug#72156, so I've now >> merged them. >> >> I'm leaving this bug open, in the hope that you or someone else will >> find the root cause for the regression and fix it. > > I will try to debug it further, but I do hope Mauro or someone else more > familiar with the widget and custom code than I am will look into it. > > Steve Berman Looks to me that it's a matter of order of function calls.  The return value of widget-create-child-value was used for setting child. I found this by using widget-browse-at at the checkbox.  I navigated to the checkbox parent, the set widget, and saw that only the unselected children were specified as children of the set widget. The attached patch should fix it. --------------qYDWOXk9a5a0FUngty9ZQpji Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-checkbox-s-child-creation.patch" Content-Disposition: attachment; filename="0001-Fix-checkbox-s-child-creation.patch" Content-Transfer-Encoding: base64 RnJvbSA4YjFjMTk1NDBjNWVmODczMDYyZTkzODlhY2IxNTZkYWZjNGY4NzVjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFdlZCwgMSBKYW4gMjAyNSAwODoyMjo0NSAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBjaGVja2JveCdzIGNoaWxkIGNyZWF0aW9uCgoqIGxpc3Avd2lkLWVkaXQu ZWwgKHdpZGdldC1jaGVja2xpc3QtYWRkLWl0ZW0pOiBTd2FwIGZ1bmN0aW9uCmNhbGxzIHNv IHRoYXQgY2hpbGQgaXMgYWN0dWFsbHkgYSB3aWRnZXQuICAoQnVnIzcyMTU2KQotLS0KIGxp c3Avd2lkLWVkaXQuZWwgfCA5ICsrKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3dpZC1lZGl0LmVs IGIvbGlzcC93aWQtZWRpdC5lbAppbmRleCBiZjNhMTE0MWJhZi4uM2FjYjc3ZGQ3ZGIgMTAw NjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApAQCAt MjU0OSwxMiArMjU0OSw5IEBAIHdpZGdldC1jaGVja2xpc3QtYWRkLWl0ZW0KIAkJCSAgICAg KHdpZGdldC1jcmVhdGUtY2hpbGQtdmFsdWUKIAkJCSAgICAgIHdpZGdldCB0eXBlIChjZHIg Y2hvc2VuKSkpCiAJCQkgICAgKHQKLQkJCSAgICAgKHdpZGdldC1jcmVhdGUtY2hpbGQtdmFs dWUKLQkJCSAgICAgIHdpZGdldCB0eXBlIChjYXIgKGNkciBjaG9zZW4pKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgOzsgVGhpcyBzb21laG93IGJyZWFrcyA6b3B0aW9ucyBh bmQgb3RoZXIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgQ3VzdG9tIGZlYXR1 cmVzLgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyAod2lkZ2V0LXNwZWNpZnkt c2VsZWN0ZWQgY2hpbGQpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICkpKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdpZGdldC1zcGVjaWZ5LXNlbGVjdGVkIGNo aWxkKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWNyZWF0ZS1jaGls ZC12YWx1ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2lkZ2V0IHR5cGUgKGNh ciAoY2RyIGNob3NlbikpKSkpKSkKIAkgICAgICAgKHQKIAkJKGVycm9yICJVbmtub3duIGVz Y2FwZSBgJWMnIiBlc2NhcGUpKSkpKQogICAgICA7OyBVcGRhdGUgcHJvcGVydGllcy4KLS0g CjIuMzQuMQoK --------------qYDWOXk9a5a0FUngty9ZQpji-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 11 06:57:45 2025 Received: (at 72404-done) by debbugs.gnu.org; 11 Jan 2025 11:57:45 +0000 Received: from localhost ([127.0.0.1]:41621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWa7c-0008Bq-SU for submit@debbugs.gnu.org; Sat, 11 Jan 2025 06:57:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40180) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWa7a-0008BX-Bj for 72404-done@debbugs.gnu.org; Sat, 11 Jan 2025 06:57:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWa7U-0007mU-0I; Sat, 11 Jan 2025 06:57:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DgLwNkFyFGTWoS5xHQeWo257+LUy8MxhfQVQOaMzJ9o=; b=BuTSX7kbD9dfHkjhS/8Y 3TKNDBujywtPwSdCImz7GFdos5aAIRWDXGuULJ4F+TGxATY8SGnQ58WD0lGj00QAQTxhnUItySN2y 5hdc1ulUiXBUUVXXBlfDFkYOZA91asrENkZ/ZJW0RP4aNFeggfNA8sykCMB2YufTNP+6HmUNIBGWv 7K40zabq3aEH5I+o5qIE7KQMKAeXwv1ZHsJRq8EREsJrU+oCSRXxQzT68Of9h6NTLsewWV0hL0GQV JCeuNwu6q7mhfC22G3R02Dq9mMA6t6HsYqHAfiWKFaT2IybHW1e+uIJNNJCARpk67NQ7FEa4k80Eq uQQTLlBGWVRaag==; Date: Sat, 11 Jan 2025 13:57:18 +0200 Message-Id: <868qrhzhpd.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: <48d661cd-a77f-4974-95d8-0672cc1c73e2@gmail.com> (message from Mauro Aranda on Wed, 1 Jan 2025 08:31:14 -0300) Subject: Re: bug#72404: 30.0.60; Customization of options is broken References: <48d661cd-a77f-4974-95d8-0672cc1c73e2@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72404-done Cc: 72404-done@debbugs.gnu.org, stephen.berman@gmx.net, jm@pub.pink, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 1 Jan 2025 08:31:14 -0300 > Cc: Eli Zaretskii , Stephen Berman , > jm@pub.pink, juri@linkov.net > From: Mauro Aranda > > Looks to me that it's a matter of order of function calls.  The return > value of widget-create-child-value was used for setting child. > > I found this by using widget-browse-at at the checkbox.  I navigated to > the checkbox parent, the set widget, and saw that only the unselected > children were specified as children of the set widget. > > The attached patch should fix it. Thanks, installed on the emacs-30 branch, and closing the bug. From unknown Tue Jun 17 01:44:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Feb 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator