Subject: bug#72396: closed (Re: [bug#72396] [PATCH v2 1/2] gnu: Add zycore.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 19 Aug 2024 06:19:03 +0000

Your bug report

#72396: [PATCH 0/2] gnu: Add zydis.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72396: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72396
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#72396] [PATCH v2 1/2] gnu: Add zycore.
From: Zheng Junjie <[email-masked]>
To: guix-patches--- via <[email-masked]>
Cc: [email-masked],Nguyễn Gia Phong <[email-masked]>
Date: Mon, 19 Aug 2024 14:17:33 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

guix-patches--- via <[email-masked]> writes:

> * gnu/packages/engineering.scm (zycore): New variable.
>
> Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
> ---
> On 2024-08-15 at 16:19+02:00, Nicolas Graves wrote:
>> On 2024-07-31 19:14, Nguyễn Gia Phong via wrote:
>>
>> > * gnu/packages/engineering.scm (zycore): New variable.
>> >
>> > +    (synopsis "Internal library for Zydis.")
>> A minor nitpick:
>> [email-masked]: no period allowed at the end of the synopsis
>>
>> Checking `guix lint` would have told you ;)
>>
>> Otherwise LGTM, built and rebuilt deterministically.
>
> Thanks, this revision fixes that.
>
> I cannot get guix lint to tell that to me however
> (I ran `./pre-inst-env guix lint zycore`).
>
>  gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 7a9c0bc436f7..24dc4f0197c7 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -40,6 +40,7 @@
>  ;;; Copyright © 2023 Sharlatan Hellseher <[email-masked]>
>  ;;; Copyright © 2023 pinoaffe <[email-masked]>
>  ;;; Copyright © 2024 Juliana Sims <[email-masked]>
> +;;; Copyright © 2024 Nguyễn Gia Phong <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1927,6 +1928,29 @@ (define-public radare2
>  it suitable for security research and analysis.")
>      (license license:lgpl3)))
>  
> +(define-public zycore
> +  (package
> +    (name "zycore")
> +    (version "1.5.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/zyantific/zycore-c")
> +                    (commit (string-append "v" version))))
> +              (sha256
> +               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
> +              (file-name (git-file-name name version))))

i move file-name before sha256.

> +    (build-system cmake-build-system)
> +    (native-inputs (list googletest))
> +    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
                                        is ZYCORE_BUILD_SHARED_LIB                    
> +                                     "-DZYCORE_BUILD_TESTS=ON")))
 
i adjust to use gexp, and disable ZYCORE_BUILD_TESTS on cross-compilation.

> +    (home-page "https://github.com/zyantific/zycore-c")
> +    (synopsis "Internal library for Zydis")
> +    (description
> +     "This package provides platfrom-independent types, macros
> +and a fallback for environments without libc for Zydis.")
> +    (license license:expat)))
> +
>  (define-public asco
>    (package
>      (name "asco")
>
> base-commit: 41c44ffd5659d13f5c1edb78d92ad27275ead78a

Subject: [PATCH 0/2] gnu: Add zydis.
From: Nguyễn Gia Phong <[email-masked]>
To: [email-masked]
Cc: Nguyễn Gia Phong <[email-masked]>
Date: Wed, 31 Jul 2024 19:12:03 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

Zydis is a library for x86 and amd64 disassembly and decoding.
My goal is to package E9Patch (amd64 binary patching tool)
which depends on it but upstream needs a bit of clean up.

Nguyễn Gia Phong (2):
  gnu: Add zycore.
  gnu: Add zydis.

 gnu/packages/engineering.scm | 55 ++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

base-commit: f59c4126827af3d2041d49f1d0a8ce12b41470cf
-- 
2.45.2