Subject: bug#72387: closed (Re: [bug#72387] Fix reproducible build for readymedia)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 01 Aug 2024 15:57:02 +0000

Your bug report

#72387: Fix reproducible build for readymedia

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72387: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72387
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#72387] Fix reproducible build for readymedia
From: Z572 <[email-masked]>
To: Vagrant Cascadian <[email-masked]>
Cc: [email-masked]
Date: Thu, 01 Aug 2024 23:56:07 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Vagrant Cascadian <[email-masked]> writes:

> The attached patch should fix build reproducibility issues of
> "readymedia" by avoiding embedding the running kernel version of the
> build machine.
>
> This was one of the examples used in the Reproducible Builds patch
> session On July 11th!
>
>   https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024
>
> live well,
>   vagrant
>
> [2. text/x-diff; 0001-gnu-readymedia-Fix-reproducible-build.patch]
> From e40dc4bc9633a44fc10ea49007618a41fa598d99 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <[email-masked]>
> Date: Wed, 3 Jul 2024 14:00:34 -0700
> Subject: [PATCH] gnu: readymedia: Fix reproducible build.
>
> * gnu/packages/upnp.scm (readymedia)[configure-flags]: Avoid embedding kernel
> version.
> ---
>  gnu/packages/upnp.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..5514b3632b 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -150,7 +150,8 @@ (define-public readymedia
>          (base32 "1al04jx72bxwqch1nv9lx536mb6pvj7pgnqzy6lm32q6xa114yr2"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:configure-flags '("--with-os-name=Linux")      ; uname -s
> +     `(#:configure-flags '("--with-os-name=Linux" ; uname -s
> +                           "--with-os-version=") ; uname -r
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-source
>
> base-commit: 2aa0127d4e3d2363c04caab88137b070b6cf1318

Thanks, push, close.

Subject: Fix reproducible build for readymedia
From: Vagrant Cascadian <[email-masked]>
To: [email-masked]
Date: Tue, 30 Jul 2024 16:24:03 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

The attached patch should fix build reproducibility issues of
"readymedia" by avoiding embedding the running kernel version of the
build machine.

This was one of the examples used in the Reproducible Builds patch
session On July 11th!

  https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024

live well,
  vagrant
From e40dc4bc9633a44fc10ea49007618a41fa598d99 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <[email-masked]>
Date: Wed, 3 Jul 2024 14:00:34 -0700
Subject: [PATCH] gnu: readymedia: Fix reproducible build.

* gnu/packages/upnp.scm (readymedia)[configure-flags]: Avoid embedding kernel
version.
---
 gnu/packages/upnp.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
index aab68a6414..5514b3632b 100644
--- a/gnu/packages/upnp.scm
+++ b/gnu/packages/upnp.scm
@@ -150,7 +150,8 @@ (define-public readymedia
         (base32 "1al04jx72bxwqch1nv9lx536mb6pvj7pgnqzy6lm32q6xa114yr2"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:configure-flags '("--with-os-name=Linux")      ; uname -s
+     `(#:configure-flags '("--with-os-name=Linux" ; uname -s
+                           "--with-os-version=") ; uname -r
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-source

base-commit: 2aa0127d4e3d2363c04caab88137b070b6cf1318
-- 
2.39.2