From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 15:52:50 2024 Received: (at submit) by debbugs.gnu.org; 30 Jul 2024 19:52:50 +0000 Received: from localhost ([127.0.0.1]:48522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYstu-0006b1-3d for submit@debbugs.gnu.org; Tue, 30 Jul 2024 15:52:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:40750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1sYstf-0006Zh-EG for submit@debbugs.gnu.org; Tue, 30 Jul 2024 15:52:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sYstQ-0004wn-Lo for bug-guile@gnu.org; Tue, 30 Jul 2024 15:52:20 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sYstP-0006t9-4s for bug-guile@gnu.org; Tue, 30 Jul 2024 15:52:20 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id A4756292CA9; Tue, 30 Jul 2024 19:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1722369120; bh=xMgiYyMlyuOUOMjRUQw6Zo6g18HDxXz+ploM+48xFvY=; h=Date:From:To:Subject; b=KogfoFzHJjYXuCWYsmNV9zN9czgWu6CTJm0mizxURpQHe3cf6SLyZIw95cfy7x8Yy cV9HK5krOjx+d4sB+CgdSCmlGjLDg5ze5JU9BJlWVseVf2foVx3Dw1ppcn8WR2CW6c ONY9DgZ4p9wEVgC6gtPnJRiCduFtaAmWnVQhGxzwV0uqQnC3L06GJYCdTCj/sqpisV nQXWr3gOoBvY5FBr3nc0Kiw2p3cVpUfs/eg027DlRIJIWNA2vXnXm/HhzcPr5HwtMG 7ct9hYQh4GYmkTysmz+nbsVgFouEO3d+dEko3Ahzs5kelTlaeaMIkNvXvN4U95m37B 2aucrdv1Tt1NPptQrhTpTx5kv6PdVXBboexLZs4iuydqfc99f22Yab9BFS+L4R7oXD JtcDle11eE61lKGzVo0hYgJCWcodP/ayuBmuvQhcnIrzwMqUSaQg6+LtXzsrvV3/ZT IyOFEIwbiFhmEaqrjmkpmrprxfL8UW4WbTmeMtAbmUi3kEAqrDp/OrqRW1bt9fnWgq JSG3Pv0UE8dPN786EOSuGt8AVpJVQdHvKhIacowtoOwOA+0zFVA4E0qF2T2OD/EcFX stOlVZYZKwMyWVHgV+mUwYA+sWRzcgJklHMaakqXeVIMXu7nKwMmVV0yBYVFD0buim A9o/y7fgL8FjC5pk0MUOmS6Y= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 5B7622929B0 for ; Tue, 30 Jul 2024 19:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1722369120; bh=xMgiYyMlyuOUOMjRUQw6Zo6g18HDxXz+ploM+48xFvY=; h=Date:From:To:Subject; b=KogfoFzHJjYXuCWYsmNV9zN9czgWu6CTJm0mizxURpQHe3cf6SLyZIw95cfy7x8Yy cV9HK5krOjx+d4sB+CgdSCmlGjLDg5ze5JU9BJlWVseVf2foVx3Dw1ppcn8WR2CW6c ONY9DgZ4p9wEVgC6gtPnJRiCduFtaAmWnVQhGxzwV0uqQnC3L06GJYCdTCj/sqpisV nQXWr3gOoBvY5FBr3nc0Kiw2p3cVpUfs/eg027DlRIJIWNA2vXnXm/HhzcPr5HwtMG 7ct9hYQh4GYmkTysmz+nbsVgFouEO3d+dEko3Ahzs5kelTlaeaMIkNvXvN4U95m37B 2aucrdv1Tt1NPptQrhTpTx5kv6PdVXBboexLZs4iuydqfc99f22Yab9BFS+L4R7oXD JtcDle11eE61lKGzVo0hYgJCWcodP/ayuBmuvQhcnIrzwMqUSaQg6+LtXzsrvV3/ZT IyOFEIwbiFhmEaqrjmkpmrprxfL8UW4WbTmeMtAbmUi3kEAqrDp/OrqRW1bt9fnWgq JSG3Pv0UE8dPN786EOSuGt8AVpJVQdHvKhIacowtoOwOA+0zFVA4E0qF2T2OD/EcFX stOlVZYZKwMyWVHgV+mUwYA+sWRzcgJklHMaakqXeVIMXu7nKwMmVV0yBYVFD0buim A9o/y7fgL8FjC5pk0MUOmS6Y= Date: Tue, 30 Jul 2024 21:52:00 +0200 From: Tomas Volf <~@wolfsden.cz> To: bug-guile@gnu.org Subject: srfi-64: test-end should not clear fail list Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, I think I found a bug in (srfi srfi-64) module shipped with GNU Guile. Reading the specification for test-expect-fail I do not see a mandate to clear expect-fail list on test-end. test-skip does have such provision, but it is lacking in the test-expect-fail. Therefore I think current behavior is wrong: (use-modules (srfi srfi-64)) (test-begin "x") (test-begin "group1") (test-expect-fail "test-a") (test-assert "test-a" #t) (pk (test-result-kind)) (test-end "group1") (test-assert "test-a" #t) (pk (test-result-kind)) (test-end) Leading to: ;;; (xpass) ;;; (pass) Have a nice day Tomas Volf From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 19:39:39 2024 Received: (at 72384) by debbugs.gnu.org; 1 Oct 2024 23:39:39 +0000 Received: from localhost ([127.0.0.1]:54391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svmSw-0000WW-GZ for submit@debbugs.gnu.org; Tue, 01 Oct 2024 19:39:39 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:39344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svmSu-0000WQ-NC for 72384@debbugs.gnu.org; Tue, 01 Oct 2024 19:39:37 -0400 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42cddc969daso8916815e9.1 for <72384@debbugs.gnu.org>; Tue, 01 Oct 2024 16:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727825916; x=1728430716; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=vHe1jSfXzu4vfm/jjNHhVnXPEvrALau8cEjhD3qmQx8=; b=JeYkX7cuZ3umWe4e3emqLg0JUdJ7/Y44DtAQAbCfekPdyKdx27C5a09AkAVN6mrxm6 Ji6oAlFgDfny5ovJmuNokub1UCBiB7iKKZ86mnxpwgcfle0cWRP+HcEjkX0mQ5egbDJp P13Ps1CWtZxKzS3XyyxtiQC3dQ2hhy2FGJZAIp2ElsAzVq8ci3k/uUhg0TukAj7SDfs8 Hz7+5VO8byWqEvof6X6VUNzTr/cYp1ZZuXen0EGgF076tFuwsVR4RGv2+swRwxDS6l6l GPS2j2Ttnw0yVmFzP+iiPVE6VcUt/QWOdEO12Jda8Ega3GeWTBejNTHuIougXpoXcDrV dQiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727825916; x=1728430716; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vHe1jSfXzu4vfm/jjNHhVnXPEvrALau8cEjhD3qmQx8=; b=FeMzAC204kVc3OZVD6qCREbVB7nD9zvGPeoV5qYZCPMSFV6vE9hwbmGRQd1WFFjI4T EDW1JUn3Lx4+C2IMwZE8AaFQxGXZse43lJwMOYOqAKgfa5hyBHaa1iGELy1RvgQbUV2S L7h6iComCHuhY0vHEmN9shr7QP3hCU360o3m9i8WEh3N8gLXma6qMXe1/z+hbXgluX5k GlLA6ncL7KVFIRwq34Ss8z5ipsKtmPU2ZukrmQ+BUueqrnXqT/zEckSIqT8jU8ySpVAt MhHaH1qCnSG6uwF5tR0YgC8ywwX4wXB37Lof9MDftTDGiC3fgyXT4sSYSTALp/VXB0AN ISGw== X-Forwarded-Encrypted: i=1; AJvYcCVxQsUt6Fj6FVhTmQn0KpaBn2dt9XmhqJiHnLXqI/Uvz6wXEMUAZ0itrOCPTHQ0ZRg0d+Iksw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxsgPSG+IqNPnQbHDzkrdzqKhnbPIOuSZ2PfDIjpr9DoeIquf2q IFNwnnyGKgF1POo846j2qAdPEn4cL7y+jAMV9BZ7yIJcGJ3qFW24V2QxZ3NZsnw= X-Google-Smtp-Source: AGHT+IGTEi8t00wLNfcM5nNccwv/y6YQqiIRtu5KvRCFd1MtkNMSEwsKGMcKkWvCdSDZbXOrS3FKAA== X-Received: by 2002:adf:f844:0:b0:37c:d0d6:ab1a with SMTP id ffacd0b85a97d-37cfba19cd5mr299540f8f.12.1727825915995; Tue, 01 Oct 2024 16:38:35 -0700 (PDT) Received: from ?IPV6:2003:106:8f04:c300:95ac:529d:6db3:196b? (p200301068f04c30095ac529d6db3196b.dip0.t-ipconnect.de. [2003:106:8f04:c300:95ac:529d:6db3:196b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c88245e763sm6821226a12.50.2024.10.01.16.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 16:38:34 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------cJzl5h4QALw3IDzoIWWmRazb" Message-ID: <7c410ef8-8c73-4107-940e-dba14273d229@gmail.com> Date: Wed, 2 Oct 2024 01:38:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#72384: srfi-64: test-end should not clear fail list To: Tomas Volf <~@wolfsden.cz>, 72384@debbugs.gnu.org References: Content-Language: en-US From: Taylan Kammer In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72384 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------cJzl5h4QALw3IDzoIWWmRazb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30.07.2024 21:52, Tomas Volf wrote: > Hello, > > I think I found a bug in (srfi srfi-64) module shipped with GNU Guile. > > Reading the specification for test-expect-fail I do not see a mandate to clear > expect-fail list on test-end. test-skip does have such provision, but it is > lacking in the test-expect-fail. Therefore I think current behavior is wrong: > > (use-modules (srfi srfi-64)) > > (test-begin "x") > > (test-begin "group1") > (test-expect-fail "test-a") > (test-assert "test-a" #t) > (pk (test-result-kind)) > (test-end "group1") > (test-assert "test-a" #t) > (pk (test-result-kind)) > > (test-end) > > Leading to: > > ;;; (xpass) > > ;;; (pass) > > Have a nice day > Tomas Volf > > I'm inclined to see this as an error/omission in the spec itself. It makes sense for test-end to clear the expected-fail list, just like it clears the skip list. If it didn't, it might cause one to accidentally mark tests as "expected failure" that weren't meant to be marked as such. Consider the following: (test-group "group1" (test-expect-fail "test-a") (test-assert "test-a" #t)) (test-group "group2" (test-assert "test-a" #t)) Since test-group is equivalent to a pair of test-begin/test-end calls, this code would be very "deceptive" if the implicit test-end didn't clear the expected-fail list. After all, the two groups look completely disjoint, and one wouldn't expect any state from the former to implicitly bleed into the latter. Also, if I'm not mistaken, there's not even a way to clear the expected-fail list explicitly. I actually have some "real-world" code that uses repetitive names in a test suite within different groups, so this isn't just a theoretical issue either:     https://codeberg.org/taylan/scheme-bytestructures/src/branch/master/run-tests.body.scm Notice how often the names "ref" and "set" are used. So, I think the behavior of the reference implementation is correct/desirable here. My implementation of SRFI-64 does the same. - Taylan --------------cJzl5h4QALw3IDzoIWWmRazb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 30.07.2024 21:52, Tomas Volf wrote:
Hello,

I think I found a bug in (srfi srfi-64) module shipped with GNU Guile.

Reading the specification for test-expect-fail I do not see a mandate to clear
expect-fail list on test-end.  test-skip does have such provision, but it is
lacking in the test-expect-fail.  Therefore I think current behavior is wrong:

    (use-modules (srfi srfi-64))

    (test-begin "x")

    (test-begin "group1")
    (test-expect-fail "test-a")
    (test-assert "test-a" #t)
    (pk (test-result-kind))
    (test-end "group1")
    (test-assert "test-a" #t)
    (pk (test-result-kind))

    (test-end)

Leading to:

    ;;; (xpass)

    ;;; (pass)

Have a nice day
Tomas Volf

I'm inclined to see this as an error/omission in the spec itself. It makes sense for test-end to clear the expected-fail list, just like it clears the skip list. If it didn't, it might cause one to accidentally mark tests as "expected failure" that weren't meant to be marked as such. Consider the following:

(test-group "group1"
  (test-expect-fail "test-a")
  (test-assert "test-a" #t))

(test-group "group2"
  (test-assert "test-a" #t))

Since test-group is equivalent to a pair of test-begin/test-end calls, this code would be very "deceptive" if the implicit test-end didn't clear the expected-fail list. After all, the two groups look completely disjoint, and one wouldn't expect any state from the former to implicitly bleed into the latter. Also, if I'm not mistaken, there's not even a way to clear the expected-fail list explicitly.

I actually have some "real-world" code that uses repetitive names in a test suite within different groups, so this isn't just a theoretical issue either:

    https://codeberg.org/taylan/scheme-bytestructures/src/branch/master/run-tests.body.scm

Notice how often the names "ref" and "set" are used.

So, I think the behavior of the reference implementation is correct/desirable here. My implementation of SRFI-64 does the same.

- Taylan

--------------cJzl5h4QALw3IDzoIWWmRazb-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 16:28:43 2024 Received: (at control) by debbugs.gnu.org; 21 Oct 2024 20:28:43 +0000 Received: from localhost ([127.0.0.1]:53472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2z18-0004TV-R2 for submit@debbugs.gnu.org; Mon, 21 Oct 2024 16:28:43 -0400 Received: from wolfsden.cz ([37.205.8.62]:50842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1t2z17-0004TM-3L for control@debbugs.gnu.org; Mon, 21 Oct 2024 16:28:41 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 112E0330159; Mon, 21 Oct 2024 20:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1729542493; bh=L21PmCHKU/O5T7HLfgNpvQoYDF2HbNrXPty/gpSqFo0=; h=Date:To:From:Subject; b=myn5W63XECRwRH2jY73JV+NuJfpnVQRm3yfSLOkW3fM5S/oDAbPQSCP6J6UzLwCcK O2YTIGUWBaRYZfdprfKl3Dpf6eLM6RBb3jSH0WizEa+VeLKCluNa45hqmATzdlItUt 05wOVtMhG5vA+X2DSSAYkRPdx3kPbsJqp5TAlJBlzjZXgf0Z4rPjRBEPL5GC9VScaf V7Jfkm2vjR/LpIsEmrvqwauCFH6EGLCsx6SbsAOwGqHvqmN2ZdEmcfji0CmsJ/BLAb T4pi/L6xggd+9/00fK9iF9eDXfeqpgjU8N2pYnr1I6cc4KXcbFJIQxkmcJlMfhE7zb 0Ji/lV9OdOuO16ZFMawCAviBaqFRYo9W6sm3z9lfDpAXpZ5eymhvTbUG/BIlXOkP3h 6jV+/baSV4pIOK5M4VMAXVqgnHA54dFCNsxXLs058x2z44lUczcwiqBbDGgs267TQu UbU/FWZ9RzxahkdLp4qT/m//91Ta3FKAZAaJIXxfVHmGEOGgE5iVgqbuH7Tcl32e3o mXTnA9qz6m1wNnRu5EdR/byOiliT6tqis5TC/yfFyiHeZOiGFSYaAkcFjtoc1ZAkzW nL/rtNzTaHusMkux+WTYwI9F2u3Svm0FKxC79wsXRI6NWrDzgD5mMJk6Qrvdm30q9V yvzsbooHog9/uSbrh/fZakgY= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [193.32.127.157]) by wolfsden.cz (Postfix) with ESMTPSA id 9F28C330CC2 for ; Mon, 21 Oct 2024 20:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1729542492; bh=L21PmCHKU/O5T7HLfgNpvQoYDF2HbNrXPty/gpSqFo0=; h=Date:To:From:Subject; b=yWg+3XQeFf+O1KXRmPqWp2335srF+mGG6jaRJWIzOey96PSPeEOH1TKBbQCinXi2s Ty9Kxlt5RrteXX3XiTt3S9skGHDxX83RpAZFXvP74W5JKzDEj8OiDr92quV9mtg32r ji7/BdtzraKS6Dxq8K1l4CI4I5++WzE87+4Dj89hU98bAYYVfBj+q5SZr3fKpDKhjG SB1vKwJmjfgKBr/ygDTl3erBoKcqiXBts83ehlG7ZnqW401JDRO1yzy7c4AVX+L1Dk jtJ97ZhGQNkTMcmosjvSLJjx3UDrcaMO7enZRnCxUNm78xIiSVdEc8gdhgR0SDlopN jSCMAd54CzZJFnnk+XUfHUTNdqCPpI0lg7NQfVozV+2IorV/szINVtkqWy6MiH/Soc DS5kWlgzPSNkgbL5RLR7FK5dNjY0B5YbhTK1qR0Evd3vbkCTwtRjM6/JVB3zQAyShp bU2HOrajUSfhkUEBkLSIvbPIlve2x9tQh3cEbslJCchV5VkAGPSI4E0uXruYPN6Ob2 3oUAchmLFgJjO7B/cBgdRTX9E0h/sQB4GqH4/rZzlwe9ww8zGneVz4rPB6gLGtqyLr rkkzN81bed7aH9e0CcX/1LQkc6ZpjWP2VN46xVreMFEzsREQjIpgUv0i0mMO2XnZFr rvJPyCcYbbRBasy9pl2uiKQc= Date: Mon, 21 Oct 2024 22:28:11 +0200 Message-ID: <8eddc6cad428f1c60d6162e80a1d2683@wolfsden.cz> To: control@debbugs.gnu.org From: Tomas Volf <~@wolfsden.cz> Subject: control message for bug #72384 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 72384 quit From unknown Sat Sep 13 02:39:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Nov 2024 12:24:27 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator