Subject: bug#72351: closed (Re: [bug#72351] [PATCH] gnu: nsis: Use scons 3 over scons-python2)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 01 Aug 2024 15:58:02 +0000

Your bug report

#72351: [PATCH] gnu: nsis: Use scons 3 over scons-python2

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72351: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72351
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#72351] [PATCH] gnu: nsis: Use scons 3 over scons-python2
From: Z572 <[email-masked]>
To: Michael Ford <[email-masked]>
Cc: [email-masked]
Date: Thu, 01 Aug 2024 23:57:05 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Michael Ford <[email-masked]> writes:

> Rather than building NSIS with Scons 3 using Python2, switch to Scons
> 3 with Python 3.
>
> From c49419c7dc262f81d664fcab4c7fd200d3627c05 Mon Sep 17 00:00:00 2001
> From: fanquake <[email-masked]>
> Date: Mon, 29 Jul 2024 11:55:07 +0100
> Subject: [PATCH] gnu: nsis: Use scons 3 over scons-python2
>
> ---
>  gnu/packages/installers.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/installers.scm b/gnu/packages/installers.scm
> index d1145a5d58..fb8b71be79 100644
> --- a/gnu/packages/installers.scm
> +++ b/gnu/packages/installers.scm
> @@ -49,7 +49,7 @@ (define (make-nsis machine target-arch nsis-target-type)
>                         ("mingw-w64" ,xlibc)))
>        (inputs (list zlib))
>        (arguments
> -       `(#:scons ,scons-python2
> +       `(#:scons ,scons-3
>           #:modules ((srfi srfi-1)
>                      (srfi srfi-26)
>                      (guix build utils)

thanks, push, close

Subject: [PATCH] gnu: nsis: Use scons 3 over scons-python2
From: Michael Ford <[email-masked]>
To: [email-masked]
Date: Mon, 29 Jul 2024 12:01:05 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Rather than building NSIS with Scons 3 using Python2, switch to Scons
3 with Python 3.

>From c49419c7dc262f81d664fcab4c7fd200d3627c05 Mon Sep 17 00:00:00 2001
From: fanquake <[email-masked]>
Date: Mon, 29 Jul 2024 11:55:07 +0100
Subject: [PATCH] gnu: nsis: Use scons 3 over scons-python2

---
 gnu/packages/installers.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/installers.scm b/gnu/packages/installers.scm
index d1145a5d58..fb8b71be79 100644
--- a/gnu/packages/installers.scm
+++ b/gnu/packages/installers.scm
@@ -49,7 +49,7 @@ (define (make-nsis machine target-arch nsis-target-type)
                        ("mingw-w64" ,xlibc)))
       (inputs (list zlib))
       (arguments
-       `(#:scons ,scons-python2
+       `(#:scons ,scons-3
          #:modules ((srfi srfi-1)
                     (srfi srfi-26)
                     (guix build utils)
-- 
2.45.2