GNU bug report logs - #72349
[PATCH] gnu: Add benchexec.

Previous Next

To reply to this bug, email your comments to 72349 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add benchexec.
Date: Mon, 29 Jul 2024 10:29:37 +0200

* gnu/packages/benchmark.scm (python-benchexec, benchexec): New variable.
---
 gnu/packages/benchmark.scm | 41 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/benchmark.scm b/gnu/packages/benchmark.scm
index bfc70c5d3d..207bd8b949 100644
--- a/gnu/packages/benchmark.scm
+++ b/gnu/packages/benchmark.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages benchmark)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system pyproject)
   #:use-module (guix build-system meson)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
@@ -394,6 +395,46 @@ (define-public phoronix-test-suite
 setup against another one.")
     (license license:gpl3+)))
 
+(define-public python-benchexec
+  (package
+    (name "python-benchexec")
+    (version "3.24")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/sosy-lab/benchexec")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "14yllwinbvifrin29vbm9ibjzswri0isvc6476ygf0whlg90z24j"))))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:test-flags #~(list "--exclude=runexecutor")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'skip-failing-tests
+            (lambda _
+              (delete-file-recursively "benchexec/test_integration"))))))
+    (propagated-inputs (list python-pyyaml))
+    (native-inputs (list coreutils python-lxml python-nose ))
+    (home-page "https://github.com/sosy-lab/benchexec/")
+    (synopsis "Framework for Reliable Benchmarking")
+    (description
+     "BenchExec is a framework for reliable benchmarking, which takes care
+of important low-level details for accurate, precise, and reproducible
+measurements.  In particular, it makes use of cgroups, kernel namespaces,
+and overlay filesystems to restrict interference of the executed tool
+with the benchmarking host.")
+    (license license:asl2.0)))
+
+(define-public benchexec
+  (package/inherit python-benchexec
+    (name "benchexec")
+    (inputs (package-propagated-inputs python-benchexec))
+    (propagated-inputs (list))))
+
 (define-public python-locust
   (package
     (name "python-locust")

base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
-- 
2.45.2

Message #8 received at 72349 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: 72349 <at> debbugs.gnu.org
Cc: liliana.prikler <at> gmail.com, Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: python-benchexec: Update to 3.29.
Date: Tue, 11 Mar 2025 19:35:08 +0000

This patch applies onto #72349. Primarily, in running the quickstart
I needed to have fuse-overlayfs installed.

* gnu/packages/benchmark.scm (python-benchexec): Update to 3.29.
[arguments]<#:phases>: Add 'fix-paths phase.
[propagated-inputs]: Add fuse-overlayfs.
[native-inputs]: Add python-setuptools and python-wheel.

Change-Id: I79916bd559fb7019f2953a0f0502d4f0ab9315eb
---
 gnu/packages/benchmark.scm | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/benchmark.scm b/gnu/packages/benchmark.scm
index 64a11530f00..f6b44dd28e5 100644
--- a/gnu/packages/benchmark.scm
+++ b/gnu/packages/benchmark.scm
@@ -53,6 +53,7 @@ (define-module (gnu packages benchmark)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages kde-frameworks)
+  #:use-module (gnu packages file-systems)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages graphics)
@@ -402,7 +403,7 @@ (define-public phoronix-test-suite
 (define-public python-benchexec
   (package
     (name "python-benchexec")
-    (version "3.24")
+    (version "3.29")
     (source
      (origin
        (method git-fetch)
@@ -411,18 +412,29 @@ (define-public python-benchexec
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "14yllwinbvifrin29vbm9ibjzswri0isvc6476ygf0whlg90z24j"))))
+        (base32 "0vcafk20sg8bwh9qqwf94d6hqk0kq3yhiraknf7jsjisf2mrksjk"))))
     (build-system pyproject-build-system)
     (arguments
      (list
       #:test-flags #~(list "--exclude=runexecutor")
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-paths
+            (lambda* (#:key inputs outputs #:allow-other-keys)
+              (let ((prog (search-input-file inputs "bin/fuse-overlayfs")))
+                (substitute* "benchexec/container.py"
+                  (("shutil.which\\(\"fuse-overlayfs\"\\)")
+                   (string-append "\"" prog "\""))))))
           (add-before 'check 'skip-failing-tests
             (lambda _
               (delete-file-recursively "benchexec/test_integration"))))))
-    (propagated-inputs (list python-pyyaml))
-    (native-inputs (list coreutils python-lxml python-nose ))
+    (propagated-inputs (list fuse-overlayfs python-pyyaml))
+    (native-inputs
+     (list coreutils
+           python-lxml
+           python-nose
+           python-setuptools
+           python-wheel))
     (home-page "https://github.com/sosy-lab/benchexec/")
     (synopsis "Framework for Reliable Benchmarking")
     (description

base-commit: 3bf7a0e8c431abfcba51806ee2a3eea9e0865472
prerequisite-patch-id: 5703b4b5ac086b269f01e2b2e197bd129c9172e5
-- 
2.48.1

Message #11 received at 72349 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Greg Hogan <code <at> greghogan.com>, 72349 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-benchexec: Update to 3.29.
Date: Wed, 12 Mar 2025 08:44:54 +0100

Am Dienstag, dem 11.03.2025 um 19:35 +0000 schrieb Greg Hogan:
> This patch applies onto #72349. Primarily, in running the quickstart
> I needed to have fuse-overlayfs installed.
> 
> * gnu/packages/benchmark.scm (python-benchexec): Update to 3.29.
> [arguments]<#:phases>: Add 'fix-paths phase.
> [propagated-inputs]: Add fuse-overlayfs.
> [native-inputs]: Add python-setuptools and python-wheel.
> 
> Change-Id: I79916bd559fb7019f2953a0f0502d4f0ab9315eb
Have you checked whether you can enable some more tests with fuse-
overlayfs?  I refrained from pushing this package because it appeared
quite broken.

Cheers

Message #14 received at 72349 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 72349 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-benchexec: Update to 3.29.
Date: Sun, 16 Mar 2025 13:18:56 -0400

On Wed, Mar 12, 2025 at 3:43 AM Liliana Marie Prikler
<liliana.prikler <at> gmail.com> wrote:
>
> Am Dienstag, dem 11.03.2025 um 19:35 +0000 schrieb Greg Hogan:
> > This patch applies onto #72349. Primarily, in running the quickstart
> > I needed to have fuse-overlayfs installed.
> >
> > * gnu/packages/benchmark.scm (python-benchexec): Update to 3.29.
> > [arguments]<#:phases>: Add 'fix-paths phase.
> > [propagated-inputs]: Add fuse-overlayfs.
> > [native-inputs]: Add python-setuptools and python-wheel.
> >
> > Change-Id: I79916bd559fb7019f2953a0f0502d4f0ab9315eb
> Have you checked whether you can enable some more tests with fuse-
> overlayfs?  I refrained from pushing this package because it appeared
> quite broken.
>
> Cheers

What do you mean by "pushing this package"? fuse-overlayfs was added
in 2022. Tests on which package, benchexec or fuse-overlayfs?

Message #17 received at 72349 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Greg Hogan <code <at> greghogan.com>
Cc: 72349 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-benchexec: Update to 3.29.
Date: Sun, 16 Mar 2025 18:26:00 +0100

Am Sonntag, dem 16.03.2025 um 13:18 -0400 schrieb Greg Hogan:
> On Wed, Mar 12, 2025 at 3:43 AM Liliana Marie Prikler
> <liliana.prikler <at> gmail.com> wrote:
> > 
> > Am Dienstag, dem 11.03.2025 um 19:35 +0000 schrieb Greg Hogan:
> > > This patch applies onto #72349. Primarily, in running the
> > > quickstart
> > > I needed to have fuse-overlayfs installed.
> > > 
> > > * gnu/packages/benchmark.scm (python-benchexec): Update to 3.29.
> > > [arguments]<#:phases>: Add 'fix-paths phase.
> > > [propagated-inputs]: Add fuse-overlayfs.
> > > [native-inputs]: Add python-setuptools and python-wheel.
> > > 
> > > Change-Id: I79916bd559fb7019f2953a0f0502d4f0ab9315eb
> > Have you checked whether you can enable some more tests with fuse-
> > overlayfs?  I refrained from pushing this package because it
> > appeared quite broken.
> > 
> > Cheers
> 
> What do you mean by "pushing this package"? fuse-overlayfs was added
> in 2022. Tests on which package, benchexec or fuse-overlayfs?
Pardon my brevity, I meant benchexec.  As far as I'm aware, it
shouldn't yet be pushed to Guix, is it?

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.