GNU bug report logs - #72342
[PATCH] services: syncthing: incorrect guessing of HOME variable

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72342: closed ([PATCH] services: syncthing: incorrect
 guessing of HOME variable)
Date: Wed, 21 Aug 2024 17:06:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 21 Aug 2024 19:04:12 +0200
with message-id <87plq1renn.fsf <at> gnu.org>
and subject line Re: [bug#72342] [PATCH] services: syncthing: incorrect guessing of HOME variable
has caused the debbugs.gnu.org bug report #72342,
regarding [PATCH] services: syncthing: incorrect guessing of HOME variable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72342: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72342
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: guix-patches <at> gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH] services: syncthing: incorrect guessing of HOME variable
Date: Sun, 28 Jul 2024 19:09:41 +0200

Fixed the issue described here:
https://lists.gnu.org/archive/html/help-guix/2024-01/msg00034.html

Fix `syncthing-shepherd-service` failing to guess the correct `HOME`
environment variable when it's `<syncthing-configuration>` does not have a
value for the `home` or `user` fields.

Change-Id: I102bfe5feba1ebb349a0cde1c987c0c10ebbab7a
---
Hello.

Ludo asked[1] to send a patch to fix `home-syncthing-service-type` not guessing the correct value
for the `HOME` environment variable. Since the discussions seems stalled, here you
have the patch.

[1]https://lists.gnu.org/archive/html/help-guix/2024-01/msg00050.html

Have a great day!
Sergio.

 gnu/services/syncthing.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/services/syncthing.scm b/gnu/services/syncthing.scm
index 9bb623186b..a7a9c6aadd 100644
--- a/gnu/services/syncthing.scm
+++ b/gnu/services/syncthing.scm
@@ -73,7 +73,15 @@ (define syncthing-shepherd-service
                 #:user #$(and (not home-service?) user)
                 #:group #$(and (not home-service?) group)
                 #:environment-variables
-                (append (list (string-append "HOME=" (or #$home (passwd:dir (getpw #$user))))
+                (append
+                 (list
+                  (string-append "HOME="
+                                 (or #$home
+                                     (passwd:dir
+                                      (getpw (if (and #$home-service?
+                                                      (not #$user))
+                                                 (getuid)
+                                                 #$user)))))
                               "SSL_CERT_DIR=/etc/ssl/certs"
                               "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt")
                         (filter (negate       ;XXX: 'remove' is not in (guile)

base-commit: fdc6274de5b1d617fcabb3f3af9d2c0dd2a6520d
-- 
2.45.2

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Cc: 72342-done <at> debbugs.gnu.org
Subject: Re: [bug#72342] [PATCH] services: syncthing: incorrect guessing of
 HOME variable
Date: Wed, 21 Aug 2024 19:04:12 +0200

Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es> skribis:

> Fixed the issue described here:
> https://lists.gnu.org/archive/html/help-guix/2024-01/msg00034.html
>
> Fix `syncthing-shepherd-service` failing to guess the correct `HOME`
> environment variable when it's `<syncthing-configuration>` does not have a
> value for the `home` or `user` fields.
>
> Change-Id: I102bfe5feba1ebb349a0cde1c987c0c10ebbab7a

I adjusted the commit log and applied it, thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.