GNU bug report logs - #72341
VC: CVS template lines not stripped when committing

Previous Next

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Christoph Badura <bad <at> bsd.de>
Cc: 72341 <at> debbugs.gnu.org
Subject: bug#72341: VC: CVS template lines not stripped when committing
Date: Sat, 15 Feb 2025 09:47:51 -0300

[Message part 1 (text/plain, inline)]

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> Date: Tue, 28 Jan 2025 23:47:56 +0100
>>> From: Christoph Badura <bad <at> bsd.de>
>>>
>>> On Tue, Jan 28, 2025 at 02:23:39PM +0200, Eli Zaretskii wrote:
>>> > The Customize UI will be more helpful if we explicitly mention the
>>> > recommended values together with descriptive tags.
>>>
>>> So, I've just tested this:
>>>   emacs -nw --eval "(customize-group 'log-edit)"
>>>
>>> Search for "done hook".
>>> Be sure to toggle the "More" button and than the "Show value" button on
>>> the line for "Log Edit Done Hook".
>>> With this patch applied there's even a "More" button at the end of the
>>> one-line description of the log-edit-done-strip-cvs-lines option.
>>>
>>> Do you really think that UX needs improving?
>>>
>>> The only thing that annoys me is that when I search for "More", the
>    point
>>> ends up just behind the button and RET doesn't toggle it.  Whereas
>    it does
>>> when it is right before a button.  Fixing that would be a huge
>    improvement
>>> for me.  But this is a separate issue.
>>>
>>> > But I realize that this is a separate issue, so maybe it should 
be the
>>> > subject of a separate patch.  So maybe just mentioning the 3
>>> > recommended values in the doc string will be enough for fixing this
>>> > issue.
>>>
>>> I've made a note in any case.
>>>
>>> I've way overrun my "emacs hacking" time budget for this week.  
I'll get
>>> back to this bug at the end of next week after returning from travel.
>>
>> Mauro, WDYT about this?
>
> I guess you're asking me about actioning the "More" button when point is
> past it, to show the rest of the documentation.
>
> There's already code that handles custom group links that way, in
> Custom-newline (RET is bound to that command).  For example:
> emacs -Q
> M-x customize-group RET vc
> C-s Log-Edit RET
> RET
>
> Emacs follows the link even though point is past the link.
>
> It should be easy to extend it to other links/buttons.

Like in the attached patch, lightly tested.  I can post it in a
different bug report if desired.

[0001-Action-button-when-point-is-just-after-it.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.