Subject: Re: [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies.

From: Zheng Junjie <[email-masked]>
Date: Tue, 30 Jul 2024 13:17:34 +0800

Fabio Natali via Guix-patches via <[email-masked]> writes:

> * gnu/packages/upnp.scm (readymedia)[inputs]: Add coreutils.
>
> Change-Id: I8f73802bd0d8fecbf5ee20853eccefc2eef82411
> ---
> Hi,
>
> This is to add coreutils to ReadyMedia/MiniDLNA's dependencies. Without
> coreutils (and the 'rm' command in particular) some ReadyMedia operations would
> otherwise fail.
>
> Thanks, cheers, Fabio.
>
>  gnu/packages/upnp.scm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..17605d3b96 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -26,6 +26,7 @@
>  (define-module (gnu packages upnp)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages base)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -154,12 +155,17 @@ (define-public readymedia
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-source
> -           (lambda _
> +           (lambda* (#:key inputs #:allow-other-keys)
>               (substitute* "Makefile.am"
> -               ((".*LIBAVUTIL_LIBS.*") "")))))))
> +               ((".*LIBAVUTIL_LIBS.*") ""))
> +             (substitute* "minidlna.c"
> +               (("rm -rf")
> +                (string-append
> +                 (assoc-ref inputs "coreutils") "/bin/rm -rf"))))))))

use (string-append (search-input-file inputs "/bin/rm") " -rf")

>      (native-inputs (list autoconf automake gettext-minimal))
>      (inputs
> -     (list ffmpeg
> +     (list coreutils

please use coreutils-minimal

> +           ffmpeg
>             flac
>             libexif
>             libid3tag
>
> base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a