Subject: bug#72338: closed (Re: [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 01 Aug 2024 15:56:02 +0000

Your bug report

#72338: [PATCH] gnu: readymedia: Add coreutils to dependencies.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
72338: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72338
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies.
From: Z572 <[email-masked]>
To: Fabio Natali via Guix-patches via <[email-masked]>
Cc: [email-masked], Fabio Natali <[email-masked]>
Date: Thu, 01 Aug 2024 23:55:18 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Fabio Natali via Guix-patches via <[email-masked]> writes:

> * gnu/packages/upnp.scm (readymedia)[inputs]: Add coreutils.
>
> Change-Id: I8f73802bd0d8fecbf5ee20853eccefc2eef82411
> ---
> Hi Zheng,
>
> Thanks for reviewing my patch. Please find below an updated version. Let me know
> should you spot anything else. 🙏
>
> Thanks, cheers, Fabio.
>
>  gnu/packages/upnp.scm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..d85e1da956 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -26,6 +26,7 @@
>  (define-module (gnu packages upnp)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages base)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -154,12 +155,17 @@ (define-public readymedia
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-source
> -           (lambda _
> +           (lambda* (#:key inputs #:allow-other-keys)
>               (substitute* "Makefile.am"
> -               ((".*LIBAVUTIL_LIBS.*") "")))))))
> +               ((".*LIBAVUTIL_LIBS.*") ""))
> +             (substitute* "minidlna.c"
> +               (("rm -rf")
> +                (string-append
> +                 (search-input-file inputs "/bin/rm") " -rf"))))))))
>      (native-inputs (list autoconf automake gettext-minimal))
>      (inputs
> -     (list ffmpeg
> +     (list coreutils-minimal
> +           ffmpeg
>             flac
>             libexif
>             libid3tag
>
> base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a

Thanks, push, close.

Subject: [PATCH] gnu: readymedia: Add coreutils to dependencies.
From: Fabio Natali <[email-masked]>
To: [email-masked]
Cc: Fabio Natali <[email-masked]>
Date: Sun, 28 Jul 2024 16:20:30 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/upnp.scm (readymedia)[inputs]: Add coreutils.

Change-Id: I8f73802bd0d8fecbf5ee20853eccefc2eef82411
---
Hi,

This is to add coreutils to ReadyMedia/MiniDLNA's dependencies. Without
coreutils (and the 'rm' command in particular) some ReadyMedia operations would
otherwise fail.

Thanks, cheers, Fabio.

 gnu/packages/upnp.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
index aab68a6414..17605d3b96 100644
--- a/gnu/packages/upnp.scm
+++ b/gnu/packages/upnp.scm
@@ -26,6 +26,7 @@
 (define-module (gnu packages upnp)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
@@ -154,12 +155,17 @@ (define-public readymedia
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-source
-           (lambda _
+           (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "Makefile.am"
-               ((".*LIBAVUTIL_LIBS.*") "")))))))
+               ((".*LIBAVUTIL_LIBS.*") ""))
+             (substitute* "minidlna.c"
+               (("rm -rf")
+                (string-append
+                 (assoc-ref inputs "coreutils") "/bin/rm -rf"))))))))
     (native-inputs (list autoconf automake gettext-minimal))
     (inputs
-     (list ffmpeg
+     (list coreutils
+           ffmpeg
            flac
            libexif
            libid3tag

base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
-- 
2.45.2