GNU bug report logs - #72326
[PATCH] gnu: Add emacs-ssh-deploy.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72326 in the body.
You can then email your comments to 72326 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sisiutl <sisiutl <at> egregore.fun>
To: guix-patches <at> gnu.org
Cc: Sisiutl <sisiutl <at> egregore.fun>
Subject: [PATCH] gnu: Add emacs-ssh-deploy.
Date: Sat, 27 Jul 2024 21:57:07 +0200

* gnu/packages/emacs-xyz.scm (emacs-ssh-deploy): New variable.

Change-Id: I016d3c15f376c099f260d955672bab2b19f8b978
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5639ed5fce..04b4a8af66 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35053,6 +35053,28 @@ (define-public emacs-ssh-agency
 passphrase until the first time you push to a remote.")
     (license license:gpl3+)))
 
+(define-public emacs-ssh-deploy
+  (package
+    (name "emacs-ssh-deploy")
+    (version "3.1.16")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://elpa.gnu.org/packages/ssh-deploy-" version
+                           ".tar"))
+       (sha256
+	(base32 "0fb88l3270d7l808q8x16zcvjgsjbyhgifgv17syfsj0ja63x28p"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/cjohansson/emacs-ssh-deploy")
+    (synopsis "Deployment via Tramp, global or per directory.")
+    (description
+     "ssh-deploy enables automatic deploys on explicit-save actions, manual uploads,
+renaming, deleting, downloads, file and directory differences, launching remote
+terminals (eshell, shell), detection of remote changes, remote directory
+browsing, remote SQL database sessions and running custom deployment scripts via
+Tramp.")
+    (license license:gpl3+)))
+
 (define-public emacs-super-save
   (package
     (name "emacs-super-save")

base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
-- 
2.45.2

Message #8 received at 72326 <at> debbugs.gnu.org (full text, mbox):

From: Suhail Singh <suhailsingh247 <at> gmail.com>
To: Sisiutl <sisiutl <at> egregore.fun>
Cc: 72326 <at> debbugs.gnu.org
Subject: Re: [bug#72326] [PATCH] gnu: Add emacs-ssh-deploy.
Date: Sat, 27 Jul 2024 19:40:05 -0400

Sisiutl <sisiutl <at> egregore.fun> writes:

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://elpa.gnu.org/packages/ssh-deploy-" version
> +                           ".tar"))
> +       (sha256
> +	(base32 "0fb88l3270d7l808q8x16zcvjgsjbyhgifgv17syfsj0ja63x28p"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/cjohansson/emacs-ssh-deploy")

Building from git should be preferred.  The tar archives on ELPA aren't
guaranteed to be bit-for-bit identical over time.  The elpa.gnu.org link
can be, instead, used as the home-page.

> +    (synopsis "Deployment via Tramp, global or per directory.")

Minor nit-pick: synopsis doesn't end with a period.  I think the wording
could probably also be improved.  Quoting the manual:

#+begin_quote
   Synopses must start with a capital letter and must not end with a
period.  They must not start with “a” or “the”, which usually does not
bring anything; for instance, prefer “File-frobbing tool” over “A tool
that frobs files”.  The synopsis should say what the package is—e.g.,
“Core GNU utilities (file, text, shell)”—or what it is used for—e.g.,
the synopsis for GNU grep is “Print lines matching a pattern”.
#+end_quote

-- 
Suhail

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sisiutl <sisiutl <at> egregore.fun>
To: guix-patches <at> gnu.org
Cc: Sisiutl <sisiutl <at> egregore.fun>
Subject: bug#72326: [PATCH v2] gnu: Add emacs-ssh-deploy
Date: Sun, 28 Jul 2024 14:17:42 +0200

* gnu/packages/emacs-xyz.scm (emacs-ssh-deploy): New variable.

Change-Id: Ice4dc774f43b116ffd01c7649f2b212b9fc96fcc
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5639ed5fce..cd94da7a14 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35053,6 +35053,30 @@ (define-public emacs-ssh-agency
 passphrase until the first time you push to a remote.")
     (license license:gpl3+)))
 
+(define-public emacs-ssh-deploy
+  (package
+    (name "emacs-ssh-deploy")
+    (version "3.1.16")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/cjohansson/emacs-ssh-deploy")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0iwciwnlkpbasnwdvvip5g39jq4qc8srfw0s07ljb3c3njg3jhsg"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/cjohansson/emacs-ssh-deploy")
+    (synopsis "A deployment plugin via Tramp, global or per directory")
+    (description
+     "ssh-deploy enables automatic deploys on explicit-save actions, manual uploads,
+renaming, deleting, downloads, file and directory differences, launching remote
+terminals (eshell, shell), detection of remote changes, remote directory
+browsing, remote SQL database sessions and running custom deployment scripts via
+Tramp.")
+    (license license:gpl3+)))
+
 (define-public emacs-super-save
   (package
     (name "emacs-super-save")

base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
-- 
2.45.2

Message #14 received at 72326 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Sisiutl <sisiutl <at> egregore.fun>, 72326 <at> debbugs.gnu.org
Cc: Sisiutl <sisiutl <at> egregore.fun>
Subject: Re: [bug#72326] [PATCH v2] gnu: Add emacs-ssh-deploy
Date: Thu, 15 Aug 2024 16:07:03 +0200

On 2024-07-28 14:17, Sisiutl wrote:
>  
> +    (synopsis "A deployment plugin via Tramp, global or per directory")
> +    (description
> +     "ssh-deploy enables automatic deploys on explicit-save actions, manual uploads,
> +renaming, deleting, downloads, file and directory differences, launching remote
> +terminals (eshell, shell), detection of remote changes, remote directory
> +browsing, remote SQL database sessions and running custom deployment scripts via
> +Tramp.")

Hi Sisiutl, 

Another minor nitpick that you can also find here
https://qa.guix.gnu.org/issue/72326:

description should start with an upper-case letter or digit

You can start the description with @code{ssh-deploy} for instance if
convenient.

Otherwise LGTM, built and rebuilt deterministically.

-- 
Best regards,
Nicolas Graves

Message #19 received at 72326-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 72326-done <at> debbugs.gnu.org
Cc: Sisiutl <sisiutl <at> egregore.fun>, Nicolas Graves <ngraves <at> ngraves.fr>,
 Suhail Singh <suhailsingh247 <at> gmail.com>
Subject: Re: [PATCH] gnu: Add emacs-ssh-deploy.
Date: Tue, 20 Aug 2024 10:27:55 +0200

Hello,

> On 2024-07-28 14:17, Sisiutl wrote:
> >  
> > +    (synopsis "A deployment plugin via Tramp, global or per directory")
> > +    (description
> > +     "ssh-deploy enables automatic deploys on explicit-save actions, manual uploads,
> > +renaming, deleting, downloads, file and directory differences, launching remote
> > +terminals (eshell, shell), detection of remote changes, remote directory
> > +browsing, remote SQL database sessions and running custom deployment scripts via
> > +Tramp.")
> 
> Hi Sisiutl, 
> 
> Another minor nitpick that you can also find here
> https://qa.guix.gnu.org/issue/72326:
> 
> description should start with an upper-case letter or digit
> 
> You can start the description with @code{ssh-deploy} for instance if
> convenient.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.