GNU bug report logs - #72305
[PATCH] Fix DocView's text conversion on tty Emacs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72305: closed ([PATCH] Fix DocView's text conversion on tty
 Emacs)
Date: Sun, 23 Feb 2025 13:45:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 23 Feb 2025 13:44:26 +0000
with message-id <CADwFkmnV00dOSv43ZWq3pL4XzKh5vcCSfmk5L9EKiPFfWOQ+vQ <at> mail.gmail.com>
and subject line Re: bug#72305: [PATCH] Fix DocView's text conversion on tty Emacs
has caused the debbugs.gnu.org bug report #72305,
regarding [PATCH] Fix DocView's text conversion on tty Emacs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72305: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72305
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix DocView's text conversion on tty Emacs
Date: Fri, 26 Jul 2024 17:49:47 +0200

[Message part 3 (text/plain, inline)]

Tags: patch

Hi,

When doing 'M-x doc-view-mode' on document buffer in "emacs -nw", Emacs
proposes to convert this document to the text version and if the user
says "yes" it calls `doc-view-open-text'.

`doc-view-open-text' tries to get the current page by calling the
`doc-view-current-page' but this latter relies on
`image-mode-window-get' which most probably return nil on a tty.

In GNU Emacs 31.0.50 (build 1, x86_64-unknown-openbsd7.5, cairo version
 1.18.0) of 2024-07-26 built on computer
Repository revision: 52cae67e1e73615fff184abcc8e635d80f8846ad
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: OpenBSD computer 7.5 GENERIC.MP#207 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=no --with-cairo
 --without-compress-install'

[0001-Fix-DocView-s-text-conversion-on-tty-Emacs.patch (text/patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
Manuel Giraud

[Message part 6 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 72305-done <at> debbugs.gnu.org, Manuel Giraud <manuel <at> ledu-giraud.fr>
Subject: Re: bug#72305: [PATCH] Fix DocView's text conversion on tty Emacs
Date: Sun, 23 Feb 2025 13:44:26 +0000

Version: 31.1

Tassilo Horn <tsdh <at> gnu.org> writes:

>> Tassilo, any comments on this patch?
>
> It's so simple that it's obviously right.

Thanks, installed on master as commit 09bef781326.

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.