GNU bug report logs - #72297
[PATCH] gnu: libdjinterop: Update to 0.21.0.

Previous Next

To reply to this bug, email your comments to 72297 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
Subject: [PATCH] gnu: libdjinterop: Update to 0.21.0.
Date: Thu, 25 Jul 2024 16:00:30 +0200

* gnu/packages/audio.scm (libdjinterop): Update to 0.21.0.

Signed-off-by: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
Change-Id: I2ec016a0b5851a780746802f8812f1829b50f5c7
---
 gnu/packages/audio.scm | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index b728220e1f..fa566696ab 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2023 Parnikkapore <poomklao <at> yahoo.com>
 ;;; Copyright © 2024 hapster <o.rojon <at> posteo.net>
+;;; Copyright © 2024 Ferran Pujol Camins <me <at> ferranpujolcamins.cat>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1609,7 +1610,7 @@ (define-public swh-plugins-lv2
 (define-public libdjinterop
   (package
     (name "libdjinterop")
-    (version "0.20.2")
+    (version "0.21.0")
     (source
      (origin
        (method git-fetch)
@@ -1618,12 +1619,10 @@ (define-public libdjinterop
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0gbaji3d105vwshjfmnbxqrs42jjjxp41jqj5srncrfv3xmzsfkr"))))
+        (base32 "0rcvp3pwd354zd4rxvai5k14ncq1zvsplqfd37dyw8vx6z81x93v"))))
     (build-system cmake-build-system)
-    (native-inputs
-     (list boost pkg-config))
-    (inputs
-     (list sqlite zlib))
+    (native-inputs (list boost pkg-config))
+    (inputs (list sqlite zlib))
     (home-page "https://github.com/xsco/libdjinterop")
     (synopsis "C++ library for access to DJ record libraries")
     (description
-- 
2.45.2

Message #8 received at 72297 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>, 72297 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: libdjinterop: Update to 0.21.0.
Date: Fri, 26 Jul 2024 22:25:07 +0000

Hi,

Em qui, 2024-07-25 às 16:00 +0200, Ferran Pujol Camins escreveu:
> * gnu/packages/audio.scm (libdjinterop): Update to 0.21.0.
> 

The current release of Mixxx, 2.4.1, expects libdjinterop at 0.20.2:

https://github.com/mixxxdj/mixxx/blob/da261b6f006141fbca8b10490e73ad2211703d20/CMakeLists.txt#L2286

set(LIBDJINTEROP_VERSION 0.20.2)

QA is likely to break here, so this update should wait for the next
release of Mixxx, which will bump libdjinterop to 0.21.0.

> Signed-off-by: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
> Change-Id: I2ec016a0b5851a780746802f8812f1829b50f5c7
> 

Commits are signed by the committer who pushes it, you don't sign your
own.

Regards,

Vinicius

Message #11 received at 72297 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
Cc: 72297 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: libdjinterop: Update to 0.21.0.
Date: Sat, 27 Jul 2024 18:05:07 +0000

Em sáb, 2024-07-27 às 19:02 +0200, Ferran Pujol Camins escreveu:

[...]
> 

> > QA is likely to break here, so this update should wait for the next
> > release of Mixxx, which will bump libdjinterop to 0.21.0.
> > 
> 
> 
> I see. My goal was precisely to have v0.21.0 packaged so I could set
> a guix shell to develop with mixxx main branch. How is this usually
> handled? 
> 

Given that this is simple version bump that doesn't need significant
changes, you can spawn a shell with --with-commit=package=version e.g.

guix shell -D mixxx --with-commit=libdjinterop=0.21.0

See "Package Transformation Options" in the manual:
https://guix.gnu.org/manual/en/html_node/Package-Transformation-Options.html

But if you needed more complex changes in the inputs, you could use
your own packages defined in local files. Create a directory with
Scheme files containing package definitions and add that directory to
the GUIX_PACKAGE_PATH environment variable. Let's say you locally
define 'mylibdjinterop', then you can use a transformation like

guix shell -D mixxx --with-input=libdjinterop=mylibdjinterop

You can find a tutorial for this here:
https://guix.gnu.org/blog/2018/a-packaging-tutorial-for-guix/

Vinicius

Message #14 received at 72297 <at> debbugs.gnu.org (full text, mbox):

From: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 72297 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: libdjinterop: Update to 0.21.0.
Date: Sat, 27 Jul 2024 19:02:18 +0200

[Message part 1 (text/plain, inline)]

>
> Commits are signed by the committer who pushes it, you don't sign your
> own.


Thanks for clarifying. I'll keep this in mind for the future.

QA is likely to break here, so this update should wait for the next
> release of Mixxx, which will bump libdjinterop to 0.21.0.
>

I see. My goal was precisely to have v0.21.0 packaged so I could set a guix
shell to develop with mixxx main branch. How is this usually handled?


On Sat, 27 Jul 2024, 00:26 Vinicius Monego, <monego <at> posteo.net> wrote:

> Hi,
>
> Em qui, 2024-07-25 às 16:00 +0200, Ferran Pujol Camins escreveu:
> > * gnu/packages/audio.scm (libdjinterop): Update to 0.21.0.
> >
>
> The current release of Mixxx, 2.4.1, expects libdjinterop at 0.20.2:
>
>
> https://github.com/mixxxdj/mixxx/blob/da261b6f006141fbca8b10490e73ad2211703d20/CMakeLists.txt#L2286
>
> set(LIBDJINTEROP_VERSION 0.20.2)
>
> QA is likely to break here, so this update should wait for the next
> release of Mixxx, which will bump libdjinterop to 0.21.0.
>
> > Signed-off-by: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
> > Change-Id: I2ec016a0b5851a780746802f8812f1829b50f5c7
> >
>
> Commits are signed by the committer who pushes it, you don't sign your
> own.
>
> Regards,
>
> Vinicius
>

[Message part 2 (text/html, inline)]

Message #17 received at 72297 <at> debbugs.gnu.org (full text, mbox):

From: Ferran Pujol Camins <ferranpujolcamins <at> gmail.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 72297 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: libdjinterop: Update to 0.21.0.
Date: Sun, 28 Jul 2024 11:56:58 +0200

[Message part 1 (text/plain, inline)]

Awesome!

Thank you very much for the explanation!

Best regards, Ferran.

Missatge de Vinicius Monego <monego <at> posteo.net> del dia ds., 27 de jul.
2024 a les 20:06:

> Em sáb, 2024-07-27 às 19:02 +0200, Ferran Pujol Camins escreveu:
>
> [...]
> >
>
> > > QA is likely to break here, so this update should wait for the next
> > > release of Mixxx, which will bump libdjinterop to 0.21.0.
> > >
> >
> >
> > I see. My goal was precisely to have v0.21.0 packaged so I could set
> > a guix shell to develop with mixxx main branch. How is this usually
> > handled?
> >
>
> Given that this is simple version bump that doesn't need significant
> changes, you can spawn a shell with --with-commit=package=version e.g.
>
> guix shell -D mixxx --with-commit=libdjinterop=0.21.0
>
> See "Package Transformation Options" in the manual:
>
> https://guix.gnu.org/manual/en/html_node/Package-Transformation-Options.html
>
> But if you needed more complex changes in the inputs, you could use
> your own packages defined in local files. Create a directory with
> Scheme files containing package definitions and add that directory to
> the GUIX_PACKAGE_PATH environment variable. Let's say you locally
> define 'mylibdjinterop', then you can use a transformation like
>
> guix shell -D mixxx --with-input=libdjinterop=mylibdjinterop
>
> You can find a tutorial for this here:
> https://guix.gnu.org/blog/2018/a-packaging-tutorial-for-guix/
>
> Vinicius
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.