From unknown Mon Jun 23 20:15:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7229 <7229@debbugs.gnu.org> To: bug#7229 <7229@debbugs.gnu.org> Subject: Status: 23.1; ido guess and ffap bug Reply-To: bug#7229 <7229@debbugs.gnu.org> Date: Tue, 24 Jun 2025 03:15:40 +0000 retitle 7229 23.1; ido guess and ffap bug reassign 7229 emacs submitter 7229 "Thibault Kruse" severity 7229 minor tag 7229 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 16 16:51:19 2010 Received: (at submit) by debbugs.gnu.org; 16 Oct 2010 20:51:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7Dio-0005Gz-2H for submit@debbugs.gnu.org; Sat, 16 Oct 2010 16:51:19 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7D01-0004vQ-2N for submit@debbugs.gnu.org; Sat, 16 Oct 2010 16:05:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7D3W-0001R5-Hb for submit@debbugs.gnu.org; Sat, 16 Oct 2010 16:08:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:36122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7D3W-0001R1-Ap for submit@debbugs.gnu.org; Sat, 16 Oct 2010 16:08:38 -0400 Received: from [140.186.70.92] (port=45654 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7D3U-0006Q7-Vg for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 16:08:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7D3T-0001Qk-NP for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 16:08:36 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:60803 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P7D3T-0001QQ-CQ for bug-gnu-emacs@gnu.org; Sat, 16 Oct 2010 16:08:35 -0400 Received: (qmail 6863 invoked by uid 0); 16 Oct 2010 20:08:30 -0000 Received: from 92.230.237.243 by www040.gmx.net with HTTP; Sat, 16 Oct 2010 22:08:28 +0200 (CEST) Content-Type: text/plain; charset="utf-8" Date: Sat, 16 Oct 2010 22:08:28 +0200 From: "Thibault Kruse" Message-ID: <20101016200828.264940@gmx.net> MIME-Version: 1.0 Subject: 23.1; ido guess and ffap bug To: bug-gnu-emacs@gnu.org X-Authenticated: #16585828 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX19qgjd4S6Bqjl4mQfs7OvPhbWGWQCi26H89gAV6mT BPf/+hBF3ipBAGtkes3nNa+VCoTdVJUwwfnQ== Content-Transfer-Encoding: 8bit X-GMX-UID: BDSJeBQuX1V6dFB5kWFyq+N/SDc4NMxl X-FuHaFi: 0.52000000000000002 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 16 Oct 2010 16:51:17 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Hi, the ffap function of ido mode in emacs makes bad guesses after javadoc-style comments: /** and xml node ends to reproduce: emacs -q --no-site-file M-x ido-mode M-x customize-option ido-use-filename-at-point Choose guess, set for current session open *scratch* buffer enter /** cursor at the end of that line M-x ido-find-file (or C-x f): ido suggests /**, instead of pwd enter cursor at the end of that line M-x ido-find-file (or C-x f): ido suggests /, instead of pwd same for M-x ffap In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-03-29 on rothera, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.10706000 configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.utf8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x M-x c u s - o i d o u C-g M-x i d o - u s C-g M-x i d o m o M-x i d o u s f i C-x b s c r / * * C-x C-f C-g M-x i d o m o x M-x M-x C-x b C-x C-f C-g M-x i d o - o f i f i C-g M-x f f a C-g M-x C-x b C-x C-f C-g < t e s t SPC / > M-x f f a C-g M-x r e p o e r t Recent messages: Creating customization setup...done To install your edits, invoke [State] and choose the Set operation Quit [3 times] Creating customization items... Creating customization items ...done Resetting customization items...done Creating customization setup...done To install your edits, invoke [State] and choose the Set operation Quit [2 times] Making completion list... [2 times] -- Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 15:02:55 2010 Received: (at 7229) by debbugs.gnu.org; 24 Oct 2010 19:02:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA5qJ-0006nK-8X for submit@debbugs.gnu.org; Sun, 24 Oct 2010 15:02:55 -0400 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PA5qG-0006nF-LU for 7229@debbugs.gnu.org; Sun, 24 Oct 2010 15:02:53 -0400 Received: (qmail 28590 invoked by uid 0); 24 Oct 2010 19:06:50 -0000 Received: from 92.230.236.20 by www174.gmx.net with HTTP; Sun, 24 Oct 2010 21:06:49 +0200 (CEST) Content-Type: text/plain; charset="utf-8" Date: Sun, 24 Oct 2010 21:06:50 +0200 From: "Thibault Kruse" Message-ID: <20101024190650.135160@gmx.net> MIME-Version: 1.0 Subject: patch To: 7229@debbugs.gnu.org X-Authenticated: #16585828 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX1/hv5tk/PDhF+CotB/v+lEDMGiDxvNfI/40bPSV9f ArRG4b7wagmOCCN9X3kBDnQXR6tLj0vEwrYA== Content-Transfer-Encoding: 8bit X-GMX-UID: 8rH3eKZ9X1V6L1B5kWFy4qR/SDc4NAzL X-FuHaFi: 0.65000000000000002 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 7229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) HI, i dont know where the ffap sources are in emacs 23.1, therefore I could not write a patch myself, but as a workaround, I created this advice. Maybe it can help. (require 'advice) (defadvice ffap-file-at-point (around bugfix-ffap activate) "returns nil when point is somewhere we do not want to guess filenames" (require 'thingatpt) ;;; prevent in javadoc style comments (narrow-to-region (line-beginning-position) (line-end-position)) (unless (or (thing-at-point-looking-at "[\\*]+") ;; for xml modes, not sure about other modes (and (member major-mode '(sgml-mode nxml-mode)) ;; ignore about and (or (thing-at-point-looking-at "")))) ad-do-it)) -- GMX DSL Doppel-Flat ab 19,99 €/mtl.! Jetzt auch mit gratis Notebook-Flat! http://portal.gmx.net/de/go/dsl From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 15:05:48 2010 Received: (at 7229) by debbugs.gnu.org; 24 Oct 2010 19:05:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PA5t5-0006on-Ih for submit@debbugs.gnu.org; Sun, 24 Oct 2010 15:05:47 -0400 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PA5t3-0006oi-Ta for 7229@debbugs.gnu.org; Sun, 24 Oct 2010 15:05:46 -0400 Received: (qmail 2149 invoked by uid 0); 24 Oct 2010 19:09:44 -0000 Received: from 92.230.236.20 by www041.gmx.net with HTTP; Sun, 24 Oct 2010 21:09:43 +0200 (CEST) Content-Type: text/plain; charset="utf-8" Date: Sun, 24 Oct 2010 21:09:43 +0200 From: "Thibault Kruse" Message-ID: <20101024190943.297020@gmx.net> MIME-Version: 1.0 Subject: patch To: 7229@debbugs.gnu.org X-Authenticated: #16585828 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX19Y0SUxAjRYba3/kpF2TomxUytUqUPO2rfYv1U3hp 1eKnwtzBh30c+S4eP9Eph3NXfeLGqgVmmEvg== Content-Transfer-Encoding: 8bit X-GMX-UID: T7PxeHMzTiE+Zxd1mmRwC+J9ZUVSRNdo X-FuHaFi: 0.70999999999999996 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 7229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) sorry, wrong path, narrow-to-region is applied wrongly in my last comment: (require 'advice) (defadvice ffap-file-at-point (around bugfix-ffap activate) "returns nil when point is somewhere we do not want to guess filenames" (require 'thingatpt) ;;; prevent in javadoc style comments (unless (or (thing-at-point-looking-at "[\\*]+") ;; for xml modes (and (member major-mode '(sgml-mode nxml-mode)) ;; don't care about and (or (thing-at-point-looking-at "")))) ad-do-it)) -- Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 11 12:02:12 2011 Received: (at 7229) by debbugs.gnu.org; 11 Mar 2011 17:02:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Py5jA-0008GK-9Q for submit@debbugs.gnu.org; Fri, 11 Mar 2011 12:02:12 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Py5j7-0008G4-01 for 7229@debbugs.gnu.org; Fri, 11 Mar 2011 12:02:10 -0500 Received: (qmail 30118 invoked by uid 0); 11 Mar 2011 17:02:02 -0000 Received: from 131.159.18.102 by www057.gmx.net with HTTP; Fri, 11 Mar 2011 18:02:00 +0100 (CET) Content-Type: text/plain; charset="utf-8" Date: Fri, 11 Mar 2011 18:02:00 +0100 From: "Thibault Kruse" Message-ID: <20110311170200.163250@gmx.net> MIME-Version: 1.0 Subject: further patch To: 7229@debbugs.gnu.org X-Authenticated: #16585828 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX1+6MGolB4G6CPr4OmVg7XEbgfuz0G9KXdzvDeF66f LqiZVD7NJELSae166GIRf/yOistEhFE6agxg== Content-Transfer-Encoding: 8bit X-GMX-UID: 5jgYGYIfbXB+RgFmzzQ2PlwiLyUmZUgp X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) More things that annoy me, patched, and missed closing ">" in xml mode: ;; ignore shebang lines like #!/bin/bash (thing-at-point-looking-at "#!/[a-zA-Z0-9:_.-/]+") (and (member major-mode '(sgml-mode nxml-mode)) ;; don't care about and (or (thing-at-point-looking-at "?") (thing-at-point-looking-at "/>")))) -- NEU: FreePhone - kostenlos mobil telefonieren und surfen! Jetzt informieren: http://www.gmx.net/de/go/freephone From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 11 12:23:48 2013 Received: (at 7229) by debbugs.gnu.org; 11 Jul 2013 16:23:48 +0000 Received: from localhost ([127.0.0.1]:48191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxJel-00030i-20 for submit@debbugs.gnu.org; Thu, 11 Jul 2013 12:23:47 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:49828) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxJeh-00030R-OU for 7229@debbugs.gnu.org; Thu, 11 Jul 2013 12:23:44 -0400 Received: by mail-pd0-f170.google.com with SMTP id x11so7679956pdj.29 for <7229@debbugs.gnu.org>; Thu, 11 Jul 2013 09:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=OLNbiwuQ64scPKnS0kRpJEy7Xpd9T1JzVYB/gvVUAhU=; b=Oc8KeDt5SOE9SQyg9R7oPNkoOrGosUenABwleWOFKAI8da7KUU4ATGstUeIagEPZy9 8CRF+qdieHvAtkzm5/5SdiaW6hLw/VKwCwzEYtiB8Q8WGlH7VMHF002JbI/DXaABENUo LaqCNDySQLFpezR7eP2Nv8E38hsYiUhkQUCMaPECmXUL4nxw2fPQdvrtg7WK8Zt/DM1f enHTb9sA5Xkb4cPBzEPidAUtnyQVjEw/R7oooKQEju2C18ImpHyWZIyPZh03BehoO2Ua gfd7sKoe2eL8XufNThLKCmD/xvMcy2atRmFGZf6IN48wQesZUVE7fMtZdzvUzqzK+TUQ 9z1Q== X-Received: by 10.66.162.102 with SMTP id xz6mr39768287pab.0.1373559817917; Thu, 11 Jul 2013 09:23:37 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id vb8sm40530178pbc.11.2013.07.11.09.23.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Jul 2013 09:23:37 -0700 (PDT) From: Leo Liu To: "Thibault Kruse" Subject: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Fri, 12 Jul 2013 00:23:33 +0800 In-Reply-To: <20101016200828.264940@gmx.net> (Thibault Kruse's message of "Sat, 16 Oct 2010 22:08:28 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 7229 Cc: 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2010-10-17 04:08 +0800, Thibault Kruse wrote: > enter /** > cursor at the end of that line > M-x ido-find-file (or C-x f): ido suggests /**, instead of pwd > enter > cursor at the end of that line > M-x ido-find-file (or C-x f): ido suggests /, instead of pwd > > same for M-x ffap I don't see any bugs here. ido and ffap seem working consistently per your request (/** and / are valid file names). Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 11 21:20:51 2013 Received: (at 7229) by debbugs.gnu.org; 12 Jul 2013 01:20:52 +0000 Received: from localhost ([127.0.0.1]:48972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxS2V-0004Or-1f for submit@debbugs.gnu.org; Thu, 11 Jul 2013 21:20:51 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:46540) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxS2S-0004Ob-8k for 7229@debbugs.gnu.org; Thu, 11 Jul 2013 21:20:49 -0400 Received: by mail-pa0-f43.google.com with SMTP id hz11so8390148pad.30 for <7229@debbugs.gnu.org>; Thu, 11 Jul 2013 18:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:face:date:message-id:user-agent:mime-version :content-type:content-disposition; bh=naVXA80mgaQZuGkNcgX7HWHNjH/6Yfgz549T9HT0CG0=; b=nQz7EpGfmw0Mrsi+yACZHH4EPj8kkF7YEITgg9KP+3cthJAXdtE471oxgHRfYsnkin F8UjYzzhmwAj61gswd151f8uqge0GBGS+Sb6gYJ14z4mAf6SvJp6IT/7ej0qOGbmACSC q5LUCenTzyXDkrQo1vTdtqH8XGGSWAs3AIBCrbK8FXqy0236OXRVlW2/E8/rxN+DEJ+5 76Mk/eFcUQt+e5psqxSymubcDn1pQGWp+Unb/qrC5sV19WrAle3TWeixsP9WygGVWT4/ HigpJySWlauLw7m9IxgJgyAovfSfdaYBxjhEqo8znRQGOoWXPHpBtgZqHIf8D/0/0WLN J9ww== X-Received: by 10.68.95.66 with SMTP id di2mr38467106pbb.180.1373592042282; Thu, 11 Jul 2013 18:20:42 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id tr10sm11026901pbc.22.2013.07.11.18.20.38 for <7229@debbugs.gnu.org> (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Jul 2013 18:20:41 -0700 (PDT) From: Leo Liu To: 7229@debbugs.gnu.org Subject: Re: bug#7229: 23.1; ido guess and ffap bug Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Fri, 12 Jul 2013 09:20:33 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: message/rfc822 Content-Disposition: inline X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Wow, that's almost 3 years ago. Thanks for even rlooking into it. Then maybe call it sub-optimal default behavior instead of a bug. If that kind of consistency is most important, then my request is invalid. However IMHO, out of 1000 times a user presses C-x f after "/**", he will in 1000 cases not intent to open a file called /**, even if such a file could exist. So I would tend towards making the tool do what the user wants, not what is most consistent in theory, but that may just be me. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sdl.web[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.43 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 FAKE_REPLY_C FAKE_REPLY_C X-Debbugs-Envelope-To: 7229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Wow, that's almost 3 years ago. Thanks for even rlooking into it. Then maybe call it sub-optimal default behavior instead of a bug. If that kind of consistency is most important, then my request is invalid. However IMHO, out of 1000 times a user presses C-x f after "/**", he will in 1000 cases not intent to open a file called /**, even if such a file could exist. So I would tend towards making the tool do what the user wants, not what is most consistent in theory, but that may just be me. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.43 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sdl.web[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 FAKE_REPLY_C FAKE_REPLY_C Delivered-To: sdl.web@gmail.com Received: by 10.68.241.133 with SMTP id wi5csp88969pbc; Thu, 11 Jul 2013 16:50:58 -0700 (PDT) X-Received: by 10.15.107.6 with SMTP id ca6mr43608636eeb.120.1373586657968; Thu, 11 Jul 2013 16:50:57 -0700 (PDT) Return-Path: Received: from mout.gmx.net (mout.gmx.net. [212.227.15.19]) by mx.google.com with ESMTP id u9si30665352eeg.141.2013.07.11.16.50.57 for ; Thu, 11 Jul 2013 16:50:57 -0700 (PDT) Received-SPF: pass (google.com: domain of thibault.kruse@gmx.de designates 212.227.15.19 as permitted sender) client-ip=212.227.15.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of thibault.kruse@gmx.de designates 212.227.15.19 as permitted sender) smtp.mail=thibault.kruse@gmx.de Received: from 3capp-gmx-bs54.server.lan ([172.19.170.138]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MXTLc-1UiYmF0ZOQ-00WXfc for ; Fri, 12 Jul 2013 01:50:57 +0200 Received: from [92.231.51.19] by 3capp-gmx-bs54.server.lan with HTTP; Fri Jul 12 01:50:57 CEST 2013 Message-ID: From: "Thibault Kruse" To: "Leo Liu" Subject: Aw: Re: bug#7229: 23.1; ido guess and ffap bug Date: Fri, 12 Jul 2013 01:50:57 +0200 (CEST) Importance: normal Sensitivity: Normal In-Reply-To: References: <20101016200828.264940@gmx.net>, X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K0:bfB5AuvMA1M0eO0JarIWF6crEhcxF0C9IDG3MU+FLds UXu+LO+OCOL0CTwgr48ipkn7FsgkcUa747kMpOcW7z+KCgyH9q WZRCdRppL9qAfKs63F+/+srwv6xSS7YNv416o74/9QhRpoBUNh y4+yX2VEWaHTXA2EM+WXt0tXr9redmrKT3KclsC1daiv69L3cC R9v/YTWahK24Od2tRekhf/3G9GKMH6Mfbk3V9AEWWuMq5tIl4s HpyVp1VGt9NkfKM+Xs/NQ/0vwuv4hMy6FJyTGS7ay4a5/GKuzA X0SXnE= MIME-Version: 1.0 Content-Type: text/html; charset=utf-8 Wow, that's almost 3 years ago. Thanks for even rlooking into it.

Then maybe call it sub-optimal default behavior instead of a bug.
If that kind of consistency is most important, then my request is invalid.
However IMHO, out of 1000 times a user presses C-x f after "/**", he will in 1000 cases not intent to open a file called /**, even if such a file could exist. So I would tend towards making the tool do what the user wants, not what is most consistent in theory, but that may just be me.

In the second case, the cursor is not on '/', but on '/>'. Suggesting '/' instead of nothing, ignoring the '>' character seems bad to me, though maybe it is consistent with some other behavior. Close as "wont fix" by all means if my position is not persuasive.

Gesendet: Donnerstag, 11. Juli 2013 um 18:23 Uhr
Von: "Leo Liu" <sdl.web@gmail.com>
An: "Thibault Kruse" <thibault.kruse@gmx.de>
Cc: 7229@debbugs.gnu.org
Betreff: Re: bug#7229: 23.1; ido guess and ffap bug
On 2010-10-17 04:08 +0800, Thibault Kruse wrote:
> enter /**
> cursor at the end of that line
> M-x ido-find-file (or C-x f): ido suggests /**, instead of pwd
> enter <test />
> cursor at the end of that line
> M-x ido-find-file (or C-x f): ido suggests /, instead of pwd
>
> same for M-x ffap

I don't see any bugs here. ido and ffap seem working consistently per
your request (/** and / are valid file names).

Leo

From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 11 21:43:56 2013 Received: (at 7229) by debbugs.gnu.org; 12 Jul 2013 01:43:56 +0000 Received: from localhost ([127.0.0.1]:48980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxSOq-0005AC-IQ for submit@debbugs.gnu.org; Thu, 11 Jul 2013 21:43:56 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:62767) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxSOo-00059x-FW for 7229@debbugs.gnu.org; Thu, 11 Jul 2013 21:43:55 -0400 Received: by mail-pd0-f180.google.com with SMTP id 10so8033981pdi.25 for <7229@debbugs.gnu.org>; Thu, 11 Jul 2013 18:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=WbUx1knFPdxOQ+IU95/qsBJ37ncvZC4MLnkKcBS7PCw=; b=Ld3vHNClIXH61VyEHvwBHmB4g5KansLF0A7+lq0aVZ513yNe4CrWOX7Gz14UcSjTTj vky4thHy8bJ+rgrkKQpDavICJtAWvwwJXd3NjlM2RxpYlBiKuxPGsIRZLhBUZNGcU2ah W6VK7qt9443C7sK1Eh9eXGlordRByAAWsKMYsPLsG1uOsJTyGfamkARbwaXO4H3AVhIV a1C5VKC0kVu921mEPSrzarINAeIWjXgal1nkFk9cdJbmKcgOXewxRzz0icfu1hhwYgNi w6s/mUbd6W7mu5ctJBKN0PV/Rl7AlXYOwQOtuXx+JkQtikt5J029LqRCEf0hIhv/Ty4G Ydgw== X-Received: by 10.68.28.232 with SMTP id e8mr39671928pbh.94.1373593428320; Thu, 11 Jul 2013 18:43:48 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id vu5sm44962611pab.10.2013.07.11.18.43.44 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Jul 2013 18:43:47 -0700 (PDT) From: Leo Liu To: "Thibault Kruse" Subject: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Fri, 12 Jul 2013 09:43:33 +0800 In-Reply-To: (Leo Liu's message of "Fri, 12 Jul 2013 09:20:33 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 7229 Cc: 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2013-07-12 09:20 +0800, Leo Liu wrote: > Then maybe call it sub-optimal default behavior instead of a bug. >From my experience I agree. I enabled ido-use-url-at-point and ido-use-filename-at-point for a while and was constantly annoyed by false positives and negatives. I have set both to nil in the last few years. Maybe the feature can be changed this way: 1. remove both ido-use-url-at-point and ido-use-filename-at-point 2. when ido-find-file is invoked with prefix, use ffap. You can experiment this with the following: (setq ido-use-filename-at-point nil ido-use-url-at-point nil) (defadvice ido-file-internal (around ffap activate) "When called with a prefix, use `ffap' instead." (if current-prefix-arg (ffap) ad-do-it)) Let me know if this is a good idea and should be part of ido.el. Thanks. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 12 03:48:47 2013 Received: (at 7229) by debbugs.gnu.org; 12 Jul 2013 07:48:47 +0000 Received: from localhost ([127.0.0.1]:49461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxY5u-0002Un-5e for submit@debbugs.gnu.org; Fri, 12 Jul 2013 03:48:46 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:49883) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxY5r-0002UO-Oe for 7229@debbugs.gnu.org; Fri, 12 Jul 2013 03:48:44 -0400 Received: by mail-pb0-f46.google.com with SMTP id rq2so8814143pbb.33 for <7229@debbugs.gnu.org>; Fri, 12 Jul 2013 00:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=aymhZQeweYp8bdaT/izcqGzy/gO3NLIkysf78RvaxZA=; b=II2PdX5HOugcmkXsmpG+yI8Ik19oxdsPNLIj3reG4fjbJvh0+dSvYHvh5ptRKTr/zw dBxEBQwb8NZCakKXHxQgVfhF2frJmrdQ5lUh07/ovWzzg4xSc1lfxAwhGBV8QqwxXSwe hxM2U3ygiyhar6YmLJM8n0SizxAFDwMTnb5IpwVb3HDOZAfROicxB+jwREZcrY5wd+pC aofRwTzRWbDYuN4ErswseSfnJ49/pZfTAynXIb5OLpjkOpqJ09ku+J04y/5UQgIBX2in EyxwWZUiYjpaQlwrwhSXF+jA2il/zKz+87ADWe88DDIW/LP250oj/m73uE68mzv+2lci w9CA== X-Received: by 10.68.226.234 with SMTP id rv10mr5381547pbc.1.1373615317694; Fri, 12 Jul 2013 00:48:37 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id i16sm46617171pag.18.2013.07.12.00.48.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Jul 2013 00:48:37 -0700 (PDT) From: Leo Liu To: "Thibault Kruse" Subject: Re: Aw: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Fri, 12 Jul 2013 15:48:29 +0800 In-Reply-To: (Thibault Kruse's message of "Fri, 12 Jul 2013 09:36:19 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 7229 Cc: 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Please CC the bug address. On 2013-07-12 15:36 +0800, Thibault Kruse wrote: > It seems that for me, doing so always yields a curent-prefix-arg that > is nil, not sure why. Do you have ffap settings that interfere? Do you try with emacs -q? Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 12 19:03:44 2013 Received: (at 7229) by debbugs.gnu.org; 12 Jul 2013 23:03:44 +0000 Received: from localhost ([127.0.0.1]:51394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxmNL-0002ij-8z for submit@debbugs.gnu.org; Fri, 12 Jul 2013 19:03:43 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:53995) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxmNH-0002iM-S6 for 7229@debbugs.gnu.org; Fri, 12 Jul 2013 19:03:40 -0400 Received: by mail-la0-f47.google.com with SMTP id fe20so7985859lab.6 for <7229@debbugs.gnu.org>; Fri, 12 Jul 2013 16:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:user-agent:date:message-id :mime-version:content-type:x-antivirus:x-antivirus-status; bh=hWaJLcPjUldtCp/wQc2BnkwZrJEDf8ez3qVliKWi0e0=; b=ZqCZSoKQUlx/iGuKrzgve0juqFbzFWUof67cYamrkAT7Lw08h64TMuSGchzoNXbCCd 4H9O0boq+qBaZSRAHPAn9yqa4nXx0jQWE0IKiR1QXvd9QM2FkJVfkCzFZQDWD9cRjX6d +j4aPPyVny8qEy021AC1tCiX1kwoQR5TOLlKLiwaoEVZWkUCa/dLTIdcuk2WVmBoScov VhUwYtIv6m6SzjFbtOUWMiMTxxyeunPyIzR/scYt5YrlhR6c21NS5oNsa/ja1WuVyQZp kdbeg1I9/h0xApt4trao5Aeh+Y64hGoAZCscQCPdqoAvRxoFFTuSbHIL7A23QH64lJB8 p9Pw== X-Received: by 10.152.121.73 with SMTP id li9mr20670313lab.42.1373670213702; Fri, 12 Jul 2013 16:03:33 -0700 (PDT) Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPSA id e5sm14649457lbw.3.2013.07.12.16.03.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 12 Jul 2013 16:03:32 -0700 (PDT) From: Dmitry Gutov To: Leo Liu Subject: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) Date: Sat, 13 Jul 2013 03:03:28 +0400 Message-ID: <8761wfpein.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-Antivirus: avast! (VPS 130712-1, 12.07.2013), Outbound message X-Antivirus-Status: Clean X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 7229 Cc: Thibault Kruse , 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Leo Liu writes: > On 2010-10-17 04:08 +0800, Thibault Kruse wrote: >> enter /** >> cursor at the end of that line >> M-x ido-find-file (or C-x f): ido suggests /**, instead of pwd >> enter >> cursor at the end of that line >> M-x ido-find-file (or C-x f): ido suggests /, instead of pwd >> >> same for M-x ffap > > I don't see any bugs here. ido and ffap seem working consistently per > your request (/** and / are valid file names). Maybe we should be able to restrict `ffap-file-at-point' to local files (which it checks for existence). After all, the variable that enables this behavior is called `ido-use-filename-at-point', and the description does not tell you that the thing at point could be interpreted as a remote URL. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 12 21:21:08 2013 Received: (at 7229) by debbugs.gnu.org; 13 Jul 2013 01:21:08 +0000 Received: from localhost ([127.0.0.1]:51614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxoWK-0007db-Ah for submit@debbugs.gnu.org; Fri, 12 Jul 2013 21:21:08 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:46647) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxoWI-0007cs-Jv for 7229@debbugs.gnu.org; Fri, 12 Jul 2013 21:21:07 -0400 Received: by mail-pb0-f49.google.com with SMTP id jt11so9472796pbb.8 for <7229@debbugs.gnu.org>; Fri, 12 Jul 2013 18:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=gTABQBMQ3f8gX3EMWNlvrTbn0xU3YxRUYsewzldREcE=; b=RCyZjwwJeV6U5WhY+QbNxzNrfua0EYn3iTZeu2D8Ypoet69P9BwdT7yd/zn664uIUY yDqaZ+m/MNCUMg8z7Q7EodI79CSbpjzEHq6e6mFBf3zEROQfQdG/3wlI6pihmYNhwZDe gFH4iX1Lc5ge0djOzG1DZfOkPDbSQKBwU1hvRjWzMi2hUbCrLWc6kQnMGqo/+Sv2Q90e 5VKi7fDSK8BQPIosX7/v+R9aj0P9lB1s9HiLSYjfWJCBBJZfy6Ia/kX85qyGSm/APR+7 K75FunfHrR87U9ow3tYATMLzQJc44AkZLl3IoR6oBFSkao8j3lidajtnHX5FWT7qrENP tl2Q== X-Received: by 10.66.189.225 with SMTP id gl1mr46132357pac.22.1373678460567; Fri, 12 Jul 2013 18:21:00 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id zv11sm50751879pab.3.2013.07.12.18.20.58 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Jul 2013 18:21:00 -0700 (PDT) From: Leo Liu To: Dmitry Gutov Subject: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> <8761wfpein.fsf@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Sat, 13 Jul 2013 09:20:54 +0800 In-Reply-To: <8761wfpein.fsf@yandex.ru> (Dmitry Gutov's message of "Sat, 13 Jul 2013 03:03:28 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 7229 Cc: Thibault Kruse , 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2013-07-13 07:03 +0800, Dmitry Gutov wrote: > Maybe we should be able to restrict `ffap-file-at-point' to local files > (which it checks for existence). > > After all, the variable that enables this behavior is called > `ido-use-filename-at-point', and the description does not tell you that > the thing at point could be interpreted as a remote URL. Is ffap-url-regexp enough? Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 12 21:25:25 2013 Received: (at 7229) by debbugs.gnu.org; 13 Jul 2013 01:25:25 +0000 Received: from localhost ([127.0.0.1]:51621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxoaT-0007nF-2r for submit@debbugs.gnu.org; Fri, 12 Jul 2013 21:25:25 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:38789) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxoaQ-0007mw-N5 for 7229@debbugs.gnu.org; Fri, 12 Jul 2013 21:25:23 -0400 Received: by mail-pb0-f41.google.com with SMTP id rp16so9595276pbb.14 for <7229@debbugs.gnu.org>; Fri, 12 Jul 2013 18:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=Ok/2YnLNT9kUKgivSDpksdPqcDB155A1JHxYoTOkfwE=; b=vs68lkOBBKBOnuzIg6uAHU8EjdesV2Fu8rWwuPZqmrGi9vG+Iuwy6dpw9ochuv8uZ2 agPiZ6wt80fELy4xD6PCYCuhTGKe4aquju6pRsCqr3EIPLr7FqD8iDE/tohiJU+g9lWr nG9yqNhGVmdr43LzthomlECC3+w15TfydijeNlbUiNF1kktHAmmbRY60MNZ/y7N/ado+ crzjFlwxmQgbtTOXCMyXKFnb0l0AerogWlehYiLu+egqH83fZubIBAztKVR8u0s+IW+q FVykKdY+zOydXsrCp8OUkIWSmg45GBjElZVfiUCHUIgTvthdVrKL++80YKr2vbC/Jboy Fl0w== X-Received: by 10.66.51.102 with SMTP id j6mr4953350pao.80.1373678716985; Fri, 12 Jul 2013 18:25:16 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id vi8sm39265437pbc.31.2013.07.12.18.25.14 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Jul 2013 18:25:16 -0700 (PDT) From: Leo Liu To: "Thibault Kruse" Subject: Re: Aw: Re: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Sat, 13 Jul 2013 09:25:12 +0800 In-Reply-To: (Thibault Kruse's message of "Fri, 12 Jul 2013 09:52:47 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 7229 Cc: 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 7229@debbugs.gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2013-07-12 15:52 +0800, Thibault Kruse wrote: > I tried: > emacs -q --no-site-file > M-x ido-mode > M-x ielm > pasted the lines you gave > switch to scratch buffer > typed "~/local" which exists > press C-x C-f Instead of C-x C-f, Try C-u C-x C-f. > no prefix is used, ido just shows ~ > debugger also indicates the prefix var is nil Please please write to the bug address 7229@debbugs.gnu.org instead of my email. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 12 21:28:13 2013 Received: (at 7229) by debbugs.gnu.org; 13 Jul 2013 01:28:13 +0000 Received: from localhost ([127.0.0.1]:51629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UxodB-0007uB-0y for submit@debbugs.gnu.org; Fri, 12 Jul 2013 21:28:13 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:60167) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uxod9-0007tv-Pt for 7229@debbugs.gnu.org; Fri, 12 Jul 2013 21:28:12 -0400 Received: by mail-lb0-f182.google.com with SMTP id r11so8122949lbv.13 for <7229@debbugs.gnu.org>; Fri, 12 Jul 2013 18:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-antivirus:x-antivirus-status; bh=SqUeGMx5nz1VoNMEwA+FxByQeNE15pFCWa1gX0YdB/o=; b=v6latNcmxnNiF2DvV0JGloYV1a0oo2MG4pNDsiXGdJjWrAHjIkFi6o9h6WPLJmSDXI aohsOo5kU8NtC9RZ0iuRFhJrryA39hMAhcLL6W+1Bo7e7m7tde6ewBd4W/QjrtN7UQ7U ZrkSOtZCqZepdVx13rNWaNoR0Y45SZSaBe2oNb8Ol+N3543ltUl5TC9dVdic1gm+RyBa UFcxwJWKftDOGSUqLTWioguBh0tWituvCYLbPtT/uQOZGCV2CL4V7AwDFbfIct29+zg3 or9ni18CETGssUSXTyXBYEXEgo4TgmgVenp7kXebv42lQxebg/NF67zy0qPsxnk18/zd 9RvQ== X-Received: by 10.152.23.99 with SMTP id l3mr20317391laf.82.1373678885293; Fri, 12 Jul 2013 18:28:05 -0700 (PDT) Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id c4sm15260665lae.7.2013.07.12.18.28.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 12 Jul 2013 18:28:04 -0700 (PDT) Message-ID: <51E0AD24.9010504@yandex.ru> Date: Sat, 13 Jul 2013 05:28:04 +0400 From: Dmitry Gutov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Leo Liu Subject: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> <8761wfpein.fsf@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 130712-1, 12.07.2013), Outbound message X-Antivirus-Status: Clean X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 7229 Cc: Thibault Kruse , 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 13.07.2013 5:20, Leo Liu wrote: > On 2013-07-13 07:03 +0800, Dmitry Gutov wrote: >> Maybe we should be able to restrict `ffap-file-at-point' to local files >> (which it checks for existence). >> >> After all, the variable that enables this behavior is called >> `ido-use-filename-at-point', and the description does not tell you that >> the thing at point could be interpreted as a remote URL. > > Is ffap-url-regexp enough? Not 100% sure what you mean, but probably not: 1) It doesn't match "/**", a value which apparently (ffap-guesser) can return even if there's no existing file with that name. 2) Likewise, it doesn't match "http:/". And I'm sure we can find other examples. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 04:01:46 2013 Received: (at 7229) by debbugs.gnu.org; 13 Jul 2013 08:01:46 +0000 Received: from localhost ([127.0.0.1]:51956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uxum0-0006n4-FF for submit@debbugs.gnu.org; Sat, 13 Jul 2013 04:01:45 -0400 Received: from mout.gmx.net ([212.227.17.21]:56887) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uxulw-0006ml-C6 for 7229@debbugs.gnu.org; Sat, 13 Jul 2013 04:01:42 -0400 Received: from 3capp-gmx-bs12.server.lan ([172.19.170.63]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MZiPg-1UkER12oIw-00LaCW for <7229@debbugs.gnu.org>; Sat, 13 Jul 2013 10:01:33 +0200 Received: from [92.229.152.222] by 3capp-gmx-bs12.server.lan with HTTP; Sat Jul 13 10:01:33 CEST 2013 MIME-Version: 1.0 Message-ID: From: "Thibault Kruse" To: 7229@debbugs.gnu.org Subject: Aw: Re: Re: Re: bug#7229: 23.1; ido guess and ffap bug Content-Type: text/html; charset=UTF-8 Date: Sat, 13 Jul 2013 10:01:33 +0200 (CEST) Importance: normal Sensitivity: Normal In-Reply-To: References: <20101016200828.264940@gmx.net> , X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K0:9WY6VunPJ+cOCaLpy682g/90AbRhc6fKiPpLmYOFj8v K62gEN2L7Gr/FTJCdlHyMH3pq1XB23QXaGH9tGMb64u0nq+ikZ EAkdDmpVMU0ZNfUZ3C/0ILY6RlULMFyubdwYx+1MRbdnroPe1h Hm06MLQ9/F8KLApTS+Ve06dxWjkK4Tk0Uq9UFCACVgCSEB+b2T XDQ3Ui+FqOF2UPBYVt3sdcaqK5LPUIE75USHyPQmDM2jRD/jTT cXsTKi4OtnTUE4EJIBGa2sFfc/KrDuYMmH/O3Urowd7Ajx8hY8 pS6+kI= X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Ok, so what I get with what you tell me is that: C-x C-f never uses ffap C-u C-x C-f always uses ffap (and thus also has the false positives for '/**' and '/>' ) [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (thibault.kruse[at]gmx.de) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.21 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts X-Debbugs-Envelope-To: 7229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Ok, so what I get with what you tell me is that: C-x C-f never uses ffap C-u C-x C-f always uses ffap (and thus also has the false positives for '/**' and '/>' ) [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.21 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (thibault.kruse[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts
Ok, so what I get with what you tell me is that:
C-x C-f never uses ffap
C-u C-x C-f   always uses ffap (and thus also has the false positives for '/**' and '/>' )
 
So as a user I'd have to learn and remember another keyboard shortcut to use when I want to have ido with ffap, is that the idea?
 
Personally, that idea might work for me (though I don't love it), but that leaves the rest of the world with bad defaults.
 
 
On a related note, I found this:
http://www.emacswiki.org/emacs/FindFileAtPoint
See "Ignore '/'" for a workaround by someone else to fix related problems.
 
 
Also looking at ffap.el sourcecode:
http://bzr.savannah.gnu.org/lh/emacs/emacs-23/annotate/head:/lisp/ffap.el
 
;; Immediate rejects (/ and // and /* are too common in C/C++):
((member name '("" "/" "//" "/*" ".")) nil)
 
So really ffap already breaks consistency for convenience, but only considers C/C++ coders. And '/' is not considered a valid completion prefix, though '/>' is considered a valid prefix and resolves to the only existing parent '/'. That's all a bit weird in ffap. If '/' itself is not valid, then maybe '/' should never be returned as suggestion by ffap (as in />, or /foo where /foo does not exist)?
 
Actually the way I fixed the problem in 7229 is this (sorry i took some time to remember, it has been 3 years):
 
 
(defadvice ffap-file-at-point (around bugfix-ffap  activate)
  "returns nil when point is somewhere we do not want to guess filenames"
  (require 'thingatpt)
;;; prevent in javadoc style comments
  (unless (or
           ;; ignore shebang lines, we are there very often and mostly do not want to open the executable
           (thing-at-point-looking-at "#!/[a-zA-Z0-9:_.-/]+")
           ;; ignore /**...* comment starts (Java-like languages, files name /*** are possible, but really unlikely)
           (thing-at-point-looking-at "/[\\*]+")
           ;; for xml modes, don't attemt to ffap-file-at-point when point is on </foo> or after <foo />, because we never want that.
           (and (member major-mode '(sgml-mode nxml-mode))
                ;; don't care about <somenode/> and </somenode>
                (or (thing-at-point-looking-at "</?[a-zA-Z_][a-zA-Z0-9:_.-]*>?")
                    (thing-at-point-looking-at "/>"))))
    ad-do-it))
 
So my advice would be to update the ffap ffap-file-at-point functions immediate rejects to include several more common false positive cases outside C/C++. My "patch" above also fixes shebang lines like "#! /usr/bin/python" which is highly annoying when working with several python scripts, and ido was constantly suggesting to open the python executable.
 
Another shortcut (like C-u C-x C-f) should IMHO only be necessary for forcing ffap to not reject anything, for those corner cases when a user has unusual work to do.
Again, it is a design decision, not a bug. I believe emacs users will be happier if C-x C-f with ido-ffap uses heuristics to avoid common false positives, rather than having to learn another shortcut.
 
 
 
Gesendet: Samstag, 13. Juli 2013 um 03:25 Uhr
Von: "Leo Liu" <sdl.web@gmail.com>
An: "Thibault Kruse" <thibault.kruse@gmx.de>
Cc: 7229@debbugs.gnu.org
Betreff: Re: Aw: Re: Re: bug#7229: 23.1; ido guess and ffap bug
On 2013-07-12 15:52 +0800, Thibault Kruse wrote:
> I tried:
> emacs -q --no-site-file
> M-x ido-mode
> M-x ielm
> pasted the lines you gave
> switch to scratch buffer
> typed "~/local" which exists
> press C-x C-f

Instead of C-x C-f, Try C-u C-x C-f.

> no prefix is used, ido just shows ~
> debugger also indicates the prefix var is nil

Please please write to the bug address 7229@debbugs.gnu.org instead of
my email.

Leo
From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 13:31:17 2013 Received: (at 7229) by debbugs.gnu.org; 13 Jul 2013 17:31:17 +0000 Received: from localhost ([127.0.0.1]:52998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy3fA-0003xL-4g for submit@debbugs.gnu.org; Sat, 13 Jul 2013 13:31:16 -0400 Received: from mail-pb0-f50.google.com ([209.85.160.50]:58622) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy3f7-0003x1-Oa for 7229@debbugs.gnu.org; Sat, 13 Jul 2013 13:31:14 -0400 Received: by mail-pb0-f50.google.com with SMTP id wz7so10019719pbc.37 for <7229@debbugs.gnu.org>; Sat, 13 Jul 2013 10:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=7Ml6aTNliozDg5L1z0mRisUFIV0yY58ZbP7tsEXAfi4=; b=P6yZpig4265rkv+MNJ/3bf6W4m+KLngXuRpsjfgsUvhoMvEOc1ugB4sCErfWKl+H0U GZy6ymMLIl4n6+P3UQTUzNTkl0rbBrk6AWeyPaGiD+GxEhl+hcNM0n6AawKhcqsEQ5Bp cYo5PEcJ0BN2DUEuwzqTiz7P7OyTX5mNq3B2wrr1sfJ50XcYZWqLJHCP+IRCcn9cpj0X BHwrHyLiGLYyvehJp/NCiLJxZcyrvexXyzsm/UHty8wktnwCl8AXmqekvkc9rhZZE8kQ H68UZYPHJGiZq4Y4UMuYX9qRsIRqPztXCo0xF5nvh84qUVzYdI7pod8u3qMnOAAZu4c8 CzOA== X-Received: by 10.66.135.146 with SMTP id ps18mr45347631pab.172.1373736667448; Sat, 13 Jul 2013 10:31:07 -0700 (PDT) Received: from Zeuss-MacBook.local ([182.48.101.29]) by mx.google.com with ESMTPSA id s5sm51656410pbo.38.2013.07.13.10.31.04 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 10:31:06 -0700 (PDT) From: Leo Liu To: "Thibault Kruse" Subject: Re: bug#7229: Aw: Re: Re: Re: bug#7229: 23.1; ido guess and ffap bug References: <20101016200828.264940@gmx.net> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Sun, 14 Jul 2013 01:31:02 +0800 In-Reply-To: (Thibault Kruse's message of "Sat, 13 Jul 2013 10:01:33 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.4) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 7229 Cc: 7229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 7229@debbugs.gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2013-07-13 16:01 +0800, Thibault Kruse wrote: > Again, it is a design decision, not a bug. I believe emacs users will > be happier if C-x C-f with ido-ffap uses heuristics to avoid common > false positives, rather than having to learn another shortcut. I consider this not a bug/flaw in ido but ffap. Special-case particular file names doesn't look like a good solution. Leo From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 14:38:34 2013 Received: (at 7229) by debbugs.gnu.org; 13 Jul 2013 18:38:34 +0000 Received: from localhost ([127.0.0.1]:53099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy4iH-00069b-SX for submit@debbugs.gnu.org; Sat, 13 Jul 2013 14:38:34 -0400 Received: from mout.gmx.net ([212.227.15.18]:63841) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy4iF-00069G-NJ for 7229@debbugs.gnu.org; Sat, 13 Jul 2013 14:38:32 -0400 Received: from 3capp-gmx-bs25.server.lan ([172.19.170.77]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MCeui-1UprEZ1uU6-009Svf for <7229@debbugs.gnu.org>; Sat, 13 Jul 2013 20:38:25 +0200 Received: from [92.229.152.222] by 3capp-gmx-bs25.server.lan with HTTP; Sat Jul 13 20:38:25 CEST 2013 MIME-Version: 1.0 Message-ID: From: "Thibault Kruse" To: 7229@debbugs.gnu.org Subject: Aw: Re: bug#7229: Re: Re: Re: bug#7229: 23.1; ido guess and ffap bug Content-Type: text/html; charset=UTF-8 Date: Sat, 13 Jul 2013 20:38:25 +0200 (CEST) Importance: normal Sensitivity: Normal In-Reply-To: References: <20101016200828.264940@gmx.net> , X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K0:dm919CUprGBgyCa5BIydIWi+mdxf0K6jL4WWBSwc96a WBwkyK1LeUr0nr+qjqE58RX68mIIK4ITN7lTZLzMzorzjhDUvQ t8aJmzhPOdaOc/lyUgw8mgmTpwHgz+EvSbGMv73iBm60INS0LE yXN2Y8eNfj5gb+Bu9aC0WLDilzNJ0qHSv8Xj9yjXEmWqLGCGc1 7+OKqJq4fR/kz5HvPsYfxZFz2eTVPS+YiBft73srvnXyOcoR9L KPz/b2oNmwrT2RhGWB5Y09RqKJTOorkrUUcmfKDITxy3PsTzFZ t6j2D4= X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I agree to this being an issue in ffap rather than ido. Trying to recognize filenames for the user in arbitrary files is not a clean problem, so I don't ever expect a clean solution to this problem. A somewhat cleaner solution could maybe be to define for each major mode it's own prefix filter for filename-at-point, taking into account the DSL used. Like I restricted my workaround to XML major modes. That way a rule concerning one kind of DSL would not affect other DSLs. And within a DSL, special cases can very well be defined. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (thibault.kruse[at]gmx.de) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.15.18 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts X-Debbugs-Envelope-To: 7229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I agree to this being an issue in ffap rather than ido. Trying to recognize filenames for the user in arbitrary files is not a clean problem, so I don't ever expect a clean solution to this problem. A somewhat cleaner solution could maybe be to define for each major mode it's own prefix filter for filename-at-point, taking into account the DSL used. Like I restricted my workaround to XML major modes. That way a rule concerning one kind of DSL would not affect other DSLs. And within a DSL, special cases can very well be defined. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.15.18 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (thibault.kruse[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 1.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts
I agree to this being an issue in ffap rather than ido. Trying to recognize filenames for the user in arbitrary files is not a clean problem, so I don't ever expect a clean solution to this problem.
 
A somewhat cleaner solution could maybe be to define for each major mode it's own prefix filter for filename-at-point, taking into account the DSL used. Like I restricted my workaround to XML major modes. That way a rule concerning one kind of DSL would not affect other DSLs. And within a DSL, special cases can very well be defined.
 
However, ffap generally discarding '//' or '/**' as filenames does not strike me as something any user would ever be annoyed about. If your filesystem looks like that, you're doomed in any case. So I am not too passionate about cleanlyness for this case.

As an example for DSL specific behavior, another extension I did for myself for C/C++major modes is that if point is at the *beginning* of any line like:
#include <foo.h>
ffap will suggest "foo.h". Things like that have no place in ffap for arbitrary files, but for C/C++ it is okay I believe. Similar rules may work for similar import statements in other languages.
 
 
 
Gesendet: Samstag, 13. Juli 2013 um 19:31 Uhr
Von: "Leo Liu" <sdl.web@gmail.com>
An: "Thibault Kruse" <thibault.kruse@gmx.de>
Cc: 7229@debbugs.gnu.org
Betreff: Re: bug#7229: Aw: Re: Re: Re: bug#7229: 23.1; ido guess and ffap bug
On 2013-07-13 16:01 +0800, Thibault Kruse wrote:
> Again, it is a design decision, not a bug. I believe emacs users will
> be happier if C-x C-f with ido-ffap uses heuristics to avoid common
> false positives, rather than having to learn another shortcut.

I consider this not a bug/flaw in ido but ffap. Special-case particular
file names doesn't look like a good solution.

Leo
From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 08:01:47 2016 Received: (at control) by debbugs.gnu.org; 23 Jul 2016 12:01:47 +0000 Received: from localhost ([127.0.0.1]:34239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQvco-00005u-SG for submit@debbugs.gnu.org; Sat, 23 Jul 2016 08:01:47 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQvcn-0008Ra-En for control@debbugs.gnu.org; Sat, 23 Jul 2016 08:01:45 -0400 Received: by mail-oi0-f52.google.com with SMTP id l65so196297780oib.1 for ; Sat, 23 Jul 2016 05:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc; bh=W+U4f4QerIs6kApEzF7TXHqm3tYZcJpNEZphLJcG40Q=; b=JLHb9lWYo2qWYH7zsqMen8fvizzq3T0dMlO3Zq4GWqiavLfzbjyVRh5lkm+t+1E5rG kamKV/sTbEc13cyvF6d8+6Zm6zt2sOkMmibeM9HgiWCPbHp4smzHCNEfwZH2rZpII4lr vv1ZRa1GgIR06YdZre2NQvltbrk0VWhCCFaf/GgilEUmHywu9YPs/9G3YKkJF2+4o+a/ EvPwaBq11dUHEV0D05sw7T3aGtI7/qtm9byJQ6eLTYPth21njHJ2OBEIcgUBgAhxX3QY L8HR0phKz4xVt4Qu62dOuE/kmecestP0J8iFvjIveB4h2+b5x+SL5eLWFNik1rp6PIza U3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=W+U4f4QerIs6kApEzF7TXHqm3tYZcJpNEZphLJcG40Q=; b=Td7np4dmp7V7ahYQDJsTp2HRNk3a5gC5tT+s+qe2k2w0bt1evfaGSK3Se2ilXqd+ud F7btcnPnPW4RYfrDxiXQBVNNEbvg8PlF9kfgdP7JhrQhjpZgH8kUK7wBUm/z9LuwPczo R8Pu/jtYWL+pILRNmUkLKyhS0Dd9RvTSahpjlCyJCu3xuBIxGmoX168Cqu7wxypFG9EJ X+d81ueW4OiCGS9fmwOd1lftu0XmxKA+LSf3YXrYoIC5Bk+LPrR4TwDH4cEvzeB7MwI6 eSF8M4UJItWncSlQU2Ov1NuJS7i73/XXHFX2xB5V1QaKXFsHL2kCGBhfPpYaemOK53m+ fMHg== X-Gm-Message-State: AEkoouu5fKIP0QKKhSxrzB3Qc5jcfHtE9BDM1HsZlVP+y31NNDUiu0qkqzSXYu79h3AwmmSVKjrzdqhLnhysGw== X-Received: by 10.157.43.108 with SMTP id f41mr5107860otd.189.1469275300010; Sat, 23 Jul 2016 05:01:40 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Sat, 23 Jul 2016 12:01:29 +0000 Message-ID: Subject: To: "control@debbugs.gnu.org" Content-Type: multipart/alternative; boundary=001a11c1684c559f4005384c50f0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 7229 normal # Severity of 7229 changed to normal so that it can be merged with 24057 -- Kaushal Modi [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kaushal.modi[at]gmail.com) 0.0 HTML_MESSAGE BODY: HTML included in message -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.52 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.52 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 7229 normal # Severity of 7229 changed to normal so that it can be merged with 24057 -- Kaushal Modi [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.52 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.52 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kaushal.modi[at]gmail.com) 0.0 HTML_MESSAGE BODY: HTML included in message 2.0 BLANK_SUBJECT Subject is present but empty -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --001a11c1684c559f4005384c50f0 Content-Type: text/plain; charset=UTF-8 severity 7229 normal # Severity of 7229 changed to normal so that it can be merged with 24057 -- Kaushal Modi --001a11c1684c559f4005384c50f0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
severity=C2=A072= 29 normal

<= /div>
# Severity of 7229 changed to normal s= o that it can be merged with 24057
--

Kaushal Modi

--001a11c1684c559f4005384c50f0-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 23 08:13:40 2016 Received: (at control) by debbugs.gnu.org; 23 Jul 2016 12:13:40 +0000 Received: from localhost ([127.0.0.1]:34274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQvoK-0000Z7-Ln for submit@debbugs.gnu.org; Sat, 23 Jul 2016 08:13:40 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQvoI-0000Yp-Eu for control@debbugs.gnu.org; Sat, 23 Jul 2016 08:13:38 -0400 Received: by mail-oi0-f42.google.com with SMTP id l65so196534074oib.1 for ; Sat, 23 Jul 2016 05:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=lkjsnp0o1zM8ZhDCuJOY9JgMCjxIL507W4m8bfDcrTk=; b=g2QdG/FmePGwibA/ixK3Y8NLcUYnhYSvt/+adk5KsfD7+9Hz54FbyEXe8/McqnLPYJ Wi9y9yCi/oBqk30kqjFjHvFG0mIIEANAOVS4sshsC6ZGW/35zpnX0Jne4DcmNqDG0fuq h2T36vJ9PXCxe0lxoZxy+WGb7vLc8yAUI3rCcy7ydxhEQajHSAMc/DeUttyQXxJSnso/ bMcpTtcg9xuf5WM24CMNHSa+vMpOvZ+xIV9nt1X9YMNcnAduJAvhLQJ+xJgKuZdT8zA0 SKvQG9mOwtWJVJOu9GnEcttE1DhvzZBj0socYCVOoof3mF7wyMKgsUueL488zezPCRoi 6Xxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lkjsnp0o1zM8ZhDCuJOY9JgMCjxIL507W4m8bfDcrTk=; b=LSEGCHkhfLpeZHDsIOu1Ml0XI1B2V4OxVmTE2iiOSR3K/E5V2IziAJfp9lLqm5Te/f 0L9nb6aKufmQJmME2vINIJCirMrX9DZWl3VD4O+ltHG3TReSfrLYq7yl6xLPDzqtgqOV EhtWr/65CjB1k5Jd7RJEUM8aBjQ9WXVj6P3cF4/75KEs2qFcWgxT6/SRXNfYiScnrcFf ITym83FkCeThOtp26l9UbaBBfAQk8GcLJzSMojdtv6z06eCJL9j+1+V7Tre0+c3fxKR1 o6zYyTdoPR45qJZtp2V6KFh4BsBzf1S1Q44VTaUfsazpW8meMhhwsij799qCdTjIwuuY 5Jwg== X-Gm-Message-State: AEkooutaY13B8AKv6gxwzK5RQW8F/ZtSRv/6tV+XcrB1e8T3ZEtQgopPSPKzBT43qrm8VgFwqUuJ/lb1QfgeLw== X-Received: by 10.202.74.80 with SMTP id x77mr4857772oia.125.1469276012910; Sat, 23 Jul 2016 05:13:32 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Sat, 23 Jul 2016 12:13:23 +0000 Message-ID: Subject: To: "control@debbugs.gnu.org" Content-Type: multipart/alternative; boundary=001a11c17c02d3a19205384c7af7 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 8990 minor severity 7229 minor severity 24057 minor merge 7229 8990 24057 quit # Noam, looks like we were toggling the severities at the same time # Hopefully, this finally does the merge :) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.42 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kaushal.modi[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.42 listed in wl.mailspike.net] 0.0 HTML_MESSAGE BODY: HTML included in message 2.0 BLANK_SUBJECT Subject is present but empty -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 8990 minor severity 7229 minor severity 24057 minor merge 7229 8990 24057 quit # Noam, looks like we were toggling the severities at the same time # Hopefully, this finally does the merge :) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.42 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.218.42 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (kaushal.modi[at]gmail.com) 0.0 HTML_MESSAGE BODY: HTML included in message 2.0 BLANK_SUBJECT Subject is present but empty -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --001a11c17c02d3a19205384c7af7 Content-Type: text/plain; charset=UTF-8 severity 8990 minor severity 7229 minor severity 24057 minor merge 7229 8990 24057 quit # Noam, looks like we were toggling the severities at the same time # Hopefully, this finally does the merge :) -- Kaushal Modi --001a11c17c02d3a19205384c7af7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
severity=C2=A08990 minor
severity=C2=A07229 minor
severity=C2=A024057=C2=A0minor=C2=A0=C2=A0
merge=C2=A07229 8990 24057
quit

=
# Noam, looks like we were t= oggling the severities at the same time
# Hopefully, this finally does the merge :)<= /div>

=
--

Kaushal Modi

--001a11c17c02d3a19205384c7af7-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 11:39:51 2017 Received: (at control) by debbugs.gnu.org; 18 Mar 2017 15:39:51 +0000 Received: from localhost ([127.0.0.1]:34082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpGSN-00081n-5c for submit@debbugs.gnu.org; Sat, 18 Mar 2017 11:39:51 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:37384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpGSL-00081Y-Mk; Sat, 18 Mar 2017 11:39:49 -0400 Received: by mail-it0-f54.google.com with SMTP id g138so56701480itb.0; Sat, 18 Mar 2017 08:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=J6A9wUUHNaK+YgRKaWj+nogcM5waUwdj3Z5SJrgCzy0=; b=tIMLEEQLiDIHZOTEZCVhUZ2D8kdkLovBp3VK6Faa+jZW6xP0SGW4RPRaPLwRJmRHzT wxAfhjmSH9rm9exanEdAnIP1x6dPaA5WreAmxcFXT0tPxNzzJWuNMRYS/dwgP+ITlqWS HPZqaDLfie4NvUv+lQCZigG6NMVqhZN+VxIaTl3Wc4kcLvulLHvdDLBImtwpYml3ATNf Lm7GquG6F8soQkQ+6nBEHX3IN3kYwbSdHy+BFU5IDxGJqwdAsyS168xDHYonBwc9O7c7 Wiu6zEDSbhaTU8wnXVdAhwTahuqLmkU90PmQQqcC5NqHSTljX6qs8R7+SvF5/WAb0t0n F6lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=J6A9wUUHNaK+YgRKaWj+nogcM5waUwdj3Z5SJrgCzy0=; b=FzKEg+cjm+giaDTMHTvW7XsGgarj37IjlOkbAhNUkQazRKkX1e18axjSUjm2os3XQo 1lAHpeIhVEBy9cCnZgEUWSs85DXD6N+jdG65ItHfCDm9tA4dnyD402lbj8bY4gZJPiRB 6id67cx6J4niOyXTrCHYk9uwDB3VRQvY6d+roSwCULw41pIZR88wP+Kn1n9ZdjzxmH6n +iEH1tGPGGtuMDBHz5OJAmcK2pJxFKmn3/++Vmq9bhPa7ycYJhEFtfch04MV0WpcMWNv Vip8UVmFFd/6IbVEBDKBK3071o+7nHnZ+ovwsA4k4AnPlcYRmOC4/amLxowc0+egpYpm UE+w== X-Gm-Message-State: AFeK/H0LtEb+dq4GkmGjBdkpdFvhfiDKuKOFAKZg7kfCAtknDFXuPfiXGUgHx7chUvHPVA== X-Received: by 10.36.137.4 with SMTP id s4mr3034959itd.63.1489851583984; Sat, 18 Mar 2017 08:39:43 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id w133sm2604809itf.2.2017.03.18.08.39.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Mar 2017 08:39:42 -0700 (PDT) From: npostavs@users.sourceforge.net To: Kaushal Modi Subject: Re: bug#24057: 25.1.50; ffap interprets comments beginning with "//" as file path References: <83lh0sx0yf.fsf@gnu.org> <83shv0v716.fsf@gnu.org> <83poq4v4jk.fsf@gnu.org> <83wpkbt92i.fsf@gnu.org> <83mvl5tzv7.fsf@gnu.org> <83invttyv7.fsf@gnu.org> <874lys64bm.fsf@users.sourceforge.net> <87var74h2j.fsf@users.sourceforge.net> Date: Sat, 18 Mar 2017 11:41:03 -0400 In-Reply-To: (Kaushal Modi's message of "Sat, 18 Mar 2017 01:28:46 +0000") Message-ID: <87r31u4mpc.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , 24057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 24057 patch quit Kaushal Modi writes: > Btw if you don't mind explaining: > - How did you detect that minor missing space? Do you have a minor mode? Or > do you have a check function? I enable ocd-mode in my brain while reading patches ;) > - Being used to using single spaces at end of sentences, I always forget > adding double spaces. More seriously, I've gotten used to using double spaces and so single spaced sentences stand out to me more now. > Is there a robust way to ensure that sentences always > end in double spaces in commit messages and in the docstrings? The trouble is that sometimes a period followed by a space doesn't end a sentence, e.g., in "Mr. Foo". Actually, this ambiguity is what convinced me to switch over to double spacing. Such cases might be rare enough in commit messages and docstrings that we could get away with some automatic warning on all matches for "\\sw[.] \\<" though. > > The attached patch has the double space fixed in the commit message. Thanks, I will push to master in a couple of days. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 08:59:47 2017 Received: (at control) by debbugs.gnu.org; 23 Mar 2017 12:59:47 +0000 Received: from localhost ([127.0.0.1]:40245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr2LD-0003Lk-JB for submit@debbugs.gnu.org; Thu, 23 Mar 2017 08:59:47 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:35012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cr2LC-0003LU-5A; Thu, 23 Mar 2017 08:59:46 -0400 Received: by mail-io0-f169.google.com with SMTP id z13so82058855iof.2; Thu, 23 Mar 2017 05:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ic4qfKslgxQ5oKyUfqIerF5cJwi1+OkOWmhKU2uUc6c=; b=RwRvtmiU3bNHEYpImPI6hp+kvmpOASCT/pAzxrGLe0GuKpYfHTI+qg1omwjCRwyDW0 lyUzDkYsiE456pnRy6hQzNgkYnPd5e0txj6HhfLdRtmZ87spN2EtN7EkNg0oyy7JpBKN uzlVHVHxmnqQMaQSe0hF8d0rZmUmPWhJIyoVBS2vYzAnZjHGUUzTnXnWM6FMwfc0yW/n BAIbG+BD9uxBqjC9GNusZ3u1e5B34rTrB2qrzSPjUsHcpjWeqrtyOlzq72Y7YtdmFbQr RbMlh+duIHYa9MuabuU/MfzleUCzvGY0i48nVziL3O0nOYTXmpkC/tq9oG/1FrXYTyNe qlAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Ic4qfKslgxQ5oKyUfqIerF5cJwi1+OkOWmhKU2uUc6c=; b=WGC5GkAExo8iVBIYCYmiWxuLNl5fcO7COn1A2XLJRnUpO5BEFKR/hy6t+PpQhw0LUI FTpryRsj32KfU/z9eLwo0K14DZJdjCUMe0iJ6obZWKvEPteDkmEPtTUF0Oajl3hTH2L+ Ms4+s5idp2G436sEnX/8M7PnmcWbMKR6KOb/LoKQWO2TGAPQQaYNwYu6vQ0bR2BA0qWy eS05/+OeK+Qzhecgq60mXDbvDxFPlgo6oFBmc/NzUdIVRoLztHDTRlU/wSxGDwCpCZoB FSp5oExy1S/VZ/SgBoRU/8WZfs768tB/269IWo9EtzIx3NsyhK70kYYxkSOrdZxV/Gum 0A9A== X-Gm-Message-State: AFeK/H117kotUKKKYXKzGeMR47PYnGESVa53niLzNpHYHKC0ZFi9HIrrgGAddfiid93W6Q== X-Received: by 10.107.175.152 with SMTP id p24mr2672128ioo.80.1490273980593; Thu, 23 Mar 2017 05:59:40 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p70sm355503itg.0.2017.03.23.05.59.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Mar 2017 05:59:39 -0700 (PDT) From: npostavs@users.sourceforge.net To: Kaushal Modi Subject: Re: bug#24057: 25.1.50; ffap interprets comments beginning with "//" as file path References: <83lh0sx0yf.fsf@gnu.org> <83shv0v716.fsf@gnu.org> <83poq4v4jk.fsf@gnu.org> <83wpkbt92i.fsf@gnu.org> <83mvl5tzv7.fsf@gnu.org> <83invttyv7.fsf@gnu.org> <874lys64bm.fsf@users.sourceforge.net> <87var74h2j.fsf@users.sourceforge.net> <87r31u4mpc.fsf@users.sourceforge.net> Date: Thu, 23 Mar 2017 09:01:02 -0400 In-Reply-To: <87r31u4mpc.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sat, 18 Mar 2017 11:41:03 -0400") Message-ID: <877f3g406p.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , 24057@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) tags 24057 fixed close 24057 26.1 quit npostavs@users.sourceforge.net writes: > > Thanks, I will push to master in a couple of days. Done [1: e472cfe8f3] 1: 2017-03-23 08:57:13 -0400 e472cfe8f3b01f29a49614f6207e4128e8b36b8c Do not include comment start chars in ffap string From unknown Mon Jun 23 20:15:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator