GNU bug report logs - #72272
[PATCH] dired-hide-details-mode hides directory's absolute path

Previous Next

Full log

Message #50 received at 72272 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alvaro Ramirez <alvaro <at> xenodium.com>
Cc: acorallo <at> gnu.org, 72272 <at> debbugs.gnu.org, stefankangas <at> gmail.com,
 visuweshm <at> gmail.com
Subject: Re: bug#72272: [PATCH] dired-hide-details-mode hides directory's
 absolute path
Date: Sat, 12 Oct 2024 14:33:50 +0300

> From: Alvaro Ramirez <alvaro <at> xenodium.com>
> Date: Wed, 9 Oct 2024 18:31:35 +0100
> Cc: 72272 <at> debbugs.gnu.org, Andrea Corallo <acorallo <at> gnu.org>,
>  Visuwesh <visuweshm <at> gmail.com>
> 
> Hi Eli / Stefan
> 
> With the latest patch disabling the feature by default, is it good to apply?

It is good, but it no longer applies.  Would you please rebase it on
the latest master branch and resubmit?

Also, please fix the following minor nits while you are at it:

> ++++
> +*** New user option 'dired-hide-details-hide-absolute-location'

The heading lines in NEWS should end in a period.

Also, since this new variable is not documented in the manual, the
entry should be marked as "---", not "+++".

> +            (let* ((dir-indent "  ")
> +                   (dir-name (or (car-safe dir-wildcard)
> +                                 (directory-file-name (file-name-directory dir))))
> +                   (dir-name-point (+ (point) (length dir-indent)))
> +                   (hideable-location (and dired-hide-details-hide-absolute-location
> +                                           (not (string-empty-p (file-name-nondirectory dir-name))))))
> +	      ;; Inserted directory name must be absolute, but keep in mind it
> +              ;; may be replaced in some instances (e.g. dired-build-subdir-alist).
> +              (insert dir-indent dir-name ":\n")
> +              (when hideable-location
> +                (put-text-property dir-name-point
> +                                   (+ dir-name-point
> +                                      (length (file-name-directory dir-name)))
> +                                   'invisible 'dired-hide-details-absolute-location)))

Here (and elsewhere in the patch) please break too-long lines into
two.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.