From unknown Fri Aug 15 20:50:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#72244] [PATCH core-updates] gnu: nss: Run tests with datefudge on 32bit systems. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jul 2024 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72244 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72244@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17216524103423 (code B ref -1); Mon, 22 Jul 2024 12:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jul 2024 12:46:50 +0000 Received: from localhost ([127.0.0.1]:57176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVsRG-0000t8-4h for submit@debbugs.gnu.org; Mon, 22 Jul 2024 08:46:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:44902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVsRB-0000sw-I2 for submit@debbugs.gnu.org; Mon, 22 Jul 2024 08:46:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVsR7-0002GS-J5 for guix-patches@gnu.org; Mon, 22 Jul 2024 08:46:41 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVsR5-0000Oa-2h for guix-patches@gnu.org; Mon, 22 Jul 2024 08:46:40 -0400 Received: from localhost (unknown [212.132.255.81]) by mira.cbaines.net (Postfix) with ESMTPSA id 4C36F27BBE2 for ; Mon, 22 Jul 2024 13:46:35 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 1629e0e7 for ; Mon, 22 Jul 2024 12:46:34 +0000 (UTC) From: Christopher Baines Date: Mon, 22 Jul 2024 13:46:33 +0100 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) As libfaketime has issues with 64bit time on 32bit systems. * gnu/packages/nss.scm (nss)[arguments]: Tweak the gtests.sh script and use datefudge rather than faketime on 32bit systems. [native-inputs]: Use datetime rather than libfaketime on 32bit systems. Change-Id: Ice97b2dc36049d6ad0a7d4154defd40b0ba41c94 --- gnu/packages/nss.scm | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 49276817ae..93c594d5e7 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -39,6 +39,7 @@ (define-module (gnu packages nss) #:use-module (gnu packages check) #:use-module (gnu packages crates-io) #:use-module (gnu packages compression) + #:use-module (gnu packages time) #:use-module (gnu packages perl) #:use-module (gnu packages sqlite)) @@ -211,11 +212,21 @@ (define-public nss (substitute* "nss/tests/dbtests/dbtests.sh" ((" -lt 5") " -lt 50")) + #$@(if (target-64bit?) + #~() + ;; Not sure why, but this avoids some tests failing + ;; when using datefudge + #~((substitute* "nss/tests/gtests/gtests.sh" + (("cd \"\\$\\(dirname \"\\$1\"\\)\"") "")))) + ;; The "PayPalEE.cert" certificate expires every six months, ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) + (invoke #$(if (target-64bit?) + "faketime" + "datefudge") + "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) @@ -240,7 +251,11 @@ (define-public nss (copy-recursively (string-append obj "/lib") lib))))))) (inputs (list sqlite zlib)) (propagated-inputs (list nspr)) ;required by nss.pc. - (native-inputs (list perl libfaketime which)) ;for tests + (native-inputs (list perl + (if (target-64bit?) + libfaketime + datefudge) + which)) ;for tests ;; The NSS test suite takes around 48 hours on Loongson 3A (MIPS) when ;; another build is happening concurrently on the same machine. base-commit: ffb56a574f03e5fb7d60ea46cc883bee7878f414 -- 2.45.2 From unknown Fri Aug 15 20:50:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#72244: closed (Re: bug#72244: [PATCH core-updates] gnu: nss: Run tests with datefudge on 32bit systems.) Message-ID: References: <87h6cccy5x.fsf@gnu.org> X-Gnu-PR-Message: they-closed 72244 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 72244@debbugs.gnu.org Date: Fri, 26 Jul 2024 09:16:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1721985362-6516-1" This is a multi-part message in MIME format... ------------=_1721985362-6516-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72244: [PATCH core-updates] gnu: nss: Run tests with datefudge on 32bit sy= stems. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72244@debbugs.gnu.org. --=20 72244: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72244 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1721985362-6516-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72244-done) by debbugs.gnu.org; 26 Jul 2024 09:15:08 +0000 Received: from localhost ([127.0.0.1]:38776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXH2a-0001fx-Bs for submit@debbugs.gnu.org; Fri, 26 Jul 2024 05:15:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXH2Y-0001el-9F for 72244-done@debbugs.gnu.org; Fri, 26 Jul 2024 05:15:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXH2K-0002z5-Ju; Fri, 26 Jul 2024 05:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=EZmx1FD0iZAtjRhE3yNWSWqBFM3aZrE1RXOsvCCHwsE=; b=PWKaxuJQ76YzHZ4SztQs oTVfa6uQg8SHDQHUhiMeEGBrmUa5Meng60is6zvDAh2PCEW4Zq5whYOOYju9U2CuHONF0fSU2bnXJ 4RI8+ZCyNW7wJCY2lUubpxntC2PYNamDZ4pssy/AGbUsDQO/lck0id7Oj40+hl6bVzIZHYjn/B7he YL93jHJtrhnXjzopFvOzoxi3KkHAKzeIcTgaT2TtCgylbpL/DK6BBF/a4TQDbSfckFW3EyFmFZdMc fdH71DvXYqxsqtJscV/EM3rw0ZwvdT8yjHbNkTDI8skjpRpkFOehV38VEE2+eqOHJtq2775J7ZUq5 lQLby3eUXe+tJw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: bug#72244: [PATCH core-updates] gnu: nss: Run tests with datefudge on 32bit systems. In-Reply-To: (Christopher Baines's message of "Mon, 22 Jul 2024 13:46:33 +0100") References: Date: Fri, 26 Jul 2024 11:14:50 +0200 Message-ID: <87h6cccy5x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72244-done Cc: 72244-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Christopher Baines skribis: > As libfaketime has issues with 64bit time on 32bit systems. > > * gnu/packages/nss.scm (nss)[arguments]: Tweak the gtests.sh script and u= se > datefudge rather than faketime on 32bit systems. > [native-inputs]: Use datetime rather than libfaketime on 32bit systems. > > Change-Id: Ice97b2dc36049d6ad0a7d4154defd40b0ba41c94 I pushed a variant as 21fe1e077aa77488bd413ef3255973c60d7468fe, as discussed in . Ludo=E2=80=99. ------------=_1721985362-6516-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jul 2024 12:46:50 +0000 Received: from localhost ([127.0.0.1]:57176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVsRG-0000t8-4h for submit@debbugs.gnu.org; Mon, 22 Jul 2024 08:46:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:44902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVsRB-0000sw-I2 for submit@debbugs.gnu.org; Mon, 22 Jul 2024 08:46:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVsR7-0002GS-J5 for guix-patches@gnu.org; Mon, 22 Jul 2024 08:46:41 -0400 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVsR5-0000Oa-2h for guix-patches@gnu.org; Mon, 22 Jul 2024 08:46:40 -0400 Received: from localhost (unknown [212.132.255.81]) by mira.cbaines.net (Postfix) with ESMTPSA id 4C36F27BBE2 for ; Mon, 22 Jul 2024 13:46:35 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 1629e0e7 for ; Mon, 22 Jul 2024 12:46:34 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH core-updates] gnu: nss: Run tests with datefudge on 32bit systems. Date: Mon, 22 Jul 2024 13:46:33 +0100 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) As libfaketime has issues with 64bit time on 32bit systems. * gnu/packages/nss.scm (nss)[arguments]: Tweak the gtests.sh script and use datefudge rather than faketime on 32bit systems. [native-inputs]: Use datetime rather than libfaketime on 32bit systems. Change-Id: Ice97b2dc36049d6ad0a7d4154defd40b0ba41c94 --- gnu/packages/nss.scm | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm index 49276817ae..93c594d5e7 100644 --- a/gnu/packages/nss.scm +++ b/gnu/packages/nss.scm @@ -39,6 +39,7 @@ (define-module (gnu packages nss) #:use-module (gnu packages check) #:use-module (gnu packages crates-io) #:use-module (gnu packages compression) + #:use-module (gnu packages time) #:use-module (gnu packages perl) #:use-module (gnu packages sqlite)) @@ -211,11 +212,21 @@ (define-public nss (substitute* "nss/tests/dbtests/dbtests.sh" ((" -lt 5") " -lt 50")) + #$@(if (target-64bit?) + #~() + ;; Not sure why, but this avoids some tests failing + ;; when using datefudge + #~((substitute* "nss/tests/gtests/gtests.sh" + (("cd \"\\$\\(dirname \"\\$1\"\\)\"") "")))) + ;; The "PayPalEE.cert" certificate expires every six months, ;; leading to test failures: ;; . To ;; work around that, set the time to roughly the release date. - (invoke "faketime" "2024-01-23" "./nss/tests/all.sh")) + (invoke #$(if (target-64bit?) + "faketime" + "datefudge") + "2024-01-23" "./nss/tests/all.sh")) (format #t "test suite not run~%")))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) @@ -240,7 +251,11 @@ (define-public nss (copy-recursively (string-append obj "/lib") lib))))))) (inputs (list sqlite zlib)) (propagated-inputs (list nspr)) ;required by nss.pc. - (native-inputs (list perl libfaketime which)) ;for tests + (native-inputs (list perl + (if (target-64bit?) + libfaketime + datefudge) + which)) ;for tests ;; The NSS test suite takes around 48 hours on Loongson 3A (MIPS) when ;; another build is happening concurrently on the same machine. base-commit: ffb56a574f03e5fb7d60ea46cc883bee7878f414 -- 2.45.2 ------------=_1721985362-6516-1--