GNU bug report logs - #72241
31.0.50; [PATCH] Use a dedicated buffer for `doc-view-open-text'

Previous Next

Package: emacs;

Reported by: Manuel Giraud <manuel <at> ledu-giraud.fr>

Date: Mon, 22 Jul 2024 08:28:01 UTC

Severity: normal

Tags: patch

Found in version 31.0.50

Done: Tassilo Horn <tsdh <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 72241 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72241 <at> debbugs.gnu.org, manuel <at> ledu-giraud.fr
Subject: Re: bug#72241: 31.0.50; [PATCH] Use a dedicated buffer for
 `doc-view-open-text'
Date: Mon, 22 Jul 2024 20:39:54 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Tassilo Horn <tsdh <at> gnu.org>
>> Date: Mon, 22 Jul 2024 20:11:34 +0200
>> 
>> I'm not sure if a NEWS entry is needed for that change.  It certainly
>> changes existing behavior but not in a way that usage patterns/muscle
>> memory would need to be adapted...
>
> Can you tell in what way the behavior will change after this?  I'd
> like to think whether a NEWS entry is necessary and what to day there.

Right now, when you open foo.pdf you see the images generated from the
PDF.  When you do C-c C-t, it'll replace the foo.pdf buffer contents
with the plain text contents of the PDF.  With another C-c C-c, the
contents are again replaced with the PDF and you see the images again.

With Manuel's patch, C-c C-t shows the plain text contents in a separate
buffer foo.pdf/text.  C-c C-c in there kills that separate buffer and
switches back to the original foo.pdf buffer.

So basically everything you have to do stays the same but there are now
two instead of just one buffer.  That has the advantage that you can
switch between them and removes the possibility that you accidentally
overwrite your PDF with the plain text contents (which in what Stefan's
FIXME was about).

Bye,
  Tassilo




This bug report was last modified 360 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.