From unknown Sun Sep 21 02:49:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72237: diffutils "make dist" not compliant with the GNU Coding Standards Resent-From: Bruno Haible Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Sun, 21 Jul 2024 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72237 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: To: 72237@debbugs.gnu.org X-Debbugs-Original-To: bug-diffutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17215903233694 (code B ref -1); Sun, 21 Jul 2024 19:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jul 2024 19:32:03 +0000 Received: from localhost ([127.0.0.1]:56090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVcHr-0000xW-8q for submit@debbugs.gnu.org; Sun, 21 Jul 2024 15:32:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:56874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVcHp-0000wy-Ai for submit@debbugs.gnu.org; Sun, 21 Jul 2024 15:32:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVcHm-0003Cs-OG for bug-diffutils@gnu.org; Sun, 21 Jul 2024 15:31:58 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVcHk-0004A6-9y for bug-diffutils@gnu.org; Sun, 21 Jul 2024 15:31:58 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1721590312; cv=none; d=strato.com; s=strato-dkim-0002; b=l+EW/KzCB59v/BnMGSj3yvaLMKLzVDG7FXqsqyaCKX46mj7XnLnX3e+iDUvfT+jfJS A5uQjj2/pBtHsDB8uuEvMEOdYpTolBK54nsbdrP0itpHiWAR3Ehc/T0+4Cwpq9EQ+Vzv p4A2UW6hsRZ7YNkOzdnjJu3R6KcylSgrM6y6Dzx+CJRGfIFlMDK+pYnIvjlCOzS6x89u 1FQZjHsfVMbBb7JBhVr/PGSLoN0gZsEWVSTrbIuVPDvuX2wIN6Q6A7H5iIfLJeh6nDKF cX3wtvRBFP80VmeZtyCv1L8WQEwUpAHhRAKjWuuw4XL4cb8hmJuiBJPce0G4VnEfgje1 WcjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1721590312; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=oXL70TI7C7xe2LXsQ4vzIlQ3jCu03OdJbOpq8jozXRU=; b=UvUv+RPjCz4NZoo9buKKXUB2f66DwbYlEQps2UW9/1PY4BJmOtE3W5F3+GkXuIuQh4 gGSIOIs9EN5LVsL/vJrYYLZylqogtldGal8TCFupIkeBhuqic0R4z+SIR6EuaqkfsCHA NQ9OySXPrvMwPJMlMD3NDdKcLyUspcuily6QyLOn7kI0oHqIjNRazhUJT9sJtZKmieJN KZK5WExgcJ3iYEvVi7OSLrrH6lOWUQx5h+5bjPwqa+NgswzjXsaPA46r9WLhQDdLtg7Y OZW9vqdmavXFnEtS1TY5W+v55GlI87/NcgpKX8gVhJkCRbZyhk4dyXlU4OwUlhiL2vsJ ko4Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1721590312; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=oXL70TI7C7xe2LXsQ4vzIlQ3jCu03OdJbOpq8jozXRU=; b=KNnpxZirXGgJcb5fgNVltiX6EIVQOIrCzmWMON8DVfrhvp1LsT++q5wg+x4ux8yM0D BRR3kkpFOZEGjTKOzIDk+ARVOfuOc2eJbh85cealLo8rXGq+uBgzM6Kv0OWSTJrrwMxp RB35My95nYAm34G/1C6iVtJNlqozyxwMjpkYeHTebpKLIWfdynSenYit7/WyRGgnzai8 VWM1DlfU3p8Vs0vzTqlIgrubsAXFWkK6Wam18u47Hu/fiQgXFXNYF2ND2soVe+YKrkZR oUpkeCL9gxYYkCO3X9WFQlpdNlLoHMrICtE850FeFlRlLkc0//mWQt7dF46Bp91A4Feu cOKw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1721590312; s=strato-dkim-0003; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=oXL70TI7C7xe2LXsQ4vzIlQ3jCu03OdJbOpq8jozXRU=; b=x7Ggl2KwIIzxxSZQFFp0++YI3wR8htOXc/Pi4ytKHi3aHxjetcB0F8viEwGAx9BlW2 W75orwTtulg19BJIZ/Bg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOejaAQLQQQx2f230GW7tdW2kDZtw==" Received: from nimes.localnet by smtp.strato.de (RZmta 50.5.0 AUTH) with ESMTPSA id N0957e06LJVqMi4 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 21 Jul 2024 21:31:52 +0200 (CEST) From: Bruno Haible Date: Sun, 21 Jul 2024 21:31:52 +0200 Message-ID: <2739967.muMEfcBPU2@nimes> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart8200989.tOnEmuZJvr" Content-Transfer-Encoding: 7Bit Received-SPF: none client-ip=85.215.255.21; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --nextPart8200989.tOnEmuZJvr Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, According to the GNU Coding Standard https://www.gnu.org/prep/standards/html_node/Standard-Targets.html "The dist target should explicitly depend on all non-source files that are in the distribution, to make sure they are up to date in the distribution." An easy way to test whether the 'dist' target has this property is to run $ ./configure $ make dist or (in a VPATH build) $ ../configure $ make dist without doing "make" before "make dist". Distributed non-source files that make this difficult are the man pages for programs, that are generated from the '--help' output using help2man. While packages that only have a top-level Makefile.am (such as GNU sed or GNU coreutils) get this right, it is a little bit more complicated in packages with a Makefile.am per directory (such as GNU diffutils and GNU gettext). Originally reported for GNU gettext at . In GNU diffutils $ ./configure; make dist V=1 fails like this: make[3]: Entering directory '/DIFFUTILS/diffutils/man' make distdir-am make[4]: Entering directory '/DIFFUTILS/diffutils/man' base=`expr cmp.1 : '\(.*\).1'` \ && test -x ../src/$base \ && (echo '[NAME]' \ && sed 's@/\* *@@; s/-/\\-/;s/^GNU //; q' ../src/$base.c) \ | PATH="../src:$PATH" \ ./help2man -i - -i ./$base.x \ -S 'diffutils 2024-05-21' $base > cmp.1-t && mv cmp.1-t cmp.1 make[4]: *** [Makefile:2483: cmp.1] Error 1 make[4]: Leaving directory '/DIFFUTILS/diffutils/man' make[3]: *** [Makefile:2322: distdir] Error 2 make[3]: Leaving directory '/DIFFUTILS/diffutils/man' The attached patch fixes it. Tested also with VPATH builds, with - GNU make, - FreeBSD make, - NetBSD make. Tested also with parallel make, through $ ./configure; make -j8 dist V=1 --nextPart8200989.tOnEmuZJvr Content-Disposition: attachment; filename="0001-build-Fix-failure-of-.-configure-make-dist.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-build-Fix-failure-of-.-configure-make-dist.patch" >From 9c8b154025243e4527ccc1640cde75d4d9ae50f4 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sun, 21 Jul 2024 21:25:01 +0200 Subject: [PATCH] build: Fix failure of "./configure; make dist" * Makefile.am (BUILT_SOURCES): New variable. (man/cmp.1, man/diff.1, man/diff3.1, man/sdiff.1): New targets. (gen-man1): New phony target. --- Makefile.am | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Makefile.am b/Makefile.am index 59084bc..564b46a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -24,6 +24,24 @@ SUBDIRS = lib src tests doc man po gnulib-tests ACLOCAL_AMFLAGS = -I m4 AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS) +# Ensure that the manual pages are up-to-date when "make dist" runs. +BUILT_SOURCES = \ + man/cmp.1 \ + man/diff.1 \ + man/diff3.1 \ + man/sdiff.1 +man/cmp.1 man/diff.1 man/diff3.1 man/sdiff.1 : gen-man1 +.PHONY: gen-man1 +gen-man1: $(top_srcdir)/src/cmp.c man/cmp.x \ + $(top_srcdir)/src/diff.c man/diff.x \ + $(top_srcdir)/src/diff3.c man/diff3.x \ + $(top_srcdir)/src/sdiff.c man/sdiff.x + $(AM_V_GEN)(cd lib && $(MAKE) $(AM_MAKEFLAGS)) \ + && (cd src \ + && $(MAKE) $(AM_MAKEFLAGS) \ + cmp$(EXEEXT) diff$(EXEEXT) diff3$(EXEEXT) sdiff$(EXEEXT)) \ + && (cd man && $(MAKE) $(AM_MAKEFLAGS) cmp.1 diff.1 diff3.1 sdiff.1) + # Arrange so that .tarball-version appears only in the distribution # tarball, and never in a checked-out repository. dist-hook: gen-ChangeLog -- 2.34.1 --nextPart8200989.tOnEmuZJvr-- From unknown Sun Sep 21 02:49:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72237: [bug-diffutils] bug#72237: diffutils "make dist" not compliant with the GNU Coding Standards Resent-From: Collin Funk Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Sun, 21 Jul 2024 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72237 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: To: Bruno Haible Cc: 72237@debbugs.gnu.org Received: via spool by 72237-submit@debbugs.gnu.org id=B72237.17215919116077 (code B ref 72237); Sun, 21 Jul 2024 19:59:02 +0000 Received: (at 72237) by debbugs.gnu.org; 21 Jul 2024 19:58:31 +0000 Received: from localhost ([127.0.0.1]:56109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVchT-0001Zx-1l for submit@debbugs.gnu.org; Sun, 21 Jul 2024 15:58:31 -0400 Received: from mail-il1-f172.google.com ([209.85.166.172]:60906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVchQ-0001Zi-C6 for 72237@debbugs.gnu.org; Sun, 21 Jul 2024 15:58:29 -0400 Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-39834949e42so9175545ab.1 for <72237@debbugs.gnu.org>; Sun, 21 Jul 2024 12:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721591840; x=1722196640; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hhq75FZtTQ8XFE1HcdoTsRcppEQpkPoPDiexb7BJ/fI=; b=PWkDjQaBhQxz3sWTh7H0OsAQAU5BFpxNlA7tBPjYbNIyRfsPnDDiAgMZNKH1fRU1xq O8EQe+JFiWdh8rR/Lb4KSGrU/a4rxgqT1SFSIXtRpNJcQKMkfzQ2nDORmH7p2ieOUyob 6NwLNXtPZHdAFggA2oCw/BG1W1vSyanoDs0h0V0ARGU6XlQ8bxCZ0sq8rhWb37QUirec njO7rp40SP3Lrc7mrYkrwK0cEe2PM0S6LYITC0p/L+Sw3F3be9+NxZ/i9MKNF9k03soM akB4Vv4MzaYlXjmvBhjXRfVVxBlWvIIwAa5Wh6saufejwyRNRerNPSb6tgOZ0rYy1HDo z/Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721591840; x=1722196640; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hhq75FZtTQ8XFE1HcdoTsRcppEQpkPoPDiexb7BJ/fI=; b=CDcbyyjMfxLFOCB6Bhwa0eeDpK+c8OGlGrpl+4kY2KeXRb9Vf4Kt4kyeG4HzX5eRw5 fDvQjp3tYcZrB191SyCkttrXahnxX6EOdgyhGkS6dHRKIqZU+R0JzI6+MO3FSBnPmXcu AgFS14ux0IBDmkEeSzgSkt8urcb79nfb0LC5tmdeKi7XZRY7kPDoPbMU/pgQYeuemnjM KCbn3QHf9Tjbi12ETW6jVr45VtG9+uYnByypzOhGH+f+VA8fmq/6yl/DHOZiUNgxrsEW tWFToEm1rhRUDXjG4uFnj9plm2YZOBFFNsN62yaI5+2YmjAGiXXdtyyuhiASYKOqXfnI JP7w== X-Gm-Message-State: AOJu0Yz6z9/tzTdTBjRjRRtYvH5HB/kkjYfydM9VmUDLVl2JoSusZB8R 1/EnMgklta/PnN1q6z5kjlfVYnEU0XkglpwI0WpZysZnggBYOyA7aaYYHQ== X-Google-Smtp-Source: AGHT+IGHlO/7ODVxk+tWuj/g68aBhhrnQzqaBVCR8lzbOAnaqAXQt7i4fq/dg11sO0x5JPPv9yK7qQ== X-Received: by 2002:a05:6e02:1fe1:b0:397:a93e:fff4 with SMTP id e9e14a558f8ab-399403ac152mr55554065ab.19.1721591839985; Sun, 21 Jul 2024 12:57:19 -0700 (PDT) Received: from fedora (c-67-180-36-62.hsd1.ca.comcast.net. [67.180.36.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f31bd9bsm40069735ad.157.2024.07.21.12.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 12:57:19 -0700 (PDT) From: Collin Funk In-Reply-To: <2739967.muMEfcBPU2@nimes> (Bruno Haible's message of "Sun, 21 Jul 2024 21:31:52 +0200") References: <2739967.muMEfcBPU2@nimes> Date: Sun, 21 Jul 2024 12:57:18 -0700 Message-ID: <87r0bmjz6p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Bruno, Bruno Haible writes: > The attached patch fixes it. Tested also with VPATH builds, with > - GNU make, > - FreeBSD make, > - NetBSD make. To save you time in the future testing either FreeBSD or NetBSD make should be enough. A portable version of NetBSD make is maintained and that one is used by FreeBSD [1] [2]. OpenBSD seems to have made their own changes and maintained it themselves since the operating system was forked from NetBSD. Also, 'bmake' is packaged in Debian and Fedora at least. You can probably build the latest version on your host system for testing. Collin [1] https://www.crufty.net/help/sjg/bmake.html [2] https://ftp.netbsd.org/pub/NetBSD/misc/sjg/ From unknown Sun Sep 21 02:49:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#72237: [bug-diffutils] BSD make Resent-From: Bruno Haible Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Sun, 21 Jul 2024 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72237 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: To: Collin Funk Cc: 72237@debbugs.gnu.org Received: via spool by 72237-submit@debbugs.gnu.org id=B72237.172159434310295 (code B ref 72237); Sun, 21 Jul 2024 20:40:02 +0000 Received: (at 72237) by debbugs.gnu.org; 21 Jul 2024 20:39:03 +0000 Received: from localhost ([127.0.0.1]:56223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVdKg-0002fz-T2 for submit@debbugs.gnu.org; Sun, 21 Jul 2024 16:39:03 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:34239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVdKe-0002fW-9m for 72237@debbugs.gnu.org; Sun, 21 Jul 2024 16:39:01 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1721594335; cv=none; d=strato.com; s=strato-dkim-0002; b=rt0bE9AViGFeIsht1LbnSfZEMBxUWYpobExS1RgsQpU5IuBSWrRQrrcEZnvs4fpZH8 1ub/n0JiPrT7JSI+n0hXiCPUKuixMTYAmF7DA9SSYuFb3btWEBmwdgsdoRdVIrEftJ8d P7av1E45Pmi3X5/kbYpWDT474MqSi7X49ZJKFOPNGSOl6zAapBzGC2/IX/OtIfQ+dr03 JqfP2+ukgipN2suocttUBz3IDFDff+rDnhi/wlJg4AnjtzsQY8dPu/Ud//wPsvTPDHZF PuF69KHSOwQeGaus/BN6zIWQCWf8ZudzUtIcGmrVvm/0o/ZGaNGjoijRKFPg3gmrC66I H0OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1721594335; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=DiUEZUfjPJ82zvMACCnoqIvzsaotlSbc15qWlQs5DIw=; b=rs+wuLw/0bTXWlIajjLn0xbaNmtVldYclBmOq2XpTFQz5jnvIXipfnQ1QEGIPWaZTL qZbm8lC15ZyhmTdrI24AVmGBpLpq2fP5VxR5jxuvrIHQnI5zVny6Y3PNgnU4sQPILc7V VQn+NHCnX5Oi22/xFoyTxF/3Sp9Q8vWiRAOTxJ5i1DNc+k+YroEdUhZfz2ZnwcILHRYI ZmRaH2CObR1rSJz8MQdcdwgKYbIri4lrwzZGUWC/PGAbrHetDxAB47ZLqlFX72P9pYZ+ LWVY5+hZdiOgr6Nya95tlGGhB4wdudRKdFkSLVvrYBCkgDi0uYUD0I6VQYiT6nMQHknk /gAw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1721594335; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=DiUEZUfjPJ82zvMACCnoqIvzsaotlSbc15qWlQs5DIw=; b=BNa+GW/Xox7vgpEZSF+PYmvUPPVwV/Q2fijTCnEiuilLT90eRaL3YHpd9ZFBkam7NF xGhCZMUTnBu0irh/DwnroyNb01t1zrhj7aDDEVwfDMLM9qjBQ+9kLqv/2e6TkGa5m03k XTQphD+3UYXfOMlb1zXivz0u6FkFsNWedbJIDz0DRIaqHZwYb9UIv26q9+wMKGVEGWtq stzAK0Zt7O8gP0dxK4CbPIv+VTyyRq0+hNota24mvkjZBzVd9cIku7wsGVs24UVLZCGg 7br6x9IjPm7bhhuMubarpXpXbfBo1XpyGIdXZ2xpCK9I1c3GP9ndfQbJaxJqZHvoensq rNGw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1721594335; s=strato-dkim-0003; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=DiUEZUfjPJ82zvMACCnoqIvzsaotlSbc15qWlQs5DIw=; b=XfLe/CqmkHC1zxKpLH2BCgBhp0bwGdzTginxPMfqrAgudobZtIZ+D8soHFCozz5R2q HapXH65Q6x+lZXaqI3Dw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOejaAQLQQQx2f230GW7tdW2kDZtw==" Received: from nimes.localnet by smtp.strato.de (RZmta 50.5.0 AUTH) with ESMTPSA id N0957e06LKcsMmV (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 21 Jul 2024 22:38:54 +0200 (CEST) From: Bruno Haible Date: Sun, 21 Jul 2024 22:38:54 +0200 Message-ID: <5858703.peFUeoqG7q@nimes> In-Reply-To: <87r0bmjz6p.fsf@gmail.com> References: <2739967.muMEfcBPU2@nimes> <87r0bmjz6p.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Collin Funk wrote: > To save you time in the future testing either FreeBSD or NetBSD make > should be enough. A portable version of NetBSD make is maintained and > that one is used by FreeBSD [1] [2]. OpenBSD seems to have made their > own changes and maintained it themselves since the operating system was > forked from NetBSD. Thanks for the hint. Indeed, the two directories freebsd - src/contrib/bmake netbsd - src/usr.bin/make appear to be quite similar. OpenBSD make behaves differently in VPATH builds, as we have recently seen. Bruno From unknown Sun Sep 21 02:49:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bruno Haible Subject: bug#72237: closed (Re: [bug-diffutils] bug#72237: diffutils "make dist" not compliant with the GNU Coding Standards) Message-ID: References: <2739967.muMEfcBPU2@nimes> X-Gnu-PR-Message: they-closed 72237 X-Gnu-PR-Package: diffutils Reply-To: 72237@debbugs.gnu.org Date: Mon, 22 Jul 2024 15:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1721660522-18697-1" This is a multi-part message in MIME format... ------------=_1721660522-18697-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #72237: diffutils "make dist" not compliant with the GNU Coding Standards which was filed against the diffutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 72237@debbugs.gnu.org. --=20 72237: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72237 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1721660522-18697-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 72237-done) by debbugs.gnu.org; 22 Jul 2024 15:01:55 +0000 Received: from localhost ([127.0.0.1]:58430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVuXz-0004rF-8m for submit@debbugs.gnu.org; Mon, 22 Jul 2024 11:01:55 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:60464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVuXw-0004r7-Eb for 72237-done@debbugs.gnu.org; Mon, 22 Jul 2024 11:01:53 -0400 Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-6bce380eb96so2361508a12.0 for <72237-done@debbugs.gnu.org>; Mon, 22 Jul 2024 08:01:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721660508; x=1722265308; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dB/tJPsjt2ZjhvFkiZbMkOXso057wcM+nnFoRMxU4HY=; b=LZEwJCqfwzPme8Pxd+P0ZfBZFA6RXq2YXTx3v48PRerp1rb73y7lgKQ5wbZN3hJGcy Kuoxcd8jAWl+75Ib7GwcDSmGZR4tZ4nKWLO97Pyw3iCOI4EgmdFiKsO29qdH9MxVd28c I1UvnTpwwSonz6DmVpExCKURyIyFGH48n5Q4EiQyf/8dWoYMOHMj9TuIojvDz4vbW9Q0 DFgHqXc+YfkOc7w1JwUMTSzOLntxfGvs7LrrCB55kdxhZVJPO3xcX+t+lUAOVmY4MQSE OcG6rsP7nxxoYL8AVWhGnFewXoWy6RHjFi3Z2ftRjAkjAkP5mxCglUWlKV1o5EuswW18 p32g== X-Gm-Message-State: AOJu0YzWsoqiguT5SJo2MMqEN0AhgCCQ89MTIs75VZ5O/GAh1ZqVmmWx zCPH1KfdSpotWBPB4l/lmSNDVrspmV5vCbF/x27AEYJvvKpE3uqLKW3u3UoxmrPNme2du8gHKPY Ph0SsSKFvsT4wYkgibBfWVmDKKAd/LQ== X-Google-Smtp-Source: AGHT+IFgH9WksZorfeqmPLNX58m7iVRux1GQYTCUTo1ceySg48YS8vmXSCGtKBB0rJ8PX4ZA3lmkg2NX7ktrSw5+Ao4= X-Received: by 2002:a17:90b:3b87:b0:2c9:99e4:51bd with SMTP id 98e67ed59e1d1-2cd274f02b2mr3236539a91.29.1721660508149; Mon, 22 Jul 2024 08:01:48 -0700 (PDT) MIME-Version: 1.0 References: <2739967.muMEfcBPU2@nimes> In-Reply-To: <2739967.muMEfcBPU2@nimes> From: Jim Meyering Date: Mon, 22 Jul 2024 08:01:36 -0700 Message-ID: Subject: Re: [bug-diffutils] bug#72237: diffutils "make dist" not compliant with the GNU Coding Standards To: Bruno Haible Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72237-done Cc: 72237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) marking as done ------------=_1721660522-18697-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Jul 2024 19:32:03 +0000 Received: from localhost ([127.0.0.1]:56090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVcHr-0000xW-8q for submit@debbugs.gnu.org; Sun, 21 Jul 2024 15:32:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:56874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVcHp-0000wy-Ai for submit@debbugs.gnu.org; Sun, 21 Jul 2024 15:32:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVcHm-0003Cs-OG for bug-diffutils@gnu.org; Sun, 21 Jul 2024 15:31:58 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVcHk-0004A6-9y for bug-diffutils@gnu.org; Sun, 21 Jul 2024 15:31:58 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1721590312; cv=none; d=strato.com; s=strato-dkim-0002; b=l+EW/KzCB59v/BnMGSj3yvaLMKLzVDG7FXqsqyaCKX46mj7XnLnX3e+iDUvfT+jfJS A5uQjj2/pBtHsDB8uuEvMEOdYpTolBK54nsbdrP0itpHiWAR3Ehc/T0+4Cwpq9EQ+Vzv p4A2UW6hsRZ7YNkOzdnjJu3R6KcylSgrM6y6Dzx+CJRGfIFlMDK+pYnIvjlCOzS6x89u 1FQZjHsfVMbBb7JBhVr/PGSLoN0gZsEWVSTrbIuVPDvuX2wIN6Q6A7H5iIfLJeh6nDKF cX3wtvRBFP80VmeZtyCv1L8WQEwUpAHhRAKjWuuw4XL4cb8hmJuiBJPce0G4VnEfgje1 WcjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1721590312; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=oXL70TI7C7xe2LXsQ4vzIlQ3jCu03OdJbOpq8jozXRU=; b=UvUv+RPjCz4NZoo9buKKXUB2f66DwbYlEQps2UW9/1PY4BJmOtE3W5F3+GkXuIuQh4 gGSIOIs9EN5LVsL/vJrYYLZylqogtldGal8TCFupIkeBhuqic0R4z+SIR6EuaqkfsCHA NQ9OySXPrvMwPJMlMD3NDdKcLyUspcuily6QyLOn7kI0oHqIjNRazhUJT9sJtZKmieJN KZK5WExgcJ3iYEvVi7OSLrrH6lOWUQx5h+5bjPwqa+NgswzjXsaPA46r9WLhQDdLtg7Y OZW9vqdmavXFnEtS1TY5W+v55GlI87/NcgpKX8gVhJkCRbZyhk4dyXlU4OwUlhiL2vsJ ko4Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1721590312; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=oXL70TI7C7xe2LXsQ4vzIlQ3jCu03OdJbOpq8jozXRU=; b=KNnpxZirXGgJcb5fgNVltiX6EIVQOIrCzmWMON8DVfrhvp1LsT++q5wg+x4ux8yM0D BRR3kkpFOZEGjTKOzIDk+ARVOfuOc2eJbh85cealLo8rXGq+uBgzM6Kv0OWSTJrrwMxp RB35My95nYAm34G/1C6iVtJNlqozyxwMjpkYeHTebpKLIWfdynSenYit7/WyRGgnzai8 VWM1DlfU3p8Vs0vzTqlIgrubsAXFWkK6Wam18u47Hu/fiQgXFXNYF2ND2soVe+YKrkZR oUpkeCL9gxYYkCO3X9WFQlpdNlLoHMrICtE850FeFlRlLkc0//mWQt7dF46Bp91A4Feu cOKw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1721590312; s=strato-dkim-0003; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=oXL70TI7C7xe2LXsQ4vzIlQ3jCu03OdJbOpq8jozXRU=; b=x7Ggl2KwIIzxxSZQFFp0++YI3wR8htOXc/Pi4ytKHi3aHxjetcB0F8viEwGAx9BlW2 W75orwTtulg19BJIZ/Bg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOejaAQLQQQx2f230GW7tdW2kDZtw==" Received: from nimes.localnet by smtp.strato.de (RZmta 50.5.0 AUTH) with ESMTPSA id N0957e06LJVqMi4 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 21 Jul 2024 21:31:52 +0200 (CEST) From: Bruno Haible To: bug-diffutils@gnu.org Subject: diffutils "make dist" not compliant with the GNU Coding Standards Date: Sun, 21 Jul 2024 21:31:52 +0200 Message-ID: <2739967.muMEfcBPU2@nimes> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart8200989.tOnEmuZJvr" Content-Transfer-Encoding: 7Bit Received-SPF: none client-ip=85.215.255.21; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --nextPart8200989.tOnEmuZJvr Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, According to the GNU Coding Standard https://www.gnu.org/prep/standards/html_node/Standard-Targets.html "The dist target should explicitly depend on all non-source files that are in the distribution, to make sure they are up to date in the distribution." An easy way to test whether the 'dist' target has this property is to run $ ./configure $ make dist or (in a VPATH build) $ ../configure $ make dist without doing "make" before "make dist". Distributed non-source files that make this difficult are the man pages for programs, that are generated from the '--help' output using help2man. While packages that only have a top-level Makefile.am (such as GNU sed or GNU coreutils) get this right, it is a little bit more complicated in packages with a Makefile.am per directory (such as GNU diffutils and GNU gettext). Originally reported for GNU gettext at . In GNU diffutils $ ./configure; make dist V=1 fails like this: make[3]: Entering directory '/DIFFUTILS/diffutils/man' make distdir-am make[4]: Entering directory '/DIFFUTILS/diffutils/man' base=`expr cmp.1 : '\(.*\).1'` \ && test -x ../src/$base \ && (echo '[NAME]' \ && sed 's@/\* *@@; s/-/\\-/;s/^GNU //; q' ../src/$base.c) \ | PATH="../src:$PATH" \ ./help2man -i - -i ./$base.x \ -S 'diffutils 2024-05-21' $base > cmp.1-t && mv cmp.1-t cmp.1 make[4]: *** [Makefile:2483: cmp.1] Error 1 make[4]: Leaving directory '/DIFFUTILS/diffutils/man' make[3]: *** [Makefile:2322: distdir] Error 2 make[3]: Leaving directory '/DIFFUTILS/diffutils/man' The attached patch fixes it. Tested also with VPATH builds, with - GNU make, - FreeBSD make, - NetBSD make. Tested also with parallel make, through $ ./configure; make -j8 dist V=1 --nextPart8200989.tOnEmuZJvr Content-Disposition: attachment; filename="0001-build-Fix-failure-of-.-configure-make-dist.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-build-Fix-failure-of-.-configure-make-dist.patch" >From 9c8b154025243e4527ccc1640cde75d4d9ae50f4 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sun, 21 Jul 2024 21:25:01 +0200 Subject: [PATCH] build: Fix failure of "./configure; make dist" * Makefile.am (BUILT_SOURCES): New variable. (man/cmp.1, man/diff.1, man/diff3.1, man/sdiff.1): New targets. (gen-man1): New phony target. --- Makefile.am | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Makefile.am b/Makefile.am index 59084bc..564b46a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -24,6 +24,24 @@ SUBDIRS = lib src tests doc man po gnulib-tests ACLOCAL_AMFLAGS = -I m4 AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS) +# Ensure that the manual pages are up-to-date when "make dist" runs. +BUILT_SOURCES = \ + man/cmp.1 \ + man/diff.1 \ + man/diff3.1 \ + man/sdiff.1 +man/cmp.1 man/diff.1 man/diff3.1 man/sdiff.1 : gen-man1 +.PHONY: gen-man1 +gen-man1: $(top_srcdir)/src/cmp.c man/cmp.x \ + $(top_srcdir)/src/diff.c man/diff.x \ + $(top_srcdir)/src/diff3.c man/diff3.x \ + $(top_srcdir)/src/sdiff.c man/sdiff.x + $(AM_V_GEN)(cd lib && $(MAKE) $(AM_MAKEFLAGS)) \ + && (cd src \ + && $(MAKE) $(AM_MAKEFLAGS) \ + cmp$(EXEEXT) diff$(EXEEXT) diff3$(EXEEXT) sdiff$(EXEEXT)) \ + && (cd man && $(MAKE) $(AM_MAKEFLAGS) cmp.1 diff.1 diff3.1 sdiff.1) + # Arrange so that .tarball-version appears only in the distribution # tarball, and never in a checked-out repository. dist-hook: gen-ChangeLog -- 2.34.1 --nextPart8200989.tOnEmuZJvr-- ------------=_1721660522-18697-1--