GNU bug report logs - #72231
[PATCH] gnu: Add emacs-org-remark.

Previous Next

Package: guix-patches;

Reported by: Vinicius Monego <monego <at> posteo.net>

Date: Sun, 21 Jul 2024 16:14:02 UTC

Severity: normal

Tags: patch

Done: Vinicius Monego <monego <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 72231-done <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Juliana Sims <juli <at> incana.org>
Cc: 72231-done <at> debbugs.gnu.org
Subject: Re: QA review for 72231
Date: Sun, 28 Jul 2024 15:37:48 +0000
Em dom, 2024-07-21 às 21:38 -0400, Juliana Sims escreveu:
> Hello,
> 
> This patch looks pretty good!  Things build fine, don't break pull, 
> etc. etc.  QA has a failure applying the patch, but I had no issues 
> apply on top of e5c0b62debc.  There is one small issue I see: the 
> description.  That "with using" bit should be cleaned up.  Also, it
> may 
> be worthwhile to include more information.  There appears to be a 
> "Features" section of the README which can provide some ideas.
> 
> Also, feel free to update your license line if you like :)
> 
> Best,
> Juli
> 
> PS this new QA web interface is snazzy!  It even gave me a little 
> checklist :D
> 
> Items marked as checked: Lint warnings, Package builds, Commit 
> messages, New package licenses, New package tests
> 
> 

Hi Juli,

I applied your suggestions and pushed the patch, thanks.

Vinicius




This bug report was last modified 1 year and 25 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.