GNU bug report logs - #72228
31.0.50; Wrong number fontification in cmake-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: Randy Taylor <dev <at> rjt.dev>
To: Ergus <spacibba <at> aol.com>
Cc: 72228 <at> debbugs.gnu.org
Subject: bug#72228: 31.0.50; Wrong number fontification in cmake-ts-mode
Date: Wed, 07 Aug 2024 01:00:01 +0000

[Message part 1 (text/plain, inline)]

On Monday, July 22nd, 2024 at 22:32, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> 
> On Sunday, July 21st, 2024 at 07:13, Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs <at> gnu.org wrote:
> 
> > When using cmake-ts-mode the numbers have 3 different faces:
> > 
> > 1, 2, 100: font-lock-number-face (OK)
> > 
> > 0 : font-lock-constant-face. The cmake-ts-mode--constants takes
> > precedence over regex in font-lock-number-face. It is not clear that
> > this one can be fixed.
> 
> 
> 1 also gets font-lock-constant-face.
> 
> I think we should just remove "1" and "0" from cmake-ts-mode--constants.
> 
> > -1, -2 : Not fontified. This seems simpler to fix, the regex in
> > font-lock-number-face is missing a `-?' before the first [[:digit:]])
> 
> 
> Indeed. Would you like to submit a patch for that and the above?

I haven't heard anything back, so I've attached a patch doing so.

[0001-Fix-cmake-ts-mode-number-fontification-Bug-72228.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.