GNU bug report logs - #72210
31.0.50; Feature request: multi-category support in `icomplete-fido-kill'.

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Fernando de Morais <fernandodemorais.jf <at> gmail.com>, 72210 <at> debbugs.gnu.org, Daniel Mendler <mail <at> daniel-mendler.de>
Subject: bug#72210: 31.0.50; Feature request: multi-category support in `icomplete-fido-kill'
Date: Fri, 11 Apr 2025 08:35:40 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> The other is the confirmation prompt, which feels like it should be
>> implemented once and for all outside of the generic function.
>
> OK, the solution below is not perfect, but I think it's good enough for now.
>
> Any objection to the patch below?

Looks fine to me, don't I don't see what it gains us/you in practice.
Maybe there are some out-of-band implementations for
icomplete-kill-candidate out there (I haven't read the rest of the
issue).

Anyway, as a micro-nit, the docstring of the generic should use a more
assertive description of the protocol: "Return non-nil" instead of
"Should return non nil".

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.