From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 19 14:22:11 2024 Received: (at submit) by debbugs.gnu.org; 19 Jul 2024 18:22:11 +0000 Received: from localhost ([127.0.0.1]:50541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUsF8-0005x1-HQ for submit@debbugs.gnu.org; Fri, 19 Jul 2024 14:22:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:40058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUsBh-0005hy-Q4 for submit@debbugs.gnu.org; Fri, 19 Jul 2024 14:18:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUmlO-0002Qw-0d for bug-gnu-emacs@gnu.org; Fri, 19 Jul 2024 08:31:06 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUmlI-0005UH-LW for bug-gnu-emacs@gnu.org; Fri, 19 Jul 2024 08:31:05 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ew3GMvei fWbDVJW+NEf2pgUL3AQDl8NBOURa2Q19uyc=; h=date:subject:to:from; d=ledu-giraud.fr; b=A+TbYCyP0UZFkKK/JG6sUKqd3PbedukCXlY2mD4H1jI+y55M0N e1ZS4wxgcznGCuAUR6QsLMeGamUx/tXA+MCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ew3GMveifWbDVJW+ NEf2pgUL3AQDl8NBOURa2Q19uyc=; h=date:subject:to:from; d=ledu-giraud.fr; b=YwAW/oLhmMdJIjpKtO0nXipyHOtqPBUxdy+Z/QFERKPrz7eNnr JAr0JEikktinn3X29Lbuevt3FjwkXkDf6wDsImxVbPvmYXA0ARqtu7BI/+mVl9DHyhVehk o0TyFpMi5oafuWoeaNtip2RjauGvNaAQEO6Zvy3HBoi8DN19AQTDDGoZSdk9IBQksyviFy dJicDqiv9UNoXajNOCXahiaPQla3/K73X9oGp1YS+M9iqm14CKFeklaAkgyS9EWu5x/jCr V2p9wQgcG7Bwvl1bE8K7pICwslbYjWdlvsLUaLcmtLaPbc7rmiT2+JEgDafPwEfsGcv8av wqmDXw2E/viQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id de057333 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 19 Jul 2024 14:30:55 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 31.0.50; DocView on Postscript with SVG support X-Debbugs-Cc: Date: Fri, 19 Jul 2024 14:30:54 +0200 Message-ID: <87msmd4l8h.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, DocView seems to do the wrong thing on a Postscript file when there is support for SVG in Emacs. I also have "gs" and "mutool" installed. How to reproduce: - emacs -Q - C-x C-f "existing-document.ps" - C-c C-c -> no images displayed Looking for pages into the cache with `doc-view-dired-cache', it seems that DocView has produced PNG content into files with "svg" extension. Emacs then tries to display SVG images with PNG content and, obviously, failed. The following patch fixes the issue for me but maybe there is more than meets the eye: diff --git a/lisp/doc-view.el b/lisp/doc-view.el index f96b1bad886..e3539f8f886 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter (pcase-let ((`(,conv-function ,type ,extension) (pcase doc-view-doc-type ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif")) + ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png")) (_ (if (and (eq doc-view-pdf->png-converter-function #'doc-view-pdf->png-converter-mupdf) doc-view-mupdf-use-svg) In GNU Emacs 31.0.50 (build 20, x86_64-unknown-openbsd7.5) of 2024-07-18 built on computer Repository revision: da97096fdbb50bf69348813c960eb8d10b2bdc44 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: OpenBSD computer 7.5 GENERIC.MP#191 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo --without-compress-install' Configured features: DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t display-time-mode: t display-battery-mode: t desktop-save-mode: t exwm-randr-mode: t server-mode: t outline-minor-mode: t electric-pair-mode: t override-global-mode: t repeat-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-randr /home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm /home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xsettings /home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xim /home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-workspace /home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-systemtray /home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-manage /home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-layout /home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-input /home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-floating /home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-core /home/manuel/prog/elisp/exwm/exwm-config hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-config /home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-background /home/manuel/.emacs.d/elpa/ef-themes-1.7.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/31.0.50/lisp/theme-loaddefs Features: (shadow descr-text dabbrev emacsbug smerge-mode diff whitespace edebug debug backtrace vc-annotate shortdoc comp-common display-line-numbers bookmark add-log vc-hg vc-bzr vc-src vc-sccs vc-svn cl-print doctor help-fns radix-tree ps-mode ibuf-ext ibuffer ibuffer-loaddefs mule-util shr-color mailalias smtpmail flow-fill sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-cache qp utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss pcmpl-gnu misearch multi-isearch tabify imenu man pcmpl-unix pulse org-indent org-agenda texinfo texinfo-loaddefs bug-reference flymake-cc flymake warnings python conf-mode oc-basic org-element org-persist org-id org-element-ast inline avl-tree ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-compat org-macs vc-dir ewoc vc on-screen eww url-queue mm-url vc-git diff-mode track-changes vc-dispatcher vc-cvs vc-rcs log-view pcvs-util make-mode view gnus-dired sh-script smie treesit executable time battery cus-load desktop frameset exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-kassio-theme ef-themes modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm ytdious mpdired transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win ebdb-message message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base timezone icalendar gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit web-mode derived disp-table erlang-start skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep compat slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline pp comint ansi-osc ansi-color ring hyperspec thingatpt elec-pair edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired dired-loaddefs use-package-core repeat easy-mmode calfw-autoloads calfw-cal-autoloads calfw-org-autoloads debbugs-autoloads ebdb-autoloads cl-extra help-mode ef-themes-autoloads exwm-autoloads hyperbole-autoloads kotl-autoloads hact set hhist on-screen-autoloads osm-autoloads rust-mode-autoloads info slime-autoloads macrostep-autoloads speed-type-autoloads transmission-autoloads xelb-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 1235798 352745) (symbols 48 72425 28) (strings 32 345078 5656) (string-bytes 1 10173833) (vectors 16 185050) (vector-slots 8 2589583 99750) (floats 8 769 8358) (intervals 56 52756 11540) (buffers 992 186)) -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 20 03:14:32 2024 Received: (at 72193) by debbugs.gnu.org; 20 Jul 2024 07:14:32 +0000 Received: from localhost ([127.0.0.1]:51636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV4Ia-00047N-At for submit@debbugs.gnu.org; Sat, 20 Jul 2024 03:14:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV4IY-000478-6H for 72193@debbugs.gnu.org; Sat, 20 Jul 2024 03:14:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV4IR-0007sS-Or; Sat, 20 Jul 2024 03:14:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dLsBSJFghHcZDKub0qMrIk0PneHOwrMZ7nNrxSoKoWw=; b=ioGoY3dHKwvU 3DkVJ6LdO1ZN6NohJq7rsRh6ijlH4R8uV4cRIg9whOYFfmXVDkS2JR2OwIzxS3oR/F/ddfdrf3j+U tIXRMV4lRa9vEcnn3d1jZ8TkB/78Qo0KrFjnTijc7U+oAbl8Vzls+xXU80x3zySqaHI7yhcA104nh g3krdYjJUBN2xjQ4/CXRH2jFOXzeuhkJDRLv2nFttX8xHhPdackRWXYTKigxwrQjYNaoe8K6KwxWl Co/MehKRvd0TsR37T8L4VCSq0GH3viDpey0rPPWE4BXKuCzo1JTQtPTw55/zQfZXfTDMrbML8xsDj yHIXJ0Hz9gg6q17zZChjxw==; Date: Sat, 20 Jul 2024 10:14:21 +0300 Message-Id: <86sew4edrm.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud , Tassilo Horn In-Reply-To: <87msmd4l8h.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#72193: 31.0.50; DocView on Postscript with SVG support References: <87msmd4l8h.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72193 Cc: 72193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 19 Jul 2024 14:30:54 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > DocView seems to do the wrong thing on a Postscript file when there is > support for SVG in Emacs. I also have "gs" and "mutool" installed. > > How to reproduce: > - emacs -Q > - C-x C-f "existing-document.ps" > - C-c C-c -> no images displayed > > Looking for pages into the cache with `doc-view-dired-cache', it seems > that DocView has produced PNG content into files with "svg" extension. > Emacs then tries to display SVG images with PNG content and, obviously, > failed. > > The following patch fixes the issue for me but maybe there is more than > meets the eye: > > diff --git a/lisp/doc-view.el b/lisp/doc-view.el > index f96b1bad886..e3539f8f886 100644 > --- a/lisp/doc-view.el > +++ b/lisp/doc-view.el > @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter > (pcase-let ((`(,conv-function ,type ,extension) > (pcase doc-view-doc-type > ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif")) > + ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png")) > (_ (if (and (eq doc-view-pdf->png-converter-function > #'doc-view-pdf->png-converter-mupdf) > doc-view-mupdf-use-svg) Tassilo, any comments or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 20 16:27:18 2024 Received: (at 72193) by debbugs.gnu.org; 20 Jul 2024 20:27:18 +0000 Received: from localhost ([127.0.0.1]:53955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVGfm-0006Qn-9W for submit@debbugs.gnu.org; Sat, 20 Jul 2024 16:27:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVGfk-0006Qa-7C for 72193@debbugs.gnu.org; Sat, 20 Jul 2024 16:27:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVGfd-0005ou-77; Sat, 20 Jul 2024 16:27:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=0h565YwESsCmT80I5B7iq2xOiqpcew4VnsAWwTgaQ5k=; b=Qx1fWo8UWhI0pYiVzM2N qFgvzgGnXK40WFB2JqoUh/Zus0MclK4ST2MPIhkHui2Sz2ovCZPuvwkM2X3nNsbzap245FpuScdzx o2tkAtGyqFu+pq6d7ET3sDoiRsf77W6sZjErUzAsjyse/M9JkLcqokneh/FS8YHtSJJVwDPxybb6b qoaun3t0VQ10aXQytR0VbNTH5l1wuXziDsNJZE95Tz+eOl+2WOV/2DvesOUaZ3Vq/w2yAneB5uN3+ kwd+TDo2E9ZEvpj8FRQCOp198Sgfj+LX8zLWOLqMqzRwZy0JzIVruagTU3kFDqDPzP+ptAGOr7A9I v248eGSJoAjOVg==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheefgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepte eltdegheffhfetkeekveekkeevgfegkeetueffleeiheekhffgffeuueegieffnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#72193: 31.0.50; DocView on Postscript with SVG support In-Reply-To: <86sew4edrm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Jul 2024 10:14:21 +0300") References: <87msmd4l8h.fsf@ledu-giraud.fr> <86sew4edrm.fsf@gnu.org> Date: Sat, 20 Jul 2024 22:27:03 +0200 Message-ID: <878qxvajxk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72193 Cc: 72193@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: Hi Manuel & Eli, >> Looking for pages into the cache with `doc-view-dired-cache', it >> seems that DocView has produced PNG content into files with "svg" >> extension. Emacs then tries to display SVG images with PNG content >> and, obviously, failed. >> >> The following patch fixes the issue for me but maybe there is more than >> meets the eye: >> >> diff --git a/lisp/doc-view.el b/lisp/doc-view.el >> index f96b1bad886..e3539f8f886 100644 >> --- a/lisp/doc-view.el >> +++ b/lisp/doc-view.el >> @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter >> (pcase-let ((`(,conv-function ,type ,extension) >> (pcase doc-view-doc-type >> ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif")) >> + ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png")) >> (_ (if (and (eq doc-view-pdf->png-converter-function >> #'doc-view-pdf->png-converter-mupdf) >> doc-view-mupdf-use-svg) > > Tassilo, any comments or suggestions? The patch is absolutely correct. That's been an oversight, I think. Thanks Manuel! Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 21 03:27:19 2024 Received: (at 72193-done) by debbugs.gnu.org; 21 Jul 2024 07:27:19 +0000 Received: from localhost ([127.0.0.1]:54677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVQyV-0007LR-3p for submit@debbugs.gnu.org; Sun, 21 Jul 2024 03:27:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVQyT-0007LC-7h for 72193-done@debbugs.gnu.org; Sun, 21 Jul 2024 03:27:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVQyM-0001bZ-7J; Sun, 21 Jul 2024 03:27:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GqhE7jjHnm8DmDiptssjwabqjWvgPLMVWsy8pTCoUik=; b=IEdgcGhQSsLu aBWcJrk7E5r0m9tpCxKch52t45pyXvDn9IvRZzgnhnpMOSlT9LLq2eNvRF7q7SnjwBAoR1vGBnUs3 pqQv8QsNiAqjCtLZ5Re+P2NMBYZGADwjRD2/9spRPtzap83I44o2MKKv2ZlwLbyLI6eHFcXZs2kBf PcPbp+snlfpcUAGy6W24czfjyIL3ZCFRNXtdGIfRae0lSXJd2aj5fair59dyv9OUlsPAUY6QQ4nHy f7x4FuLVEK/tydJdkQpcF5kzHyCdEUH0Z1A7hoZG1H70JliNiOK24W2RSoMHFzGZitBPml/r6dv1M B1n7qjQrCLQpXcj+6+qLxw==; Date: Sun, 21 Jul 2024 10:27:06 +0300 Message-Id: <86bk2rciid.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <878qxvajxk.fsf@gnu.org> (message from Tassilo Horn on Sat, 20 Jul 2024 22:27:03 +0200) Subject: Re: bug#72193: 31.0.50; DocView on Postscript with SVG support References: <87msmd4l8h.fsf@ledu-giraud.fr> <86sew4edrm.fsf@gnu.org> <878qxvajxk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 72193-done Cc: 72193-done@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: Manuel Giraud , 72193@debbugs.gnu.org > Date: Sat, 20 Jul 2024 22:27:03 +0200 > > Eli Zaretskii writes: > > Hi Manuel & Eli, > > >> Looking for pages into the cache with `doc-view-dired-cache', it > >> seems that DocView has produced PNG content into files with "svg" > >> extension. Emacs then tries to display SVG images with PNG content > >> and, obviously, failed. > >> > >> The following patch fixes the issue for me but maybe there is more than > >> meets the eye: > >> > >> diff --git a/lisp/doc-view.el b/lisp/doc-view.el > >> index f96b1bad886..e3539f8f886 100644 > >> --- a/lisp/doc-view.el > >> +++ b/lisp/doc-view.el > >> @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter > >> (pcase-let ((`(,conv-function ,type ,extension) > >> (pcase doc-view-doc-type > >> ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif")) > >> + ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png")) > >> (_ (if (and (eq doc-view-pdf->png-converter-function > >> #'doc-view-pdf->png-converter-mupdf) > >> doc-view-mupdf-use-svg) > > > > Tassilo, any comments or suggestions? > > The patch is absolutely correct. That's been an oversight, I think. > Thanks Manuel! Thanks, now installed on the emacs-30 branch, and closing the bug. From unknown Fri Sep 19 17:22:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Aug 2024 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator