GNU bug report logs - #72180
[PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.

Previous Next

Package: guix-patches;

Reported by: Mathieu Laparie <matf <at> disr.it>

Date: Thu, 18 Jul 2024 17:56:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Laparie <matf <at> disr.it>
Subject: bug#72180: closed (Re: [PATCH 0/2] gnu: mpv: Update to 0.38.0 and
 include sixel support.)
Date: Thu, 05 Sep 2024 20:26:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#72180: [PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 72180 <at> debbugs.gnu.org.

-- 
72180: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72180
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 72180-done <at> debbugs.gnu.org
Cc: Z572 <873216071 <at> qq.com>, Mathieu Laparie <matf <at> disr.it>
Subject: Re: [PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.
Date: Thu, 05 Sep 2024 22:24:15 +0200
Hello,

> Mathieu Laparie <matf <at> disr.it> writes:
> 
> > I needed sixel support in mpv and noticed our package did not include it, and updated to 0.38.0 while I was at it. This inmplied upgrading libplacebo to 6.338.2, but 7.349.0 is available and works too, so I jumped to that version. mpv 0.38.0 comes with a number of improvements on top of the sixel support included here, among which better playlist display in terminal (was previously garbled with broken character sequences hardcoded from the OSD), support for --input-commands to run commands at startup, zooming on Ctrl+wheel, etc.
> >
> > The pkg-config name of libsixel seems to be gdk-pixbuf, and it appeared that adding just libsixel in inputs was not enough for mpv to build with sixel support.
> 
> I think should move gdk-pixbuf to libsixel's propagated-inputs, and add
> a comment say gdk-pixbuf pkg-config's “Requires.private” need
> gdk-pixbuf, and add a TODO for "remove it when we use pkgconf."

Thank you. I applied the patch with the suggestions above. MPV had
already been updated, tho.

Regards,
-- 
Nicolas Goaziou



[Message part 3 (message/rfc822, inline)]
From: Mathieu Laparie <matf <at> disr.it>
To: guix-patches <at> gnu.org
Cc: Mathieu Laparie <matf <at> disr.it>
Subject: [PATCH 0/2] gnu: mpv: Update to 0.38.0 and include sixel support.
Date: Thu, 18 Jul 2024 19:55:22 +0200
I needed sixel support in mpv and noticed our package did not include it, and updated to 0.38.0 while I was at it. This inmplied upgrading libplacebo to 6.338.2, but 7.349.0 is available and works too, so I jumped to that version. mpv 0.38.0 comes with a number of improvements on top of the sixel support included here, among which better playlist display in terminal (was previously garbled with broken character sequences hardcoded from the OSD), support for --input-commands to run commands at startup, zooming on Ctrl+wheel, etc.

The pkg-config name of libsixel seems to be gdk-pixbuf, and it appeared that adding just libsixel in inputs was not enough for mpv to build with sixel support.

Mathieu Laparie (2):
  gnu: libplacebo: Update to 7.349.0.
  gnu: mpv: Update to 0.38.0, include sixel support.

 gnu/packages/video.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.45.2




This bug report was last modified 256 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.