GNU bug report logs - #72147
30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 72147 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command
Date: Thu, 25 Jul 2024 21:08:42 +0300

>> >> Thanks for the patch, now pushed to master.
>> >
>> > Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to
>> > `query-replace-read-args', for stylistic reasons?
>>
>> It's not clear how such arg should be combined with
>> `query-replace-lazy-highlight' in `query-replace-read-args':
>>
>> (defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight)
>>   ...
>>   (from (minibuffer-with-setup-hook
>>             (minibuffer-lazy-highlight-setup
>>              :highlight query-replace-lazy-highlight
>>
>> with `and'?  With `or'?  With `xor'?
>> `(and query-replace-lazy-highlight (not no-highlight))'?
>
> The installed patch binds query-replace-lazy-highlight to nil and
> shadows the old binding.  This would correspond to
>
>   (and query-replace-lazy-highlight (not no-highlight))
>
> which looks reasonable in this case: we just an argument to inhibit
> highlighting.  Because we never want highlighting in some cases (like
> here).

Agreed, let's add a new argument.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.