Subject: Re: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command

From: Michael Heerdegen <[email-masked]>
Date: Wed, 24 Jul 2024 19:09:48 +0200

Juri Linkov <[email-masked]> writes:

> >> Thanks for the patch, now pushed to master.
> >
> > Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to
> > `query-replace-read-args', for stylistic reasons?
>
> It's not clear how such arg should be combined with
> `query-replace-lazy-highlight' in `query-replace-read-args':
>
> (defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight)
>   ...
>   (from (minibuffer-with-setup-hook
>             (minibuffer-lazy-highlight-setup
>              :highlight query-replace-lazy-highlight
>
> with `and'?  With `or'?  With `xor'?
> `(and query-replace-lazy-highlight (not no-highlight))'?

The installed patch binds query-replace-lazy-highlight to nil and
shadows the old binding.  This would correspond to

  (and query-replace-lazy-highlight (not no-highlight))

which looks reasonable in this case: we just an argument to inhibit
highlighting.  Because we never want highlighting in some cases (like
here).

Michael.