Subject: Re: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command

From: Juri Linkov <[email-masked]>
Date: Tue, 23 Jul 2024 20:40:47 +0300

>> Thanks for the patch, now pushed to master.
>
> Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to
> `query-replace-read-args', for stylistic reasons?

It's not clear how such arg should be combined with
`query-replace-lazy-highlight' in `query-replace-read-args':

(defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight)
  ...
  (from (minibuffer-with-setup-hook
            (minibuffer-lazy-highlight-setup
             :highlight query-replace-lazy-highlight

with `and'?  With `or'?  With `xor'?
`(and query-replace-lazy-highlight (not no-highlight))'?