GNU bug report logs - #7214
sort --debug maps large old-style field number to 0 in diagnostic

Previous Next

Full log

Message #20 received at 7214 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>
Cc: Pádraig Brady <P <at> draigBrady.com>, 7214 <at> debbugs.gnu.org
Subject: Re: bug#7214: sort --debug maps large old-style field number to 0
	in	diagnostic
Date: Thu, 14 Oct 2010 09:48:52 -0700

On 10/14/10 05:44, Jim Meyering wrote:
>>        *val = SIZE_MAX;
>> > +      if (debug) /* Note --debug must come before keys to diagnose this.  */
>> > +        error (0, 0, _("%" PRIuMAX " is too large, using %zu"), n, *val);
> That does sound like an improvement (that would require comment changes),

No, it's better to silently treat large field numbers as if they were infinity.

'sort' already does that in other cases (e.g., specify_nthreads),
and so does 'join' (e.g., string_to_join_field), and we should
be doing that whenever possible.

The idea is that, since 'sort' can't possibly represent a line that
contains more than SIZE_MAX fields, it's correct to treat very large
field numbers, even numbers that provoke LONGINT_OVERFLOW, as if they
were SIZE_MAX.  GNU code should not contain arbitrary limits: so
when it's correct to substitute a representable number for a
number that's so large that it's unrepresentable, we should do that
instead of reporting an overflow and failing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.