GNU bug report logs - #72138
30.0.50; [PATCH] Fix ring size in comint-read-input-ring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#72138: closed (30.0.50; [PATCH] Fix ring size in
 comint-read-input-ring)
Date: Sat, 27 Jul 2024 07:15:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 27 Jul 2024 10:13:52 +0300
with message-id <867cd72tov.fsf <at> gnu.org>
and subject line Re: bug#72138: 30.0.50; [PATCH] Fix ring size in comint-read-input-ring
has caused the debbugs.gnu.org bug report #72138,
regarding 30.0.50; [PATCH] Fix ring size in comint-read-input-ring
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
72138: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72138
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Fix ring size in comint-read-input-ring
Date: Tue, 16 Jul 2024 18:10:00 +0800

[Message part 3 (text/plain, inline)]

Hi,

When comint-read-input-ring reads history to the ring, the global
value of comint-input-ring-size (i.e. 500) is used regardless of the
local value due to the use of temp buffer. For example:

1. HISTSIZE=10 emacs -Q
2. M-x shell

The buffer-local value of comint-input-ring-size is correctly set to
10, but C-c C-l shows 500 commands.

The attached patch fixes the problem that comint-read-input-ring
ignores the buffer-local comint-input-ring-size. Thanks.

[0001-lisp-comint.el-comint-read-input-ring-Fix-ring-size.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: 72138-done <at> debbugs.gnu.org
Subject: Re: bug#72138: 30.0.50;
 [PATCH] Fix ring size in comint-read-input-ring
Date: Sat, 27 Jul 2024 10:13:52 +0300

> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Tue, 16 Jul 2024 18:10:00 +0800
> 
> When comint-read-input-ring reads history to the ring, the global
> value of comint-input-ring-size (i.e. 500) is used regardless of the
> local value due to the use of temp buffer. For example:
> 
> 1. HISTSIZE=10 emacs -Q
> 2. M-x shell
> 
> The buffer-local value of comint-input-ring-size is correctly set to
> 10, but C-c C-l shows 500 commands.
> 
> The attached patch fixes the problem that comint-read-input-ring
> ignores the buffer-local comint-input-ring-size. Thanks.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.