GNU bug report logs - #72138
30.0.50; [PATCH] Fix ring size in comint-read-input-ring

Previous Next

Package: emacs;

Reported by: Liu Hui <liuhui1610 <at> gmail.com>

Date: Tue, 16 Jul 2024 10:11:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Fix ring size in comint-read-input-ring
Date: Tue, 16 Jul 2024 18:10:00 +0800
[Message part 1 (text/plain, inline)]
Hi,

When comint-read-input-ring reads history to the ring, the global
value of comint-input-ring-size (i.e. 500) is used regardless of the
local value due to the use of temp buffer. For example:

1. HISTSIZE=10 emacs -Q
2. M-x shell

The buffer-local value of comint-input-ring-size is correctly set to
10, but C-c C-l shows 500 commands.

The attached patch fixes the problem that comint-read-input-ring
ignores the buffer-local comint-input-ring-size. Thanks.
[0001-lisp-comint.el-comint-read-input-ring-Fix-ring-size.patch (text/x-patch, attachment)]

This bug report was last modified 355 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.