From unknown Sat Jun 21 10:39:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#72106 <72106@debbugs.gnu.org> To: bug#72106 <72106@debbugs.gnu.org> Subject: Status: [PATCH 0/3] gnu: klee: Enable test suite Reply-To: bug#72106 <72106@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:39:09 +0000 retitle 72106 [PATCH 0/3] gnu: klee: Enable test suite reassign 72106 guix-patches submitter 72106 soeren@soeren-tempel.net severity 72106 normal tag 72106 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 06:37:02 2024 Received: (at submit) by debbugs.gnu.org; 14 Jul 2024 10:37:02 +0000 Received: from localhost ([127.0.0.1]:57190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwbF-0007td-OM for submit@debbugs.gnu.org; Sun, 14 Jul 2024 06:37:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:35166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwbE-0007tU-Hx for submit@debbugs.gnu.org; Sun, 14 Jul 2024 06:37:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSwbC-00041f-NF for guix-patches@gnu.org; Sun, 14 Jul 2024 06:36:58 -0400 Received: from magnesium.8pit.net ([45.76.88.171]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSwbA-0000FW-NS; Sun, 14 Jul 2024 06:36:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=+1C55jRk XiuKjGbt1lslca7/ju3raqWw2ktU4A5YaNo=; h=date:subject:cc:to:from; d=soeren-tempel.net; b=VgtLW0Ck/q1oNwG1cRewDT3+fbmHXMCTxhlc7091akOZ0fD bjtlU+7OLJdoZ0H9XkByilKl1lB0L3aHQDSf3fRmFux5rl2yd0OXgwEL24gY/N72ITNEFd g4i/HlaAp4Hy30Vi8M1sb+j+rLvcASAuriCu6/b6rppsxNyrI/ZbxQ= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id a8071e58 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 12:36:51 +0200 (CEST) From: soeren@soeren-tempel.net To: guix-patches@gnu.org Subject: [PATCH 0/3] gnu: klee: Enable test suite Date: Sun, 14 Jul 2024 12:36:16 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=45.76.88.171; envelope-from=soeren@soeren-tempel.net; helo=magnesium.8pit.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) From: Sören Tempel The KLEE version packaged added in #71634 did not enable the KLEE test suite. This patchset re-adds the changes from #68296 to get the test suite to pass. Additionally, while working on this, I noticed that the current KLEE package does not propagate the Python dependencies needed by klee-stats, which I fixed as well. Lastly, I also passed a custom #:strip-directories argument to avoid stripping of LLVM bitcode which (prior to this patchset) caused strip(1) to emit several warnings in the build log. P.S.: I also think it might be worthwhile to only enable the KLEE package on x86_64 Linux . Let me know if I should add that as well :-) Sören Tempel (3): gnu: klee: Propagate Python dependencies needed by klee-stats. gnu: klee: Enable the test suite. gnu: klee: Only strip bin directory. gnu/packages/check.scm | 32 +++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) base-commit: c1d367f57e89c3f2efd964e6d638bd89b0b1df97 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 06:42:29 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 10:42:29 +0000 Received: from localhost ([127.0.0.1]:57197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwgW-000824-NU for submit@debbugs.gnu.org; Sun, 14 Jul 2024 06:42:28 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:33611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwgU-00081p-GK; Sun, 14 Jul 2024 06:42:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=pAIB28EV 2EOu6+lXunicw4spUDclmd/FmTTmfF7duBU=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=wtdO31rL7mGhDLZIPHT839KEst/ 2P6uGoEH332yVsytNyOs78Ko/G62cZt0BJTHbgK7QwRnUqWJ1L8lO50VPttzYqONNs3qPE cK9HwBW6CSSFSDezhmbaM3YhzQL70xFj48+GfkKBS2Ky0Rc63CDVTW+t+Ah7WbV6Kdiie/ L2D4= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 58842ae0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 12:42:22 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH 1/3] gnu: klee: Propagate Python dependencies needed by klee-stats. Date: Sun, 14 Jul 2024 12:42:13 +0200 Message-ID: <2f96e525abd91df6bf774c18e601f497bffa618f.1720953093.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel Without these dependencies, the klee-stats Python script, which is shipped by the klee package, does not work correctly. * gnu/packages/check.scm (klee): Add propagated Python inputs. --- gnu/packages/check.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 3bfcf5a37e..f31e1bdb36 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1087,6 +1087,8 @@ (define-public klee (string-append "-DKLEE_UCLIBC_PATH=" (search-input-file %build-inputs "/lib/klee/libc.a")) "-DENABLE_POSIX_RUNTIME=ON"))) + ;; klee-stats tool (shipped in /bin) requires Python. + (propagated-inputs (list python python-tabulate)) (native-inputs (list clang-13 llvm-13 python-lit)) (inputs (list bash-minimal klee-uclibc gperftools sqlite z3)) (build-system cmake-build-system) From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 06:42:31 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 10:42:31 +0000 Received: from localhost ([127.0.0.1]:57199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwgZ-00082I-0c for submit@debbugs.gnu.org; Sun, 14 Jul 2024 06:42:31 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:33611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwgV-00081p-FS; Sun, 14 Jul 2024 06:42:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=jK/OlAnR Dsq7BtWFQ5XGXZgWYNcElHQv1Hr0fJcomek=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=Tc5wlt0lks2kwf/AnzgYNyNXC6U J9nDWl4FYiPLhZt9FzNSJUjcl4cGWRvW61Pba3QjdkqIM1rgH5O0itPjRAC39qrxAuQodH jp5UDhmL/vDfxTMaaIVYYBGhYYundawfssUF7Xe0ke+eXRVqg8DyZkA+VEUYcGuitSFlbH jwLI= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 824deea9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 12:42:25 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH 2/3] gnu: klee: Enable the test suite. Date: Sun, 14 Jul 2024 12:42:14 +0200 Message-ID: <3628ef5ffdfff900c749131956e3109dbd813493.1720953093.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Enable all tests. [arguments]: Add phase to patch lit configuration, set #:test-target. <#:configure-flags?>: Enable system and unit tests, configure gtest. [inputs]: Add googletest and python-lit. --- gnu/packages/check.scm | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index f31e1bdb36..14d7124908 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,13 +1063,23 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:test-target "check" #:phases #~(modify-phases %standard-phases - (add-after 'unpack 'patch + (add-after 'unpack 'patch-cmake (lambda _ (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") "${KLEE_UCLIBC_PATH}")))) + (add-after 'unpack 'patch-lit-config + (lambda _ + ;; Make sure that we retain the value of the GUIX_PYTHONPATH + ;; environment variable in the test environmented created by + ;; python-lit. Otherwise, the test scripts won't be able to + ;; find the python-tabulate dependency, causing test failures. + (substitute* "test/lit.cfg" + (("addEnv\\('PWD'\\)" env) + (string-append env "\n" "addEnv('GUIX_PYTHONPATH')"))))) (add-after 'install 'wrap-hooks (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -1080,7 +1090,13 @@ (define-public klee `("KLEE_RUNTIME_LIBRARY_PATH" = (,(string-append lib "/klee/runtime/")))))))) #:configure-flags - #~(list (string-append "-DLLVMCC=" + #~(list "-DENABLE_UNIT_TESTS=ON" + "-DENABLE_SYSTEM_TESTS=ON" + (string-append "-DGTEST_SRC_DIR=" + (assoc-ref %build-inputs "googletest")) + (string-append "-DGTEST_INCLUDE_DIR=" + (assoc-ref %build-inputs "googletest") "/googletest/include") + (string-append "-DLLVMCC=" (search-input-file %build-inputs "/bin/clang")) (string-append "-DLLVMCXX=" (search-input-file %build-inputs "/bin/clang++")) @@ -1090,7 +1106,14 @@ (define-public klee ;; klee-stats tool (shipped in /bin) requires Python. (propagated-inputs (list python python-tabulate)) (native-inputs (list clang-13 llvm-13 python-lit)) - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3)) + (inputs + `(("bash-minimal" ,bash-minimal) + ("klee-uclibc" ,klee-uclibc) + ("gperftools" ,gperftools) + ("sqlite" ,sqlite) + ("z3" ,z3) + ("python-lit" ,python-lit) + ("googletest" ,(package-source googletest)))) (build-system cmake-build-system) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 06:42:34 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 10:42:35 +0000 Received: from localhost ([127.0.0.1]:57202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwgc-00082Y-HG for submit@debbugs.gnu.org; Sun, 14 Jul 2024 06:42:34 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:33611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSwgZ-00081p-35; Sun, 14 Jul 2024 06:42:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=bU2150kK Ecbw9iJJrk8Hb3AFf6PdxTB+h+3WQOiKgvI=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=IKEhxULUYdZPyhSqBypCo5ZSO/L 6bTNjRSKESJzL2IJ+ja0+y0vR6cgE7kijAjlRNlbGURBgKV56UyVg/6D/ca9eE14WgXp9h /ZiQ4SvNj1xzrJskdSsB2igvedYYD/LobeeRdAvHVSmIRhy8JMudqJ3ypERyA6G7zZ+Zc/ r8s8= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id ec6ed8b5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 12:42:29 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH 3/3] gnu: klee: Only strip bin directory. Date: Sun, 14 Jul 2024 12:42:15 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel This avoid several warnings to be emitted by strip(1) when attempting to strip .bca (i.e. LLVM bitcode) files shipped in /lib/klee/runtime/. * gnu/packages/check.scm (klee): Set #:strip-directories. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 14d7124908..47e99a6be5 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,6 +1063,7 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:strip-directories #~(list "bin") ;don't strip LLVM bitcode in /lib #:test-target "check" #:phases #~(modify-phases %standard-phases From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 07:44:25 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 11:44:25 +0000 Received: from localhost ([127.0.0.1]:57215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSxeT-0003ql-FV for submit@debbugs.gnu.org; Sun, 14 Jul 2024 07:44:25 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:44295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSxeR-0003qX-O0 for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 07:44:24 -0400 Received: by mail-lf1-f66.google.com with SMTP id 2adb3069b0e04-52e9f863c46so3780308e87.1 for <72106@debbugs.gnu.org>; Sun, 14 Jul 2024 04:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720957396; x=1721562196; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=RUkuXfJ/+e386gb4AGfMJHh665EbNCeXfVAHoI97TLo=; b=JL5dV5OegvUimg2Eqm3Zs/O4P9pAjQV7+z4vj5xxycFhRzRJGmUZezhJTVUJAX7+Fk 7siw+dJ5nmoMQFX5uN9uswqEulVU4mFt8C9Gw1/0r3CcWjTUxyCWxx6MZmnC6vfjkbIN CWjc0I18iWkkGNAT84tL2pAAdc+qYhmzYZhSSCiWfW9UNIxZbZ49qrHRZbId+n8N8A00 c2koaAVwehrhJM+rf7KIM+6+yiTOZKhyCVbMwFZAkYGynSBczlXecKCMhrjc4puZZfmm XXlsDKBO4evvD4Vr2OpKCQEH2yp5thd0fB5241tohLkTltXJD0Ua21qLFHh7JDIBaBeo OSiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720957396; x=1721562196; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RUkuXfJ/+e386gb4AGfMJHh665EbNCeXfVAHoI97TLo=; b=wx2gyMhTGAsQtUDCh+tk//V/LgBmC8Uj9hqESCV5lhFtOdqcTDWFrjmHgKj7pYQZGF MLZCA/pYGIovbugN7Y7QoR0EKgCD0H3QnfcdYEoECL/3DRMj66E5Vne21b5OnoRjFl34 nlhJFOOKfxKIGqj6+qa5+YeDvjQceei3f+fhNpVfLrOPCPUGhM7Y2/RiGVGQXeB/345v Zbh8EVpfW3lY+JNs0EambCDf/E11c9I/GFAsLjb0GIn8GSyXHulNJJ3Z55xqEDXGzx0D LijcYWmfT13qyez4Jk6V3fJkNu8d62WesP5LN3gbRImVWBvak2BRU1x9QKNkmhUXgfwg k8GQ== X-Forwarded-Encrypted: i=1; AJvYcCWsr5OZiTIw931m82yuGkgRkc44cQnFUt9AiWMVSO0oUfPkk4PuPoTJzPfN+dNX9UXcqh160Bd8F2qRKw4hQeIsCwzwfKk= X-Gm-Message-State: AOJu0Yw3K7ZmaA7oMjvTPk9zj5PHRXhNV1l/7gLfQ9d+0DHheiK28/ZH 0R/x3LoK+5+uhwtF2lM5iL3+SZiQfigRyJ6RXAtCLpPUOn/2tfbC X-Google-Smtp-Source: AGHT+IEEb/RrAnufTJGHy/NY22H/Ddne7r8i1DPjl4MOGYbuWCa9l784nd7IFBAMDB9V+r0FqNe84Q== X-Received: by 2002:a05:6512:401d:b0:52e:9fe0:bee4 with SMTP id 2adb3069b0e04-52eb9990e64mr11348934e87.9.1720957395944; Sun, 14 Jul 2024 04:43:15 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a8799e7esm39673365e9.18.2024.07.14.04.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 04:43:15 -0700 (PDT) Message-ID: <1de2040ef0eb380b20bd893a67428826ec547698.camel@gmail.com> Subject: Re: [PATCH 1/3] gnu: klee: Propagate Python dependencies needed by klee-stats. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Sun, 14 Jul 2024 13:43:13 +0200 In-Reply-To: <2f96e525abd91df6bf774c18e601f497bffa618f.1720953093.git.soeren@soeren-tempel.net> References: <2f96e525abd91df6bf774c18e601f497bffa618f.1720953093.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 14.07.2024 um 12:42 +0200 schrieb soeren@soeren-tempel.net: > From: S=C3=B6ren Tempel >=20 > Without these dependencies, the klee-stats Python script, > which is shipped by the klee package, does not work correctly. >=20 > * gnu/packages/check.scm (klee): Add propagated Python inputs. Can we use a wrapper instead? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 12:18:06 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 16:18:06 +0000 Received: from localhost ([127.0.0.1]:58498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT1vK-0002kf-0o for submit@debbugs.gnu.org; Sun, 14 Jul 2024 12:18:06 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT1vI-0002kX-RP for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 12:18:05 -0400 Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4266ea6a488so27390795e9.1 for <72106@debbugs.gnu.org>; Sun, 14 Jul 2024 09:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720973822; x=1721578622; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=x2dtecfeUelshO1jtsJAmRcZc3MA0/SgmxhzHx9h2bE=; b=lqyt9/3brvxupla/dkpzMnr5bbKnNFLRv0lXAv6tvbhReKmpOTvJghlvIyykJHdaI/ CFlp/TmSC2lu52cWCUQK5SB4QQMVuhlyF/Aa7LKAl0vekXw9ZGkelWtQzM5ABtOaTV+A bt2uEROwCPdxG5CcDW5NCEt4sjqgTPpBeGTF3VlclFKCmdpfGXmUvfqS7lnKV9DmxUH2 qPLCslGK3E+6aPj4sVORKbR6HZ8Osb60OQxnMHEcBt0CVtFIhvimIUlvhZFxXyhkcUYq q9dFy27avc6OElAHPYClbXukEa8myGao2ugplkQ/T5WGnDd5y7oU2tby9TJkCId3R6Kg yHZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720973822; x=1721578622; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x2dtecfeUelshO1jtsJAmRcZc3MA0/SgmxhzHx9h2bE=; b=JNh37eG5e0Vt2XqMJjngHiOHAU5lpdU/Fz4qQaxpa7Z8daZY/1pX2+tgdvYvhVXW8c d2+vGNti2/+VXKTXpk834kjKoTbeJEXFxG7ju3mWaVOv1angyoQOK2QTnslX7k2m/Qvr u/jmeAV9sYqVO63vPMLJEyC1nmHim3xLgc4uuSQBjDB/C3wbJOXBwaHTyW7F1VWMdUHv 3F5WioHt3lWZjM4wMC/kYEzCzEa1yFFB9yfVVqSm7Cf2yoUIDu0P2e0sTz8MNcYJUT/3 gyT/K6pAqSZ41vGHz7pduVKR4/FfRQQYo14C2Qepjwz3HgMuQPqkuh3QbYr3Gvg9o/+n KwfQ== X-Forwarded-Encrypted: i=1; AJvYcCWwF9cVmCqkYOx1RPJ48CZPWwGwYrh/pUVIa000uDJguPoGo4bbSIG4U0z8HtL2haYDN0raXaeN06QFAj9g5EgXfkBo1W0= X-Gm-Message-State: AOJu0YwZRawytkOc61gviIqxv1/PrA9VRESNY4ht/G6HRgVjwFy12PRH w+hy2SbUYSaXps6BuL9y3mjGxdafAomzfp1JfQWQacDqguIkQeoU X-Google-Smtp-Source: AGHT+IFOxsnfUUY4n2i8TVlAYvaKLRbISKUneXyYgYjtiioKQfBbTnQJaw5U8jd31rU0ar05wb6Rug== X-Received: by 2002:a7b:c052:0:b0:426:5c81:2538 with SMTP id 5b1f17b1804b1-426707cf827mr125374405e9.14.1720973822471; Sun, 14 Jul 2024 09:17:02 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f25a957sm90266245e9.13.2024.07.14.09.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 09:17:02 -0700 (PDT) Message-ID: <5bc6bc1832077b3153fcb28ed0ef9233411ea69d.camel@gmail.com> Subject: Re: [PATCH 0/3] gnu: klee: Enable test suite From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Sun, 14 Jul 2024 18:17:00 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 14.07.2024 um 12:36 +0200 schrieb soeren@soeren-tempel.net: > Lastly, I also passed a custom #:strip-directories argument to avoid > stripping of LLVM bitcode which (prior to this patchset) caused > strip(1) to emit several warnings in the build log. There is only .bca files in there, right? > P.S.: I also think it might be worthwhile to only enable the KLEE > package on x86_64 Linux .=C2=A0 Let > me know if I should add that as well :-) Ah, yes, good catch. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:25:40 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:25:40 +0000 Received: from localhost ([127.0.0.1]:58553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3um-0005tq-Ft for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:25:40 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:38211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3uj-0005ta-M4; Sun, 14 Jul 2024 14:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=nur36Ipu yaz95UB5/m4gQD1z7emY/chP5Rzf3nZo1Gc=; h=date:subject:cc:to:from; d=soeren-tempel.net; b=tFrgOPOhhevSCtG4Csa9dPjpcVhEBxwLAjz5KqGwhnapBgM GvZefe5l4RLinXQ/HKOQ+sDdpTXF5OFsWPd98fnDo631bMyIA3JGAHhOJLx255RBTgaZnN 4owUvHw7LrIfsFHXSJDOp5VMYAdiUU9xT8Js9bf3YhJHE1NcVMhViM= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id c85d8bfb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 20:25:32 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v2 1/5] gnu: klee: Wrap klee-stats for Python dependencies. Date: Sun, 14 Jul 2024 20:25:24 +0200 Message-ID: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Wrap klee-stats. --- gnu/packages/check.scm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 3bfcf5a37e..6b0ea0aaa8 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1070,7 +1070,15 @@ (define-public klee (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") "${KLEE_UCLIBC_PATH}")))) - (add-after 'install 'wrap-hooks + (add-after 'install 'wrap-klee-stats + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (wrap-program (string-append bin "/klee-stats") + `("GUIX_PYTHONPATH" ":" prefix + ,(search-path-as-string->list + (getenv "GUIX_PYTHONPATH"))))))) + (add-after 'install 'wrap-klee (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin")) @@ -1088,7 +1096,7 @@ (define-public klee (search-input-file %build-inputs "/lib/klee/libc.a")) "-DENABLE_POSIX_RUNTIME=ON"))) (native-inputs (list clang-13 llvm-13 python-lit)) - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3)) + (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python python-tabulate)) (build-system cmake-build-system) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") base-commit: c1d367f57e89c3f2efd964e6d638bd89b0b1df97 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:25:43 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:25:43 +0000 Received: from localhost ([127.0.0.1]:58555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3uo-0005tz-R9 for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:25:43 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:38211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3ul-0005ta-5L; Sun, 14 Jul 2024 14:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=dt7AlBh4 0ARHFDBM7ecjCCLfhwNxcqmY4uiadEWfKsU=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=C4IVaiH7YBudSsWqwLcgI4s5+XO r1Txcw22EHOF9Kme1wVlRS9A3LID8L5lSkXEJjWqcvkrL5k7Pdo1rfLc2ba3pB/veM9jhv DzfLrFiyu4oM1tk4s7QARQcps+dnBr5gQisfv45+ka7w7YM0tHh/+2ApE6/809RNzsVzUT 5X+I= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id bedb9c07 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 20:25:35 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v2 2/5] gnu: klee: Enable the test suite. Date: Sun, 14 Jul 2024 20:25:25 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Enable all tests. [arguments]: Add phase to patch lit configuration, set #:test-target. <#:configure-flags?>: Enable system and unit tests, configure gtest. [inputs]: Add googletest and python-lit. --- gnu/packages/check.scm | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 6b0ea0aaa8..552cb39de5 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,13 +1063,23 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:test-target "check" #:phases #~(modify-phases %standard-phases - (add-after 'unpack 'patch + (add-after 'unpack 'patch-cmake (lambda _ (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") "${KLEE_UCLIBC_PATH}")))) + (add-after 'unpack 'patch-lit-config + (lambda _ + ;; Make sure that we retain the value of the GUIX_PYTHONPATH + ;; environment variable in the test environmented created by + ;; python-lit. Otherwise, the test scripts won't be able to + ;; find the python-tabulate dependency, causing test failures. + (substitute* "test/lit.cfg" + (("addEnv\\('PWD'\\)" env) + (string-append env "\n" "addEnv('GUIX_PYTHONPATH')"))))) (add-after 'install 'wrap-klee-stats (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -1088,7 +1098,13 @@ (define-public klee `("KLEE_RUNTIME_LIBRARY_PATH" = (,(string-append lib "/klee/runtime/")))))))) #:configure-flags - #~(list (string-append "-DLLVMCC=" + #~(list "-DENABLE_UNIT_TESTS=ON" + "-DENABLE_SYSTEM_TESTS=ON" + (string-append "-DGTEST_SRC_DIR=" + (assoc-ref %build-inputs "googletest")) + (string-append "-DGTEST_INCLUDE_DIR=" + (assoc-ref %build-inputs "googletest") "/googletest/include") + (string-append "-DLLVMCC=" (search-input-file %build-inputs "/bin/clang")) (string-append "-DLLVMCXX=" (search-input-file %build-inputs "/bin/clang++")) @@ -1096,7 +1112,15 @@ (define-public klee (search-input-file %build-inputs "/lib/klee/libc.a")) "-DENABLE_POSIX_RUNTIME=ON"))) (native-inputs (list clang-13 llvm-13 python-lit)) - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python python-tabulate)) + (inputs + `(("bash-minimal" ,bash-minimal) + ("klee-uclibc" ,klee-uclibc) + ("gperftools" ,gperftools) + ("sqlite" ,sqlite) + ("z3" ,z3) + ("python", python) + ("python-tabulate" ,python-tabulate) + ("googletest" ,(package-source googletest)))) (build-system cmake-build-system) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:25:48 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:25:48 +0000 Received: from localhost ([127.0.0.1]:58559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3uu-0005uN-7X for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:25:48 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:22399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3us-0005uA-FD; Sun, 14 Jul 2024 14:25:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=mJuyxIaq S3DIHSF/YE1z9DiAwEU54vtVdKS5DRoTtmY=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=EwghHc/NirzolN6wUaWCKDrtKhA KT0qEIsXTyqBHbERghTmuv86dlB1jdjWUfyY0fAaHNsTdxVWkgFowSD6p6fFUq9uc9CYEJ 5RHZyWz2OOYJmxdsgZ/PrnAv8axNCU1vKFp4Wvse+VNdnqKOWR5yB6zG00yHOkjEIP8EdW QfrY= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 99cf5786 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 20:25:38 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v2 3/5] gnu: klee: Only strip bin directory. Date: Sun, 14 Jul 2024 20:25:26 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel This avoid several warnings to be emitted by strip(1) when attempting to strip .bca (i.e. LLVM bitcode) files shipped in /lib/klee/runtime/. * gnu/packages/check.scm (klee): Set #:strip-directories. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 552cb39de5..3f3cc64e8e 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,6 +1063,7 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:strip-directories #~(list "bin") ;don't strip LLVM bitcode in /lib #:test-target "check" #:phases #~(modify-phases %standard-phases From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:25:51 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:25:51 +0000 Received: from localhost ([127.0.0.1]:58562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3ux-0005ud-Ft for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:25:51 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:22399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3ut-0005uA-8F; Sun, 14 Jul 2024 14:25:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=Aoz48D9i mt4tmA1eFota5zyQ8Ad0ikNbP3ijtXrF5ts=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=fI8adjoaPDbv+SfymUq1KBX/yiB Vp7rUUVaPczsXUi/h3YuhTNtXC1S9HTehOKToncplK4xMP60CIFwRkq0d9+7LAfmN3ZFjo QJ+Yb86ESe6vnUsT3KZ5rN573psREgbRZ5F/WqrpC1C/1TniX3cQ/pPKtAiHaPHizPu6D8 CnQw= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 6f035429 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 20:25:40 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v2 4/5] gnu: klee: Only build on x86_64 Linux. Date: Sun, 14 Jul 2024 20:25:27 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Add supported-systems. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 3f3cc64e8e..3fc88b078f 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1123,6 +1123,7 @@ (define-public klee ("python-tabulate" ,python-tabulate) ("googletest" ,(package-source googletest)))) (build-system cmake-build-system) + (supported-systems '("x86_64-linux")) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") (description "KLEE is a symbolic virtual machine built on top of the LLVM From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:25:52 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:25:52 +0000 Received: from localhost ([127.0.0.1]:58564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3ux-0005uf-QG for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:25:52 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:22399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3uu-0005uA-9e; Sun, 14 Jul 2024 14:25:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=AA262M6/ 7EVuUpdOgajbSIuFw9Gr6S1xGYKHe1TyHWs=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=Qapu+MvkIvLnJ99GVMwbIiehBf3 Pj4yA0av7okpzsk7lTHMEVHQUcYtNnUDsvak0dHTfGjCKbLohmJCvrvee3/CQX2ncKm5+x GZejccESdo5/mG557o1tjqZ7BurbVLaTCrwkoxM8/f9KcvqTlF4X/gyH0opTcXOCiGj4QN K7QY= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 1f70092b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 20:25:41 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v2 5/5] gnu: klee-uclibc: Only build on x86_64 Linux. Date: Sun, 14 Jul 2024 20:25:28 +0200 Message-ID: <96e57f4f5fc4ea592923427484333c7dfea55a3c.1720981528.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Add supported-systems. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 3fc88b078f..e48d392251 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1006,6 +1006,7 @@ (define-public klee-uclibc (sha256 (base32 "12fnr5mq80cxwvv09gi844mi31jgi8067swagxnlxlhxj4mi125j")))) (build-system gnu-build-system) + (supported-systems '("x86_64-linux")) (arguments `(#:tests? #f ;upstream uClibc tests do not work in the fork #:strip-directories '() ;only ships a static library, so don't strip anything. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:29:53 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:29:53 +0000 Received: from localhost ([127.0.0.1]:58573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3yr-000618-FQ for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:29:53 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:17610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT3yp-00060v-GE for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 14:29:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=nmv291Uo HtVVU4go0DKZI6N6X1jgYy+F7m7XcisWoEI=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=KDUXtjXSVFvOzKdfujtV5q+ykFE sodf/Sblc3gGdWsk1morCUo7C2RRu3YSACyd98xVaXE/u/xUAgx6JXhXSP3ykPiUqSgCzY SfxpQF3CRk0rDZfx6lxOJS52J+uaUB883PP3Y1tMFZzqVB0/wfOwlIim6YIf/3x2pEGCp9 renc= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 6d28f407 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 20:29:49 +0200 (CEST) Date: Sun, 14 Jul 2024 20:29:48 +0200 To: Liliana Marie Prikler Subject: Re: [PATCH 0/3] gnu: klee: Enable test suite From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <5bc6bc1832077b3153fcb28ed0ef9233411ea69d.camel@gmail.com> In-Reply-To: <5bc6bc1832077b3153fcb28ed0ef9233411ea69d.camel@gmail.com> Message-Id: <2RJBKARQLC2CS.2DWJ8IEINRRAC@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: 72106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Thanks for your feedback, I added a v2 to incorporate your feedback. Liliana Marie Prikler wrote: > Can we use a wrapper instead? Sure, good idea! I modified the patch to wrap klee-stats instead. Haven't done that so far so please check if I did it correctly :) > > Lastly, I also passed a custom #:strip-directories argument to avoid > > stripping of LLVM bitcode which (prior to this patchset) caused > > strip(1) to emit several warnings in the build log. > > There is only .bca files in there, right? Only .bca files and one shared library (libkleeRuntest.so) are in /lib. Does stripping of shared libraries do anything? If so: Should we just live with the warnings or should we strip that file individually? > > P.S.: I also think it might be worthwhile to only enable the KLEE > > package on x86_64 Linux .=C2=A0 L= et > > me know if I should add that as well :-) > > Ah, yes, good catch. I added two additional commits to set supported-systems for KLEE. Best, S=C3=B6ren From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:55:01 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:55:01 +0000 Received: from localhost ([127.0.0.1]:58583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT4NB-0006dK-6i for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:55:01 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:42314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT4N9-0006d0-Eu for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 14:55:00 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-595856e2336so5994794a12.1 for <72106@debbugs.gnu.org>; Sun, 14 Jul 2024 11:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720983232; x=1721588032; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4IwHX8l3KS+4H+1kxSUUSu4kWL/Qk2RtmhQ1IuAzxSI=; b=BNYh1Sf8TVhbC6LL4pzkmBkxtzocnQzrwQP5CCL+DNh1Yrxy9iHotm8q9UwdGqeG9j kc+8ontWaw+KbCRk2qKiglaMVIWrdujRXbUynssUNklJ2aoVFoJi58wSSt9017Yq4oVR fDngKisRqrwnSTeWCm4UksbfewKYwNPISO7n1nZh6yPN4mEGKaF2DIgiY0qtop4yVgyv rXIqZY+mR5DpokSMOanac7Bd61fpz7295f+q+3eLE7i89Ft9fctx3jN8kxIAXguBxPsx GbgQNh13fnSqpnJ5GCPSEPELB6mWJPQ05rHS/VP6hRY7oWl3srm5jRjwtwA0V1peu/rL hifg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720983232; x=1721588032; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4IwHX8l3KS+4H+1kxSUUSu4kWL/Qk2RtmhQ1IuAzxSI=; b=nUEKshYx36UQSDm2C77dgdmxM74z3M2TZ2mOE3OJbPAxYbcaofjZBR1jkv/1NEreqi dnkC3UHCx5Qd5Kcw4+1UTKM2w754QSJbGYIM//RFY7KfRpXf8eY62fh2S9/PZVfSmis9 3d/d1CGZSoN4Mh804c2UUHLmQKoIjvOpd2MOW2Bi/1U8gtj3nd8p2tRbNbZoNMwsXI81 CS4GqPEGZ2BqDBy7p2IAm9P0Qu/iNAMq5B8wnC1SOhi804HV6RwheQAr+KBRZp33QLSf BiJ8+5hM3IygeFD3izw4eEiGqFVtM7cCJ0+0497KOnfKFsYoJWGP4VncHiPV6/A4m0+4 n5hA== X-Forwarded-Encrypted: i=1; AJvYcCVRVUMCM9hCFBN3aIOFMiPXApbwiSIB/85VyYLD3V7RnBpC9dzQ8nN61Wymm56FGm0zcy8ccdCXpj9zSPgmut0gvTJvdv8= X-Gm-Message-State: AOJu0YzroIvFMswY2aI4vKZrhqSlm3FPetTor2NnY858kkzLeKUXwqT2 w4gMCPaHkQ/tj3+tWxgS5uYo5c45QHvPNrnIZV9AXHmyrBoxAB2o X-Google-Smtp-Source: AGHT+IGjwwK5hvywPeunyzkG7zcgzEDJQAL9hfS7gFEIivuaLhRZIuByvK3CVqfBxszGwh/H5BUgVQ== X-Received: by 2002:a50:d6dc:0:b0:57d:4a0d:d597 with SMTP id 4fb4d7f45d1cf-599648a33ddmr6031692a12.12.1720983231738; Sun, 14 Jul 2024 11:53:51 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-59b25528e18sm2411371a12.56.2024.07.14.11.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 11:53:51 -0700 (PDT) Message-ID: <68c1ee2dec2780cc8d6d5bc0db0f36492236b85c.camel@gmail.com> Subject: Re: [PATCH v2 2/5] gnu: klee: Enable the test suite. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Sun, 14 Jul 2024 20:53:49 +0200 In-Reply-To: References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gU29ubnRhZywgZGVtIDE0LjA3LjIwMjQgdW0gMjA6MjUgKzAyMDAgc2NocmllYgpzb2VyZW5A c29lcmVuLXRlbXBlbC5uZXQ6Cj4gRnJvbTogU8O2cmVuIFRlbXBlbCA8c29lcmVuQHNvZXJlbi10 ZW1wZWwubmV0Pgo+IAo+ICogZ251L3BhY2thZ2VzL2NoZWNrLnNjbSAoa2xlZSk6IEVuYWJsZSBh bGwgdGVzdHMuCj4gW2FyZ3VtZW50c106IEFkZCBwaGFzZSB0byBwYXRjaCBsaXQgY29uZmlndXJh dGlvbiwgc2V0ICM6dGVzdC10YXJnZXQuCj4gPCM6Y29uZmlndXJlLWZsYWdzPz46IEVuYWJsZSBz eXN0ZW0gYW5kIHVuaXQgdGVzdHMsIGNvbmZpZ3VyZSBndGVzdC4KPiBbaW5wdXRzXTogQWRkIGdv b2dsZXRlc3QgYW5kIHB5dGhvbi1saXQuCj4gLS0tCj4gwqBnbnUvcGFja2FnZXMvY2hlY2suc2Nt IHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwg MjcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZ251L3Bh Y2thZ2VzL2NoZWNrLnNjbSBiL2dudS9wYWNrYWdlcy9jaGVjay5zY20KPiBpbmRleCA2YjBlYTBh YWE4Li41NTJjYjM5ZGU1IDEwMDY0NAo+IC0tLSBhL2dudS9wYWNrYWdlcy9jaGVjay5zY20KPiAr KysgYi9nbnUvcGFja2FnZXMvY2hlY2suc2NtCj4gQEAgLTEwNjMsMTMgKzEwNjMsMjMgQEAgKGRl ZmluZS1wdWJsaWMga2xlZQo+IMKgwqDCoMKgwqDCoCAoYmFzZTMyCj4gIjFubWE2ZHFpOGNoamI5 N2xsc2E4bXp5c2tnc2c0ZHg1NmxtOGo1MTRqNXdtcjh2a2FmejYiKSkpKQo+IMKgwqDCoCAoYXJn dW1lbnRzCj4gwqDCoMKgwqAgKGxpc3QKPiArwqDCoMKgwqAgIzp0ZXN0LXRhcmdldCAiY2hlY2si Cj4gwqDCoMKgwqDCoCAjOnBoYXNlcwo+IMKgwqDCoMKgwqAgI34obW9kaWZ5LXBoYXNlcyAlc3Rh bmRhcmQtcGhhc2VzCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoYWRkLWFmdGVyICd1bnBhY2sgJ3BhdGNoCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoYWRkLWFmdGVyICd1bnBhY2sgJ3BhdGNoLWNtYWtlCj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsYW1iZGEgXwo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHN1YnN0 aXR1dGUqICJDTWFrZUxpc3RzLnR4dCIKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ICgoIlxcJFxce0tMRUVfVUNMSUJDX1BBVEhcXH0v bGliL2xpYmNcXC5hIikKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgICIke0tMRUVfVUNMSUJDX1BBVEh9IikpKSkKPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChhZGQtYWZ0ZXIgJ3VucGFjayAncGF0 Y2gtbGl0LWNvbmZpZwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIChsYW1iZGEgXwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCA7OyBNYWtlIHN1cmUgdGhhdCB3ZSByZXRhaW4gdGhlIHZhbHVlIG9mCj4g dGhlIEdVSVhfUFlUSE9OUEFUSAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCA7OyBlbnZpcm9ubWVudCB2YXJpYWJsZSBpbiB0aGUgdGVzdAo+IGVu dmlyb25tZW50ZWQgY3JlYXRlZCBieQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBweXRob24tbGl0LiBPdGhlcndpc2UsIHRoZSB0ZXN0IHNj cmlwdHMKPiB3b24ndCBiZSBhYmxlIHRvCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IGZpbmQgdGhlIHB5dGhvbi10YWJ1bGF0ZSBkZXBlbmRl bmN5LAo+IGNhdXNpbmcgdGVzdCBmYWlsdXJlcy4KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHN1YnN0aXR1dGUqICJ0ZXN0L2xpdC5jZmciCj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo KCJhZGRFbnZcXCgnUFdEJ1xcKSIgZW52KQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCBlbnYgIlxuIgo+ICJh ZGRFbnYoJ0dVSVhfUFlUSE9OUEFUSCcpIikpKSkpCklmIHRoaXMgaXMgYSB0ZXN0LCB0aGVuIHdl IHNob3VsZCB1c2UgbmF0aXZlLWlucHV0cyBiZWxvdy4KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYWRkLWFmdGVyICdpbnN0YWxsICd3cmFwLWtsZWUtc3Rh dHMKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxh bWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQo+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxldCogKChvdXQgKGFzc29j LXJlZiBvdXRwdXRzICJvdXQiKSkKPiBAQCAtMTA4OCw3ICsxMDk4LDEzIEBAIChkZWZpbmUtcHVi bGljIGtsZWUKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgYCgiS0xFRV9SVU5USU1FX0xJQlJBUllfUEFUSCIgPQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg KCwoc3RyaW5nLWFwcGVuZCBsaWIKPiAiL2tsZWUvcnVudGltZS8iKSkpKSkpKSkKPiDCoMKgwqDC oMKgICM6Y29uZmlndXJlLWZsYWdzCj4gLcKgwqDCoMKgICN+KGxpc3QgKHN0cmluZy1hcHBlbmQg Ii1ETExWTUNDPSIKPiArwqDCoMKgwqAgI34obGlzdCAiLURFTkFCTEVfVU5JVF9URVNUUz1PTiIK PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICItREVOQUJMRV9TWVNURU1fVEVTVFM9T04iCj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAiLURHVEVTVF9TUkNfRElS PSIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIChhc3NvYy1yZWYgJWJ1aWxkLWlucHV0cyAiZ29vZ2xldGVzdCIpKQo+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKHN0cmluZy1hcHBlbmQgIi1ER1RFU1RfSU5DTFVERV9ESVI9Igo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGFz c29jLXJlZiAlYnVpbGQtaW5wdXRzICJnb29nbGV0ZXN0IikKPiAiL2dvb2dsZXRlc3QvaW5jbHVk ZSIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAiLURMTFZNQ0M9 Igo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIChzZWFyY2gtaW5wdXQtZmlsZSAlYnVpbGQtaW5wdXRzCj4gIi9iaW4vY2xhbmciKSkKPiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAiLURMTFZNQ1hYPSIKPiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo c2VhcmNoLWlucHV0LWZpbGUgJWJ1aWxkLWlucHV0cwo+ICIvYmluL2NsYW5nKysiKSkKPiBAQCAt MTA5Niw3ICsxMTEyLDE1IEBAIChkZWZpbmUtcHVibGljIGtsZWUKPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc2VhcmNoLWlucHV0LWZp bGUgJWJ1aWxkLWlucHV0cwo+ICIvbGliL2tsZWUvbGliYy5hIikpCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgIi1ERU5BQkxFX1BPU0lYX1JVTlRJTUU9T04iKSkpCj4gwqDCoMKgIChuYXRp dmUtaW5wdXRzIChsaXN0IGNsYW5nLTEzIGxsdm0tMTMgcHl0aG9uLWxpdCkpCj4gLcKgwqAgKGlu cHV0cyAobGlzdCBiYXNoLW1pbmltYWwga2xlZS11Y2xpYmMgZ3BlcmZ0b29scyBzcWxpdGUgejMK PiBweXRob24gcHl0aG9uLXRhYnVsYXRlKSkKPiArwqDCoCAoaW5wdXRzCj4gK8KgwqDCoMKgIGAo KCJiYXNoLW1pbmltYWwiICxiYXNoLW1pbmltYWwpCj4gK8KgwqDCoMKgwqDCoCAoImtsZWUtdWNs aWJjIiAsa2xlZS11Y2xpYmMpCj4gK8KgwqDCoMKgwqDCoCAoImdwZXJmdG9vbHMiICxncGVyZnRv b2xzKQo+ICvCoMKgwqDCoMKgwqAgKCJzcWxpdGUiICxzcWxpdGUpCj4gK8KgwqDCoMKgwqDCoCAo InozIiAsejMpCj4gK8KgwqDCoMKgwqDCoCAoInB5dGhvbiIsIHB5dGhvbikKPiArwqDCoMKgwqDC oMKgICgicHl0aG9uLXRhYnVsYXRlIiAscHl0aG9uLXRhYnVsYXRlKQo+ICvCoMKgwqDCoMKgwqAg KCJnb29nbGV0ZXN0IiAsKHBhY2thZ2Utc291cmNlIGdvb2dsZXRlc3QpKSkpCldoeSB0aGUgcGFj a2FnZSBzb3VyY2UgYW5kIG5vdCB0aGUgY29tcGlsZWQgcGFja2FnZT8gIENhbiB3ZSBtYWtlIGl0 IHNvCnRoYXQgd2UgY2FuIHVzZSBhIHByZWJ1aWx0IGNvbXBpbGVkIG9uZT8KCkNoZWVycwoK From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:55:15 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:55:15 +0000 Received: from localhost ([127.0.0.1]:58586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT4NO-0006e7-N9 for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:55:14 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:58698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT4NM-0006dt-PS for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 14:55:13 -0400 Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-58ba3e38027so3765436a12.1 for <72106@debbugs.gnu.org>; Sun, 14 Jul 2024 11:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720983245; x=1721588045; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=zdwVqDgf88DLTB8HR6SMhiWsdJq/hmqJd3bq2uExNYE=; b=ULbHCAMoKGIvbzNyFhtMX0L9x8PzvPp7URXZp6DsfA9wR4ezOyoCrhJSGYKwiIKtB2 2/sXnZER/4+4WuEagIrrQa2h5xnKdQYLHosiV+6QOE9QNBXIT61oa3mocwGffeg0SV7k n/BTphiM5oz2D43OuJiPfO9XeBz6n15Hju1PPTg+dq+kO13+su0ilxmbOOqT0JBSZAjk YKzNGEpiZ1cpytaK2YeN9QgpaujPPVJhk2XN3yeCkLFYhr6ellXDJ0n+9lBdRwU7yCw7 j1pjZWdgAj50FTzd+DfvD62t85M+K1YDANqFv2Icbv2Jg3ymA4nCwoP+CNNTQcxAdO/t z0nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720983245; x=1721588045; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zdwVqDgf88DLTB8HR6SMhiWsdJq/hmqJd3bq2uExNYE=; b=WSj5Ir+9rM2T763PuvgL7dDOg0BSPgRQp69PXJJLXrknU7KT4xp7ePVCGCEhrfAi5C HtpddjfwpHCmIZJwJobY9Xdzmlj2dkRA7LDCRUhF1gRZFgkmA9bKNjAz1hJXWLl57dAa +8Fj3GoMHXYyH8bVo7LgmSfeSK4KSW1SFDMW98S2i0KVvBuo+K1gAxjKW+KEzhDhQx3O MfFHsCkJaIYZKKmk6QhDuRPBmKfszk19Bn4JBrrr3ko8LSBUTsGG/QTFfJt3Bc/rb50e XFmwqDyA6Zy/XybqaaqreiIR/X3pQ9yY3SJjghYsqLDWVmo3YpHJZWgeCXoxJwovpcsX ZoEg== X-Forwarded-Encrypted: i=1; AJvYcCW6tsPvENdwI3jftj7xzneCKEkAkt+9Y6xH+s386azy4SKaayT/SJKN4nyA8MvXPuw3nMtyAur0eOxeXm/puSnqNpjak9s= X-Gm-Message-State: AOJu0YwH1YRVk/OLshRcFt31Nm+bv20Okh2nh19bkzx+xgZZ7b3xo4qZ bXH55Qj0t5bFcR7KQTJsZ82gC7+9JnPnGAttjSkm2oNSCzbgXn1y X-Google-Smtp-Source: AGHT+IEs1rGCVf4LS9gNlC7ZrQYLLBZHm5el/uCNUKq5d+TVHXUJM0v/jLCmpOppzb4EwdTdXh/m5w== X-Received: by 2002:a05:6402:34c8:b0:57a:27c8:3269 with SMTP id 4fb4d7f45d1cf-594baa8bb35mr14320558a12.4.1720983245282; Sun, 14 Jul 2024 11:54:05 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-59b255261c5sm2457360a12.43.2024.07.14.11.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 11:54:04 -0700 (PDT) Message-ID: <270253dd66bbaf388b3e279174f9bacaac434a07.camel@gmail.com> Subject: Re: [PATCH v2 4/5] gnu: klee: Only build on x86_64 Linux. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Sun, 14 Jul 2024 20:54:04 +0200 In-Reply-To: References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 14.07.2024 um 20:25 +0200 schrieb soeren@soeren-tempel.net: > From: S=C3=B6ren Tempel >=20 > * gnu/packages/check.scm (klee): Add supported-systems. > --- > =C2=A0gnu/packages/check.scm | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm > index 3f3cc64e8e..3fc88b078f 100644 > --- a/gnu/packages/check.scm > +++ b/gnu/packages/check.scm > @@ -1123,6 +1123,7 @@ (define-public klee > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("python-tabulate" ,python-tab= ulate) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("googletest" ,(package-source= googletest)))) > =C2=A0=C2=A0=C2=A0 (build-system cmake-build-system) > +=C2=A0=C2=A0 (supported-systems '("x86_64-linux")) > =C2=A0=C2=A0=C2=A0 (home-page "https://klee-se.org/") > =C2=A0=C2=A0=C2=A0 (synopsis "Symbolic execution engine") > =C2=A0=C2=A0=C2=A0 (description "KLEE is a symbolic virtual machine built= on top of > the LLVM LGTM From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:56:05 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 18:56:05 +0000 Received: from localhost ([127.0.0.1]:58591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT4OD-0006fh-2c for submit@debbugs.gnu.org; Sun, 14 Jul 2024 14:56:05 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:61548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT4OB-0006ez-Bz for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 14:56:03 -0400 Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-a797c62565aso376161566b.2 for <72106@debbugs.gnu.org>; Sun, 14 Jul 2024 11:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720983296; x=1721588096; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=3FC29DauysfNyzjT4QiK0UIy2c80B9aP9VYlrNpPzrc=; b=X7Re9qAy5uqNvjXXyBc2tLjo0yLtYEWCeRTZGiZN+Mo4uX+aptuRyXWtflSDYOGJhj SUkyllfvqEm77ZHW0FouprcZebNCBLveqWhRuGWXE5ajMOmzt8KJVgJNPB7snqUrU4nN ctZ4+VkaHxm5vlIA6FaSgS6XfiqKFXpCCIpxJMCVV/e0Y2uqKA7/52raNdWf+bm6L7Cd 3JeTNz/k1aUg372hEi/l3axyOZ/xHZ7qagEPX8trytSJrI4VSzfUBLdL/BFuf/OC141r 7ifHrkpwwcz/lqea+YmUvNoISyyiL9HxerHyLXn+kMoHoRYj4n6CgV7hmnrdxoDxh22J OkIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720983296; x=1721588096; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3FC29DauysfNyzjT4QiK0UIy2c80B9aP9VYlrNpPzrc=; b=MNpPZx3Kub6b5dYoK81Qo+Gy0ahgU8SSP9HZw+NMxtu7KwAgS6gwGQNz9SvSPDAW+4 9gpGWyJot+5KSmtwzZxRg/zeub8h28iUFOYa21mP7pdZE38a36PXIzwAjMU1J6pv7YPI RwxcXhFzmqjf5u8iKsk93yfwZ7V6K+8CbJNuGq2eqs8fTJ+50iTi1NClav+11zkfv4gf uyBxy4cW4Qxl/QbGkc4RxwMRp5ympT6qq65SzBGMK65rjMtGlP7uJL9lqRB21QWWHA+k 2q3oD+kc1+2axQnGEdApgbyNL/JyFpnzzGUfpY3uHQpz3r/1FoT4LUNRwOHwnnkmqD5F bHMA== X-Forwarded-Encrypted: i=1; AJvYcCWfJtc2hNHRrsyv5d70uCaQazotPkW3uBy28chwf4Pn0rASYwCgmvvqjue5zfUhsadTwcCYvd0SIyHaqbCuMYETbwHd5ZM= X-Gm-Message-State: AOJu0YwA15u/fCHOSUEFsfsZNL6nEvBoxzHgCz3Rmuph2IMNeGMMrlw2 SB+nM2xamvFb0hqHDPGCXovKL0M1bWY5zv0rv+lPZSJ+f+3JfNI0 X-Google-Smtp-Source: AGHT+IEPQTzK30nkQ4kAISxllps/kgfSAR3EMk5CYUs1j8iuu9n34gqvHj+Wk4Ucfp1wA+2TgAM8Zg== X-Received: by 2002:a17:906:5650:b0:a72:8d2f:8594 with SMTP id a640c23a62f3a-a780b6b2f20mr1085286666b.27.1720983295720; Sun, 14 Jul 2024 11:54:55 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5b48dbsm153565866b.57.2024.07.14.11.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 11:54:55 -0700 (PDT) Message-ID: <89de2118659f749a31b0f777d9ac4d1f700a4819.camel@gmail.com> Subject: Re: [PATCH v2 5/5] gnu: klee-uclibc: Only build on x86_64 Linux. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Sun, 14 Jul 2024 20:54:53 +0200 In-Reply-To: <96e57f4f5fc4ea592923427484333c7dfea55a3c.1720981528.git.soeren@soeren-tempel.net> References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> <96e57f4f5fc4ea592923427484333c7dfea55a3c.1720981528.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 14.07.2024 um 20:25 +0200 schrieb soeren@soeren-tempel.net: > From: S=C3=B6ren Tempel >=20 > * gnu/packages/check.scm (klee): Add supported-systems. Should be klee-uclibc. > --- > =C2=A0gnu/packages/check.scm | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm > index 3fc88b078f..e48d392251 100644 > --- a/gnu/packages/check.scm > +++ b/gnu/packages/check.scm > @@ -1006,6 +1006,7 @@ (define-public klee-uclibc > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 > "12fnr5mq80cxwvv09gi844mi31jgi8067swagxnlxlhxj4mi125j")))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (build-system gnu-build-system) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (supported-systems '("x86_64-linux")) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (arguments > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #f ;upstream uClibc= tests do not work in the fork > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:strip-directorie= s '() ;only ships a static library, so > don't strip anything. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 16:04:17 2024 Received: (at 72106) by debbugs.gnu.org; 14 Jul 2024 20:04:18 +0000 Received: from localhost ([127.0.0.1]:58623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT5SD-0002h5-HP for submit@debbugs.gnu.org; Sun, 14 Jul 2024 16:04:17 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:47788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT5SC-0002gx-37 for 72106@debbugs.gnu.org; Sun, 14 Jul 2024 16:04:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=6IrxjRqR CnssLmGgSH/l0312MOUWfRDPxOtcH3oxecY=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=ZjCM0f803i4owvylZwZiPRFTi1B LweUSaBZQqIPvIIbCrsjpNUhEoga4oW9+ejVOThuU+Jgq/Vo50U8Z6MaB682riXJw4wq2h 4KV54hPAhyCUcQiZ4TXCq13w0tXzDQtwOjUJcXvYCwSkCLNGqvkS/6kGMqKY679ZRNS6mN 4A/Q= Received: from localhost (dynamic-2a02-3102-49da-001b-720e-aee8-aafa-f98d.310.pool.telefonica.de [2a02:3102:49da:1b:720e:aee8:aafa:f98d]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id d01c4f92 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 14 Jul 2024 22:04:10 +0200 (CEST) Date: Sun, 14 Jul 2024 22:04:09 +0200 To: Liliana Marie Prikler Subject: Re: [PATCH v2 2/5] gnu: klee: Enable the test suite. From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> <68c1ee2dec2780cc8d6d5bc0db0f36492236b85c.camel@gmail.com> In-Reply-To: <68c1ee2dec2780cc8d6d5bc0db0f36492236b85c.camel@gmail.com> Message-Id: <39BYRNCZVFJV2.39MMBNJU3FT1T@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: 72106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Liliana, Liliana Marie Prikler wrote: > Why the package source and not the compiled package? Can we make it so > that we can use a prebuilt compiled one? Unfortunately, this does not seem to be possible. You can only point the KLEE build system to a googletest source [1]. This seems to be related to some peculiarity of googletest as other Guix package do the same thing [2] [3] [4] (there are more grep for "package-source googletest"). > If this is a test, then we should use native-inputs below. What exact dependency are you referring to? python-lit is already declared as a dependency through native-inputs. > Should be klee-uclibc. Good catch! I can send a revision fixing the commit message. Is there anything else I should adjust in a v3 revision? Cheers, S=C3=B6ren [1]: https://github.com/klee/klee/blob/master/README-CMake.md?plain=3D1#L60= -L62 [2]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/crypto.sc= m?id=3Deb508e32d2d359c94d2cabebfe90dc32ca5dcf4f#n336 [3]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/benchmark= .scm?id=3Deb508e32d2d359c94d2cabebfe90dc32ca5dcf4f#n241 [4]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/chemistry= .scm?id=3Deb508e32d2d359c94d2cabebfe90dc32ca5dcf4f#n407 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 20 05:57:06 2024 Received: (at 72106) by debbugs.gnu.org; 20 Jul 2024 09:57:06 +0000 Received: from localhost ([127.0.0.1]:51805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV6pu-0008Rq-9l for submit@debbugs.gnu.org; Sat, 20 Jul 2024 05:57:06 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:52812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sV6ps-0008RK-7I for 72106@debbugs.gnu.org; Sat, 20 Jul 2024 05:57:04 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9D70DAAE; Sat, 20 Jul 2024 11:56:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jw6haIuG87OL; Sat, 20 Jul 2024 11:56:58 +0200 (CEST) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 27F9B865; Sat, 20 Jul 2024 11:56:58 +0200 (CEST) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: soeren@soeren-tempel.net Subject: Re: [bug#72106] [PATCH v2 2/5] gnu: klee: Enable the test suite. In-Reply-To: (soeren@soeren-tempel.net's message of "Sun, 14 Jul 2024 20:25:25 +0200") References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> Date: Sat, 20 Jul 2024 11:56:57 +0200 Message-ID: <87cyn8qtcm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 72106 Cc: 72106@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello S=C3=B6ren, soeren@soeren-tempel.net skribis: > (,(string-append lib "/klee/runtime/")))= ))))) > #:configure-flags > - #~(list (string-append "-DLLVMCC=3D" > + #~(list "-DENABLE_UNIT_TESTS=3DON" > + "-DENABLE_SYSTEM_TESTS=3DON" > + (string-append "-DGTEST_SRC_DIR=3D" > + (assoc-ref %build-inputs "googletest")) > + (string-append "-DGTEST_INCLUDE_DIR=3D" > + (assoc-ref %build-inputs "googletest") "/goo= gletest/include") I would replace (assoc-ref =E2=80=A6) by: #+(package-source googletest) > - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python py= thon-tabulate)) > + (inputs > + `(("bash-minimal" ,bash-minimal) > + ("klee-uclibc" ,klee-uclibc) > + ("gperftools" ,gperftools) > + ("sqlite" ,sqlite) > + ("z3" ,z3) > + ("python", python) > + ("python-tabulate" ,python-tabulate) > + ("googletest" ,(package-source googletest)))) =E2=80=A6 and leave =E2=80=98googletest=E2=80=99 out of =E2=80=98inputs=E2= =80=99 entirely, keeping the concise input list without labels. (I think we shouldn=E2=80=99t reintroduce input labels; the goal has always been to remove them.) WDYT? Besides, to answer Liliana, Googletest is often used as a =E2=80=9Csource library=E2=80=9D like you=E2=80=99re doing here; there are quite a few othe= r packages that do that in Guix already, as you explained. That=E2=80=99s OK. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 16:40:30 2024 Received: (at 72106) by debbugs.gnu.org; 25 Jul 2024 20:40:30 +0000 Received: from localhost ([127.0.0.1]:37867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GI-0001Pk-1Z for submit@debbugs.gnu.org; Thu, 25 Jul 2024 16:40:30 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:27883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GE-0001PT-UU; Thu, 25 Jul 2024 16:40:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=QzDsyC3P 5loJyDY1sF9vqHeTQlz3AyHgbunbLRUyylY=; h=date:subject:cc:to:from; d=soeren-tempel.net; b=LrmW3Puv8jhxabfnrCkxHvYh9Ubm1HJVFm9+yDBjTwph1dy yers9RQymCbomXxtQySTeZeo7hkoIUKppwiwyBHzIsP+sDGPp5JYMzGKgWs9g10RzpjavF Gy23Xs7w6+M991Oz8LXhHuwALAQVjIUshhNz2xnOqqJzv3bmRRZnnw= Received: from localhost (dynamic-176-005-150-084.176.5.pool.telefonica.de [176.5.150.84]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 39b35f2d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Thu, 25 Jul 2024 22:40:14 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v3 1/5] gnu: klee: Wrap klee-stats for Python dependencies. Date: Thu, 25 Jul 2024 22:39:59 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Wrap klee-stats. --- gnu/packages/check.scm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 412b94569c..3c5ed7a3c3 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1070,7 +1070,15 @@ (define-public klee (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") "${KLEE_UCLIBC_PATH}")))) - (add-after 'install 'wrap-hooks + (add-after 'install 'wrap-klee-stats + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (wrap-program (string-append bin "/klee-stats") + `("GUIX_PYTHONPATH" ":" prefix + ,(search-path-as-string->list + (getenv "GUIX_PYTHONPATH"))))))) + (add-after 'install 'wrap-klee (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin")) @@ -1088,7 +1096,7 @@ (define-public klee (search-input-file %build-inputs "/lib/klee/libc.a")) "-DENABLE_POSIX_RUNTIME=ON"))) (native-inputs (list clang-13 llvm-13 python-lit)) - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3)) + (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python python-tabulate)) (build-system cmake-build-system) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") base-commit: 03062c7a9fd74d625639e1a325e9cb58d1cd74e3 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 16:40:32 2024 Received: (at 72106) by debbugs.gnu.org; 25 Jul 2024 20:40:32 +0000 Received: from localhost ([127.0.0.1]:37869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GK-0001Pw-DT for submit@debbugs.gnu.org; Thu, 25 Jul 2024 16:40:32 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:27883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GG-0001PT-PI; Thu, 25 Jul 2024 16:40:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=ghaH4brx H0gD+106AK1DCiXvNpAN26VmT7pIwtH9ARs=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=pWzw+pi6S9RI1ZqM1eCB1ep+uGd F4GvWx5YeQCmk8sRcS5Mt6oc7z5H+15ViMqaXwkefGtwJG0CoCVESs5DawyxGTxAMBaOSr bW+HQpanFYzPZif9unjLzW/h91KSFfXSXB6HtAxJDZjHKmj94y6nUgJlDCAaP+fP9q9lJ9 1+P8= Received: from localhost (dynamic-176-005-150-084.176.5.pool.telefonica.de [176.5.150.84]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 77438f42 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Thu, 25 Jul 2024 22:40:19 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v3 2/5] gnu: klee: Enable the test suite. Date: Thu, 25 Jul 2024 22:40:00 +0200 Message-ID: <879a9aeca685352ce048738e127b8ab3cbb58460.1721940003.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Enable all tests. [arguments]: Add phase to patch lit configuration, set #:test-target. <#:configure-flags?>: Enable system and unit tests, configure gtest. [inputs]: Add googletest and python-lit. --- gnu/packages/check.scm | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 3c5ed7a3c3..48e8ae3aef 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,13 +1063,23 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:test-target "check" #:phases #~(modify-phases %standard-phases - (add-after 'unpack 'patch + (add-after 'unpack 'patch-cmake (lambda _ (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") "${KLEE_UCLIBC_PATH}")))) + (add-after 'unpack 'patch-lit-config + (lambda _ + ;; Make sure that we retain the value of the GUIX_PYTHONPATH + ;; environment variable in the test environmented created by + ;; python-lit. Otherwise, the test scripts won't be able to + ;; find the python-tabulate dependency, causing test failures. + (substitute* "test/lit.cfg" + (("addEnv\\('PWD'\\)" env) + (string-append env "\n" "addEnv('GUIX_PYTHONPATH')"))))) (add-after 'install 'wrap-klee-stats (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -1088,7 +1098,13 @@ (define-public klee `("KLEE_RUNTIME_LIBRARY_PATH" = (,(string-append lib "/klee/runtime/")))))))) #:configure-flags - #~(list (string-append "-DLLVMCC=" + #~(list "-DENABLE_UNIT_TESTS=ON" + "-DENABLE_SYSTEM_TESTS=ON" + (string-append "-DGTEST_SRC_DIR=" + #+(package-source googletest)) + (string-append "-DGTEST_INCLUDE_DIR=" + #+(package-source googletest) "/googletest/include") + (string-append "-DLLVMCC=" (search-input-file %build-inputs "/bin/clang")) (string-append "-DLLVMCXX=" (search-input-file %build-inputs "/bin/clang++")) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 16:40:43 2024 Received: (at 72106) by debbugs.gnu.org; 25 Jul 2024 20:40:43 +0000 Received: from localhost ([127.0.0.1]:37874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GU-0001QV-QD for submit@debbugs.gnu.org; Thu, 25 Jul 2024 16:40:43 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:4204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GS-0001QB-GV; Thu, 25 Jul 2024 16:40:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=X+v2rHzw ZHfjw9L4H7zUbxHOLlN9tkcHbT5iqvnywVg=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=A+EBJprfD/YpwmfpJlbO2KHatXd c2sw98d0yMq8FZyQzBSa1ma5Sg6a62+ZsLqqeW+46sEsqyyxb/lwu09qwWPGnt8okX+2yG irBKKjcTTidkwClkm+f1siEwmlQgW57f/keXSI0YO350m1zid4d9JLZnnCZ0LmSQpazhmz UpO8= Received: from localhost (dynamic-176-005-150-084.176.5.pool.telefonica.de [176.5.150.84]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 9ff7ef2d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Thu, 25 Jul 2024 22:40:21 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v3 3/5] gnu: klee: Only strip bin directory. Date: Thu, 25 Jul 2024 22:40:01 +0200 Message-ID: <4f359d704cbadd3884b16b41a7d4799ed14a2990.1721940003.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel This avoid several warnings to be emitted by strip(1) when attempting to strip .bca (i.e. LLVM bitcode) files shipped in /lib/klee/runtime/. * gnu/packages/check.scm (klee): Set #:strip-directories. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 48e8ae3aef..1b7381cd36 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,6 +1063,7 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:strip-directories #~(list "bin") ;don't strip LLVM bitcode in /lib #:test-target "check" #:phases #~(modify-phases %standard-phases From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 16:40:43 2024 Received: (at 72106) by debbugs.gnu.org; 25 Jul 2024 20:40:43 +0000 Received: from localhost ([127.0.0.1]:37876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GV-0001QX-3M for submit@debbugs.gnu.org; Thu, 25 Jul 2024 16:40:43 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:31487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GS-0001QD-RR; Thu, 25 Jul 2024 16:40:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=bj/nnUyk kjM2rLFHyzE2bw4XRDtNRPxhCUxF6Kom9JU=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=G4yyUTZhsuhkoll1ttCNapE4Eha HIzbTm+IaGtTF2yLWTKzOxjw2t38N7ovX+qtvsrcRE6B+xo9tB2tRq8GY8s5RCjIC6ZQhX bw9Sm+SwSDd+w11OUVJT12b9sYO3p5Y8XBxeFs5mdvC/bbdAQGoKBJOQPO8ICV4upSdWMz Lelc= Received: from localhost (dynamic-176-005-150-084.176.5.pool.telefonica.de [176.5.150.84]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 8ae31efd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Thu, 25 Jul 2024 22:40:23 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v3 4/5] gnu: klee: Only build on x86_64 Linux. Date: Thu, 25 Jul 2024 22:40:02 +0200 Message-ID: <6d51c298a83bcbc8581f229dd7bdb07ccadaf525.1721940003.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Add supported-systems. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 1b7381cd36..75393ca179 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1115,6 +1115,7 @@ (define-public klee (native-inputs (list clang-13 llvm-13 python-lit)) (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python python-tabulate)) (build-system cmake-build-system) + (supported-systems '("x86_64-linux")) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") (description "KLEE is a symbolic virtual machine built on top of the LLVM From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 16:40:43 2024 Received: (at 72106) by debbugs.gnu.org; 25 Jul 2024 20:40:43 +0000 Received: from localhost ([127.0.0.1]:37878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GV-0001Qf-Ea for submit@debbugs.gnu.org; Thu, 25 Jul 2024 16:40:43 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:4204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5GT-0001QB-HE; Thu, 25 Jul 2024 16:40:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=FJ1v0r9h mddUck/1kLuRjn+tiXF/8qs7hlw0D0xNk0U=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=TY6zQpXkGD05B+CxnW/UaJa3ijs BQJ7Y9qL9lZzBQprHebHtQoya5WlVGnFSZnc/dsV270kH3TEkxf+weLbvlIi/7PDG+GnHs x4R4/WFIVODvUmhFmrwxWSdn8419pJyF9dsICuetL7FF9IF/D5IQ/KJh83SCbpRNPPjtMw VDpI= Received: from localhost (dynamic-176-005-150-084.176.5.pool.telefonica.de [176.5.150.84]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 729f9c77 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Thu, 25 Jul 2024 22:40:25 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v3 5/5] gnu: klee-uclibc: Only build on x86_64 Linux. Date: Thu, 25 Jul 2024 22:40:03 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee-uclibc): Add supported-systems. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 75393ca179..493829082b 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1006,6 +1006,7 @@ (define-public klee-uclibc (sha256 (base32 "12fnr5mq80cxwvv09gi844mi31jgi8067swagxnlxlhxj4mi125j")))) (build-system gnu-build-system) + (supported-systems '("x86_64-linux")) (arguments `(#:tests? #f ;upstream uClibc tests do not work in the fork #:strip-directories '() ;only ships a static library, so don't strip anything. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 25 16:43:23 2024 Received: (at 72106) by debbugs.gnu.org; 25 Jul 2024 20:43:23 +0000 Received: from localhost ([127.0.0.1]:37888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5J5-0001VM-1O for submit@debbugs.gnu.org; Thu, 25 Jul 2024 16:43:23 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:16318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX5J3-0001VC-20 for 72106@debbugs.gnu.org; Thu, 25 Jul 2024 16:43:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=HH2/2H9G VoMeqBcmgI21/G3bZ9+fp56mWkfi1+SrVxI=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=CTZoLsrFb+qS+DflSgb3vpm39bD yHJ31L0SUhWGExEC7Y/L39WDoF6T+6lnS81lRYcZtkaymhPOdwEmGYdZx90AhO7UuDVDMa MuTNTY42geAEP4vTOcqKTP/C7map56A5X4k06AroSGEcg6QWYUhstu7tiGWvrMIo8dcHl1 vWPk= Received: from localhost (dynamic-176-005-150-084.176.5.pool.telefonica.de [176.5.150.84]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id dd9c8826 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Thu, 25 Jul 2024 22:43:12 +0200 (CEST) Date: Thu, 25 Jul 2024 22:43:11 +0200 To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: Re: [bug#72106] [PATCH v2 2/5] gnu: klee: Enable the test suite. From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <3ba31459921293a61ca8933ce7395f4a6d58b559.1720981528.git.soeren@soeren-tempel.net> <87cyn8qtcm.fsf@gnu.org> In-Reply-To: <87cyn8qtcm.fsf@gnu.org> Message-Id: <2U760OLV542OU.37ELTO3E6V5BR@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: 72106@debbugs.gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s wrote: > Hello S=C3=B6ren, Hi Ludo, > =E2=80=A6 and leave =E2=80=98googletest=E2=80=99 out of =E2=80=98inputs= =E2=80=99 entirely, keeping the concise > input list without labels. (I think we shouldn=E2=80=99t reintroduce inp= ut > labels; the goal has always been to remove them.) >=20 > WDYT? Thanks for this suggestion, this sounds very good to me! I just send a v3 which implements this and also fixes the commit message typo that Liliana pointed out. Let me know if there is anything else that needs to be done :) Best, S=C3=B6ren From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 14:38:52 2024 Received: (at 72106) by debbugs.gnu.org; 26 Jul 2024 18:38:53 +0000 Received: from localhost ([127.0.0.1]:40028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXPq8-0002cW-Hp for submit@debbugs.gnu.org; Fri, 26 Jul 2024 14:38:52 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:52722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXPq5-0002cA-Lw for 72106@debbugs.gnu.org; Fri, 26 Jul 2024 14:38:51 -0400 Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-3687ea0521cso1686475f8f.1 for <72106@debbugs.gnu.org>; Fri, 26 Jul 2024 11:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722019055; x=1722623855; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bIp8sdwH1Tk1c+ASN9wGhIo6akUrYV2+HNknZORbrYU=; b=jMjUScMjGnDRbfqL37bsYOzDx93kqoMpnNnJQySUD9X7R2zcLVMQih/k+GjOnrMT8R qSVqZZ3NohX1+b0a+C8cMhzp/ifaDRpvnTuzXd+wmVe+p/NuGnCwwhrJlmKOVitJLcrd Yur8a5l29niILEPg0CkMnODrC/zWP9cgVIe5fdqhdUt5X7Y8GjBTiRdqJ24sc11oWaYR wDCnpFiVM3ZvAhaoLIOZ8EReLZmktoBL4s3/l03RVv+CMOAVQOuuiqU0DFAScsQ4IdzX +KC4pFqPunyiZCwAfs7JSCmIXVEEMfSDvdIkD87Awrv7l82MDZKuNMNWmMpZuK8rF3A7 yiGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722019055; x=1722623855; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bIp8sdwH1Tk1c+ASN9wGhIo6akUrYV2+HNknZORbrYU=; b=LuyLyUqA7PSsK92hHCgdKIiN8oLquO7Soxy1ebHxuFU5Oh3+CcPw5UP+EYAOg1NRwi CjSEXhnMod0Dt1H6glMFrR4v4R51v9zf6VKi/CoKPnK8VtUogEphiNFmJpO5Y2yqRdaZ 37ILBhtZpgatcAcRvDdbKmiWh+KW6MWGFWntG1ojlRZ8TjIHVzYL0KUFjuC+xPdSVs5e 1LC4VcUdbcES7SYLihlBLcLjReSwA4/zLQ3rGOcoNYWMLZDj5rZ7GrlR80RawkD1Y1Oz 1mrswOxtVJCfzYZF9JRK/S3Xs5V9oIKfhk9veaaoczplzLHaSfmlcktZx4VLoz+L7pfx 0m9A== X-Forwarded-Encrypted: i=1; AJvYcCVa7YNuQzpQfaeUkGOASdKUVii5E2bDPXMOK4E+/uhZYUY7fmgTLNGU7CUfY01U6HtAu929iQH78e/+eTWZIQ8sjtV1tRQ= X-Gm-Message-State: AOJu0YwRd5N3tPZlaGTiao6ZB+eN2Jhr03ogtaRphV7cnbgektwkwyoY jzgyX/8xRSE7YNHpaFPfDUXsSSbieAp7flYGE6gsiHtrdpyYsfXw X-Google-Smtp-Source: AGHT+IFcsESv6bvJb4j7qYwLDi7O+uHb5b7HZDcpzmF4PuZSR5Lpmr/aTZtLHg3hY5VTl7tF59I63w== X-Received: by 2002:a5d:4a06:0:b0:366:f04d:676f with SMTP id ffacd0b85a97d-36b5cf25519mr379827f8f.12.1722019054701; Fri, 26 Jul 2024 11:37:34 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b36863aa7sm5768915f8f.109.2024.07.26.11.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 11:37:34 -0700 (PDT) Message-ID: <56b8badbe6e918f25aa542b22b26582683c0271f.camel@gmail.com> Subject: Re: [PATCH v3 1/5] gnu: klee: Wrap klee-stats for Python dependencies. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Fri, 26 Jul 2024 20:37:33 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRG9ubmVyc3RhZywgZGVtIDI1LjA3LjIwMjQgdW0gMjI6MzkgKzAyMDAgc2NocmllYgpzb2Vy ZW5Ac29lcmVuLXRlbXBlbC5uZXQ6Cj4gRnJvbTogU8O2cmVuIFRlbXBlbCA8c29lcmVuQHNvZXJl bi10ZW1wZWwubmV0Pgo+IAo+ICogZ251L3BhY2thZ2VzL2NoZWNrLnNjbSAoa2xlZSk6IFdyYXAg a2xlZS1zdGF0cy4KPiAtLS0KPiDCoGdudS9wYWNrYWdlcy9jaGVjay5zY20gfCAxMiArKysrKysr KysrLS0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvY2hlY2suc2NtIGIvZ251L3BhY2thZ2Vz L2NoZWNrLnNjbQo+IGluZGV4IDQxMmI5NDU2OWMuLjNjNWVkN2EzYzMgMTAwNjQ0Cj4gLS0tIGEv Z251L3BhY2thZ2VzL2NoZWNrLnNjbQo+ICsrKyBiL2dudS9wYWNrYWdlcy9jaGVjay5zY20KPiBA QCAtMTA3MCw3ICsxMDcwLDE1IEBAIChkZWZpbmUtcHVibGljIGtsZWUKPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzdWJzdGl0dXRlKiAiQ01h a2VMaXN0cy50eHQiCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAKPiAoKCJcXCRcXHtLTEVFX1VDTElCQ19QQVRIXFx9L2xpYi9saWJjXFwu YSIpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAiJHtLTEVFX1VDTElCQ19QQVRIfSIpKSkpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYWRkLWFmdGVyICdpbnN0YWxsICd3cmFwLWhvb2tzCj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYWRkLWFmdGVyICdp bnN0YWxsICd3cmFwLWtsZWUtc3RhdHMKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtl eXMpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IChsZXQqICgob3V0IChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikpCj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGJpbiAo c3RyaW5nLWFwcGVuZCBvdXQgIi9iaW4iKSkpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5k IGJpbiAiL2tsZWUtCj4gc3RhdHMiKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGAoIkdVSVhfUFlUSE9OUEFUSCIgIjoiIHByZWZp eAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAsKHNlYXJjaC1wYXRoLWFzLXN0cmluZy0+bGlzdAo+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo Z2V0ZW52ICJHVUlYX1BZVEhPTlBBVEgiKSkpKSkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKGFkZC1hZnRlciAnaW5zdGFsbCAnd3JhcC1rbGVlCj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsYW1iZGEqICgj OmtleSBpbnB1dHMgb3V0cHV0cyAjOmFsbG93LQo+IG90aGVyLWtleXMpCj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobGV0KiAoKG91dCAoYXNz b2MtcmVmIG91dHB1dHMgIm91dCIpKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYmluIChzdHJpbmctYXBwZW5kIG91 dCAiL2JpbiIpKQpXaHkgbm90IGNvbnNvbGlkYXRlIHRoZXNlIGludG8gYSBzaW5nbGUgJ3dyYXAg cGhhc2U/CgpDaGVlcnMK From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 14:39:49 2024 Received: (at 72106) by debbugs.gnu.org; 26 Jul 2024 18:39:49 +0000 Received: from localhost ([127.0.0.1]:40035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXPr3-0002eQ-Bg for submit@debbugs.gnu.org; Fri, 26 Jul 2024 14:39:49 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:60778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXPr1-0002eD-G2 for 72106@debbugs.gnu.org; Fri, 26 Jul 2024 14:39:47 -0400 Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-368380828d6so1700774f8f.1 for <72106@debbugs.gnu.org>; Fri, 26 Jul 2024 11:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722019113; x=1722623913; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=XXLOSZoIcoAfJxU5bHc0fks1IkqxlummYXooroRQE8I=; b=kAYCRdmoYdYSrMU6MeeJm4mzgxAB0gWvaq2O7iMoltufYA58Mfhc+vH4hAl2g9gsjP DBgGPHZJ8TgJVpeUwn+tFu9arzLdh6b9qzi083VpP+XLlEGy9DrRn9Dc8peyVeK5RTa0 ag0+Lc0ml9teUDw/eFApe2yAsm4yakgIWlkkBrviU8fHF/LyHUGH+ukpJ6IqLe6qU/3N fIINyGzByMMFThmrw3f5PWaJG933yirFgETjW75QJC5G/uWIrQAmzmMQ+L3ug4Z4+MS0 8ow1N3qroQZ2XuGVLs6Vq2SKbgxuN4sAmiWQJbafXKeRnxOyUtDSPffVKSbnotZfA1c2 Mcmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722019113; x=1722623913; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XXLOSZoIcoAfJxU5bHc0fks1IkqxlummYXooroRQE8I=; b=sj8DewCRDyTTR+5z5/ZWQCdtQ7TCO4S5NnGosdl66UZSfRCCDwaq7YHTdaplvwOVxP upGRSRunsQ/5g5TQuBMMDXgaBVr3gZ3d6Mxl8pD91Ypz8t/dUR1vB1dd2XEltOHVnTfb X6PzpFoEdqwy5B1E9LT7k+zdnV4ckislDDm+b6v/i23XEeE/uDBqE8MqG+1wQjWVW6oI gO801ThO/lV/wWTg2XAe49yANB8eCrcP21JSyf1qnknAeC54Tm/kwHO1MKIRpP0Mx2sj 1KvtNOQG3g9jYCyFe8C/mt3mD4xfXztTS4pyNfNlioAy846a4fEVnkEy4N5e4YZU7Eaa vp6Q== X-Forwarded-Encrypted: i=1; AJvYcCUjw4G8bZRujFNacmP5Q9qaGpdEuW96g0ajisB5SJSdJ9f5FjV6nLyrDnCddQzhm7BVzkPXT9Ays9J+qO62xQbFSWPudSo= X-Gm-Message-State: AOJu0YxiJD64BivQEC1mws+Dxbxs75izSbaCKDvQAd+AIFItmsj+9EjN 3HKuiG4NHUKVjgKEnq8ypY8enSVnS/KKQg0hyRAW9QuW3UhI3FgJ X-Google-Smtp-Source: AGHT+IH3huHIib0+4gOV3BO92Lx8Cum1jySPCWcl2gNp1IBkNMpmqK5LlCs4rDWCcYHwg4/WNUQAvg== X-Received: by 2002:adf:ebca:0:b0:367:89b0:f58a with SMTP id ffacd0b85a97d-36b5d0cbd31mr319087f8f.58.1722019112930; Fri, 26 Jul 2024 11:38:32 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c0673sm5806810f8f.5.2024.07.26.11.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 11:38:32 -0700 (PDT) Message-ID: <79cfa1459d9da25e594f5ff49ebc01232fcc4554.camel@gmail.com> Subject: Re: [PATCH v3 3/5] gnu: klee: Only strip bin directory. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Fri, 26 Jul 2024 20:38:31 +0200 In-Reply-To: <4f359d704cbadd3884b16b41a7d4799ed14a2990.1721940003.git.soeren@soeren-tempel.net> References: <4f359d704cbadd3884b16b41a7d4799ed14a2990.1721940003.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 25.07.2024 um 22:40 +0200 schrieb soeren@soeren-tempel.net: > From: S=C3=B6ren Tempel >=20 > This avoid several warnings to be emitted by strip(1) when attempting > to strip .bca (i.e. LLVM bitcode) files shipped in > /lib/klee/runtime/. >=20 > * gnu/packages/check.scm (klee): Set #:strip-directories. > --- LGTM From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 26 14:42:51 2024 Received: (at 72106) by debbugs.gnu.org; 26 Jul 2024 18:42:51 +0000 Received: from localhost ([127.0.0.1]:40040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXPty-0002jN-SY for submit@debbugs.gnu.org; Fri, 26 Jul 2024 14:42:51 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXPtx-0002jG-IM for 72106@debbugs.gnu.org; Fri, 26 Jul 2024 14:42:50 -0400 Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-42803bbf842so24621145e9.1 for <72106@debbugs.gnu.org>; Fri, 26 Jul 2024 11:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722019300; x=1722624100; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=eSkUznjU1dHYjpS2BRXQFn9AjU8vdg0ARLyO5dHcl8g=; b=gwkZCYiM9iSX3bg7bBio+68SR2KX5vudnh/U2q60VYUJ3GMqLYPIuoI94m6IPOvwa7 FLOplMrf6d78b0ySVKPbrwnGEzsymyGmVprI59gYnuntPqyjhPirWA7OR1HxqRGOl0Q5 uYQdzvKsF1dUAuKANMuViCuF8lRBbcNDx2rqtc5/KK+dKp/JzpNvQw1nHBj7YwAE3YEG fI6tDUKZIE0uw+AowgOg8u5p0+L6xtu0jj4n7UtWusFky6oXEiXzGae9hxck5YkuO8ev PlYdQPn9Gsitdn40MkUEQT90uTt53kh5OJLJVjy4dm9S9Hj64AJyimHCPxFm0vxh4G2K Gm0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722019300; x=1722624100; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eSkUznjU1dHYjpS2BRXQFn9AjU8vdg0ARLyO5dHcl8g=; b=FTOLKQpg09qxXQsSDg6DxyCFcPcvrhVSbxzbWSn2SttL7g6QqXNXmI6sJobwMhApJ9 wNJ44xE2cTYw6tyRdQwd1CnfhqzaO4QKUvO0B/OP3BW8F86trh8+T9oM1jh0Y0nBsDip ocO0JvtPuhv13yRAjICJjC85PQVonVlpSFwDK3I3AmId6qkPBkqy+SfYNB73swsRqNEU FmjXy1oIq6nJTgcJ/Cnxv8q+dJMR7EGHce1cwbPFwy+XwLemBKeJGMQXPzFrlC/0i/Pc 9iAegB4kugIPfkABokTmXsGCt4wcB3amk381c5k9EvmMVrr7d4e4PMddTxKdSXOIAGXM uCtg== X-Forwarded-Encrypted: i=1; AJvYcCXPm8jMrQtNziYzAyiGKd6rHGANm/qGkTFT2Hg8d2hFhTWXQJjyLYnoz0UEmxCZua6GHRrxJ3eZfFOgi7qClSYEa+MlL9A= X-Gm-Message-State: AOJu0YykKzB5srqVyqvkNiVMhoXBvfwduD72UReVA1+1Vw/SfuddjWVp PQuFBSvaLRhvJ8DPfTCVyBYcA3SHwDmToVardTx+2YRXPAZVZzvGSxCc9P/l X-Google-Smtp-Source: AGHT+IGRwJmmrV9ppNDCpf9snrXzElZoJ+ahk/0kXjJwlRzkmn4ubDfHdqxiIsNsZ1bDffSWwKLo6w== X-Received: by 2002:a05:600c:2e12:b0:426:593c:9359 with SMTP id 5b1f17b1804b1-42811e0b67dmr5098605e9.32.1722019299793; Fri, 26 Jul 2024 11:41:39 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c0574sm5798457f8f.8.2024.07.26.11.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 11:41:39 -0700 (PDT) Message-ID: <9a2d14183cf4e700652b162126b018b246e94ce0.camel@gmail.com> Subject: Re: [PATCH v3 4/5] gnu: klee: Only build on x86_64 Linux. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106@debbugs.gnu.org Date: Fri, 26 Jul 2024 20:41:38 +0200 In-Reply-To: <6d51c298a83bcbc8581f229dd7bdb07ccadaf525.1721940003.git.soeren@soeren-tempel.net> References: <6d51c298a83bcbc8581f229dd7bdb07ccadaf525.1721940003.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 25.07.2024 um 22:40 +0200 schrieb soeren@soeren-tempel.net: > From: S=C3=B6ren Tempel >=20 > * gnu/packages/check.scm (klee): Add supported-systems. > --- To recall, i386 does not work? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:11:50 2024 Received: (at 72106) by debbugs.gnu.org; 27 Jul 2024 09:11:50 +0000 Received: from localhost ([127.0.0.1]:40524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSv-0002Ct-Gv for submit@debbugs.gnu.org; Sat, 27 Jul 2024 05:11:50 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:37864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSs-0002Bq-Su; Sat, 27 Jul 2024 05:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=M+KKNM2P gid9S74B6vaAX7yMEiSIVz3PFrASLrPAVqM=; h=date:subject:cc:to:from; d=soeren-tempel.net; b=HQkT7MfJh2U9Aq1Es1gL8+hQ1zE6D6yLr2QTKyf2jNz6I68 J5KMP8ox5VBJ4aGgqOoyNoZrH416HphpkTcyO/Zd36+qXTN/3Dr+g1NhwhvI4t7ycL0asR 5mKjpcaXl4ohHBYzcn3f0UULNaa+dcpmWr2eRP0T8wXopzWhlUBn4g= Received: from localhost (dynamic-176-005-148-021.176.5.pool.telefonica.de [176.5.148.21]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id c750bbef (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 27 Jul 2024 11:11:32 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v4 1/5] gnu: klee: Wrap klee-stats for Python dependencies. Date: Sat, 27 Jul 2024 11:10:54 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Wrap klee-stats. --- gnu/packages/check.scm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 412b94569c..347bd2e1aa 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1070,12 +1070,17 @@ (define-public klee (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") "${KLEE_UCLIBC_PATH}")))) - (add-after 'install 'wrap-hooks + (add-after 'install 'wrap-programs (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bin (string-append out "/bin")) (lib (string-append out "/lib"))) - ;; Ensure that KLEE finds runtime libraries (e.g. uclibc). + ;; Ensure that klee-stats finds its Python dependencies. + (wrap-program (string-append bin "/klee-stats") + `("GUIX_PYTHONPATH" ":" prefix + ,(search-path-as-string->list + (getenv "GUIX_PYTHONPATH")))) + ;; Ensure that klee finds runtime libraries (e.g. uclibc). (wrap-program (string-append bin "/klee") `("KLEE_RUNTIME_LIBRARY_PATH" = (,(string-append lib "/klee/runtime/")))))))) @@ -1088,7 +1093,7 @@ (define-public klee (search-input-file %build-inputs "/lib/klee/libc.a")) "-DENABLE_POSIX_RUNTIME=ON"))) (native-inputs (list clang-13 llvm-13 python-lit)) - (inputs (list bash-minimal klee-uclibc gperftools sqlite z3)) + (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python python-tabulate)) (build-system cmake-build-system) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") base-commit: c6ff1d6ff761af0bd9bac5403fd834f04a14a192 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:11:53 2024 Received: (at 72106) by debbugs.gnu.org; 27 Jul 2024 09:11:53 +0000 Received: from localhost ([127.0.0.1]:40529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSz-0002Gl-3a for submit@debbugs.gnu.org; Sat, 27 Jul 2024 05:11:53 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:37864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSu-0002Bq-Sx; Sat, 27 Jul 2024 05:11:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=Z4p4jsTc 9sCpWAYyukfwOVFy/CFI1x9cQQPu2IaK6Tc=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=tkY3j9WrViEc0KeG2L37xd/tyL3 Ma/TclHapXht3WQ0q2RpKsYY3lhLM4kmbJkEXLNZMcKM635vC1yzk45aiedEUViG0nT35q VnFtV+SFNHPVFrAmnFipsyZ0qNRzFibRmb0jPm3mBWfeId4pR+FWmcLiRWMARBLsZe5Exk U4Cg= Received: from localhost (dynamic-176-005-148-021.176.5.pool.telefonica.de [176.5.148.21]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id c07b19d7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 27 Jul 2024 11:11:33 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v4 2/5] gnu: klee: Enable the test suite. Date: Sat, 27 Jul 2024 11:10:55 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Enable all tests. [arguments]: Patch lit configuration and set #:test-target. <#:configure-flags?>: Enable system and unit tests, configure gtest. --- gnu/packages/check.scm | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 347bd2e1aa..aeaa2e807f 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,13 +1063,22 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:test-target "check" #:phases #~(modify-phases %standard-phases (add-after 'unpack 'patch (lambda _ + ;; Allow specification of an absolute full path to uclibc. (substitute* "CMakeLists.txt" (("\\$\\{KLEE_UCLIBC_PATH\\}/lib/libc\\.a") - "${KLEE_UCLIBC_PATH}")))) + "${KLEE_UCLIBC_PATH}")) + ;; Make sure that we retain the value of the GUIX_PYTHONPATH + ;; environment variable in the test environmented created by + ;; python-lit. Otherwise, the test scripts won't be able to + ;; find the python-tabulate dependency, causing test failures. + (substitute* "test/lit.cfg" + (("addEnv\\('PWD'\\)" env) + (string-append env "\n" "addEnv('GUIX_PYTHONPATH')"))))) (add-after 'install 'wrap-programs (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -1085,7 +1094,13 @@ (define-public klee `("KLEE_RUNTIME_LIBRARY_PATH" = (,(string-append lib "/klee/runtime/")))))))) #:configure-flags - #~(list (string-append "-DLLVMCC=" + #~(list "-DENABLE_UNIT_TESTS=ON" + "-DENABLE_SYSTEM_TESTS=ON" + (string-append "-DGTEST_SRC_DIR=" + #+(package-source googletest)) + (string-append "-DGTEST_INCLUDE_DIR=" + #+(package-source googletest) "/googletest/include") + (string-append "-DLLVMCC=" (search-input-file %build-inputs "/bin/clang")) (string-append "-DLLVMCXX=" (search-input-file %build-inputs "/bin/clang++")) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:11:53 2024 Received: (at 72106) by debbugs.gnu.org; 27 Jul 2024 09:11:53 +0000 Received: from localhost ([127.0.0.1]:40531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSz-0002H1-Em for submit@debbugs.gnu.org; Sat, 27 Jul 2024 05:11:53 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:37864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSw-0002Bq-1z; Sat, 27 Jul 2024 05:11:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=eMLsc+bT pLPCpRhiXWQ7r5mfI3qcR/g+8MN7acfcW50=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=ErmDXfTYFOcAbEKUX3aO0mzJ48x M7FZVODxayqU5lENK+27zLOicA3RzDfmHiTHk5H/oCBOsHLDtiXi/zgK/aO+yM+fJBM5Fm 8zzYzK7ihC0C88/WidQWa31YmMA5/eV8bDWO672gzFcGIEGFpYclysfPZQlRONahWRPNt9 okA0= Received: from localhost (dynamic-176-005-148-021.176.5.pool.telefonica.de [176.5.148.21]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 398f2d56 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 27 Jul 2024 11:11:34 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v4 3/5] gnu: klee: Only strip bin directory. Date: Sat, 27 Jul 2024 11:10:56 +0200 Message-ID: <8fe1c17fdbaf83b685d95b5717e84d2f23036660.1722071458.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel This avoid several warnings to be emitted by strip(1) when attempting to strip .bca (i.e. LLVM bitcode) files shipped in /lib/klee/runtime/. * gnu/packages/check.scm (klee): Set #:strip-directories. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index aeaa2e807f..250206886f 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1063,6 +1063,7 @@ (define-public klee (base32 "1nma6dqi8chjb97llsa8mzyskgsg4dx56lm8j514j5wmr8vkafz6")))) (arguments (list + #:strip-directories #~(list "bin") ;don't strip LLVM bitcode in /lib #:test-target "check" #:phases #~(modify-phases %standard-phases From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:11:54 2024 Received: (at 72106) by debbugs.gnu.org; 27 Jul 2024 09:11:54 +0000 Received: from localhost ([127.0.0.1]:40533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSz-0002Hu-QH for submit@debbugs.gnu.org; Sat, 27 Jul 2024 05:11:54 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:37864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSw-0002Bq-Q9; Sat, 27 Jul 2024 05:11:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=knLLaUme miw7yeQqBcHRSsF86ZkeU7397IRG2FdzIL8=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=xGfhdNQcu/iw4P5zNiD3MGEEGS5 hyxAVIKx0HCI15n3XRtWXKoqSZOQVkqcHzd52pcIc6hA4OFrC7M8b8iM1hEdgoCLyy556t kOm1bhR2a0WTuxYwQa1hS1D6XwbSs1qxRZYxHslMhV3HOiQN0Yoz1NHcFkIC/ExibwSRg3 QPIc= Received: from localhost (dynamic-176-005-148-021.176.5.pool.telefonica.de [176.5.148.21]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id d574c409 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 27 Jul 2024 11:11:35 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v4 4/5] gnu: klee: Only build on x86_64 Linux. Date: Sat, 27 Jul 2024 11:10:57 +0200 Message-ID: <4a6fe96af9b83df4604fbc485eb080da722c7609.1722071458.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee): Add supported-systems. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 250206886f..ae3ec90944 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1111,6 +1111,7 @@ (define-public klee (native-inputs (list clang-13 llvm-13 python-lit)) (inputs (list bash-minimal klee-uclibc gperftools sqlite z3 python python-tabulate)) (build-system cmake-build-system) + (supported-systems '("x86_64-linux")) (home-page "https://klee-se.org/") (synopsis "Symbolic execution engine") (description "KLEE is a symbolic virtual machine built on top of the LLVM From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:11:54 2024 Received: (at 72106) by debbugs.gnu.org; 27 Jul 2024 09:11:54 +0000 Received: from localhost ([127.0.0.1]:40535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdT0-0002J2-E6 for submit@debbugs.gnu.org; Sat, 27 Jul 2024 05:11:54 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:37864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdSx-0002Bq-Ji; Sat, 27 Jul 2024 05:11:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=oaolez0P 67Q0SwhWmuOEe0k3MVqEzM29Bro3RuUaiV4=; h=references:in-reply-to:date: subject:cc:to:from; d=soeren-tempel.net; b=A8jfXXwCW9Y7GBjA/+0yAhgt+Lq M/KXZwTfe9CDR5ibuh1THUn6HPTFjigi+6k1q28X9/Co9R90Pp0JyJf4QCk0CPRZzkKLUF YYAK+Je9p5mMrEEE35h/uLRrGvumxX5H6T6nFgMVCISakIP6qr+vnW345FH3Eij8wRcBIP aKq0= Received: from localhost (dynamic-176-005-148-021.176.5.pool.telefonica.de [176.5.148.21]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 52533eba (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 27 Jul 2024 11:11:36 +0200 (CEST) From: soeren@soeren-tempel.net To: 72106@debbugs.gnu.org Subject: [PATCH v4 5/5] gnu: klee-uclibc: Only build on x86_64 Linux. Date: Sat, 27 Jul 2024 11:10:58 +0200 Message-ID: <219dfd8a2b8f710ccf632c838524a23b77575eca.1722071458.git.soeren@soeren-tempel.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel * gnu/packages/check.scm (klee-uclibc): Add supported-systems. --- gnu/packages/check.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index ae3ec90944..b8fbe3f6a8 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -1006,6 +1006,7 @@ (define-public klee-uclibc (sha256 (base32 "12fnr5mq80cxwvv09gi844mi31jgi8067swagxnlxlhxj4mi125j")))) (build-system gnu-build-system) + (supported-systems '("x86_64-linux")) (arguments `(#:tests? #f ;upstream uClibc tests do not work in the fork #:strip-directories '() ;only ships a static library, so don't strip anything. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 05:14:10 2024 Received: (at 72106) by debbugs.gnu.org; 27 Jul 2024 09:14:10 +0000 Received: from localhost ([127.0.0.1]:40543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdVC-0002UZ-2T for submit@debbugs.gnu.org; Sat, 27 Jul 2024 05:14:10 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:17421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXdVA-0002Tg-Dd for 72106@debbugs.gnu.org; Sat, 27 Jul 2024 05:14:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=opensmtpd; bh=KpVA+hkA YizuxLpC3y9czL6y1KKpBptApty3BD3sfJ8=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=a/OcZ86h90ECCOnOwSqMAWcUAZd 3JwJmeVDysk5h/mtw+oz270G49pfDJnX1YEbVN1tZ2HZXOjqKjpjDF4vDSSX/jqFm1Nr40 jJsfQz0KtezbbEnpVt191TPO79G5+1ohXK8aKK4zKp34Q7TvKtifR0TFjtYkplKGkrQc0t xrU8= Received: from localhost (dynamic-176-005-148-021.176.5.pool.telefonica.de [176.5.148.21]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 3aec85eb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 27 Jul 2024 11:13:57 +0200 (CEST) Date: Sat, 27 Jul 2024 11:13:57 +0200 To: Liliana Marie Prikler Subject: Re: [PATCH v3 4/5] gnu: klee: Only build on x86_64 Linux. From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <6d51c298a83bcbc8581f229dd7bdb07ccadaf525.1721940003.git.soeren@soeren-tempel.net> <9a2d14183cf4e700652b162126b018b246e94ce0.camel@gmail.com> In-Reply-To: <9a2d14183cf4e700652b162126b018b246e94ce0.camel@gmail.com> Message-Id: <2KZX7K5B5F7SC.24V48OE5C6IF8@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 72106 Cc: 72106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Liliana Marie Prikler wrote: > To recall, i386 does not work? Yes, i386 does not work as KLEE assumes a 64-bit pointer representation. Liliana Marie Prikler wrote: > Why not consolidate these into a single 'wrap phase? Good idea, I consolidated everything into a single 'wrap phase. Additionally, I also consolidated the patching into a single 'patch phase. Best, S=C3=B6ren From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 13:29:51 2024 Received: (at 72106-done) by debbugs.gnu.org; 27 Jul 2024 17:29:51 +0000 Received: from localhost ([127.0.0.1]:42315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXlEt-0000GO-H6 for submit@debbugs.gnu.org; Sat, 27 Jul 2024 13:29:51 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:59582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXlEr-0000FP-MG for 72106-done@debbugs.gnu.org; Sat, 27 Jul 2024 13:29:50 -0400 Received: by mail-lj1-f194.google.com with SMTP id 38308e7fff4ca-2ef2c56d9dcso27809211fa.2 for <72106-done@debbugs.gnu.org>; Sat, 27 Jul 2024 10:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722101313; x=1722706113; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Y+WiLWIVp5zUj+jIpB9/xzsMd4g0VFAVr0f6QQzYhRY=; b=Bbp5C5eUC2/Gtzm8/zrKrdQgo2VYB6QPFvf5ORNO0onl2tSMrB9fbzRJ+lQO7qCB51 bLLwpU2Nnq2HCpW/8fB7L7HRLT2qtV1E1brpWblX+PyhxusZ9GXSoXS8Ny4j0bCNGjdT p27rqDn+SKHJE4dmosjLY7vHPgg2AZvGqqGyODvSsoWzTW0gDHdEdxILUG/h+QM34E3c Lk9swk6qMM3THBU7A8S+boAIkLjXQ0gGHuRwSzr+pe4mD8ZOr6V9wLbgcvFBVtgjcnbD +HY8UEwAviw5kFjkPQibX36EIlWfv/v1Mv22K9P6hOklwDIyB7FnFK3rFu/Z86IfGoyi 2O9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722101313; x=1722706113; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y+WiLWIVp5zUj+jIpB9/xzsMd4g0VFAVr0f6QQzYhRY=; b=vAQrQH/zUw0Vp2k8fcX/A5DdV0HjSmeXMdi96dSsHaR7tQ60BsjQO+g3ysnYc4/gf1 QngQGzt92MvzyPfNkn5w2AGJhMYarzWFMXlUtp6+5thXOynn+5jWM8ukPMxGCftT45X6 oLmk9MZLa89naovgZhW/DZiZjAtAmjHFtzu95LkPt2CW171S1K4JUenx4VXtrRXyl6Gi r2mMKCEFAcZp4H8/7bvAmQRuWALasehMw93PLYltuA2WGEDBWvx9g+lO4hCWqX+iP7N+ tbI9wbmBVMAJyO9y/+GvKYq0pr/c8odXNoTZyyqK5pTGvLqL7oWnVFu+mcIYT/OvG6ZO SUlQ== X-Forwarded-Encrypted: i=1; AJvYcCWtPckduTcSgdNHeG59cODQxN8Hofo1lo8NhxnBGOgQLdlCjp3bYju5d9HKi6JL0XYV5rsd8Z/pfOXaZvNYpL0+4g4gpyy4MxeNuA== X-Gm-Message-State: AOJu0YzLunjSUk1UtgMrKJm0Y34SFN/NhMrckya2SGlO0EQ0JsAVWkTp nVlB5XTTooMq+S5P7H2+92+lTQad/sGBocPHKjum3wTnCYmM6k7NEKu4VjMc X-Google-Smtp-Source: AGHT+IFyea5ws6E2c8OSYj9irL6tk6Kbdqks9sFGxrG2qoNZer5dbVD/nnBt64+NI5SJhjWKq6sE3Q== X-Received: by 2002:ac2:548c:0:b0:52e:a721:497b with SMTP id 2adb3069b0e04-5309b2bcc59mr2072164e87.38.1722101312656; Sat, 27 Jul 2024 10:28:32 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab2314csm305888666b.14.2024.07.27.10.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Jul 2024 10:28:32 -0700 (PDT) Message-ID: <65f1753857a6181cfcaf1c44924cd4bfba400fd5.camel@gmail.com> Subject: Re: [PATCH v4 5/5] gnu: klee-uclibc: Only build on x86_64 Linux. From: Liliana Marie Prikler To: soeren@soeren-tempel.net, 72106-done@debbugs.gnu.org Date: Sat, 27 Jul 2024 19:28:27 +0200 In-Reply-To: <219dfd8a2b8f710ccf632c838524a23b77575eca.1722071458.git.soeren@soeren-tempel.net> References: <219dfd8a2b8f710ccf632c838524a23b77575eca.1722071458.git.soeren@soeren-tempel.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Am Samstag, dem 27.07.2024 um 11:10 +0200 schrieb soeren@soeren-tempel.net: > From: Sören Tempel > > * gnu/packages/check.scm (klee-uclibc): Add supported-systems. > --- Pushed as 46a64c7fdd0572830 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [209.85.208.194 listed in bl.score.senderscore.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.194 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.194 listed in list.dnswl.org] X-Debbugs-Envelope-To: 72106-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Am Samstag, dem 27.07.2024 um 11:10 +0200 schrieb soeren@soeren-tempel.net: > From: S=C3=B6ren Tempel >=20 > * gnu/packages/check.scm (klee-uclibc): Add supported-systems. > --- Pushed as 46a64c7fdd057283063aae6df058579bb07c4b6a. Cheers From unknown Sat Jun 21 10:39:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Aug 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator