GNU bug report logs - #72104
[PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties

Previous Next

Package: emacs;

Reported by: George Huebner <george <at> feyor.sh>

Date: Sun, 14 Jul 2024 07:20:01 UTC

Severity: normal

Tags: patch

Merged with 72848

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: George Huebner <george <at> feyor.sh>
To: 72104 <at> debbugs.gnu.org
Subject: bug#72104: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties
Date: Sun, 14 Jul 2024 02:19:23 -0500
[Message part 1 (text/plain, inline)]
Tags: patch

xwidget-at assumes the text-property at `point-min` either doesn't 
exist or is an xwidget, and can improperly access fields. This 
patch just returns nil if the text-property isn't an xwidget.

This is definitely an edge case; I use a package called org-modern 
where headlines are formatted with text-properties, which is how I 
found the bug:
Debugger entered--Lisp error: (wrong-type-argument listp #("◉" 0 1 
(face org-modern-symbol)))
 xwidget-at(1)
 xwidget-webkit-current-session()


In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon 
Version
170 AppKit 2487.5)
Windowing system distributor 'Apple Inc.', version 14.4.0
System Description:  macOS 14.4

Configured using:
'configure
--prefix=/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-29.1
--disable-build-details --with-modules --without-gif 
--without-jpeg
--without-png --without-tiff --without-x --without-xpm
'--enable-mac-app=$$out/Applications' --with-gnutls --with-mac
--with-xml2 --without-ns --with-compress-install
--with-toolkit-scroll-bars --with-native-compilation
--without-imagemagick --with-mailutils --without-small-ja-dic
--with-tree-sitter --without-xinput2 --without-xwidgets 
--without-dbus
--without-selinux --with-xwidgets'
[0001-xwidget-Fix-xwidget-at-misinterpreting-non-xwidget-t.patch (text/patch, attachment)]

This bug report was last modified 83 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.